Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Music playback
  • Assigned To
    nicolas_p
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by roolku - 2008-01-29
Last edited by pondlife - 2008-03-09

FS#8529 - Gather Runtime broken starting with r16025

On rebuffering it only gathers runtime data (e.g. playcount) for the last track. I.e. playing an album with 10 titles where the first 6 tracks fit into the buffer it will only record the info for track 6 and not for tracks 1-5.

Noticed on the gigabeat current version and tracked back with the gigabeat sim to revision 16025 (i.e. still okay with r16024).

Closed by  pondlife
2008-03-09 18:22
Reason for closing:  Fixed

Confirmed that this is also happening on iPod video.

Until nico_p comes back from his skiing holidays to fix it, you can revert his commit to still keep the runtime data accurate.

I'm back but still catching up. I promise to look into this ASAP.

After a bit of thinking, I'm pretty sure that the only hunk you need to apply from the patch you gave is the third one. Setting elapsed to 0 will cause the unbuffer callback not to log the tracks. I need to do some testing before I commit the fix.

Is this still a problem?

To me, it still happens, except that the only track that updates is the first track played. Weird.. isn't it?

I'm using r16456.

Using r16524, only the last track in the playlist is added to the "recently played tracks" list.

Seems to work now, r16546 must have fixed it!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing