Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Simulator
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Bertrik Sikken - 2008-04-28
Last edited by Bertrik Sikken - 2008-07-03

FS#8947 - Add a stub in the simulator for ata_disk_is_active

This patch adds a simulator stub for function ata_disk_is_active, allowing the removal of a bunch of #ifdef SIMULATOR macros.

The implementation of the stub is very simple and returns true once after ata_spin has been called and always returns false after ata_spindown has been called. We could make a more realistic simulation of active disk behaviour (e.g. with a timer) but I’d like to keep it simple and this implementation can return both true and false under specific conditions.

Closed by  Bertrik Sikken
2008-07-03 13:39
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r17927.

Jonathan Gordon commented on 2008-04-30 00:26

I like that you’ve tried to make it actually work, but doing it this way means it will only appear to be spinning the first time.

a better solution would be to remove it from the plugin api and fix battery bench to use the ata spindown callback (which is realy the only place where this is misused)

Bertrik Sikken commented on 2008-05-03 09:48

Synced against svn 17312.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing