FS#9013 - adds shut down and show clock to main menu, wps shortcut to view clock
Attached to Project:
Rockbox
Opened by Mark Ganson (TheMarkster) - Monday, 19 May 2008, 18:53 GMT
Last edited by Paul Louden (Llorean) - Tuesday, 20 January 2009, 12:01 GMT
Opened by Mark Ganson (TheMarkster) - Monday, 19 May 2008, 18:53 GMT
Last edited by Paul Louden (Llorean) - Tuesday, 20 January 2009, 12:01 GMT
|
DetailsThis patch does 5 things:
1) adds shutdown option in main menu 2) adds show clock option in main menu 3) adds hotkey shortcut to clock in wps 4) speeds up loading of clock by disabling the logo screen and status messages on loading/saving settings on start/exit 5) adds pressing play button as means of exiting the clock plugin Usage: From the while playing screen (wps) press and hold the play button to switch to the clock display. Press play again to exit the clock and go back to the wps. Currently, the hotkey shortcut (long play) to show the clock from the while playing screen is only implemented for the e200. It would be a very simple matter to add to other targets just by editing the keymap file for that target. I realize it is bad form to add multiple features into a single patch, but only the shut down option is unrelated to the others. TODO: 1) Voice doesn't work for the new main menu options 2) Add keymaps for hotkey shortcuts for more targets |
This task depends upon
Closed by Paul Louden (Llorean)
Tuesday, 20 January 2009, 12:01 GMT
Reason for closing: Rejected
Additional comments about closing: Not working toward inclusion, redundant or previously rejected features included in the patch.
Tuesday, 20 January 2009, 12:01 GMT
Reason for closing: Rejected
Additional comments about closing: Not working toward inclusion, redundant or previously rejected features included in the patch.
Also, why exactly would you want to load the clock plugin from the WPS? Not to mention many players do not have a button free in the WPS anyway. For a spoken clock, simply use the one in the Rockbox Info screen.
Why load the clock plugin from the WPS? I find it is convenient to be able to just press the play button to load the digital clock rather than have to navigate through the System -> Rockbox Info screens. Plus, the clock plugin is larger and easier to read from a distance, for example, from my hip. To clarify, it is the Show Clock and Shut Down main menu options that voice isn't working on, not for the clock plugin itself. As far as I know, the clock plugin was never designed to speak the current time, but I could be wrong on that score. In any case, a visually impaired person might not be able to read the Show Clock menu item (or the clock in the system info screen), but perhaps still be able to read the larger font used by the digital clock. Having the clock plugin read out the current time is not a bad idea, though...
For those players lacking a free button in the WPS, the patch will still function without the hotkey, via the main menu. The only Rockbox'd player I own is the e200, which is also the only keymap I edited to include this hotkey. On the e200 the long play/pause was free and available, so that's the one I chose for it. It's also why I modified the clock plugin to use the play button as an exit key for it. I can press and hold play/pause on my e200 to see the current time, and then press play again to quickly jump right back to the WPS screen.
You can add a large RTC looking however you'd like TO your WPS. Perhaps to be shown when the hold switch is on, or when you pause playback, or just always visible in some free space.
FS#6733, thanks.If you want this considered for SVN, it needs to be split into individual patches for the various features. Perhspa the best way would be to update #6733 with tehe shutdown/restart functionality and leave only the clock changes here. I'd also suggest that the hotkey from WPS to clock be scrapped.
Look at the .diff file where you see this line added to the /apps/keymaps/keymap-e200.c:
{ ACTION_WPS_SHOWCLOCK, BUTTON_UP|BUTTON_REPEAT, BUTTON_NONE },
You would need to add a similar line to the WPS section of the /apps/keymaps/keymap-h10.c file, but replacing BUTTON_UP with the hotkey button you'd like to assign for he shortcut. If you want to use a long play (holding play down for about a second or so) you would use BUTTON_PLAY in place of BUTTON_UP. So, your line to add would look like:
{ ACTION_WPS_SHOWCLOCK, BUTTON_PLAY|BUTTON_REPEAT, BUTTON_NONE },
Just put it in the section where you see all the other ACTION_WPS_xxx stuff.
One more thing. Be sure to look at the other combinations already defined for your player so as not to conflict with something else the combination might already be used for. I don't see any BUTTON_PLAY|BUTTON_REPEAT, BUTTON_NONE sequences, so there shouldn't be any conflicts if you decide to use BUTTON_PLAY. There is a potential conflict with the action for STOP, though. You'll have to experiment with it to see if it interferes or not.
Thanks for the feedback. I am personally using this patch on my e200 series player daily. Based on that experience, the hotkey is an integral part of the patch. If I have to take the player off my belt clip and navigate the menus I almost might as well just use the clock in system -> rockbox info.
The changes made were: I added a shortcut to the wps (long power -- press and hold power) to power off the player from the wps screen. My player (e200) already shuts down when holding power from the wps screen, but the behavior I have found to be erratic. My method here works faster and (hopefully) more consistent.
Note: to stop the current file from playing do a quick tap of menu/power
Note: to power off the player from wps, press and hold menu/power
Usage: Here's how I apply the patch. Copy the clock3.diff file into the rockbox folder (apps will be a subdirectory of rockbox).
From a terminal shell, enter:
patch -p0 <clock3.diff
I created the clock3.diff file by:
svn diff apps >clock3.diff
Usage: Open a terminal and switch to your rockbox source directory (apps should be a subdirectory). Then enter: patch -p0 <clock5.diff
I carry my player on a belt clip and when I want to see the time I press and hold Play/Pause to bring up the clock. With the display now inverted while the clock is being shown, it's a bit easier to see what time it is.