Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System iPod 5G
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by vasile - 2008-05-21
Last edited by petur - 2008-05-25

FS#9021 - HAVE_RECORDING bug

Tried to send this to the dev list, but it seems not to have gone through:

I downloaded the daily build of Rockbox yesterday for my video ipod. Today I decided to recompile without the audio recording features (I don’t have a mic on this ipod). When I commented out the line defining HAVE_RECORDING, it wouldn’t compile without the attached patch because SOUND_LEFT_GAIN, SOUND_RIGHT_GAIN and SOUND_MIC_GAIN only get defined in firmware/export/audiohw.h if HAVE_RECORDING is defined. In order for HAVE_RECORDING to work properly, that value needs to be tested in wm8758.c as it is in, say, wm8731.c.

I haven’t gotten very deep in the code, but casual inspection suggests as3514.c and other some others might suffer from the same defect. The one file patched below was the only one I needed to change for this target.

Closed by  petur
2008-05-25 21:19
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

thanks and welcome to the credits list ;)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing