FS#9173 - add a new time/date screen for all time related stuff

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Wednesday, 09 July 2008, 08:27 GMT
Last edited by Jonathan Gordon (jdgordon) - Monday, 01 December 2008, 09:28 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


this adds a new top level menu option "time & date" which goes to a screen with the time and date at the top constantly being updated, and the remainder of the screen is a menu of the time options, change/set time, change alarm, sleep timer, time format...

on non RTC targets the sleep timer stays under "system"

it _should_ talk the current time when it enters the screen but doesn't and I need to figure out a nice way to do it...
pressing the context menu action will talk the current time.

I'm also not sure if the menu shold be in the main menu or in the system menu...

ignore the 2nd statusbar line in the screenshot... something is broken there, but its fine on target
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 01 December 2008, 09:28 GMT
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Wednesday, 09 July 2008, 09:20 GMT
minor update... move the screen into the system menu, and fix an issue with the statusbar not being updated
Comment by PaulJam (PaulJam) - Wednesday, 09 July 2008, 13:54 GMT

i tried the patch in the H300 uisimulator and noticed that various buttons don't do what i would expect them to do in that screen:

PLAY enters the selected option (expected: [resume playback and] return to WPS).
STOP goes back to the previous menu (expected: stop playback).
A-B does nothing (expected: return to main menu).
long A-B does nothing (expected: open the quickscreen).

H300 uisim r17994.
Comment by Steve Bavin (pondlife) - Wednesday, 09 July 2008, 14:13 GMT
My humble opinion is that this is not needed - the existing info screen will do fine (once it's working properly). Maybe we could rename "Rockbox Info" to the more accurate "System Info", and move the Sleep Timer into the System Settings menu alongside the other time options though.
Comment by Steve Bavin (pondlife) - Wednesday, 09 July 2008, 14:48 GMT
In addition to the keymaps, this needs voice support for reading out the current time and date.
Comment by Jim Dunleavy (jim.dunleavy) - Wednesday, 09 July 2008, 14:57 GMT
Whether Time appears in System or Info menu, I'd like to see it as
either first or last entry in the menu so as to minimize keystrokes
needed to access it.
Comment by Jonathan Gordon (jdgordon) - Wednesday, 29 October 2008, 12:11 GMT
dug this up again...

reworked it to use the menu API instead of simplelist which makes things much easier.

PaulJam, your points are all fixed (except context menu button which talks the current time)
Steve, current time will talk will talk the curent time when you press the usual context menu button...

It probably needs to talk the current time on entry instead of talking the first item, but that could be difficult.

Also, part of this patch which needs thinking about is cleaning up the set time/date screen (and the alarm screen)
Comment by Jonathan Gordon (jdgordon) - Thursday, 30 October 2008, 07:12 GMT
quick sync
Comment by Frank Gevaerts (fg) - Tuesday, 25 November 2008, 15:40 GMT
I like the idea of time setting things not being in a menu called "Info"