FS#9197 - Return correct failure code if the WPS has too many viewports

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Tuesday, 15 July 2008, 19:15 GMT
Last edited by Alexander Levin (fml2) - Monday, 11 October 2010, 14:56 GMT
Task Type Patches
Category Applications
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The title says it all, I have nothing to add
This task depends upon

Closed by  Alexander Levin (fml2)
Monday, 11 October 2010, 14:56 GMT
Reason for closing:  Rejected
Additional comments about closing:  A very old patch; obsoltete by now
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 15 July 2008, 23:11 GMT
Have you tested this patch? I don't think it will work correctly, because the value of PARSE_FAIL_LIMITS_EXCEEDED is positive, whereas parsing functions like parse_viewport are supposed to return either the number of characters they read or a strictly negative error value. Maybe there is no apparent problem (thanks to the other check for the viewport limit), but this looks wrong to me.
Comment by Alexander Levin (fml2) - Wednesday, 16 July 2008, 05:23 GMT
To be honest, I have not tested the patch. I just have seen that a wrong literal is used in this case and have assumed that the general frame is correctly set up. If it's not, then a fix is needed at another place (but this fix is still correct IMHO).
Comment by Alexander Levin (fml2) - Wednesday, 16 July 2008, 18:39 GMT
Here is another try. Now also tested, although not very extensively. Also added some comments.