Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Geert Hendrickx - 2008-08-14
Last edited by Jens Arnold - 2008-08-26

FS#9280 - fix "make tar" for BSD tar compatibility

The “make tar” target uses tar -u to update an existing tarfile. This doesn’t work however with BSD tar if the tarfile doesn’t exist yet, and the Makefile explicitly removes the tarfile initially (so why use -u anyway?). Changing -u (update) into -c (create) makes this compatible with both GNU and BSD tar (tested on NetBSD with both versions of tar).

Closed by  Jens Arnold
2008-08-26 23:23
Reason for closing:  Fixed
Additional comments about closing:  

Fix committed to SVN, including the necessary buildzip.pl changes.

Geert Hendrickx commented on 2008-08-26 22:10

“tar -c” is not the proper solution since $ziptool may be called twice (when including fonts).

As agreed on IRC, it would be better to modify buildzip.pl to call $ziptool only once.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing