FS#9329 - Remove total tracks and total discs from ID3v2 tags.

Attached to Project: Rockbox
Opened by Magnus Holmgren (learman) - Wednesday, 27 August 2008, 19:38 GMT
Task Type Patches
Category ID3 / meta data
Status New
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


This patch removes any total tracks and total discs number from the track and disc number fields in ID3v2 tags, so that track and disc numbers are displayed consistently across different tagging formats.

What happens is that if a number larger than zero can be parsed from the start of the field, then the field is terminated on the first "/" char.

Added as a patch as I don't know if this behavior is wanted.
This task depends upon

Comment by Paul Louden (Llorean) - Wednesday, 27 August 2008, 20:19 GMT
Personally, I'd prefer to trust users to put the information in their tag that they want to be displayed.

Realistically, I expect more reports like the one that prompted you to post the patch rather than just use it yourself if we don't include this behaviour.

Any chance you know of a specification somewhere that says the "Track" and "Disc number" fields are supposed to be numeric, or supposed to not contain total tracks, or anything else that would help justify this?
Comment by Jonas Häggqvist (rasher) - Wednesday, 27 August 2008, 20:24 GMT

The 'Track number/Position in set' frame is a numeric string containing the order number of the audio-file on its original recording. This MAY be extended with a "/" character and a numeric string containing the total number of tracks/elements on the original recording. E.g. "4/9".

The 'Part of a set' frame is a numeric string that describes which part of a set the audio came from. This frame is used if the source described in the "TALB" frame is divided into several mediums, e.g. a double CD. The value MAY be extended with a "/" character and a numeric string containing the total number of parts in the set. E.g. "1/2".

Not exactly what you hoped for.
Comment by Rafaël Carré (funman) - Thursday, 11 December 2008, 17:07 GMT
I understand that "/ total" is wanted and this patch is incorrect
Comment by Jonas Häggqvist (rasher) - Thursday, 11 December 2008, 17:08 GMT
I think this should be closed - Lear?
Comment by Magnus Holmgren (learman) - Friday, 12 December 2008, 17:57 GMT
If total is wanted, shouldn't a totaltracks field be added then (and totaldiscs?), so that it can be displayed for non-ID3v2 formats too?