FS#9537 - Backdrop for viewport

Attached to Project: Rockbox
Opened by John Woznack (Software_Samurai) - Saturday, 08 November 2008, 23:11 GMT
Task Type Patches
Category Themes
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


I'd like to suggest the following new WPS feature(s):

1. A viewport can be assigned an image as a "backdrop".
a. A viewport may be assigned an image dynamically via the WPS tag "%VX<identifier>"
(i.e. %VXa for image a, %VXZ for image Z, etc.)
b. As a viewport is being processed and drawn, its backdrop would be drawn "first", followed by any other normal images/characters.

2. Viewport may define FF00FF as a background color, which would then be "transparent". This would allow overlapping viewports.

3. Fonts drawn in a viewport with a backdrop would automatically be drawn with DRMODE_FG.

Notes on the attached patch file:
+ It was created from the SVN revision 18997 on Nov 3, 2008.
+ Although I stubbed in the new functions for all the LCD drivers, I've only flushed out the 16 bit driver so far.

This task depends upon

Comment by Dominik Riebeling (bluebrother) - Sunday, 09 November 2008, 09:21 GMT
your patch unfortunately isn't following the coding guidelines (tabs at various places).
Comment by John Woznack (Software_Samurai) - Sunday, 09 November 2008, 14:17 GMT
Sorry about that. I'll remove them ASAP.
Comment by John Woznack (Software_Samurai) - Sunday, 09 November 2008, 15:14 GMT
Here's my patch file without those evil tabs!
Comment by Peter D'Hoye (petur) - Wednesday, 12 November 2008, 21:40 GMT
Apart from missing the point of this feature, we do not support (or want) overlapping viewports.
Comment by John Woznack (Software_Samurai) - Wednesday, 12 November 2008, 23:39 GMT
"Apart from missing the point of this feature"

1. So that a viewport can have a backdrop image with scrollable font on top. (e.g. With viewports that activate other viewport based on various conditions, the overall arrangement/style can be dramatically different.)
2. So that a viewport can have a _dynamic_ backdrop image, with scrollable font on top. (e.g. Have a different image under the currently playing song title depending on what type of file it is.)
3. So that viewports can overlap.

"we do not support (or want) overlapping viewports."

I do. May I ask why you do not want to support overlapping viewports?
Comment by Thomas Martitz (kugel.) - Thursday, 13 November 2008, 18:54 GMT
Well, I don't see much point in this feature as far as the WPS is concerned (as you can achieve the same thing using the traditional way of showing bitmaps in the wps).
Except for for font over bitmaps part of course, which might be indeed very handy.

However I can this being usefull in other screens.

Also, with this, we could simplify / unify bitmap displaying in general + alowing fonts displayed on top of that bitmaps.
Comment by Karl Kurbjun (kkurbjun) - Friday, 18 December 2009, 04:53 GMT
Being able to use images as backdrops in viewports would be really handy for themes, and now with the custom SBS I can see it being even more useful. It could save quite a bit of space depending on how the theme is setup too.

I'm not sure about the approach for the bitmap/font drawing though in the LCD driver though. This method would be quite a bit slower than the real backdrop method, it would be nice if this could be implemented in a way that was close to the performance of the real backdrop. At the moment I don't have a suggestion how though.