FS#9640 - WPS comments "eat" line-endings
Opened by Jonas Häggqvist (rasher) - Sunday, 14 December 2008, 18:01 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 15 August 2010, 14:22 GMT
|
DetailsComments in WPS files act very strangely if they're not on a line of their own. The following (and attached) wps demonstrates this:
----------Start---------- Artist: %ia Title: %it foo bar Artist: %ia# Comment Title: %it# Comment -----------End----------- Expected output: ----------Start---------- Artist: Dire Straits Title: Walk Of Life foo bar Artist: Dire Straits Title: Walk Of Life -----------End----------- Actual output: ----------Start---------- Artist: Dire Straits Title: Walk Of Life foo barArtist: Dire StraitsTitle: Walk Of Life -----------End----------- It seems to me that comment-characters should only "eat" line-endings if they're at the beginning of a line? This behaviour was introduced in r13140 (http://svn.rockbox.org/viewvc.cgi?view=rev&revision=13140), seemingly on purpose, but I don't think "inline" comments were considered - that's why I'm adding this as a bug. As a note, at least one WPS in SVN uses this behaviour to break a long line, so if it's fixed, that WPS should be modified as well. |
Sunday, 15 August 2010, 14:22 GMT
Reason for closing: Wont Fix
Additional comments about closing: it seems that this behaviour is wanted. feel free to reopen and bring it up on the ml or irc if you want.

