FS#9689 - greylib pictureflow for greyscale targets

Attached to Project: Rockbox
Opened by Andrew Mahone (Unhelpful) - Sunday, 21 December 2008, 05:00 GMT
Last edited by Andrew Mahone (Unhelpful) - Saturday, 17 January 2009, 00:38 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch allows pictureflow to be used on greyscale (but not mono) targets using greylib, and the new greylib scaler. It requires the recent updates from  FS#9458 , and the scaler output plugging support and greylib output plugin from  FS#9683 . It incorporates my previous pictureflow scaling patch from  FS#9665 , which does not apply cleanly over the other two patches.

The tracklist and album view work exactly as on color targets, in greyscale. The greylib overlay is disabled in the config menu, as this does not rely on color. I have tested on Mini 2G and iPod 4G sims, as well as on iPod video sim (to verify color works correctly).
Closed by  Andrew Mahone (Unhelpful)
Saturday, 17 January 2009, 00:38 GMT
Reason for closing:  Accepted
Additional comments about closing:  this work was committed in r19598
Comment by Andrew Mahone (Unhelpful) - Sunday, 21 December 2008, 17:09 GMT
Reordered loops while creating reflection, so that some math can be moved out of the inner loop. Also made the scaling factor used for the reflection a constant, and of lower precision, to replace a 32x32->64 multiply with a ->32 one.