FS#9692 - cant save the file after "changes NOT saved" in text editor

Attached to Project: Rockbox
Opened by Johannes Linke (Jaykay) - Sunday, 21 December 2008, 12:17 GMT
Last edited by Teruaki Kawashima (teru) - Tuesday, 21 July 2009, 14:54 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


to reproduce it:

1. open text_editor in the application-menu.
2. press down to show the menu of the editer.
3. select "save"
4. enter nothing, but press play.
5. it should say "changes NOT saved"
6. after that you can do what you want, every time you try to save something it says "changes NOT saved" directly after pressing "Save".

workaround: restart text_editor :)

expected behaviour: when selecting "save" in 6., the editor should give you a second chance to save the file.
This task depends upon

Closed by  Teruaki Kawashima (teru)
Tuesday, 21 July 2009, 14:54 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in r21994.
Comment by Johannes Linke (Jaykay) - Sunday, 21 December 2008, 12:21 GMT
i forgot again: sansa e280 + r19396.

can anybody change the category to plugins?
Comment by Yoshihisa Uchida (Uchida) - Wednesday, 21 January 2009, 09:21 GMT
I create the patch file.

Please confirm it.
Comment by Yoshihisa Uchida (Uchida) - Thursday, 22 January 2009, 10:35 GMT
I correct my patch file a little.
Comment by Johannes Linke (Jaykay) - Friday, 23 January 2009, 21:28 GMT
i corrected the patch file also a little, thre was a mistake in the path and i changed a splash.

with this patch the bug does no longer happen.

can someone commit & close this?
Comment by Yoshihisa Uchida (Uchida) - Saturday, 24 January 2009, 02:32 GMT
In the comment that uses IRC, because the possibility that your comment disappears in other opinions is high
because time zone that you and I are acting is not suitable, my comment write here.
(I confirmed your IRC comments for about 30 minutes ago.)

When file open failure, I change the message as "Can not save !!".
In this case, I thought that the message should be modified because error occurs, the text was not saved
and it is not correct that the message is "Changes NOT saved" because the user did not cancel the preservation processing.