- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface → Simulator
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#9717 - Fix "warning: "htobe16" redefined"
I think newer? SDL includes <endian.h>
(my fedora10’s SDL version is 1.2.13),
and simulator build log says like the following.
— warning: “htobe16” redefined
— http://build.rockbox.org/showlog.cgi?date=20081226T160730Z&type=iAudio%20M3%20-%20Simulator#prob1 — This patch fix it.
Closed by nls
2009-01-24 10:17
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-01-24 10:17
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Committed with funman's suggested
change, thanks!
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
You don’t need to check if a symbol is defined before undefining it, simply use “#undef xxx”
However I think sdl.h should be checked to see if some macro can prevent inclusion of endian.h
I think ‘#define _ENDIAN_H’ somewhere before including headers would prevent it (as a -D_ENDIAN_H perhaps).
I think -D_ENDIAN_H is not good, because endian.h defines other thins like “__BYTE_ORDER”.
And if it doesn’t defined, a lot of error is printed.
If it’s enclosed into #ifdef SIMULATOR (because only the sim use SDL) I think this should be good.
Michael what do you think ?