Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Configuration
  • Assigned To No-one
  • Operating System Gigabeat F/X
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Sanggon, Lee - 2009-01-02
Last edited by Torne Wuff - 2010-04-13

FS#9744 - add missing sw tone control parameter on gigabeat s

Currently, there are sw tone coltrol option(bass/treble) on sound menu.
But sw tone control parameter for gigabeat s is missing, so sw tone control option don’t work and just change volume.

This patch add missing sw tone control parameter on gigabeat s.

Closed by  Torne Wuff
2010-04-13 21:49
Reason for closing:  Fixed
Additional comments about closing:  

r25641

Michael Sevakis commented on 2010-04-02 06:37

A good interim measure. This thing has been a point of contention. Mostly because I wish that we’d use the hardware EQ to its fullest potential rather than using it in a crippled way. If something has hardware controls we use those instead of software ones, since the SW one were intended as a way to give tone control to lacking hardware. No way to handle this has been agreed upon. There’s been some criticism that users might be confused by the presence of two EQs and the best I can come up with is to have five controls labelled as “tone”.

Then again, having two menu items and no functionality is also confusing. :-\

Perhaps: bass, low-mid, mid, high-mid, treble?

Torne Wuff commented on 2010-04-13 21:49

Until someone implements *some* kind of HW tone control, this will do :)

The change to sound.c is not needed, though; that list only needs to include codecs which have HW tone control but not HW prescale.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing