Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#9856 : More robust patchset.cfg reader for midi player

Rockbox

Tasklist

FS#9856 - More robust patchset.cfg reader for midi player

Attached to Project: Rockbox
Opened by Corwyn Simpson (siber_cat) - Sunday, 01 February 2009, 07:28 GMT
Task Type Patches
Category Plugins
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

I was reading http://forums.rockbox.org/index.php?topic=17079.0 and thought I'd take a swing at it. So far, I have added (potentially shaky?) support for the '#' comments in the file posted, allowing both Windows and Linux line ending formats, and longer filename support.
Still having problems with the white space after each entry, and detecting or assuming the presence of the file extension.
   midi-patchset-fix.r19736.diff (2.1 KiB)
This task depends upon

Comment by Nils Wallménius (nls) - Sunday, 01 February 2009, 10:40 GMT
Looks good, one question though, why do you define your own FILE_NAME_LIMIT instead of using MAX_PATH ?
Comment by Alexander Papst (DerPapst) - Friday, 13 February 2009, 22:23 GMT
I've applied the patch to r20001 however the midi plugin freezes while loading the instruments (blacklight still reacts but leaving the plugin fails).
Attached is the same patch but it is using MAX_PATH instead of FILE_NAME_LIMIT (same behaviour).
   midi-patchset-fix.r20001.diff (2 KiB)

Loading...