Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Teruaki Kawashima - 2009-03-01
Last edited by Andrew Mahone - 2009-05-16

FS#9971 - rework Superdom plugin

1. make duplicated code into function such as

 putting resources on borad,
 moving unit,
 attacking to opponent's territory and calculating result.

2. change function computer_war to avoid endless loop.
3. simplify redundancy conditionals.
4. handle canceling at selecting place or input number.
5. use while(1) loop instead of goto.
6. use system font when drawing score. (part of  FS#7593  ?)
this maybe fixes bugs reported at  FS#9962 ,  FS#9963 ,  FS#9965 .

Closed by  Andrew Mahone
2009-05-16 08:22
Reason for closing:  Accepted
Additional comments about closing:  

Committed as r20959.

Teruaki Kawashima commented on 2009-03-04 15:46

i found some mistakes on my patch..
here is new one.

Teruaki Kawashima commented on 2009-04-14 07:45

update patch.
fix bug. do rb→close(fd); after loading saved game.
resume from proper menu after load the save data. version is changed and cannot use old data.
e.g. if game was saved in War menu, game starts from War menu when loaded the game.

Hilton Shumway commented on 2009-05-11 16:19

This does fix at least  FS#9962 .

Hilton Shumway commented on 2009-05-11 16:39

And  FS#9963 

Hilton Shumway commented on 2009-05-13 15:26

 FS#9965  is fixed by this too.

Are we going to assume Teruaki is a real name or try to get a better one?

Teruaki Kawashima commented on 2009-05-16 07:24

edited name being shown to a better one.
but I believe my name is already in docs/CREDITS.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing