Obviously there is no one who wants to open a mp3 file with text viewer. With this patch applied, ‘Open With..’ only shows plugins that are associated in ‘viewers.config’. To see a full list of viewers plugin, just set the ‘Show Files’ option to ‘All’ and try again.

Some builtin filetypes are text file, so I added them into ‘viewers.config’ for the accessibility.

Hi there,

first of all: this is my first contribution to rockbox and I tried my best to make myself familiar with the way things work there. I am sure, not everything is where it belongs. Please help me to get things in order :).

second: thanks to the author of Patch  FS#1803  that made this possible.

The purpose of this patch is to watch the tuner reported field strength (estimate) and mute, when it drops below a customizable threshold. Wether muting or not as well as the threshold are customizable in the fm tuner menu. It should not interfere with manual muting and should not affect recording (i didn’t test that yet). THe threshold is specified in pseudo-dBuV.
It also adjusts frequency display to display as MMM.KKK instead of MMM.KK. This is for people who adjust region settings and channel widths.

My testing conditions were limited to the sansa c250.  FS#1803  reports to work on the tuner chips LV24020LP (e.g. sansa c250) and TEA5767. I only tested the first. Please report back possible field strength values you see on devices using these chips.

This code should not break anything. I did a testbuild for some iPods (without tuner) that compiled cleanly. Simulator also works.

Currently only english and german translation are done.

User guide:
This patch conditionally adds 1 or 2 lines to the tuner main window that look like this:

Sig: [-M] -235dBuV
Automute below -555dBuV

The second line is only displayed if automute is enabled. The first line shows the status of the tuner. The 2 characters in the braces exlain as [ab]:

a: either 'O' or '-' 
   'O': current field strength is above threshold
   '-': current field strength is equal to or below threshold
b: either 'M' or '-'
   'M': will mute on or below threshold
   '-': automute disabled.
(both are only updated on field strength change)

The second line should be selfexplaining, same for the menu entries.

Request for comments!

When the c200 is docked (as detected by the charger discrete being active), switch to line out. This was necessary for the Griffen “iTrip Auto for Sansa” adapter to produce output. I would assume this is necessary for other docking stations.

This is *NOT* a perfect patch, but it is a start and is necessary to make docking stations with audio output work.

Limitations:
* I mute the headphone output, so plugging in a non-docking charger will prevent listening via the headphones while charging. Both can be enabled… if the charger is plugged in, it probably isn’t an issue but that is what the Sansa firmware does.

* The charger/headphones detection is done only on power up. This is suboptimal, but usually “correct.” A better technique would be to hook into the charger status announcements, but I don’t have time right now.

This is the first step of being able to use the pictureflow plugin from a database search. The database now indexes the path to the coverimage for each audio file. In the database browser you can select “Cover by...” genre, artist, composer, year or all and will be presented with a list of cover image paths. (Imagine a call to the pictureflow plugin at this stage, so instead of a list of boring paths you get nice and shiny images). After selecting a path it will display the list of files that would be queued when a cover image is picked in the plugin.

Next step is to work out how to safely call the plugin without losing the context and utilise the return value from it to queue the files.

Issues so far are:

- the preferred size of 100×100 is hardcoded (this should be configurable or at least be consistent with the value in the pictureflow
the db update for covers has the same restrictions as the other tags, i.e. it will only detect changed cover art on
the coverflow plugin needs to work while music is playing (or stop playback if needs
since there is no guaranteed relation between album name and image file, the album name can’t be displayed

Before you get carried away, this is the script that will build talk clips in /.rockbox/talkclips/* for all tags and labels (reading tagnavi.config as well as the database_[0-9]*.tcd files).

The idea is that the database code will then look here for talk clips.

In the long term, the same method could be used for the file browser if desired.

Hopefully someone will help me out with the database code side of things, as I don’t think I’m up to that challenge.

A first port of espeak running on rockbox.
Warning: Only tested on Sansa player!

I have skipped some advanced features of espeak, for example:
- mbrola
- on the fly Translator language switching (try: ‘spring’ with german selected)

Because this plugin is very basic, there is no file input selection.
It always reads from the ‘test.txt’ in the root.
You have to unzip the espeak-data to the root of your player.

This patch should apply to all ipods, but needs testing - on both a mixture of ipods and mixture of operating systems. I’ve tested it successfully on my Color with both Linux and Mac OS X.

Current SVN behaviour is to write some magic to the end of IRAM and reboot the ipod when a USB connection is detected. This causes the Apple bootloader to start the disk mode application which is stored in flash ROM.

This patch cuts out the reboot stage and uses rolo to start the disk mode application directly from flash - meaning the ipod enters disk mode almost immediately. This is done in a new rolo_load_rom() function which copies the image from ROM to RAM and then executes it.

This is a sequel for  FS#5736 . It correctly displays the OEM-encoded short DOS file names.

Following code pages are supported: cp850 (western Europe), cp852 (central Europe), cp737 (greek), cp866 (cyriliic), cp862 (hebrew).

If you change the default code page (in the settings menu) and there are files that are displayed with the short DOS names, you’d better rebuild the dir cache (if it’s activated) since the UTF8-name of the file changes.

When I compile the modified sources, I get the following warning which I don’t understand:
CC common/unicode.c
common/unicode.c:136: warning: function declaration isn’t a prototype

Could anyone tell me what that means and what the reason is?

I would like to run my iPod with its keypad locked all the time, thus I wrote a little patch to an option to disable the settings reset during startup regardless of the hold button's position.

You will find the patch attached to this message. I'm not entirely convinced by the name of the new option (or my wording in general) so if you have a better idea, feel free to rename things.

Version 9e186e34ab-190820

i have an ipod 7th gen
rockbox installed
140.000 titles

database contains in unpredictable many cases of the folders 2 times the same title
not in all folders, but it happens very often that i open one and i see all titles 2x although they are only 1x on the sd card

the files exist only ONCE
but the database keeps listing them all 2 times

i rebuilt it several times, but the database keeps on doing that

any hint what i can do?

start as apple / itunes and delete rockbox folder / install new did not help

Creative ZEN
Daily build: rockbox-creativezen-20170112

Bug description:
When plugging any dummy plastic or a non supported SD card, the device freezes and displays a white screen with a “PANIC” error message.
Plugging a standard SD card works fine.
To restore the system, you have to use a paper clip to do a hardware reset and turn the device on again.

Hi,

I have installed Rockbox build 0F89B04-160628 using this (https://files.freemyipod.org/~user890104/bootloader-ipodclassic.html) method.

I have created a dynamic playlist (Database > long select artist > current playlist > Queue Shuffled). Play and then pause the music and then hold the play button down to shutdown rockbox. Plug in USB cable from your computer (Win10) in to the iPod and the iPod should start powering on and then a white *panic* screen should appear.

Workaround is to have Rockbox already fully booted before plugging in a USB cable from the computer.

When playing music, I can hear codec errors in the music. It occurs every time on a certain song, and other songs that are smaller in file size, it does not occur on, but occurs on the next one. I believe it is a buffering issue, and makes the music unlistenable. I used the daily on 10/21/2015

On 320kb/s MP3s it occurs much more often, and 128kb/s MP3s it occurs less often, but when it occurs its a series of glitches that distort the music.

I am sure its not the MP3s themselves, because it doesn't occur in the official firmware, and when I rewind it, it does not make the same sound until later. It has a very prominent 'glitchy' sound and later it changes the speed of the song.

I replaced it with the 3.1.3 MP3 codec, and the same glitch occurs.

I do not have a line out so its made through the speaker, but the problem is so bad that you can hear it very clearly.

The MP3 was 320kb/s

Memo is the glitchy one, and Memo-1 is it being played correctly.

I noticed that the playlist seems to become one item shorter when I shuffle it, using the latest Git master branch (commit 70d57080) on a Sansa Clip+.

Steps to reproduce:
1. Clear the playlist by pressing Stop (power button)
2. Add a small number of tracks to the playlist
3. Shuffle the playlist (playlist view, menu, Shuffle)
4. Observe that playlist is one item shorter than before

I tracked the reason for this down, and attach a patch. This isn't a "proper" fix, and is a bit hacky, but it does illustrate what causes the problem.

I use the attached custom WPS that displays the active Replaygain value and type next to the track number.

When playing mpc files created by foobar2000 with the tracknumber/totaltracks tag format, if the track# is 10 or higher and the applied gain negative (as in the attached mpc), mangled characters are displayed between the gain value and type, eg:

10/12 -2.00 dB *gibberish* (Album)

This is reproducible with the latest simulator build d0fffd6-150104 but I only recently noticed the issue and don't know when it began. I have an old sim build 935d8be-121229 and it works correctly there.

## This was tried out with Sansa Fuzev2 simulator version d392da8-140922, built from git on a 64 bit Linux system ##

I discovered something which seems to be a bug somewhere in the place where WPS get interpreted or rendered.

When I use a scrolling line just after a line containing sublines, the scrolling line stops scrolling as soon as the sublines change the first time.

Below are steps to reproduce it on the UI simulator for the Sansa Fuzev2. I think it also works without using a clear configuration. I haven’t tested with a real device, only with the simulator.

Attached are a .wps-file showing the buggy behaviour (’scrollline_after_sublines_bug.buggy.wps’), and a .wps-file working correctly (’scrollline_after_sublines_bug.workaround.wps’), which are the same files as quoted below.

STEPS TO REPRODUCE:

(0) Use Sansa Fuzev2 simulator version d392da8-140922, build from git on a 64 bit Linux system.

(1) Use a clear configuration, so erase

    .rockbox/.playlist_control
    .rockbox/config.cfg
    .rockbox/nvram.bin
    .rockbox/database.ignore
  in your 'simdisk' directory.

(2) Start the rockbox UI simulator

(3) Change the theme to ‘rockbox_failsafe’, i.e. in the menu, do the following:

• ‘Settings’ → ‘Theme Settings’ → ‘Browse Theme Files’ → ‘rockbox_failsafe.cfg’
• ‘Settings’ → ‘Theme Settings’ → ‘While Playing Screen’ → ‘rockbox_failsafe.wps’
• ‘Settings’ → ‘Theme Settings’ → ‘Radio Screen’ → ‘rockbox_failsafe.fms’
• ‘Settings’ → ‘Theme Settings’ → ‘Base Skin’ → ‘rockbox_failsafe.sbs’

(4) Use the following .wps-file as the “While Playing Screen” skin:

=⇒ # Two sublines:
Text1;Text2
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
# Another line of just text (Not needed to reproduce the bug, but if it is swapped with the long line above, the long line scrolles correctly):
Textline.
#### Here the following Bug appears:
# When the Line ‘Text1;Text2’ changes the sublines the first time, the subsequent line stops scrolling. It happens when the sublines change; as when you use ‘%t(5)Text1;Text2’, the scrolling stops only after 5 seconds, when the sublines actually change.
⇐=

Workaround:
(4a) Put the scrolling line not directly after a line with sublines. The following .wps as the “While Playing Screen” skin works:

=⇒ # Two sublines:
Text1;Text2
# Another line of just text. Needed to make the long line scrolling correctly:
Textline.
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
#### Here the bug does not appear, the long line scrolls corretly. But when the long scrolling line is put just below the line with the sublines, it stops scrolling as soon as the sublines change for the first time.
⇐=

Consider the following theme markup:

%Vl(progressbar,306,156,10,80,-)
%pb(0,0,10,80,progressbar.bmp,vertical)

That draws a vertical progress bar that will get filled from bottom to top. When a song starts to play, the progress bar is one pixel high, at the correct position (at the bottom of the viewport). That 1px-high image quickly jumps up one pixel (moves up by one pixel), then comes back down one pixel (at the correct position) whenever the progress percentage is high enough. The progress bar then displays normally and grows as the song is playing. See attached screenshots.

Expected behavior: the position of the progress bar (relative to the viewport) should not change. The bug has been observed in the iPod Classic and Clip Zip sims (builds 1bc89bd and 77bfff5) as well on the actual devices. Inverting the progress bar (with the "invert" parameter) shows the correct behavior (inverted bar with no such glitch).

Affected themes: Ash (iPod Classic), SugarBrown (Clip Zip).

On my Sansa c250v1, the starfield plugin crashes at the address 0x01F80394 with a data abort.
It seems that the plugin is attempting to execute data.
Strangely, it does not happen in the simulator.

With my 5th generation iPod, if I connect USB while the hard drive is spinning, I often get full speed mode instead of high speed mode. This testing is with 00b8563, but I’ve observed the same problem in the past. Here’s the relevant part of Linux 3.8.0-21-generic dmesg output:

[26644.712035] usb 2-2: new high-speed USB device number 18 using ehci-pci
[26644.904471] usb 2-2: device descriptor read/all, error -71
[26644.965905] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.967780] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.968004] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.971577] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.973440] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.973459] hub 2-0:1.0: hub_port_status failed (err = -32)
[26645.176048] hub 2-0:1.0: unable to enumerate USB device on port 2
[26645.428038] usb 6-2: new full-speed USB device number 8 using uhci_hcd
[26645.979070] usb 6-2: not running at top speed; connect to a high speed hub
[26646.009069] usb 6-2: New USB device found, idVendor=05ac, idProduct=1209
[26646.009076] usb 6-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[26646.009080] usb 6-2: Product: Rockbox media player
[26646.009083] usb 6-2: Manufacturer: Rockbox.org
[26646.009087] usb 6-2: SerialNumber: 100000000000A270014B32BEB
[26646.024242] scsi21 : usb-storage 6-2:1.0
[26647.038109] scsi 21:0:0:0: Direct-Access TOSHIBA MK3008GAL BU11 PQ: 0 ANSI: 4
(I’ve removed the remaining USB storage messages because they don’t seem relevant)

If the hard drive is not spinning, I get high speed mode. However, there is a disconnect and the device is detected twice:

[27356.784126] usb 6-2: USB disconnect, device number 9
[27371.208044] usb 2-2: new high-speed USB device number 24 using ehci-pci
[27371.347053] usb 2-2: New USB device found, idVendor=05ac, idProduct=1209
[27371.347058] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[27371.347062] usb 2-2: Product: Rockbox media player
[27371.347065] usb 2-2: Manufacturer: Rockbox.org
[27371.347069] usb 2-2: SerialNumber: 100000000000A270014B32BEB
[27373.079038] scsi25 : usb-storage 2-2:1.0
[27373.337244] usb 2-2: USB disconnect, device number 24
[27373.640029] usb 2-2: new high-speed USB device number 25 using ehci-pci
[27373.779220] usb 2-2: New USB device found, idVendor=05ac, idProduct=1209
[27373.779226] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[27373.779229] usb 2-2: Product: Rockbox media player
[27373.779233] usb 2-2: Manufacturer: Rockbox.org
[27373.779236] usb 2-2: SerialNumber: 100000000000A270014B32BEB
[27373.820382] scsi26 : usb-storage 2-2:1.0
[27374.823266] scsi 26:0:0:0: Direct-Access TOSHIBA MK3008GAL BU11 PQ: 0 ANSI: 4
(Again, I’ve removed the remaining USB storage messages because they don’t seem relevant)

I get the same behaviour regarding high speed vs. full speed mode in Windows 7, but I’m not aware of Windows reporting other USB errors anywhere.

I was sometimes having USB difficulties that seemed to be due to contact oxidization or dust from not using the dock connector in a long time, but I don’t think that’s the cause here.

I’m attaching USB traces from WireShark using Linux usbmon. In both cases I removed all the USB mass storage stuff after get max lun because it seems irrelevant and increases file size a lot. When the result is full speed, something goes wrong after the set address response. When the result is high speed, something goes wrong after the set configuration request. In both cases the first sign of trouble is an interrupt from the USB hub.

This is on a Gigabyte GA-P35-DS3R rev V1.0 motherboard with Intel P35 + ICH9R chipset.

Rockbox 3.1.3 on Clip+ (also iriver h140/340. also previous versions of rockbox).

Some HE-AAC files play back at half speed.

Example file info (comment/lyric fields removed as very long):

General
Complete name : Witness_-_The_Khmer_Rouge_take_power.m4a
Format : MPEG-4
Format profile : Apple audio with iTunes info
Codec ID : M4A
File size : 4.09 MiB
Duration : 9mn 0s
Overall bit rate mode : Constant
Overall bit rate : 63.5 Kbps
Album : Witness
Album/Performer : BBC Radio
Track name : The Khmer Rouge take power
Grouping : News
Performer : BBC World Service
Composer : BBC iPlayer
Genre : News
Recorded date : 2013-04-18T08:50:00+01:00
Tagged date : UTC 2013-04-18 09:07:25
Writing application : Lavf55.0.100

Audio
ID : 1
Format : AAC
Format/Info : Advanced Audio Codec
Format profile : HE-AAC / LC
Codec ID : 40
Duration : 9mn 0s
Duration_LastFrame : -1ms
Bit rate mode : Constant
Bit rate : 62.7 Kbps
Channel(s) : 2 channels
Channel positions : Front: L R
Sampling rate : 48.0 KHz / 24.0 KHz
Compression mode : Lossy
Stream size : 4.04 MiB (99%)

30 second sample attached (cut with ffmpeg, full metadata)

Forum report http://forums.rockbox.org/index.php/topic,43012.0.html

Hi,
I am using a Sansa Clip Zip with Rockbox 3.13.
I’ve noticed, when I lock or unlock the device, the message, which indicates the current state, does not disappear completely. Its still there.

Cheers,
Conrad

In the "Graphic Equalizer" menu and when I connect the player to a computer to transfer the data labels are displayed incorrectly (instead of letters symbols, as in the screenshot).
The problem occurs when I use the Russian language.
The problem I see for a long time, please fix it.

Screenshot of the screen that is displayed when transferring data, I could not do.
P.S. Sorry for my bad English.

On my Sansa Clip+ 4GB, with Rockbox v3.11.2

Recording a wav file through internal microphone. If the audio signal clips at the positive limit, bad things happen:
1) Most of the time the recorded signal wraps around to a full scale negative value, which makes it sound terrible.
2) Sometimes the recorded signal wraps around to a near zero value, which still makes it sound terrible but the distortion is not so loud

3) Clipping at the negative end of the range is as you would expect - a flat line which sounds like normal digital distortion, as you would expect

See attached picture of the recorded waveform showing each of the 3 situations described above.

Both issues seem to appear with any version of my theme and with any build.
Let's try it with the latest version 1.30 of my theme (in attachment but also here: http://themes.rockbox.org/index.php?themeid=1585 ) and a recent build (I use version: 0c4bd3a-120406)

-Theme loading

When you load the theme for the 1st time, the WPS will never load properly (failsafe). The workaround is to turn off the device and turn it on again and then the WPS will always load properly until you reload the theme for some reasons (trying another theme and revert back to mine etc).
I tried both with the full theme version and this "light" version of WPS: http://pastie.org/3747546

-USB connection (tested on Windows 7, with or without a microSD, and there isn't such an issue with the other themes)

If I plug the USB cable while the player is on or off, it will almost never mount properly.
Usually the USB screen appears on my SBS, the computer recognizes a USB device is connected but either nothing appears in "my computer" or the device appears but is not accessible. When I unplug the USB cable, the Zip gets stuck on the USB screen and only reset can turn it off.
Sometimes it even displays some erros like that when plugging the USB cable: "data abort at 30FSR 0x8 (domain 0, fault address 0x964176 bt pc: 0x3006AC3 bt end" , sometimes it doesn't display the USB on SBS but gets stuck on the main menu.
And rarely in the same conditions it also mounts properly…

Like for WPS, I made a "light" version of SBS without the status bar and that way the Zip seems to mount and unmout properly every time!
http://pastie.org/private/cauhxelaip7hrpqpcwdbxw So maybe a tag in the status bar causes the issue with USB connection?

It's Seems to be no support for RTL languages like Hebrew and Arabic in rockbox for android.
Instead of מוסיקה written הקיסומ (in English - Instead of "Music" written "cisuM).
I attach pictures for example:

The %pb tag has a small problem. If an image is specified but no height, the tag draws the size of a line even if larger than the the image. This leads to pixel garbage below the progressbar.

The test.wps reproduces the problem in the 320x480 sdl app The default font, 27-adobe, has to be selected probably. The wps works if a height, i.e. 20 in this case as the image height, is specified

Test.png shows the problem. test.zip is the small test theme.

The config caused the iPod to appear frozen (frozen screen) after bootup. The iPod would boot, show the normal boot screen and then created a boot screen mixed with theme settings. Picture: http://imgur.com/E4srA the iPod refuse and refused to mount.

Fix:
1: Boot into recovery diskmode
2: Remove conflicting config.cfg
3: Reboot into normal mode

Player = Sansa ClipZip
Rockbox current build :

Rockbox WebOS app.

Built on r31467, 32/64-bit Ubuntu 11.10, running on a 32GB Touchpad

Directions (only tested on the above):

* Install WebOS PDK: https://developer.palm.com/content/resources/develop/sdk_pdk_download.html

* Install platform-native libsdl-dev if you haven't already. Only needed to pass configuration check as the PDK doesn't properly install staging sdl-config for some reason.

* Apply patch (patch -p0 < filename.patch)

* cd webos

* ../tools/configure, select WebOS target (206)

* make && make install && sh ./buildpkg.sh

Notes:

* This is one big hack – I fudged just about everything in /firmware (how the target system works is still not altogether clear to me) and piggybacked a lot of this off of the SDL target. Mostly in the interest of getting it to run without adding ifdefs all over the place. Obviously we'll want to be more methodical and thorough about exactly which changes need to go where moving forward.

* The Touchpad's SDL video implementation appears to adjust orientation and scale output to fit within 1024x768 as best as possible. This means that a 800x480 build will appear in landscape mode, letterboxed, while a 320x480 will appear in portrait mode, pillarboxed. The device itself automatically orients to landscape – meaning, if you're in a portrait resolution and then you exit, everything will initially be sideways – but that doesn't affect input. Scaling routines are noticeably slow.

* I tried building this as a hybrid Enyo/PDK (window mgr friendly) app but had some problems with the native part failing to execute at SDL_Init. So for now no backgrounding or notification bar.

* Make scripts use the ARM compilers installed with the PDK. I'm wondering though if this is superfluous given that the Rockbox toolchain also supports ARM7. I did try exposing some of the ARM-specific assembly but the compilation failed with the PDK compiler.

800x480 build: http://www.jasonyu.net/webos/org.rockbox.raap_0.0.1_all.ipk

This patch adds a %ch tag that returns the number of channels in the current file.

Unfortunately, the large majority of codecs don't fill in this field in struct mp3entry. In the codecs covered by the rockbox testfiles collection, only atrac, cook and tta actually work.

I don't think it makes much sense to commit this with so few supported codecs, so help is appreciated on the codec side of things

What the title says.
At whatever sample rate I use (24k & 48k tested), each sample is duplicated.

Update to my tools/talkclips.py script. Minor updates which include:
- Better handling of logfile eg. we don't leave it open as was the case
before
- Report a few more details in the log eg. start/end time, duration, and
number of talk clips created. This is useful to dettect how many files
had problems…
- Summarise output for user at end, of processing, number of talkclips
created and how long this took (in seconds).
- Report to user how many talk clips will need to be created to give
them an indication of potential waiting time etc. This is calculated by
first determining how many files are on the device excluding .talk files, and how many .talk
files there are, and calculating the difference.
- This information allows a percentage indication to be drawn throughout
the script, so now the user can track the percentage as processing takes
place.

Patch is attached.

Thanks.

The patch adds two new WPS tags:

1. %Ln yields the number of the list item currently being drawn

2. The operator "/?" (which can be used in the %if tag) yields the string "div" if the first operant is divisible by the second and NULL otherwise.

With these two additions it should be possible to create themes where list items are coloured alternately (as an example).

The whole work has been done by gevaerts on 2011-09-12 (and all the credits also go to him), I only placed the patch to the patch tracker, changed the operator from "/" to "/?", and changed the function name from "skinlist_get_item" to "skinlist_get_item_number".

He posted the patch on the binpaste and it would be pity if it got lost.

Hacking from Antoine Cellerier’s code for solitaire.c, I put together a rough freecell game.

It currently works for Sansa E200 targets. Others should work once button mappings are done.

This is not heavily tested, so feel free to report or fix any problems you encounter.

I've found a problem with the new autoresume feature in 3.8. I use it when listening to podcasts and sometimes find that it resumes from near the end of a new episode - e.g. on a 30 minute podcast it will resume from 28 or 29 minutes - usually about the place where a previous epidsode finished and I skipped past the end credits.

What I think is happening is that there is some code in the database that tries to resurrect the runtime statistics for files that have been deleted and then restored - as the last offset is in this data, it is reusing the last offset from an old episode.

I've put some more logf()s in tagcache.c in build_numeric_indices(). I can see that if the filenames don't match (line 2306) it then tries to match any 2 tags out of the 3: artist, album or title. For the podcasts, the artist and album are always the same (i.e. the producer and which one of their podcasts it is), but the title is different (i.e. "Episode 100", "Episode 101", etc). So if I've listened to Episode 100 and then deleted the file, and then add Episode 102 to the player, it matches the artist and album and so resurrects the wrong data from Episode 100.

I've disabled the resurrection based on tags (just commented it out) and the problem seems to have gone away. A better fix would be to ensure that all 3 tags or matched or to ensure that title is one of the matched tags

This patch allows the line out on the Sansa Fuze V2 to be enable/disabled by means of the existing Lineout poweroff setting (previously used on some iPods).

By assigning this setting to the quickscreen I can switch between headphones and lineout after plugging into the dock. Still no luck in finding out how to autodetect the dock.

I'm not 100% sure that re-using the "Lineout Poweroff" setting is the right thing to do here as it's not powering on/off the line-out - just switching between headphones and line out

These experimental patches dynamically add new tracks to the database when they are played. This allows users who (for various reasons [1]) prefer to not fully initialize the database to take advantage of database-based features such as autoresume (remember a resume position for each file), runtime statistics, or track ratings.

The current patch set is only a prototype. It's still somewhat inefficient because it does a full database commit and reload for each new track that is played.

The actual database-extension patch (patch 0002) works by refactoring tagcache_build to create a new interface, tagcache_add_file, that adds a single file to the database. This new function runs in the database thread and takes a dircache_entry pointer, which is provided by way of a Q_UPDATE event. The audio thread generates this event in tagtree_buffer_event when the initial DB lookup fails, and later checks the database again in tagtree_track_finish_event. If the DB commit and reload have succeeded in the meantime, this second lookup will succeed and the runtime information the user is interested in (stats, resume info) can be stored in the DB.

Patch 0001 changes the DB commit's buffer-allocation preference from using the dircache buffer to using the RAM DB's buffer. (This used to be the preference until r10003 reversed it, supposedly because the dircache buffer typically is bigger. I don't know yet how valid this argument is today.) This reversal avoids needlessly flushing and refilling the dircache and makes the Q_UPDATE event-passing mechanism more robust (because in-flight update events contain dircache_entry pointers, which would have to be invalidated when the dircache is flushed – which is not done yet).

Current limitations/caveats:
* Requires dircache and Load-DB-to-RAM enabled (and only works on targets that include these features)
* tagcache_add_file does not respect any database.[un]ignore files in the directory hierarchy above the added new file.
* DB needs to be initialized to begin with. There's no UI function for a basic DB initialization (without scanning and adding all files) yet.
* Not very thoroughly tested (mostly in simulator, with small file sets)

Possible improvements:
* Delay committing DB changes if more track-add events are in the tagcache queue
* Incremental commit: Could be optimized for add-one-track case
* Incremental load_tagcache: Avoid flushing and reloading full database
* Add function to initialize an empty DB

Comments welcome!

Footnote:
[1] Reasons for not using the database, or not keeping it up to date, include: metadata parser instability; prefer not keep tags up to date; prefer file browser over database browser

Bomberman like game with ai.
Not finished yet - lots of bugs and things to be done are known :)
Tested on Cowon D2 and also on some simulators with the same screen size (will work on other screen sizes too, but not now).
Somebody test it on iPod Video and on Zen Vision:M please.
Any suggestions greatly appreciated!
Hope the patch will work…

While the database initialisation is running, the tagcache queue can overflow due to system broadcast messages. This can be seen by running a simulator (it will crash with KERNEL_ASSERT after a while) or on a target by enabling KERNEL_OBJECT_CHECKS, then initialising the database and repeatedly connecting/disconnecting a charger.

The same problem may well happen with other queues (dircache, for example).

I got no SD-Card support for my E-250 after boot into USB mode.
I plug in my powered off player into usb and only have access to internal storage.

If i plug in my player booted up there is no problem.

I am using daily build r29174-110131.

Various users on IRC recently reported cases of filesystem corruption. I have seen them as well, especially when using USB mode (I'm using a Sansa ClipV2, USB-enabled through  FS#11664 ).

One strangeness I've experienced is that when my system has detected filesystem corruption, it is often enough to remove the player from USB and then replug it, without repairing the filesystem and without rebooting Rockbox; on the next USB mount, the filesystem is clean. This might indicate that some buffer is flushed too late for the USB host to see.

[EDIT: Removed previously attached patch, which is now tracked separately as FS#11883.]

This patch adds a frequency response graph below the equalizer's controls, making it an EQ that is actually "graphical".

I'm still not sure about the accuracy of the represented curve, in particular the Q factor on the peaking filters seems to have an effect opposite to the expected, though the equations are taken from the same "audio EQ cookbook" the equalizer is based on, any help is appreciated!

The user interface is still incomplete, I want to add proper tags on the axes and bars. I also thought about re-enabling the theme on this screen (why is it disabled?) and change the behavior of the "right" button, making it consistent with other menus.

Tested on a Sansa e200.

at least in the 16bit lcd drivers, all functions which use transparency (or clear pixels) get the pixel colour from the backdrop image, completly ignoring the bg_pattern.

This isnt a problem except in skins where it is perfectly reasonable to want a background image for most of the screen but a solid colour for one or two viewports.

There is a tiny problem though, bg_pattern is set to LCD_DEFAULT_BG which is a valid colour, so we probably need to add a flag to the viewport struct to say if it should ignore the background image or not.

This patch contains several improvements to the Chopper game designed to make it run with a high framerate instead of a low, jerky one. Previously, the game depended on sleeping for a number cycles before drawing another frame, causing very jerky motion. Now the game should run at a high framerate all the time. The gameplay should be about the same, at least on targets with a display of >64px. I don’t have any of these smaller targets, so I wasn’t able to test. Please tell me what you think of my changes.

I am trying to use the last method mentioned on the ipodpatcher wiki page to write Rockbox directly into the OSOS image on my iPod Nano2G. Sometimes it works properly, but other times it fails saying that it couldn't read the header from the .ipodx file. I am following the instructions exactly, so that can't be an issue. I have tried hexediting the .ipodx file, and in some cases I can get ipodpatcher to read the header by editing the first four values, but this always causes a Checksum Error. Here is the exact output:

C:\Users\Michael Marley\Downloads>ipodpatcher.exe -wf rockbox.ipodx
ipodpatcher 5.0 with v4.0 bootloaders (v1.0 for 2nd Gen Nano)
(C) Dave Chapman 2006-2009
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[INFO] Scanning disk devices… [INFO] Read XML info (4 bytes)
[INFO] Ipod found - 2nd Generation Nano ("winpod") - disk device 1
[INFO] Reading partition table from \\.\PhysicalDrive1
[INFO] Sector size is 2048 bytes
[INFO] Part Start Sector End Sector Size (MB) Type
[INFO] 0 63 48194 94.0 Empty (0x00)
[INFO] 1 48195 1982462 3777.9 W95 FAT32 (0x0b)
[INFO] Read XML info (4 bytes)
[INFO] Ipod model: 2nd Generation Nano ("winpod")
[ERR] Failed to read header from rockbox.ipodx
[ERR] –write-firmware failed.

This patch adds a sector-based read/write cache between the storage and fat drivers.
It has a static pool of 64 sector buffers which can be locked by the file handling code to replace the sector buffers in the file and dir structs, and serve as cache as long as they aren’t used. It can also be used to enforce exclusive access to a sector.

If requested using the STORAGE_NEEDS_ALIGN define, all storage accesses will be aligned to cacheline boundaries.

This patch adds a couple more lines to Track Info for Play Count and Rating.
Currently these don’t seem to show up anywhere else.

Tested against r26427 with Fuze v2 and USim.

Hi all,

Currently for all models, the Morse Code input method can only type lowercased letters. Here I provide a patch which enables people to switch between lower cased and upper cased letters, I implemented this for Fuze and Fuze v2, and further fixes will be provided soon (or someone else want to add some key mapping options into your keymaps?)

The patch (also attached):

Index: apps/action.h

   ACTION_KBD_DOWN,
   ACTION_KBD_MORSE_INPUT,
   ACTION_KBD_MORSE_SELECT,

   /* the following are helper actions for touchscreen targets,

   "abcdefghijklmnopqrstuvwxyz1234567890,.?-@ ";

                       state.morse_code |= 0x01;
               }
               break;

           case ACTION_KBD_SELECT:

                   /* turn off hangul input */
                   state.hangul = false;

               }

               break;

           int morse_code;

           outline[0] = morse_alphabets[i];

           sc->putsxy(x, y, outline);

           morse_code = morse_codes[i];

   { ACTION_KBD_DONE,         BUTTON_UP,                        BUTTON_NONE },
   { ACTION_KBD_ABORT,        BUTTON_HOME|BUTTON_REPEAT,        BUTTON_NONE },
   { ACTION_KBD_MORSE_SELECT, BUTTON_SELECT|BUTTON_REL,         BUTTON_NONE },

   LAST_ITEM_IN_LIST

New build target, for iriver E10.

A lot of target-specific functions are missing, so it doesn't compile when it reaches the linker. But I think it's about time to insert the build target into SVN, and #rockbox seems to agree.

Also, building a simulator build works quite well. The simulator BMP and the keymaps needs some work, but it works pretty well, including music playback.

I've done some testing with building for other targets and nothing seems to be broken by this patch. I couldn't figure out how to include the BMP in the patch so i attach it separately.

When loading a saved Brickmania game, the game is loaded corrupted. Please see screenshot attached to see for yourself. There is one brick in the right side which is shown corrupted, and one corrupted rectangle in the left side of the screen which drops like a power object, and stays at the bottom of the screen.

This issue happens on Cowon D2 target. It doesn't happen on the D2's simulator.

Looking at the code and comparing the loading/saving function against the Bubble's game functions, I can see that the return value of file operations is not checked (I'll fix that).
In Bubbles, there's a single file operation of reading/writing the game context struct. In Brickmania there are several consequent file operation to read/write each variable. Maybe the drivers doesn't handle this well on this target. A workaround for that could possibly be to join all saved variables under one game context struct as in Bubbles, but that could mask a real bug somewhere else.