Rockbox

IDTask TypeCategoryPrioritySummaryOpenedOpened byLast Edited  desc
10023PatchesDriversVery LowiTunes communication for software USB targets2009-03-14Jonas Häggqvist22009-03-173 Task Description

This patch will make an e200 present its SD card as an ipod mini 2G when queried by iTunes. It does this by changing a number of things:

1) Responding to SCSI inqueries
2) Using Ipod USB vid/pid and other usb details

The patch also enables logf for the usb_storage.c because I’m in a bit of a hurry.

To use this, make sure you have a partition on the SD card of type 0 (any size should do) and also the appropriate Ipod file structure (can be generated with e.g. gtkpod).

8295PatchesDatabaseVery Lowdatabase integration of pictureflow2007-12-10Robert Kukla32009-03-073 Task Description

This is the first step of being able to use the pictureflow plugin from a database search. The database now indexes the path to the coverimage for each audio file. In the database browser you can select “Cover by...” genre, artist, composer, year or all and will be presented with a list of cover image paths. (Imagine a call to the pictureflow plugin at this stage, so instead of a list of boring paths you get nice and shiny images). After selecting a path it will display the list of files that would be queued when a cover image is picked in the plugin.

Next step is to work out how to safely call the plugin without losing the context and utilise the return value from it to queue the files.

Issues so far are:

- the preferred size of 100×100 is hardcoded (this should be configurable or at least be consistent with the value in the pictureflow
the db update for covers has the same restrictions as the other tags, i.e. it will only detect changed cover art on
the coverflow plugin needs to work while music is playing (or stop playback if needs
since there is no guaranteed relation between album name and image file, the album name can’t be displayed

9330PatchesRbutilVery Lowpatch for openBSD support for ipodpatcher2008-08-28Brian22008-10-083 Task Description

The following patches will allow someone running openBSD to run ipodpatcher. This is my first pass at these patches, so they cannot be integrated without some problems.

A few outstanding questions remain:

1) should I use /dev/sd0c or /dev/rsd0c?

2) why do byteorder(3) functions exist in fat32format.c?

3) how do the developers want to handle disk geometry?

I ask the last question because my patch overwrites the existing ioctl with what works for openBSD, rather than separate it out. And the patch doesn't fully use what is available in struct disklabel. I plan to re-write this one.

The fat32format.diff comments out byteorder(3) functions. The ipodio-posix.diff converts the file to openBSD disk geometry. The ipodpatcher.diff corrects the device used.

I have only tested the patches above for ipodpatcher on iPod nano 1st gen.

8305PatchesOperating System/DriversVery Lowc200: support docking stations with audio2007-12-12Jerry52008-06-163 Task Description

When the c200 is docked (as detected by the charger discrete being active), switch to line out. This was necessary for the Griffen “iTrip Auto for Sansa” adapter to produce output. I would assume this is necessary for other docking stations.

This is *NOT* a perfect patch, but it is a start and is necessary to make docking stations with audio output work.

Limitations:
* I mute the headphone output, so plugging in a non-docking charger will prevent listening via the headphones while charging. Both can be enabled… if the charger is plugged in, it probably isn’t an issue but that is what the Sansa firmware does.

* The charger/headphones detection is done only on power up. This is suboptimal, but usually “correct.” A better technique would be to hook into the charger status announcements, but I don’t have time right now. :-(

9059PatchesFont/charsetVery LowWenQuanYi Unibit font2008-05-31William Poetra Yoga Hadisoeseno2008-05-313 Task Description

This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2].

I’m adding this font because:
1. Currently there is no good Chinese font for Rockbox.
2. The best Chinese font (unifont) has unevenly sized Chinese characters, while this font has uniformly sized Chinese characters.

The attachments contain screenshots of the simulator, to show how this font would look like on the iPod Nano. I’ve also attached a screenshot using the Unifont font to show the uneven sizes of Chinese characters, for comparison. I don’t know about other languages, but I’d think other CJK languages work better in this font as well, due to the merging of WenQuanYi Bitmap Song.

According to the project[3], this font is made by combining the GNU Unifont (GPL), WenQuanYi Bitmap Song (GPL) and Fixed-16×8 (Public Domain) fonts. The maintainer of GNU Unifont also acknowledges this fact at [4].

This font is licensed under the GPLv2 with a font embedding exception[3]:

[quote]
** GPL v2 license with font embedding exception:

As a special exception, if you create a document which uses this
font, and embed this font or unaltered portions of this font into
the document, this font does not by itself cause the resulting
document to be covered by the GNU General Public License. This
exception does not however invalidate any other reasons why the
document might be covered by the GNU General Public License. If you
modify this font, you may extend this exception to your version of
the font, but you are not obligated to do so. If you do not wish to
do so, delete this exception statement from your version.
[/quote]

I don’t mind either way, but it would be up to Rockbox developers whether to strip off this exception. And either way, the font is compatible with Rockbox’s license (GPLv2).

The font I’m attaching is a modified version (and only the bdf); you can download the original version from [5]. My modification is:

— wqy-unibit.bdf.orig 2008-06-01 04:47:36.839752214 +0800
+++ wqy-unibit.bdf 2008-06-01 05:01:51.031748178 +0800
@@ -64,7 +64,7 @@
CHARSET_ENCODING “-1” CHARSET_COLLECTIONS “ASCII ISO8859-5 GB2312.1980 BIG5-0 KSC5601.1989-0 JISX0208.1997 ISO10646-1” ENDPROPERTIES
-CHARS 46443
+CHARS 46444
STARTCHAR uni0000
ENCODING 0
SWIDTH 500 0

This is because convbdf will emit a warning “Warning: DWIDTH spec > max FONTBOUNDINGBOX” when converting the font. This is because there are actually 46444 STARTCHAR entries, but only 46443 glyphs – the character “mu” is encoded as 181 and 956, with the exact same glyph. The generated .fnt file is exactly the same with or without my modification.

Additionally, this font is quite big so it’s a bit big on the screen of the iPod Nano. But it would be great on larger screens. Please take a look at the screenshots in the attachments.

Links:
[1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?Unibit_README [4] http://www.unifoundry.com/unifont.html [5] http://downloads.sourceforge.net/wqy/wqy-unibit-bdf-1.1.0-1.tar.gz?use_mirror=osdn

8764PatchesFM TunerVery LowAuto mute weak stations2008-03-20Joel Garske72008-03-203 Task Description

Hi there,

first of all: this is my first contribution to rockbox and I tried my best to make myself familiar with the way things work there. I am sure, not everything is where it belongs. Please help me to get things in order :).

second: thanks to the author of Patch  FS#1803  that made this possible.

The purpose of this patch is to watch the tuner reported field strength (estimate) and mute, when it drops below a customizable threshold. Wether muting or not as well as the threshold are customizable in the fm tuner menu. It should not interfere with manual muting and should not affect recording (i didn’t test that yet). THe threshold is specified in pseudo-dBuV.
It also adjusts frequency display to display as MMM.KKK instead of MMM.KK. This is for people who adjust region settings and channel widths.

My testing conditions were limited to the sansa c250.  FS#1803  reports to work on the tuner chips LV24020LP (e.g. sansa c250) and TEA5767. I only tested the first. Please report back possible field strength values you see on devices using these chips.

This code should not break anything. I did a testbuild for some iPods (without tuner) that compiled cleanly. Simulator also works.

Currently only english and german translation are done.

User guide:
This patch conditionally adds 1 or 2 lines to the tuner main window that look like this:

Sig: [-M] -235dBuV
Automute below -555dBuV

The second line is only displayed if automute is enabled. The first line shows the status of the tuner. The 2 characters in the braces exlain as [ab]:

a: either 'O' or '-' 
   'O': current field strength is above threshold
   '-': current field strength is equal to or below threshold
b: either 'M' or '-'
   'M': will mute on or below threshold
   '-': automute disabled.
(both are only updated on field strength change)

The second line should be selfexplaining, same for the menu entries.

Request for comments!

7984PatchesDatabaseVery LowTalk clip support for Database2007-10-17Jonas Häggqvist42007-10-213 Task Description

Before you get carried away, this is the script that will build talk clips in /.rockbox/talkclips/* for all tags and labels (reading tagnavi.config as well as the database_[0-9]*.tcd files).

The idea is that the database code will then look here for talk clips.

In the long term, the same method could be used for the file browser if desired.

Hopefully someone will help me out with the database code side of things, as I don’t think I’m up to that challenge.

5757PatchesDriversVery LowCorrectly display short DOS file names in file browser2006-08-01Alexander Levin32006-08-053 Task Description

This is a sequel for  FS#5736 . It correctly displays the OEM-encoded short DOS file names.

Following code pages are supported: cp850 (western Europe), cp852 (central Europe), cp737 (greek), cp866 (cyriliic), cp862 (hebrew).

If you change the default code page (in the settings menu) and there are files that are displayed with the short DOS names, you’d better rebuild the dir cache (if it’s activated) since the UTF8-name of the file changes.

When I compile the modified sources, I get the following warning which I don’t understand:
CC common/unicode.c
common/unicode.c:136: warning: function declaration isn’t a prototype

Could anyone tell me what that means and what the reason is?

10511PatchesBuild environmentVery LowFixed multiple-language feature in tools/configure2009-08-11Rosso Maltese22020-07-142 Task Description

The patch fix the multiple-language feature, maintaining the same behaviour in interactive and batch mode and with “make reconf”. Now it’s possible to build more than one voice language at once, specifying different engine and option set for each one.
So, running “make voice”, all the selected languages will be built.

To help the comprehension, here it is a batch mode sample:

../tools/configure –target=ipodvideo –ram=64 –type=av –language=italiano,espanol –tts=f,e –voice=lp_diphone –ttsopts=, –encopts=’-q 10 -c 10,-q 5 -c 5’

This is like to run:

../tools/configure –target=ipodvideo –ram=64 –type=av –language=italiano –tts=f –voice=lp_diphone –ttsopts=’ ' –encopts=’-q 10 -c 10’

../tools/configure –target=ipodvideo –ram=64 –type=av –language=espanol –tts=e –voice=lp_diphone –ttsopts=’ ' –encopts=’-q 5 -c 5’

In the first case, I set the language to italian, using festival with voice lp_diphone (female), no further festival options and some manual encoder options.
In the second case, I set the language to spanish, using espeak. Even if I set the voice, the value is ignored, since the selected TTS engine doesn’t use it.

I also added some cosmetics, like some very circumstantial indentation, blank check in rootdir too, simpler numbered menu generation, some terser command pipes.

The patch is applied to r22250.

I don’t know if it’s a really wanted feature, but the word FIXME in the script hurt me! :-)

13097BugsOperating System/DriversVery LowPANIC white screen when plugging a non supported SD car...2017-01-12Mario C.12020-07-072 Task Description

Creative ZEN
Daily build: rockbox-creativezen-20170112

Bug description:
When plugging any dummy plastic or a non supported SD card, the device freezes and displays a white screen with a “PANIC” error message.
Plugging a standard SD card works fine.
To restore the system, you have to use a paper clip to do a hardware reset and turn the device on again.

12138PatchesPluginsVery LowFreecell game - new plugin for rockbox2011-05-29Jason Stark22020-06-292 Task Description

Hacking from Antoine Cellerier’s code for solitaire.c, I put together a rough freecell game.

It currently works for Sansa E200 targets. Others should work once button mappings are done.

This is not heavily tested, so feel free to report or fix any problems you encounter.

11249PatchesOperating System/DriversVery LowFixed Morse Code case switching (on Sansa Fuze / FuzeV2...2010-05-07Wenyu "Hearson" Zhang22020-06-292 Task Description

Hi all,

Currently for all models, the Morse Code input method can only type lowercased letters. Here I provide a patch which enables people to switch between lower cased and upper cased letters, I implemented this for Fuze and Fuze v2, and further fixes will be provided soon (or someone else want to add some key mapping options into your keymaps?)

The patch (also attached):

Index: apps/action.h

— apps/action.h (revision 25886)
+++ apps/action.h (working copy)
@@ -239,6 +239,7 @@

   ACTION_KBD_DOWN,
   ACTION_KBD_MORSE_INPUT,
   ACTION_KBD_MORSE_SELECT,

+ ACTION_KBD_MORSE_CASE_SWITCH,

   

#ifdef HAVE_TOUCHSCREEN

   /* the following are helper actions for touchscreen targets,

Index: apps/recorder/keyboard.c

— apps/recorder/keyboard.c (revision 25886)
+++ apps/recorder/keyboard.c (working copy)
@@ -148,6 +148,7 @@

#ifdef HAVE_MORSE_INPUT
/* FIXME: We should put this to a configuration file. */
+static bool morse_uppercase = false;
static const char *morse_alphabets =

   "abcdefghijklmnopqrstuvwxyz1234567890,.?-@ ";

static const unsigned char morse_codes[] = {
@@ -573,6 +574,11 @@

                       state.morse_code |= 0x01;
               }
               break;

+ case ACTION_KBD_MORSE_CASE_SWITCH:
+ if (state.morse_mode) {
+ morse_uppercase = !morse_uppercase;
+ }
+ break;
#endif /* HAVE_MORSE_INPUT */

           case ACTION_KBD_SELECT:

@@ -626,7 +632,8 @@

                   /* turn off hangul input */
                   state.hangul = false;

- kbd_inschar(&state, morse_alphabets[j]);
+ kbd_inschar(&state,
+ morse_uppercase ? toupper(morse_alphabets[j]) : morse_alphabets[j]);

               }

#endif /* HAVE_MORSE_INPUT */

               break;

@@ -862,6 +869,10 @@

           int morse_code;
           outline[0] = morse_alphabets[i];

+
+ if (morse_uppercase)
+ outline[0] = toupper(outline[0]);
+

           sc->putsxy(x, y, outline);
           morse_code = morse_codes[i];

Index: apps/keymaps/keymap-fuze.c

— apps/keymaps/keymap-fuze.c (revision 25886)
+++ apps/keymaps/keymap-fuze.c (working copy)
@@ -269,6 +269,7 @@

   { ACTION_KBD_DONE,         BUTTON_UP,                        BUTTON_NONE },
   { ACTION_KBD_ABORT,        BUTTON_HOME|BUTTON_REPEAT,        BUTTON_NONE },
   { ACTION_KBD_MORSE_SELECT, BUTTON_SELECT|BUTTON_REL,         BUTTON_NONE },

+ { ACTION_KBD_MORSE_CASE_SWITCH, BUTTON_HOME, BUTTON_NONE },

   LAST_ITEM_IN_LIST

}; /* button_context_keyboard */

13193PatchesConfigurationVery LowAdd option to disable settings reset on startup2020-04-01Stefan Ott12020-04-032 Task Description

I would like to run my iPod with its keypad locked all the time, thus I wrote a little patch to an option to disable the settings reset during startup regardless of the hold button's position.

You will find the patch attached to this message. I'm not entirely convinced by the name of the new option (or my wording in general) so if you have a better idea, feel free to rename things.

13178BugsDatabaseVery Lowall titles in database 2x, even after several rebuilts2019-09-08mike22019-09-112 Task Description

Version 9e186e34ab-190820

i have an ipod 7th gen
rockbox installed
140.000 titles

database contains in unpredictable many cases of the folders 2 times the same title
not in all folders, but it happens very often that i open one and i see all titles 2x although they are only 1x on the sd card

the files exist only ONCE
but the database keeps listing them all 2 times

i rebuilt it several times, but the database keeps on doing that

any hint what i can do?

start as apple / itunes and delete rockbox folder / install new did not help

12074PatchesSettingsVery LowAdd setting to enable/disable lineout on Sansa Fuze V22011-04-19Rob Walker242019-08-022 Task Description

This patch allows the line out on the Sansa Fuze V2 to be enable/disabled by means of the existing Lineout poweroff setting (previously used on some iPods).

By assigning this setting to the quickscreen I can switch between headphones and lineout after plugging into the dock. Still no luck in finding out how to autodetect the dock.

I'm not 100% sure that re-using the "Lineout Poweroff" setting is the right thing to do here as it's not powering on/off the line-out - just switching between headphones and line out

12974BugsPluginsVery LowStarfield plugin crash on c200v12014-04-19Franklin12018-07-242 Task Description

On my Sansa c250v1, the starfield plugin crashes at the address 0x01F80394 with a data abort.
It seems that the plugin is attempting to execute data.
Strangely, it does not happen in the simulator.

13076BugsOperating System/DriversVery LowiPod Classic (160GB Thick) - PANIC - usb_storage_init_c...2016-07-13A Man Eating Duck12016-07-132 Task Description

Hi,

I have installed Rockbox build 0F89B04-160628 using this (https://files.freemyipod.org/~user890104/bootloader-ipodclassic.html) method.

I have created a dynamic playlist (Database > long select artist > current playlist > Queue Shuffled). Play and then pause the music and then hold the play button down to shutdown rockbox. Plug in USB cable from your computer (Win10) in to the iPod and the iPod should start powering on and then a white *panic* screen should appear.

Workaround is to have Rockbox already fully booted before plugging in a USB cable from the computer.

13059BugsCodecsVery LowMP3 Codec decoding has artifacts2015-10-22Alex12015-10-222 Task Description

When playing music, I can hear codec errors in the music. It occurs every time on a certain song, and other songs that are smaller in file size, it does not occur on, but occurs on the next one. I believe it is a buffering issue, and makes the music unlistenable. I used the daily on 10/21/2015

On 320kb/s MP3s it occurs much more often, and 128kb/s MP3s it occurs less often, but when it occurs its a series of glitches that distort the music.

I am sure its not the MP3s themselves, because it doesn't occur in the official firmware, and when I rewind it, it does not make the same sound until later. It has a very prominent 'glitchy' sound and later it changes the speed of the song.

I replaced it with the 3.1.3 MP3 codec, and the same glitch occurs.

I do not have a line out so its made through the speaker, but the problem is so bad that you can hear it very clearly.

The MP3 was 320kb/s

Memo is the glitchy one, and Memo-1 is it being played correctly.

13040PatchesPlaylistsVery LowPlaylist becomes one item shorter when shuffled2015-03-21Thomas White12015-05-302 Task Description

I noticed that the playlist seems to become one item shorter when I shuffle it, using the latest Git master branch (commit 70d57080) on a Sansa Clip+.

Steps to reproduce:
1. Clear the playlist by pressing Stop (power button)
2. Add a small number of tracks to the playlist
3. Shuffle the playlist (playlist view, menu, Shuffle)
4. Observe that playlist is one item shorter than before

I tracked the reason for this down, and attach a patch. This isn't a "proper" fix, and is a bit hacky, but it does illustrate what causes the problem.

13022BugsUser InterfaceVery LowReplaygain display error in WPS in Musepack files when ...2015-01-04Abel2015-01-042 Task Description

I use the attached custom WPS that displays the active Replaygain value and type next to the track number.

When playing mpc files created by foobar2000 with the tracknumber/totaltracks tag format, if the track# is 10 or higher and the applied gain negative (as in the attached mpc), mangled characters are displayed between the gain value and type, eg:

10/12 -2.00 dB *gibberish* (Album)

This is reproducible with the latest simulator build d0fffd6-150104 but I only recently noticed the issue and don't know when it began. I have an old sim build 935d8be-121229 and it works correctly there.

13003BugsUser InterfaceVery LowScrolling line broken if put directly after sublines.2014-09-24Oid Maps2014-09-242 Task Description

## This was tried out with Sansa Fuzev2 simulator version d392da8-140922, built from git on a 64 bit Linux system ##

I discovered something which seems to be a bug somewhere in the place where WPS get interpreted or rendered.

When I use a scrolling line just after a line containing sublines, the scrolling line stops scrolling as soon as the sublines change the first time.

Below are steps to reproduce it on the UI simulator for the Sansa Fuzev2. I think it also works without using a clear configuration. I haven’t tested with a real device, only with the simulator.

Attached are a .wps-file showing the buggy behaviour (’scrollline_after_sublines_bug.buggy.wps’), and a .wps-file working correctly (’scrollline_after_sublines_bug.workaround.wps’), which are the same files as quoted below.

STEPS TO REPRODUCE:

(0) Use Sansa Fuzev2 simulator version d392da8-140922, build from git on a 64 bit Linux system.

(1) Use a clear configuration, so erase

    .rockbox/.playlist_control
    .rockbox/config.cfg
    .rockbox/nvram.bin
    .rockbox/database.ignore
  in your 'simdisk' directory.

(2) Start the rockbox UI simulator

(3) Change the theme to ‘rockbox_failsafe’, i.e. in the menu, do the following:

  • ‘Settings’ → ‘Theme Settings’ → ‘Browse Theme Files’ → ‘rockbox_failsafe.cfg’
  • ‘Settings’ → ‘Theme Settings’ → ‘While Playing Screen’ → ‘rockbox_failsafe.wps’
  • ‘Settings’ → ‘Theme Settings’ → ‘Radio Screen’ → ‘rockbox_failsafe.fms’
  • ‘Settings’ → ‘Theme Settings’ → ‘Base Skin’ → ‘rockbox_failsafe.sbs’

(4) Use the following .wps-file as the “While Playing Screen” skin:

=⇒ # Two sublines:
Text1;Text2
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
# Another line of just text (Not needed to reproduce the bug, but if it is swapped with the long line above, the long line scrolles correctly):
Textline.
#### Here the following Bug appears:
# When the Line ‘Text1;Text2’ changes the sublines the first time, the subsequent line stops scrolling. It happens when the sublines change; as when you use ‘%t(5)Text1;Text2’, the scrolling stops only after 5 seconds, when the sublines actually change.
⇐=

Workaround:
(4a) Put the scrolling line not directly after a line with sublines. The following .wps as the “While Playing Screen” skin works:

=⇒ # Two sublines:
Text1;Text2
# Another line of just text. Needed to make the long line scrolling correctly:
Textline.
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
#### Here the bug does not appear, the long line scrolls corretly. But when the long scrolling line is put just below the line with the sublines, it stops scrolling as soon as the sublines change for the first time.
⇐=

12998BugsThemesVery LowVertical progress bar (%pb) glitches at the start of a ...2014-09-16Guillaume Cocatre-Zilgien22014-09-162 Task Description

Consider the following theme markup:

%Vl(progressbar,306,156,10,80,-)
%pb(0,0,10,80,progressbar.bmp,vertical)

That draws a vertical progress bar that will get filled from bottom to top. When a song starts to play, the progress bar is one pixel high, at the correct position (at the bottom of the viewport). That 1px-high image quickly jumps up one pixel (moves up by one pixel), then comes back down one pixel (at the correct position) whenever the progress percentage is high enough. The progress bar then displays normally and grows as the song is playing. See attached screenshots.

Expected behavior: the position of the progress bar (relative to the viewport) should not change. The bug has been observed in the iPod Classic and Clip Zip sims (builds 1bc89bd and 77bfff5) as well on the actual devices. Inverting the progress bar (with the "invert" parameter) shows the correct behavior (inverted bar with no such glitch).

Affected themes: Ash (iPod Classic), SugarBrown (Clip Zip).

12856BugsMusic playbackVery LowHE-AAC plays back at wrong speed2013-04-21Julian Hughes42013-08-242 Task Description

Rockbox 3.1.3 on Clip+ (also iriver h140/340. also previous versions of rockbox).

Some HE-AAC files play back at half speed.

Example file info (comment/lyric fields removed as very long):

General
Complete name : Witness_-_The_Khmer_Rouge_take_power.m4a
Format : MPEG-4
Format profile : Apple audio with iTunes info
Codec ID : M4A
File size : 4.09 MiB
Duration : 9mn 0s
Overall bit rate mode : Constant
Overall bit rate : 63.5 Kbps
Album : Witness
Album/Performer : BBC Radio
Track name : The Khmer Rouge take power
Grouping : News
Performer : BBC World Service
Composer : BBC iPlayer
Genre : News
Recorded date : 2013-04-18T08:50:00+01:00
Tagged date : UTC 2013-04-18 09:07:25
Writing application : Lavf55.0.100

Audio
ID : 1
Format : AAC
Format/Info : Advanced Audio Codec
Format profile : HE-AAC / LC
Codec ID : 40
Duration : 9mn 0s
Duration_LastFrame : -1ms
Bit rate mode : Constant
Bit rate : 62.7 Kbps
Channel(s) : 2 channels
Channel positions : Front: L R
Sampling rate : 48.0 KHz / 24.0 KHz
Compression mode : Lossy
Stream size : 4.04 MiB (99%)

30 second sample attached (cut with ffmpeg, full metadata)

Forum report http://forums.rockbox.org/index.php/topic,43012.0.html

12639BugsThemesVery LowCertain themes cause the WPS to not load properly and U...2012-04-08Ludovic Jacques112013-08-152 Task Description

Both issues seem to appear with any version of my theme and with any build.
Let's try it with the latest version 1.30 of my theme (in attachment but also here: http://themes.rockbox.org/index.php?themeid=1585 ) and a recent build (I use version: 0c4bd3a-120406)

-Theme loading

When you load the theme for the 1st time, the WPS will never load properly (failsafe). The workaround is to turn off the device and turn it on again and then the WPS will always load properly until you reload the theme for some reasons (trying another theme and revert back to mine etc).
I tried both with the full theme version and this "light" version of WPS: http://pastie.org/3747546

-USB connection (tested on Windows 7, with or without a microSD, and there isn't such an issue with the other themes)

If I plug the USB cable while the player is on or off, it will almost never mount properly.
Usually the USB screen appears on my SBS, the computer recognizes a USB device is connected but either nothing appears in "my computer" or the device appears but is not accessible. When I unplug the USB cable, the Zip gets stuck on the USB screen and only reset can turn it off.
Sometimes it even displays some erros like that when plugging the USB cable: "data abort at 30FSR 0x8 (domain 0, fault address 0x964176 bt pc: 0x3006AC3 bt end" , sometimes it doesn't display the USB on SBS but gets stuck on the main menu.
And rarely in the same conditions it also mounts properly…

Like for WPS, I made a "light" version of SBS without the status bar and that way the Zip seems to mount and unmout properly every time!
http://pastie.org/private/cauhxelaip7hrpqpcwdbxw So maybe a tag in the status bar causes the issue with USB connection?

12840BugsUser InterfaceVery LowLock/Unlock-Message does not disappear completely 2013-03-11Conrad Kostecki42013-07-272 Task Description

Hi,
I am using a Sansa Clip Zip with Rockbox 3.13.
I’ve noticed, when I lock or unlock the device, the message, which indicates the current state, does not disappear completely. Its still there.

Cheers,
Conrad

12865BugsDriversVery Low5G iPod USB connection errors and full speed mode if ha...2013-05-24Boris Gjenero12013-05-252 Task Description

With my 5th generation iPod, if I connect USB while the hard drive is spinning, I often get full speed mode instead of high speed mode. This testing is with 00b8563, but I’ve observed the same problem in the past. Here’s the relevant part of Linux 3.8.0-21-generic dmesg output:

[26644.712035] usb 2-2: new high-speed USB device number 18 using ehci-pci
[26644.904471] usb 2-2: device descriptor read/all, error -71
[26644.965905] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.967780] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.968004] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.971577] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.973440] ehci-pci 0000:00:1d.7: port 2 reset error -110
[26644.973459] hub 2-0:1.0: hub_port_status failed (err = -32)
[26645.176048] hub 2-0:1.0: unable to enumerate USB device on port 2
[26645.428038] usb 6-2: new full-speed USB device number 8 using uhci_hcd
[26645.979070] usb 6-2: not running at top speed; connect to a high speed hub
[26646.009069] usb 6-2: New USB device found, idVendor=05ac, idProduct=1209
[26646.009076] usb 6-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[26646.009080] usb 6-2: Product: Rockbox media player
[26646.009083] usb 6-2: Manufacturer: Rockbox.org
[26646.009087] usb 6-2: SerialNumber: 100000000000A270014B32BEB
[26646.024242] scsi21 : usb-storage 6-2:1.0
[26647.038109] scsi 21:0:0:0: Direct-Access TOSHIBA MK3008GAL BU11 PQ: 0 ANSI: 4
(I’ve removed the remaining USB storage messages because they don’t seem relevant)

If the hard drive is not spinning, I get high speed mode. However, there is a disconnect and the device is detected twice:

[27356.784126] usb 6-2: USB disconnect, device number 9
[27371.208044] usb 2-2: new high-speed USB device number 24 using ehci-pci
[27371.347053] usb 2-2: New USB device found, idVendor=05ac, idProduct=1209
[27371.347058] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[27371.347062] usb 2-2: Product: Rockbox media player
[27371.347065] usb 2-2: Manufacturer: Rockbox.org
[27371.347069] usb 2-2: SerialNumber: 100000000000A270014B32BEB
[27373.079038] scsi25 : usb-storage 2-2:1.0
[27373.337244] usb 2-2: USB disconnect, device number 24
[27373.640029] usb 2-2: new high-speed USB device number 25 using ehci-pci
[27373.779220] usb 2-2: New USB device found, idVendor=05ac, idProduct=1209
[27373.779226] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[27373.779229] usb 2-2: Product: Rockbox media player
[27373.779233] usb 2-2: Manufacturer: Rockbox.org
[27373.779236] usb 2-2: SerialNumber: 100000000000A270014B32BEB
[27373.820382] scsi26 : usb-storage 2-2:1.0
[27374.823266] scsi 26:0:0:0: Direct-Access TOSHIBA MK3008GAL BU11 PQ: 0 ANSI: 4
(Again, I’ve removed the remaining USB storage messages because they don’t seem relevant)

I get the same behaviour regarding high speed vs. full speed mode in Windows 7, but I’m not aware of Windows reporting other USB errors anywhere.

I was sometimes having USB difficulties that seemed to be due to contact oxidization or dust from not using the dock connector in a long time, but I don’t think that’s the cause here.

I’m attaching USB traces from WireShark using Linux usbmon. In both cases I removed all the USB mass storage stuff after get max lun because it seems irrelevant and increases file size a lot. When the result is full speed, something goes wrong after the set address response. When the result is high speed, something goes wrong after the set configuration request. In both cases the first sign of trouble is an interrupt from the USB hub.

This is on a Gigabyte GA-P35-DS3R rev V1.0 motherboard with Intel P35 + ICH9R chipset.

12576BugsID3 / meta dataVery Lowwma files with cover_art picture are not read on Sansa ...2012-02-03Ch P42013-03-012 Task Description

Player = Sansa ClipZip
Rockbox current build :

Target: sansaclipzip
Target id: 68
Target define: -DSANSA_CLIPZIP
Memory: 8
CPU: arm
Manufacturer: as3525
Version: 7d54ff0-120203
Binary: rockbox.sansa
Binary size: 595788
Actual size: 595780
RAM usage: 922040
Features: alarm:backlight_brightness:crossfade:dircache:flash_storage:lcd_bitmap:lcd_non-mono:lcd_color:pitchscreen:multivolume:multidrive_usb:quickscreen:radio:recording:recording_swcodec:recording_mic:rtc:swcodec:tagcache:tc_ramcache:charging:large_plugin_buffer:ab_repeat_buttons:albumart:usb_power:usbstack
gcc: arm-elf-eabi-gcc (GCC) 4.4.4
ld: GNU ar (GNU Binutils) 2.20.1.20100303
Host gcc: gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)
Host system: Linux

I cannot read .wma files with cover_art jpg.
The same file on the Sansa ClipZip as MSC storage is read correctly by plenty of players on my Ubuntu-PC : totem, VLC, mplayer …etc… I join a file as example (with and without cover_art jpg).

12496PatchesOperating System/DriversVery LowRaaA WebOS2011-12-30Jason Yu102013-01-042 Task Description

Rockbox WebOS app.

Built on r31467, 32/64-bit Ubuntu 11.10, running on a 32GB Touchpad

Directions (only tested on the above):

* Install WebOS PDK: https://developer.palm.com/content/resources/develop/sdk_pdk_download.html

* Install platform-native libsdl-dev if you haven't already. Only needed to pass configuration check as the PDK doesn't properly install staging sdl-config for some reason.

* Apply patch (patch -p0 < filename.patch)

* cd webos

* ../tools/configure, select WebOS target (206)

* make && make install && sh ./buildpkg.sh

Notes:

* This is one big hack – I fudged just about everything in /firmware (how the target system works is still not altogether clear to me) and piggybacked a lot of this off of the SDL target. Mostly in the interest of getting it to run without adding ifdefs all over the place. Obviously we'll want to be more methodical and thorough about exactly which changes need to go where moving forward.

* The Touchpad's SDL video implementation appears to adjust orientation and scale output to fit within 1024x768 as best as possible. This means that a 800x480 build will appear in landscape mode, letterboxed, while a 320x480 will appear in portrait mode, pillarboxed. The device itself automatically orients to landscape – meaning, if you're in a portrait resolution and then you exit, everything will initially be sideways – but that doesn't affect input. Scaling routines are noticeably slow.

* I tried building this as a hybrid Enyo/PDK (window mgr friendly) app but had some problems with the native part failing to execute at SDL_Init. So for now no backgrounding or notification bar.

* Make scripts use the ARM compilers installed with the PDK. I'm wondering though if this is superfluous given that the Rockbox toolchain also supports ARM7. I did try exposing some of the ARM-specific assembly but the compilation failed with the PDK compiler.

800x480 build: http://www.jasonyu.net/webos/org.rockbox.raap_0.0.1_all.ipk

12758BugsLanguageVery LowIncorrect display of labels in Russian2012-09-28Sergey Gubanov42012-10-062 Task Description

In the "Graphic Equalizer" menu and when I connect the player to a computer to transfer the data labels are displayed incorrectly (instead of letters symbols, as in the screenshot).
The problem occurs when I use the Russian language.
The problem I see for a long time, please fix it.

Screenshot of the screen that is displayed when transferring data, I could not do.
P.S. Sorry for my bad English.

12692BugsRecordingVery LowRecording - positive clipping wraps around to negative ...2012-06-11dockjkox22012-06-122 Task Description

On my Sansa Clip+ 4GB, with Rockbox v3.11.2

Recording a wav file through internal microphone. If the audio signal clips at the positive limit, bad things happen:
1) Most of the time the recorded signal wraps around to a full scale negative value, which makes it sound terrible.
2) Sometimes the recorded signal wraps around to a near zero value, which still makes it sound terrible but the distortion is not so loud

3) Clipping at the negative end of the range is as you would expect - a flat line which sounds like normal digital distortion, as you would expect

See attached picture of the recorded waveform showing each of the 3 situations described above.

12629BugsLanguageVery LowRTL support in android devices2012-04-01Haim22012-04-042 Task Description

It's Seems to be no support for RTL languages like Hebrew and Arabic in rockbox for android.
Instead of מוסיקה written הקיסומ (in English - Instead of "Music" written "cisuM).
I attach pictures for example:

12608BugsUser InterfaceVery Low%pb tag draws larger area than bitmap, showing pixel ga...2012-03-07Thomas Martitz12012-03-072 Task Description

The %pb tag has a small problem. If an image is specified but no height, the tag draws the size of a line even if larger than the the image. This leads to pixel garbage below the progressbar.

The test.wps reproduces the problem in the 320x480 sdl app The default font, 27-adobe, has to be selected probably. The wps works if a height, i.e. 20 in this case as the image height, is specified

Test.png shows the problem. test.zip is the small test theme.

12589BugsConfigurationVery LowConflicting config/theme2012-02-14Arne Stierman32012-02-152 Task Description

The config caused the iPod to appear frozen (frozen screen) after bootup. The iPod would boot, show the normal boot screen and then created a boot screen mixed with theme settings. Picture: http://imgur.com/E4srA the iPod refuse and refused to mount.

Fix:
1: Boot into recovery diskmode
2: Remove conflicting config.cfg
3: Reboot into normal mode

12490PatchesID3 / meta dataVery LowWPS tag for number of channels2011-12-27Frank Gevaerts32011-12-282 Task Description

This patch adds a %ch tag that returns the number of channels in the current file.

Unfortunately, the large majority of codecs don't fill in this field in struct mp3entry. In the codecs covered by the rockbox testfiles collection, only atrac, cook and tta actually work.

I don't think it makes much sense to commit this with so few supported codecs, so help is appreciated on the codec side of things

11862PatchesUser InterfaceVery LowAdd a frequency response graph to the graphic equalizer...2011-01-06Attilio Scotolati82011-11-182 Task Description

This patch adds a frequency response graph below the equalizer's controls, making it an EQ that is actually "graphical". :-)

I'm still not sure about the accuracy of the represented curve, in particular the Q factor on the peaking filters seems to have an effect opposite to the expected, though the equations are taken from the same "audio EQ cookbook" the equalizer is based on, any help is appreciated!

The user interface is still incomplete, I want to add proper tags on the axes and bars. I also thought about re-enabling the theme on this screen (why is it disabled?) and change the behavior of the "right" button, making it consistent with other menus.

Tested on a Sansa e200.

12350BugsRecordingVery LowClipv2 - Rockbox duplicates samples - effectively halve...2011-10-26neum22011-10-272 Task Description

What the title says.
At whatever sample rate I use (24k & 48k tested), each sample is duplicated.

12334PatchesUtilsVery LowUpdate to my tools/talkclips.py script2011-10-15Daniel Dalton12011-10-152 Task Description

Update to my tools/talkclips.py script. Minor updates which include:
- Better handling of logfile eg. we don't leave it open as was the case
before
- Report a few more details in the log eg. start/end time, duration, and
number of talk clips created. This is useful to dettect how many files
had problems…
- Summarise output for user at end, of processing, number of talkclips
created and how long this took (in seconds).
- Report to user how many talk clips will need to be created to give
them an indication of potential waiting time etc. This is calculated by
first determining how many files are on the device excluding .talk files, and how many .talk
files there are, and calculating the difference.
- This information allows a percentage indication to be drawn throughout
the script, so now the user can track the percentage as processing takes
place.

Patch is attached.

Thanks.

9954BugsRemoteVery LowiAudio X5L remote erratic starting with build from 2009...2009-02-25Chris Miller152011-09-282 Task Description

I have been using Rockbox for almost 2 years now on my X5L together with the remote and I have frequently updated to the current version, so I am familiar with how it works.

I have noticed that after updating to version 20090221, my X5’s remote’s LCD behaves erratically (strange lines being displayed all over, vertically shaky image) right after booting Rockbox, then the display turns off completely after a few seconds. Strangely though, the controls still work and the blue display light comes on when working the controls, but the display is turned off (there is nothing being displayed, as if the player were turned off). If I unplug and reconnect the remote, the remote’s LCD comes on, but soon turns off again. The X5’s main LCD is working just fine.

I thought that my remote was dying on me, but decided to check if it was somehow related to the development of Rockbox. I reverted back one build after another and found that the last build that works OK for my remote is 20090210. So, in all the builds starting with 20090211 (I have thoroughly checked all from 20090211 to 20090225), the remote is practically unusable. I looked at the changes done on that day (http://www.rockbox.org/daily/changelogs/changes-20090211.html), but could not single out the probable cause.

Great software, anyway!

12277PatchesThemesVery LowWPS tags for the list item number and the "divisible" o...2011-09-13Alexander Levin82011-09-182 Task Description

The patch adds two new WPS tags:

1. %Ln yields the number of the list item currently being drawn

2. The operator "/?" (which can be used in the %if tag) yields the string "div" if the first operant is divisible by the second and NULL otherwise.

With these two additions it should be possible to create themes where list items are coloured alternately (as an example).

The whole work has been done by gevaerts on 2011-09-12 (and all the credits also go to him), I only placed the patch to the patch tracker, changed the operator from "/" to "/?", and changed the function name from "skinlist_get_item" to "skinlist_get_item_number".

He posted the patch on the binpaste and it would be pity if it got lost.

12076BugsDatabaseVery LowAutoresume feature can start from wrong offset due to r...2011-04-19Rob Walker152011-08-082 Task Description

I've found a problem with the new autoresume feature in 3.8. I use it when listening to podcasts and sometimes find that it resumes from near the end of a new episode - e.g. on a 30 minute podcast it will resume from 28 or 29 minutes - usually about the place where a previous epidsode finished and I skipped past the end credits.

What I think is happening is that there is some code in the database that tries to resurrect the runtime statistics for files that have been deleted and then restored - as the last offset is in this data, it is reusing the last offset from an old episode.

I've put some more logf()s in tagcache.c in build_numeric_indices(). I can see that if the filenames don't match (line 2306) it then tries to match any 2 tags out of the 3: artist, album or title. For the podcasts, the artist and album are always the same (i.e. the producer and which one of their podcasts it is), but the title is different (i.e. "Episode 100", "Episode 101", etc). So if I've listened to Episode 100 and then deleted the file, and then add Episode 102 to the player, it matches the artist and album and so resurrects the wrong data from Episode 100.

I've disabled the resurrection based on tags (just commented it out) and the problem seems to have gone away. A better fix would be to ensure that all 3 tags or matched or to ensure that title is one of the matched tags

11919BugsBootloaderVery LowNo SD-Card support in USB mode after boot2011-02-02Jens Erdmann52011-07-152 Task Description

I got no SD-Card support for my E-250 after boot into USB mode.
I plug in my powered off player into usb and only have access to internal storage.

If i plug in my player booted up there is no problem.

I am using daily build r29174-110131.

8569PatchesRemoteVery LowIriver remote keymap changes2008-02-09Steve Bavin72011-07-122 Task Description

The attached patch slightly modifies the keymap of the H300 non-LCD remote to allow access to the browser from the WPS (by use of LONG PLAY).

I know that it works ok from an H300 with a non-LCD remote, but I don’t know if I’ve broken the LCD remotes completely.

Please could users of both the H100 and H300 LCD remotes try this patch and tell me that the WPS context keymap is unaffected. For reference, you can see the intended mapping here: http://www.rockbox.org/twiki/bin/view/Main/KeymapIriverHSeries

9205BugsCodecsVery LowWMA Decoder - Problematic Files (Gaps/Skipping) - Examp...2008-07-19Andrew Beveridge52011-04-202 Task Description

Hello World :)
Attached is a VBR WMA music file, which fails to play correctly on my “RockPod” iPod Nano.
The same file decodes perfectly using the latest ffmpeg build.
Therefore I can only assume there is something about this file which triggers a bug in the Rockbox-specific WMA decoder.
Also attached is a microphone recording of the sound which comes out of my iPod when Rockbox attempts to play the faulty WMA.

I have over 3000 WMA tracks, all encoded using an identical method, all of which will not play correctly in rock box, so if you would like any more examples, or information, please ask.

Thanks for all your help :)
(If there is any way I can help debug/update the code for the wma decoder, please let me know where to start, I understand the C source code pretty well)

~Andrew

12073PatchesDatabaseVery LowDynamically add files to database as they are played2011-04-18sideral32011-04-192 Task Description

These experimental patches dynamically add new tracks to the database when they are played. This allows users who (for various reasons [1]) prefer to not fully initialize the database to take advantage of database-based features such as autoresume (remember a resume position for each file), runtime statistics, or track ratings.

The current patch set is only a prototype. It's still somewhat inefficient because it does a full database commit and reload for each new track that is played.

The actual database-extension patch (patch 0002) works by refactoring tagcache_build to create a new interface, tagcache_add_file, that adds a single file to the database. This new function runs in the database thread and takes a dircache_entry pointer, which is provided by way of a Q_UPDATE event. The audio thread generates this event in tagtree_buffer_event when the initial DB lookup fails, and later checks the database again in tagtree_track_finish_event. If the DB commit and reload have succeeded in the meantime, this second lookup will succeed and the runtime information the user is interested in (stats, resume info) can be stored in the DB.

Patch 0001 changes the DB commit's buffer-allocation preference from using the dircache buffer to using the RAM DB's buffer. (This used to be the preference until r10003 reversed it, supposedly because the dircache buffer typically is bigger. I don't know yet how valid this argument is today.) This reversal avoids needlessly flushing and refilling the dircache and makes the Q_UPDATE event-passing mechanism more robust (because in-flight update events contain dircache_entry pointers, which would have to be invalidated when the dircache is flushed – which is not done yet).

Current limitations/caveats:
* Requires dircache and Load-DB-to-RAM enabled (and only works on targets that include these features)
* tagcache_add_file does not respect any database.[un]ignore files in the directory hierarchy above the added new file.
* DB needs to be initialized to begin with. There's no UI function for a basic DB initialization (without scanning and adding all files) yet.
* Not very thoroughly tested (mostly in simulator, with small file sets)

Possible improvements:
* Delay committing DB changes if more track-add events are in the tagcache queue
* Incremental commit: Could be optimized for add-one-track case
* Incremental load_tagcache: Avoid flushing and reloading full database
* Add function to initialize an empty DB

Comments welcome!

Footnote:
[1] Reasons for not using the database, or not keeping it up to date, include: metadata parser instability; prefer not keep tags up to date; prefer file browser over database browser

11877BugsOperating System/DriversVery LowFilesystem corruption after entering USB mode2011-01-14sideral112011-04-182 Task Description

Various users on IRC recently reported cases of filesystem corruption. I have seen them as well, especially when using USB mode (I'm using a Sansa ClipV2, USB-enabled through  FS#11664 ).

One strangeness I've experienced is that when my system has detected filesystem corruption, it is often enough to remove the player from USB and then replug it, without repairing the filesystem and without rebooting Rockbox; on the next USB mount, the filesystem is clean. This might indicate that some buffer is flushed too late for the USB host to see.

[EDIT: Removed previously attached patch, which is now tracked separately as FS#11883.]

11927PatchesDatabaseVery LowQueue overflow during database initialisation2011-02-11Steve Bavin82011-04-142 Task Description

While the database initialisation is running, the tagcache queue can overflow due to system broadcast messages. This can be seen by running a simulator (it will crash with KERNEL_ASSERT after a while) or on a target by enabling KERNEL_OBJECT_CHECKS, then initialising the database and repeatedly connecting/disconnecting a charger.

The same problem may well happen with other queues (dircache, for example).

11930PatchesGamesVery LowBomberman2011-02-12Lev Panov2011-02-122 Task Description

Bomberman like game with ai.
Not finished yet - lots of bugs and things to be done are known :)
Tested on Cowon D2 and also on some simulators with the same screen size (will work on other screen sizes too, but not now).
Somebody test it on iPod Video and on Zen Vision:M please.
Any suggestions greatly appreciated!
Hope the patch will work…

9917PatchesDriversVery LowCowon D2 Usb Serial2009-02-16Michaël Burtin52010-10-262 Task Description

Here’s a patch to have a functional usb_serial driver allowing the use of “Logf over Usb” debug function.

11665PatchesLCDVery LowLCD functions ignore viewport bg_pattern if a backgroun...2010-10-11Jonathan Gordon42010-10-112 Task Description

at least in the 16bit lcd drivers, all functions which use transparency (or clear pixels) get the pixel colour from the backdrop image, completly ignoring the bg_pattern.

This isnt a problem except in skins where it is perfectly reasonable to want a background image for most of the screen but a solid colour for one or two viewports.

There is a tiny problem though, bg_pattern is set to LCD_DEFAULT_BG which is a valid colour, so we probably need to add a flag to the viewport struct to say if it should ignore the background image or not.

11545PatchesGamesVery LowChopper improvements2010-08-16Michael Marley32010-08-262 Task Description

This patch contains several improvements to the Chopper game designed to make it run with a high framerate instead of a low, jerky one. Previously, the game depended on sleeping for a number cycles before drawing another frame, causing very jerky motion. Now the game should run at a high framerate all the time. The gameplay should be about the same, at least on targets with a display of >64px. I don’t have any of these smaller targets, so I wasn’t able to test. Please tell me what you think of my changes.

Showing tasks 151 - 200 of 669 Page 4 of 14<<First - 2 - 3 - 4 - 5 - 6 - Last >>

Available keyboard shortcuts

Tasklist

Task Details

Task Editing