Rockbox

Right now if the voice file fails to load, there’s a splash message but blind users won’t be able to see it.

(usually this happens because they upgraded rockbox without upgrading the voice file too)

It would be useful if we could embed a failsafe voice file, containing only that one prompt, so the user will know what is going on.

Just English for now, though ideally one for every language we support.

(Oh, and a pony too. Please?)

This patch adds SubRip subtitle support to MPEG Player.
http://wiki.multimedia.cx/index.php?title=SubRip

Files need to have the same name as the video file with a “.srt” extension.

I know that the OSD rendering is not implement in a way that linuxstb and jhMikeS would like but I still wanted to post the patch here in case anyone felt like adapting it. (Current OSD only renders on top of the video area, it can be adapted to add other OSD channels … like display a seek bar, volume control, playback state, etc.)

Enjoy,

Edit: I’ve also added a timebar display (when changing the volume)

Neither of the tools, ipodpatcher or Rockbox Utility 1.4.0, work on macOS Catalina.

Catalina removed 32bit support.

Using ipodpatcher generates the following error:

bash-3.2$ ./ipodpatcher
bash: ./ipodpatcher: Bad CPU type in executable

And Rockbox Utility has a white circle with a line through it indicating that it does not work with this version of the OS.

(see attached file)

Whenever screendump is enabled,It gets a panic error.
Error Message:
*PANIC*
Stkov usb
pc:080739ac sp:080f5458

Update to my tools/talkclips.py script. Minor updates which include:
- Better handling of logfile eg. we don't leave it open as was the case
before
- Report a few more details in the log eg. start/end time, duration, and
number of talk clips created. This is useful to dettect how many files
had problems…
- Summarise output for user at end, of processing, number of talkclips
created and how long this took (in seconds).
- Report to user how many talk clips will need to be created to give
them an indication of potential waiting time etc. This is calculated by
first determining how many files are on the device excluding .talk files, and how many .talk
files there are, and calculating the difference.
- This information allows a percentage indication to be drawn throughout
the script, so now the user can track the percentage as processing takes
place.

Patch is attached.

Thanks.

The attached patch fixes a minor compiler warning on 64 bit platforms.

The following set of WPS tags demonstrates:

# WPS Document
%wd
%V(0,0,-,10,2)%Vb(000000)%Vf(FFF000)
%aL%cH:%cM %ac%pv %aR%bt
%V(0,11,-,30,2)%Vb(000000)%Vf(FFF000)
%it

If you alternately insert and remove a space between the second occurence of %Vb/%Vf, the track title text appears and disappears. It appears to happen in a few other variations, but this is the shortest concrete example.

Emuriver is an emulator (not simulator) for iriver ifp-7xx series. It’s part of the http://www.rockbox.org/wiki/IriverIfpPort and has until now been hosted at the main author’s (Tomek’s) site http://www.mimuw.edu.pl/~tmal/rockbox/ It includes a tool to create flash images for use with the emulator, and a tool to mount such images and do basic file management on them.

This version is almost identical to the last version from Tomek’s site, but I had to fix a few bugs to make it usable on my system. Changes are as follows:

flashimgtool.c: Outputs usage information on errors. (I didn’t do this; I don’t know where this code came from but it’s useful.)

hardware.c: Bug: Arguments were missing in a function call which would sometimes cause segmentation faults, and (I don’t know why or how) slow down the emulator.

main.c: Changed a default file name from prog_flash.bin to prog_flash.img (I didn’t do this)

main.c: Bug: Added explicit return value to nonvoid function. The implicit return value was sometimes -1 which indicated an error so emuriver aborted.

make_flash_img.c: Optimizations: “if” replaced with “else if”. (I didn’t do this)

uicurses.c: Rename a variable into someting more unique. (I didn’t do this)

The reason I’m submitting this patch is that I think the emulator could be useful as it is for those trying to build the ifp port from SVN, that it could (maybe) be worked on to support other players, and that my bugfixes should be included for those building emuriver.

There are a few issues: The flashimgtool subdir in emuriver duplicates a few (three years old) files from RB, disk.c, fat.c, and some more. You might not like the directory structure. It uses an ancient version of autotools. I haven’t been able to create flash images that actually work with flashimgtool. I haven’t built the RB port for ifp yet, so I don’t know if it will run in emuriver or not.

Yes I have discussed the patch in IRC.

The aim of this patch is to make releases as simple as possible... i.e the end goal would be to have someone run “$ ~/rockbox/tools/release/release.sh 3.3” and that would do everything except feed the cat...

the first version just modifies bins.pl to accept a version number which eventually gets passed to the Makefile and used in the source to set the version string in the source to “3.x-rBLAAA”.

This also defines RBRELEASE which can be used in the source to do stuff, for example, remove the debug menu in releases (if we decide to do that...) (RELEASE is defined in speex so had to add the RB prefix...)

Also, this changes the way configure is run to use command line args instead of passing input to it which is Just Wrong (TM) :p

Create database application.

1) At first FS9349 patch file (http://www.rockbox.org/tracker/task/9349?getfile=17401) apply.

2) After this task’s patch apply.

On my X3, it triggers the MIPS equivalent of a segfault. (directory has 792 entries, tried to access it with only 500 allowed)

Rather than crashing outright, I think it would be better to detect this and somehow error out gracefully?

I store the album art by putting a folder.jpg file in the album's directory.
Any WPS on other players shows the cover pictures properly if album art is enabled in the theme.

I am aware of caveats like progressive jpgs, that are not supported by RB.

In the attached zip file, there are four directories with a folder.jpg file and a free opus file for demonstration purposes.

All pictures show up fine on my Sansa E200 (v1) using CabbieV2 or lebellium_Samsung-like.
However, on my XduOO x3ii the pictures are not displayed for the examples 1 - 3, but show for example 4.

None of the jpgs are progressive and I cannot figure out a difference between 1-3 and 4.

I don't know how to debug this further myself, but would be happy doing any furter experiments.

This is true for the current dev builds, e.g. b450707955.

Rockbox doesn't speak in the FM mode with voice configured. I tried it in my local language (spanish) and in english with same results. Apparently it is not a problem of the translation, because sometimes (only 2 or 3 times in at about one year that I'm using the player) the player speak some words. This works correctly in release version.
My actual version is 0f89b04, but it happend in all dev versions.

build 00a3658. files dont list or play alphabetically regardless of setting in file view menu.

Revision a8758c9 and Stable (3.13)

If you use the Hold Switch to Lock Keys and remove it again to unlock, buttons doesn't work.
Move around with finger at touchpad work. After this bottons work without problems.

Short:
Start Rockbox
Move the curser over Settings (Example)
Move Hold switch to Lock
Move Hold switch to Unlock
Press Middle Button (Doesnt work)
Move around on Touchpad
Press Middle Button (work)

This patch will add a setting, called "Scroll Bar Border", which will determine whether menus / lists will have scrollbars with borders or not.

The default value for this setting is "yes", so that it matches previous behavior.

Rockbox version 3.13
Wenn I delete a file being played, it continues to play (which is OK for me). But when I rewind in this file while playing, Rockbox hangs and does not respond to any key presses. The screen light stays on. I have to press the hard reset or wait until the battery is empty.

This also sometimes happens when I press fastforward, but it always happens when pressing rewind.

Desired behavior:
- Preferred: permit rewinding/fastforwarding (and really delete the file only after stopping the replay)
- ignore rewind/fast forward; alternatively
- skip to the next file immediately after deleting.

Thanks for reading, and please contact me if you cannot reproduce this! I have a Iriver H140 and I must say that all my recordings are in wavpack (recordings made using SPDIF-IN), so I do not know whether this also happens with other file formats and with other players.

-Stefan

I use the attached custom WPS that displays the active Replaygain value and type next to the track number.

When playing mpc files created by foobar2000 with the tracknumber/totaltracks tag format, if the track# is 10 or higher and the applied gain negative (as in the attached mpc), mangled characters are displayed between the gain value and type, eg:

10/12 -2.00 dB *gibberish* (Album)

This is reproducible with the latest simulator build d0fffd6-150104 but I only recently noticed the issue and don't know when it began. I have an old sim build 935d8be-121229 and it works correctly there.

## This was tried out with Sansa Fuzev2 simulator version d392da8-140922, built from git on a 64 bit Linux system ##

I discovered something which seems to be a bug somewhere in the place where WPS get interpreted or rendered.

When I use a scrolling line just after a line containing sublines, the scrolling line stops scrolling as soon as the sublines change the first time.

Below are steps to reproduce it on the UI simulator for the Sansa Fuzev2. I think it also works without using a clear configuration. I haven’t tested with a real device, only with the simulator.

Attached are a .wps-file showing the buggy behaviour (’scrollline_after_sublines_bug.buggy.wps’), and a .wps-file working correctly (’scrollline_after_sublines_bug.workaround.wps’), which are the same files as quoted below.

STEPS TO REPRODUCE:

(0) Use Sansa Fuzev2 simulator version d392da8-140922, build from git on a 64 bit Linux system.

(1) Use a clear configuration, so erase

    .rockbox/.playlist_control
    .rockbox/config.cfg
    .rockbox/nvram.bin
    .rockbox/database.ignore
  in your 'simdisk' directory.

(2) Start the rockbox UI simulator

(3) Change the theme to ‘rockbox_failsafe’, i.e. in the menu, do the following:

• ‘Settings’ → ‘Theme Settings’ → ‘Browse Theme Files’ → ‘rockbox_failsafe.cfg’
• ‘Settings’ → ‘Theme Settings’ → ‘While Playing Screen’ → ‘rockbox_failsafe.wps’
• ‘Settings’ → ‘Theme Settings’ → ‘Radio Screen’ → ‘rockbox_failsafe.fms’
• ‘Settings’ → ‘Theme Settings’ → ‘Base Skin’ → ‘rockbox_failsafe.sbs’

(4) Use the following .wps-file as the “While Playing Screen” skin:

=⇒ # Two sublines:
Text1;Text2
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
# Another line of just text (Not needed to reproduce the bug, but if it is swapped with the long line above, the long line scrolles correctly):
Textline.
#### Here the following Bug appears:
# When the Line ‘Text1;Text2’ changes the sublines the first time, the subsequent line stops scrolling. It happens when the sublines change; as when you use ‘%t(5)Text1;Text2’, the scrolling stops only after 5 seconds, when the sublines actually change.
⇐=

Workaround:
(4a) Put the scrolling line not directly after a line with sublines. The following .wps as the “While Playing Screen” skin works:

=⇒ # Two sublines:
Text1;Text2
# Another line of just text. Needed to make the long line scrolling correctly:
Textline.
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
#### Here the bug does not appear, the long line scrolls corretly. But when the long scrolling line is put just below the line with the sublines, it stops scrolling as soon as the sublines change for the first time.
⇐=

I’m using the latest Dev build for the Fuze+. SanDisk Sansa Fuze+ 5ef1e2d. Same issues experienced in v3.12 stable.

The screen, for lack of a better term, jumps when navigating in upside-down mode.

http://youtu.be/dRfiBtMx2to

I would like to leave my player charging overnight and have it resume playback in the morning to wake me.

My player remains on when charging and cannot be turned off.

The alarm does not resume playing if the player is already on when the alarm time passes.

I suspect this probably applies to all players, mine is a Sandisk Sansa Clip+.

Rockbox info says v. 3.13 - the stable build grabbed by RockboxUtility, which this bugtracker doesn’t seem to know about yet.

Hi,
I am using a Sansa Clip Zip with Rockbox 3.13.
I’ve noticed, when I lock or unlock the device, the message, which indicates the current state, does not disappear completely. Its still there.

Cheers,
Conrad

Key lock (activated by pressing Power in the WPS) deactivates when music playback stops (end of playlist). The keypad then becomes active again. It shouldn’t get activated until Power is pressed again.

As the title suggests, fun things like: https://plus.google.com/102855057878446061693/posts/FkQ4wQZb8VD can happen in this instance.

Initially reported here: http://www.rockbox.org/irc/log-20130113#07:14:49

[Saint]

I'm running Rockbox 3.11.2 on a Sansa Clip+.
I followed these steps:
- go to the Main Menu
- Files
- long press on <microSD1>
- Playlist Catalogue
- Add to New Playlist
I tried to save the playlist with a long press of the select button (not sure of the button's actual name; it is the button in the middle of the 4-way controller and the one that is usually used to select the highlighted option). I was returned to the Files menu. The playlist did not get saved, and there was no error explaining why.

As a result, I spent a long time assuming that long press of select was a "cancel" action, and tried short and long presses of every other button trying to save the playlist.

Workaround: instead of accepting the suggested filename, remove the "<" and ">" characters from the auto-entered filename ("/Playlists/<microSD1>.m3u8") to be able to save the playlist.

Suggested fixes: The filename suggested by Rockbox should not include "<", ">", or other un-saveable characters. In addition, if the user tries to save a file with invalid characters, a warning or error message should be posted (like the "Cancelled" message that briefly pops up when the power button is pressed to exit from the set-filename screen).

While I am playing some song on my iPod classic 2G, and scrolling through a list (even the main menu, but the glitch there is somehow different), if I unplug and then replug the headphones, some of the WPS UI gets drawn over the current view. I'm attaching a screenshot to make it more clear. It only happens while playing a song.
I'm using build bf6abf7 (most recent at the moment).
Also attaching my config.

The settings submenu with the playlist viewer settings like “show icons”, “show indices” and “track display” to select between file name only and full path for playlist entries is not available in the playlist viewer menu in the Android version.

So these settings cannot be changed.

This happens in all version I tried until now (latest was a12b2a5).

In Rockbox for Android it is not possible to highlight an entry in a list without selecting (entering) it.

For example, if I am in the playlist viewer showing the list of just playing songs with my ipod (running rockbox) I was able to scroll through the list which moved the higligting bar through the list and then I could select the desired entry by pressing enter. With the touchscreen I found no way only to highlight a certain entry.

This is important if all entries are very long and have the same starting text. For example "Ludwig von Beethoven, Symphony No. 9 - 1. Adagio" cannot be distinguished from "Ludwig von Beethoven, Symphony No. 9 - 2. Andante" in the playlist viewer since the distinguishing part is cut off. With my ipod I could highlight the entries with the scroll wheel and the highlighted line started horizontally scrolling so I could see the complete text. With the Android port I can only touch the line, but touching the line does not only highlight it but also selects it and so starts playing.

This problem also exists in other list with long entries and happens with all version I compiled until now (latest was a12b2a5).

When you configure Shortcuts to replace the Quick Screen then there is this unwanted behaviour:
Exiting the Shortcuts menu always returns to the Main Menu, not to the screen from which the Shortcuts menu was invoked by pressing the Quick Screen key combination.

Tested on: Sansa Clip+
Builds tested: latest daily - b7bc240-120409

			latest current -	2406005-120410

Using the %pL Tag (in WPS) in order to simply display it or use it in a conditional tag (like in the “analog” theme yields very high values (let call it spikes) - where they should not be, while the bar-type peak meter is working fine.

Within the simulator, everithing is running smooth, as far as I could see.

I tried to have a look at the sources but that’s too much at the moment.

Does somebody have a clue ?

Regards

  Ralf

The %pb tag has a small problem. If an image is specified but no height, the tag draws the size of a line even if larger than the the image. This leads to pixel garbage below the progressbar.

The test.wps reproduces the problem in the 320x480 sdl app The default font, 27-adobe, has to be selected probably. The wps works if a height, i.e. 20 in this case as the image height, is specified

Test.png shows the problem. test.zip is the small test theme.

I know keymap changes can be a difficult topic, this one however is just a small change - which, I hope, improves usability of Clip players quite a bit.

I just swapped the behavior of two functions when browsing lists: short press on the power button returns to WPS, and pressing menu + center stops playback while in lists. Return to WPS is arguably the much more often used functionality of the two, and this change makes it easier to do that.

When turning on my Sansa with Rockbox 3.10, the display sometimes goes all white and stays that way until the screensaver kicks in. The player works fine during that time and can be controlled blindly. After the screen turns off and I turn it on again, the screen works as expected. This does not happen all the time, but very often.

There are some problems with the quickscreen on the Sansa Fuze. I traced it back to r31246, a text alignment bugfix:

- Quickscreen items flicker a lot and sometimes vanish for half a second on each change of an option.

- Setting the right option (Repeat) to "Shuffle" and then back to something else causes "Shuffle" to stick on screen. Leaving the quickscreen and returning to it reveals the correct setting.

This only happens for longer scrolling strings of text, e.g. "Shuffle" is "Zufallswiedergabe" in German.

Hello!
Not very long ago I got iPod Nano 2 gen 8gb, installed rockbox and encountered this strange behavior:

After pushing and releasing Hold button player doesn't react on wheel. When I'm trying to use some other button(Menu, for example), nothing happens. After third attempt to use a button Rockbox does button context properly, showing me what I wanted to see a few clicks ago. What happens with interface after using Hold? When I return to 'Now playing' screen throughout Menu, all works fine. But right after using Hold button I can't nor increase/decrease volume, neither move in a menu list.

Languages like Thai use combining diacritical marks which display above or below the adjoining character. When text scrolls off the screen, the text jerks back and re-scrolls what seems to be the width of the diacritical mark. It seems that the scrolling algorithm is counting the width of the diacritical mark, where it should be ignored.

svn-r31216

when deleting a directory with several files in it the splash screen, that is appearing when deleting the individual files, gets printed over the last one without clearing the screen prior to it.

To reproduce, ensure car adapter mode is enabled, start playback, and leave the now playing screen. If the charger isn't connected, connect it now. Then, disconnect the charger, causing a car adapter mode pause. Some parts of the now playing screen will overwrite the current screen. I see this in file view, main menu and settings. The main menu is quickly redrawn and back to normal, but the file view is only redrawn after I do something. Now, reconnect the charger, which causes a car adapter mode unpause after a short delay. The same thing happens.

I've seen this on:
- 5G iPod using Firewire power, running 3.10RC and r31106
- Archos Recorder V2 using charger, running 3.10RC and r31106

Edit: The same thing happens with headphone plug-in unpause (but not headphone unplug pause). I expect the problem also happens when using BUTTON_MULTIMEDIA_PLAYPAUSE, but I did not test that.

The problem is due to the pause_action() and unpause_action() calls in apps/misc.c. The second parameter is "bool updatewps". It is true in all cases except headphone unplug pause. I don't know why it's false in that particular case.

The second parameter probably shouldn't be there. The WPS should simply update itself if it is currently displayed.

Hello, all
There's a problem with viewing files in some circumstances in iPod 5.5G last 3.9 release.

When I:
playing something in /Music/Artist/Track.flac,
pause playback,
connect USB cable.
rename /Music/Artist to /Music/ArtistSOMETHING, then disconnect USB cable

I just cannot turn playback on ("~Do not exist" or something message appears, it's OK, I know),
BUT
when I trying to enter in "Files" menu - there's no reaction at all. Just nothing. I can't play of any other existing track or change to any directory without restarting device, or:

just go to Playlists → VIew catalog → select some playlist, then some music appears. But it's too long imho.

Is "it" bug or not?.. :)

Thanks,
sorry for my english,

The key lock feature on my clip+ can be circumvented. Select the last title in a directory using the file browser. Then activate the software hold. When the song finishes the Player skips to the file browser and the key lock is turned off after a button press. You can navigate around the menus until you return to the playing screen, then the key lock turns on again.

SVN r30720

After upgrading my 1st generation iPod Nano from Rockbox 3.6 to 3.9 the cover art display does not seem to be working consistently.

When using a playlist the first track will always show the correct cover art, but any tracks after that will continue to show the first track's cover. This also happens if I skip forward or backward between tracks in the playlist.

If I manually select a file to play the correct cover will show, and if I manually select another track during the play-back of the first the cover art will change to the new track.

I have also tried this with current build r30334 (2011-08-20T13:14:30) with the same results.

Attached is a patch that:

* adds an option to chose the date format in the system menu (choice between YMD, DMY and MDY)
* adds a %cF theme tag so that theme can know in which order to display the date

There are a few new strings that I only added in English.

This is my very first rockbox patch so please let me know if anything should be improved.

I did the patch against svn 29827 and tested it in a simulated Fuze v2 as well as a real one.

On the default FM radio screen only the pre-set name line appears to scroll if wider than the screen. Other lines don't. This occurs on all releases tested up to current r29824-110504.

To reproduce, set to a large font and go to the FM Radio (I use 32 Terminus Bold - I want to read the screen when not wearing glasses, but it still occurs to a degree with fonts smaller than this).

Example display:
Station: 101.3 ("MHz" not visible - no scrolling)
Stereo
Mode: Scan
Signal Strength (": nn dBμV" not visible - no scrolling)

On my iPod video, when I choose to load the WPS on startup (either in the Settings menu or in the alarm menu), it doesn't work. The player stays on the main (root?) screen.

I had to tweak root_menu.c (which I join) to get the alarm to work with the WPS. This is not a patch, but a quick and dirty workaround that I did just to be waked up on time tomorrow…

Hello,

empty menu items crash rockbox due to NULL pointer access.
Easily reproducable with the "LCD settings" in RaaA / SDL app build.

The resulting valgrind trace looks like this:
==22619== Invalid read of size 4
==22619== at 0x407FDA: do_menu (menu.c:555)
==22619== by 0x41B198: miscscrn (root_menu.c:323)
==22619== by 0x41B377: load_screen (root_menu.c:520)
==22619== by 0x41B72A: root_menu (root_menu.c:688)
==22619== by 0x406DFA: main (main.c:196)
==22619== Address 0x0 is not stack'd, malloc'd or (recently) free'd

Question:
Should we protect against "menu→submenus" being NULL or
should the menu system hide empty menus without any items at all?

Cheers,
Thomas

Split out from  FS#11748 .

This patch adds an option to prevent rewinding to the beginning of a track to avoid losing the current playback and resume position by accidentally pressing the Left key. Instead, Left always directly skips back to the previous track. This behavior can be enabled for all tracks or only for those tracks that can be autoresumed on automatic track change (which already is separately configurable).

I'm dropping this patch here for now because I see little chance right now of this being accepted into the trunk. Some developers have complained about the considerable configuration complexity of autoresume as it is, and although this additional behavior can be convenient, there is no ultimate need for it because the resume position prior to the rewind to 0:00 is preserved as long as another skip occurs within the first 15 seconds of the rewound track's playback (for example, by pressing Left again to skip to the previous track).

This change was originally contributed by Dave Slusher in  FS#11748 . I just added the configuration logic.

Patch relative to r29484.

I didn't like that the "Backlight on first keypress" function ignores the first keypress no matter which key was pressed. For example, I want the volume keys to work normally even when the backlight is off (that is, they should turn on the backlight *and* change the volume).

This patch restricts "Backlight on first keypress" to certain buttons only. in other words, these buttons work normally only when the backlight is on; otherwise, they just turn on the backlight. As a proof of concept, it changes the Clip and Clip+ behavior to filter out only the Home key when the backlight is off, allowing the other keys to function normally.

It works by allowing button-target.h to define the buttons that are filtered by the "Backlight on first keypress" function. If left undefined, the function filters all buttons when the backlight is off, as in the status quo.

[EDIT: Clarified that there is no overlap with  FS#9305  - Context sensitive backlight on key press]

I suspect this bug has appeared since r29333, r29341, r29342 but I'm not 100% sure, it worked fine a few days back.

When I delete a file it goes well, but after I delete a file after first switching to another application or to the Android main screen deleting a file locks the main screen, it also locks up for other Android native screens like the keyboard you get when you create a directory.

I use Android 2.1 on a Cowon D3 device.

3.7.1, r29372, tested on Sansa e270

The idea is that when connected via USB, devices with button/wheel lights will indicate disk activity using the light, similar to a USB flash drive.

This works, sort of.
One real problem has been encountered:
The calls to buttonlight_on() and _off() seem to override the backlight_timeout_plugged setting, preventing the backlight from shutting off when this is enabled.

This patch adds a frequency response graph below the equalizer's controls, making it an EQ that is actually "graphical".

I'm still not sure about the accuracy of the represented curve, in particular the Q factor on the peaking filters seems to have an effect opposite to the expected, though the equations are taken from the same "audio EQ cookbook" the equalizer is based on, any help is appreciated!

The user interface is still incomplete, I want to add proper tags on the axes and bars. I also thought about re-enabling the theme on this screen (why is it disabled?) and change the behavior of the "right" button, making it consistent with other menus.

Tested on a Sansa e200.