Rockbox

Rockbox starts with remote, but doesn't respond to button presses except turning backlight on with build 6039eb05b-180313.
It works with deaeb73-161114 though.

decode_packet in wmaprodec.c returns -1 almost immediately, most likely due to being passed corrupted data by the ASF parser, although I have not confirmed that to be the case. I've seen similar issues in WMA Std. Theres probably some ASF feature we do not correctly implement.

Latest version of rockbox installed on both Sansa e200 2GB and Sansa Clip Zip 4GB. (3.13) Sorry, release 3.12 was the only one available in the reported version pulldown.

Windows 7 Pro 16GB RAM, i5-2500K, 3.3GHz/ 3.6 GHz, 64-bit. 7.3 Windows Experience Index. OS is otherwise stable and up-to-date.

Blue Screen of Death only happens when I try to connect first one Sansa Device via USB to Windows, transfer mp3’s or update a theme, unplug it, then connect a second Sansa different device. It doesn’t matter whether I start with the e200 or the Clip Zip or vice versa. Upon immediately connecting via USB with the second device, I get a BSOD. I have two e200 devices. It can happen sometimes even when I connect first one e200, then the other.

I can disconnect and reconnect the starting device (for instance the Clip Zip) as often as necessary, but if I want to connect to the e200 (for instance to update a theme), I have to reboot the computer in order to avoid the BSOD.

This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2].

I’m adding this font because:
1. Currently there is no good Chinese font for Rockbox.
2. The best Chinese font (unifont) has unevenly sized Chinese characters, while this font has uniformly sized Chinese characters.

The attachments contain screenshots of the simulator, to show how this font would look like on the iPod Nano. I’ve also attached a screenshot using the Unifont font to show the uneven sizes of Chinese characters, for comparison. I don’t know about other languages, but I’d think other CJK languages work better in this font as well, due to the merging of WenQuanYi Bitmap Song.

According to the project[3], this font is made by combining the GNU Unifont (GPL), WenQuanYi Bitmap Song (GPL) and Fixed-16×8 (Public Domain) fonts. The maintainer of GNU Unifont also acknowledges this fact at [4].

This font is licensed under the GPLv2 with a font embedding exception[3]:

[quote]
** GPL v2 license with font embedding exception:

As a special exception, if you create a document which uses this
font, and embed this font or unaltered portions of this font into
the document, this font does not by itself cause the resulting
document to be covered by the GNU General Public License. This
exception does not however invalidate any other reasons why the
document might be covered by the GNU General Public License. If you
modify this font, you may extend this exception to your version of
the font, but you are not obligated to do so. If you do not wish to
do so, delete this exception statement from your version.
[/quote]

I don’t mind either way, but it would be up to Rockbox developers whether to strip off this exception. And either way, the font is compatible with Rockbox’s license (GPLv2).

The font I’m attaching is a modified version (and only the bdf); you can download the original version from [5]. My modification is:

— wqy-unibit.bdf.orig 2008-06-01 04:47:36.839752214 +0800
+++ wqy-unibit.bdf 2008-06-01 05:01:51.031748178 +0800
@@ -64,7 +64,7 @@
CHARSET_ENCODING “-1” CHARSET_COLLECTIONS “ASCII ISO8859-5 GB2312.1980 BIG5-0 KSC5601.1989-0 JISX0208.1997 ISO10646-1” ENDPROPERTIES
-CHARS 46443
+CHARS 46444
STARTCHAR uni0000
ENCODING 0
SWIDTH 500 0

This is because convbdf will emit a warning “Warning: DWIDTH spec > max FONTBOUNDINGBOX” when converting the font. This is because there are actually 46444 STARTCHAR entries, but only 46443 glyphs – the character “mu” is encoded as 181 and 956, with the exact same glyph. The generated .fnt file is exactly the same with or without my modification.

Additionally, this font is quite big so it’s a bit big on the screen of the iPod Nano. But it would be great on larger screens. Please take a look at the screenshots in the attachments.

Links:
[1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?Unibit_README [4] http://www.unifoundry.com/unifont.html [5] http://downloads.sourceforge.net/wqy/wqy-unibit-bdf-1.1.0-1.tar.gz?use_mirror=osdn

This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2]. This font is similar to the WenQuanYi Unibit font (FS#9059) and focuses mostly on ASCII and CJK, but I’m also posting this font for inclusion because this one has different point sizes, like for example the nimbus, Sazanami and ProFont fonts already included in Rockbox. With the different point sizes, especially lower point sizes, this font is great for small screens such as my iPod Nano.

I’m attaching some screenshots of this font under various point sizes and weights. I’ve also taken screenshots with the simulator to show how it would look like in Rockbox.

Additionally, this font is available from the original website at [3]. There is also an online README file at [4]. The source BDF files are available from the project’s SourceForge page at [5], and the BDF files I’m attaching come from the source package at [6].

According to the project[4], this font is a derivation of older free fonts and enhanced with bitmaps made by online users. As such, it is licensed under the GPLv2 with a font embedding exception[4]:

[quote]
** GPL v2 license with font embedding exception:

As a special exception, if you create a document which uses this
font, and embed this font or unaltered portions of this font into
the document, this font does not by itself cause the resulting
document to be covered by the GNU General Public License. This
exception does not however invalidate any other reasons why the
document might be covered by the GNU General Public License. If you
modify this font, you may extend this exception to your version of
the font, but you are not obligated to do so. If you do not wish to
do so, delete this exception statement from your version.
[/quote]

It’s up to Rockbox developers whether to strip off this exception. Either way, the font is compatible with Rockbox’s license (GPLv2).

Links:
[1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?BitmapSong [4] http://www.wenq.org/index.cgi?Hero_README [5] http://sourceforge.net/projects/wqy/ [6] http://downloads.sourceforge.net/wqy/wqy-bitmapfont-bdf-gb18030-0.9.9-0.tar.gz?modtime=1194227675&big_mirror=0

Hi,
I’m trying to record myself playing the guitar using my old, trusty FuzeV2 (both a very old version - sorry didn’t wrote it down but had to be at least a couple of years ago - and today’s version 87229a4). Recording parameters as follows:

Trigger: Repeat
TrigType: New file
Prerecord Time: 1s
Start Above: -22dB
for at least: 1s
Stop Below: -26dB
for at least: 1s
Presplit Gap: 1s (don’t really understand what it does from the manual, but it says it usually has to be the same value of the Stop Below Time, so…)

Recording starts correctly when noise is detected according to conditions; then apparently it correctly detects the silence and stops the recording. But immediately the ‘Repeat Trigger’ parameter kicks in and _immediately starts a new recording_. At this point, the trigger status and the recording status aren’t matching anymore. The recording screen shows the recording file size growing, but the Trigger status is ‘Ready’. I have confirmed that on the actual file on disk the silence is meanwhile recorded.

Did I understand any of the parameters wrong or has anybody else the same problem?

Rockbox doesn't speak in the FM mode with voice configured. I tried it in my local language (spanish) and in english with same results. Apparently it is not a problem of the translation, because sometimes (only 2 or 3 times in at about one year that I'm using the player) the player speak some words. This works correctly in release version.
My actual version is 0f89b04, but it happend in all dev versions.

Voicing of menus will work fine on the default font. However, if 08-Namil is used, the voicing dies upon reboot.

See also http://forums.rockbox.org/index.php/topic,51408.0.html .

http://web.mit.edu/mgg6/www/cover.jpg

This file is correctly decoded and displayed in the Fuze+ simulator, but testing on device results in playback stopping. Interestingly, nothing crashes, playback just stops. In theory we should be able to decode this, the resizer does not need to load more than a few lines of the image at once, which should easily fit in memory. Alternatively, if it is too large (or rather wide given that its decoded line by line) for the available space, it should probably just be rejected.

This patch adds an option to allow the Fastforward/Rewind buttons to be used to skip tracks entirely.

This is an itch of mine that I scratched and am offering up to others if you are interested.

I’ve been using audio lessons to learn Japanese and ran into issues navigating with the normal FF/RW buttons. The acceleration based on track length left me with no sense of time since I don’t keep track of how far I am into my 30 minute long lessons. Simply backing up 5 seconds to catch something I missed was a problem because I’d have to look at what I was doing to see how far I’d ff/rw. Kinda hard when one tick moves 30 seconds too. This is problematic when driving! The existing skip-length feature is really good for this. However, if I use that to skip 5 second increments then I abandon any way of skipping entire tracks. So I re-purposed the FF/RW buttons for skipping tracks and use skip-length for navigating within a track.

I’ve been using this in r27841 for about a week on my Gigabeat, but it seems like it should work for r27942 as well.

I recognize some problem with USB support.

When I’m connecting my player first time, it’s work correct - computer’s mounting device propertly. BUT When I disconnecting it, turn on playing and while music is still playing I’m connecting player once more - Rockbox is crashing and give information about “unidentified instruction at… “. Now player looks like dead - I must reset it and Rockbox start correctly.
When I’m not turning on songs - all works fine.

Sorry for my english…I’m still learining It

USB is broken on mr500. I’ve tried r31467, but this has been the case since at least a few weeks ago.

Enabling logf in the relevant places causes rockbox not to boot, so wasn’t helpful.

This is a very early patch to enable USB on the mini2440.

This patch let rockbox react on USB, but unfortunatly i dont get further then the first reset interrupt from USB. Something in the init has to be wrong, so i dont get ep0 interrupt which should follow the reset.

Because of this problems, no attempt has been made to implement the acutal data transfer functions.

If someone wants to step in and debug.. feel free !

The aim of this patch is to make releases as simple as possible... i.e the end goal would be to have someone run “$ ~/rockbox/tools/release/release.sh 3.3” and that would do everything except feed the cat...

the first version just modifies bins.pl to accept a version number which eventually gets passed to the Makefile and used in the source to set the version string in the source to “3.x-rBLAAA”.

This also defines RBRELEASE which can be used in the source to do stuff, for example, remove the debug menu in releases (if we decide to do that...) (RELEASE is defined in speex so had to add the RB prefix...)

Also, this changes the way configure is run to use command line args instead of passing input to it which is Just Wrong (TM) :p

Version: 3.13

Variable ‘tmp’ on line 565 is possibly not initialised (found by cppcheck).

Click on the music file and die

Hello there,

When I reboot my Rockboxed iPod nano second generation, it changes the time +5 hours.

Does anyone know why this can be? Thanks

The purpose of the game is to press one of the four direction keys as fast as possible when randomly asked to do so. At the end of the game, min/max/average values are displayed.

When a WPS defines a touch area combining %T and setting_inc or setting_dec, although the themesite parser does not show any problems and allows the theme to be loaded normally, the themesite doesn't display the theme. Some examples to be found in this forums thread : http://forums.rockbox.org/index.php?topic=25098.msg173725#msg173725

It seems that operators are discarded when used in a tagnavi.config (or tagnavi_custom.config) format line condition.

For example,

%format “fmt_abtitle” “*%s - %02d:%02d” title Lm Ls ? playcount > “0” & lastoffset == “0” %format “fmt_abtitle” “%s - %02d:%02d” title Lm Ls Now if we used “fmt_abtitle” instead of “fmt_title” in the default tagnavi file, we would expect all tracks with a playcount greater than 0 and lastoffset equal to zero to be prefixed by three asterixes (*). Instead ALL the tracks with a playcount greater than zero are prefixed, leading me to think that the & lastoffset == “0” part is discarded. If I make the following change:

%format “fmt_abtitle” “***%s - %02d:%02d” title Lm Ls ? lastoffset == “0” & playcount > “0” %format “fmt_abtitle” “%s - %02d:%02d” title Lm Ls

Now all tracks with a lastoffset equal to zero are prefixed, which again proves that the and operator was clearly ignored and unparsed.

Add support for two new scroll styles, STYLE_NODRAW and STYLE_CUSTOM, with STYLE_CUSTOM causing the draw to be done via a hook (set with lcd_set_style_hook). lcd_puts_stroll_style_offset also returns a struct scrollinfo pointer. This may be used in conjunction with STYLE_NODRAW to redraw the scrolling text in a plugin which draws other graphics to the same part of the screen, by drawing the text using the offset in the struct scrollinfo after the background graphics have been drawn. My latest patch from  FS#4817  is required, as it consolidates styled text drawing in one function, making it easier to replace the normal draw with a call to the hook, and reducing the binsize impact of this feature as well.

Support for core text scrolling in PictureFlow plugin to follow .

Playing 320K MP3s pauses often in Version 3.15 and daily build 7d00533 also UI becomes unresponsive
Version 3.14 or older does not reproduce the issue in either 44 or 48khz sampling rate and same sound options
Is not reproducible under OF or Version 3.15 running on IPOD 6G
seems to be a cpu usage issue as compiling a version of rockbox with much higher than stock CPU clocks seems to alleviate the issue to an extent but there is still occasional pauses that is not present after reverting to 3.14 and stock 80 mhz clock speed.

Tested with r19410

If I boot with the headphones plugged in, sound always works (at least I didn’t have it fail yet). If I boot without headhones plugged in, and plug them in later, sound often doesn’t work. This may also depend on whether the player was turned off for a long time, whether the previous boot was USB mode, and whether the headphones were unplugged before or after shutting down.

Sorry, not sure in which build part of this ceased to function, but I think it was just prior to 3.10

In the Clip Sim's I can no longer access the Lock Screen. "H" used to do this for me, as I recall.

Also, the charge values in the Clip Sim's no longer incrementally increase and decrease. The charge values used to go from 0 to 100 and then back down again.

This applies to the Clip Zip Sim as well. I haven't tried the Fuze Sim.

Thanks.

The key lock feature on my clip+ can be circumvented. Select the last title in a directory using the file browser. Then activate the software hold. When the song finishes the Player skips to the file browser and the key lock is turned off after a button press. You can navigate around the menus until you return to the playing screen, then the key lock turns on again.

SVN r30720

see http://svn.rockbox.org/viewvc.cgi?view=rev;revision=30461 and http://www.rockbox.org/wiki/Main/CustomWPS#Drawing_the_lists_using_a_skin and bug me on IRC when someone finds the time to add it. hopefully the wiki has enough info though - Jd

Creative ZEN simulator build 9d0c0e3-170115
Creative ZEN device build 8fec364f6-170125

Steps:

(Asing attached config.cfg)

1 Set Settings, Playback Settings > Shuffle to Yes
2 In Files, enter a folder of tracks and press Select to play
3 Go up to the folder itself, press long select > Current playlist > Insert Last
4 Press long select > Current playlist > Insert
5 Press long select > Current playlist > Insert
6 Go to Now Playing > Current playlist > View current playlist

Expected: Four copies of the list, all shuffled

Observed: One copy of the list, shuffled, followed by three not shuffled: http://i.imgur.com/Emldcdt.png

Video at https://www.youtube.com/watch?v=KANEkz0zRZ8

When you configure Shortcuts to replace the Quick Screen then there is this unwanted behaviour:
Exiting the Shortcuts menu always returns to the Main Menu, not to the screen from which the Shortcuts menu was invoked by pressing the Quick Screen key combination.

Tested on: Sansa Clip+
Builds tested: latest daily - b7bc240-120409

			latest current -	2406005-120410

If you build RaaA for SDL with HAVE_TOUCHSCREEN disabled there are no key bindings for the SDL_PAD in any of the plugins. This patch attempts to define generic key mappings for the 3×3 number pad on a typical PC keyboard. It needs work however. For instance, after a bit of testing I decided I’d prefer not to wait for a key repeat on the HOME button to quit most of the plugins. That said, it may prove a useful starting point developers building for RaaA platforms without a mouse or touchscreen. (Like me with the zipit.)

For the Zipit I plan to fix up the generic SDL keys first, testing on a real PC, and then try and figure out a way to use most of them as is. I’m not sure yet if it makes sense to define a ZIPIT_PAD for the few plugins where alternative keys make sense, or use some other #ifdef.

Scrolling the scrollwheel doesn't count as a button press for the Textviewer plugin's idle Timeout.

## This was tried out with Sansa Fuzev2 simulator version d392da8-140922, built from git on a 64 bit Linux system ##

I discovered something which seems to be a bug somewhere in the place where WPS get interpreted or rendered.

When I use a scrolling line just after a line containing sublines, the scrolling line stops scrolling as soon as the sublines change the first time.

Below are steps to reproduce it on the UI simulator for the Sansa Fuzev2. I think it also works without using a clear configuration. I haven’t tested with a real device, only with the simulator.

Attached are a .wps-file showing the buggy behaviour (’scrollline_after_sublines_bug.buggy.wps’), and a .wps-file working correctly (’scrollline_after_sublines_bug.workaround.wps’), which are the same files as quoted below.

STEPS TO REPRODUCE:

(0) Use Sansa Fuzev2 simulator version d392da8-140922, build from git on a 64 bit Linux system.

(1) Use a clear configuration, so erase

    .rockbox/.playlist_control
    .rockbox/config.cfg
    .rockbox/nvram.bin
    .rockbox/database.ignore
  in your 'simdisk' directory.

(2) Start the rockbox UI simulator

(3) Change the theme to ‘rockbox_failsafe’, i.e. in the menu, do the following:

• ‘Settings’ → ‘Theme Settings’ → ‘Browse Theme Files’ → ‘rockbox_failsafe.cfg’
• ‘Settings’ → ‘Theme Settings’ → ‘While Playing Screen’ → ‘rockbox_failsafe.wps’
• ‘Settings’ → ‘Theme Settings’ → ‘Radio Screen’ → ‘rockbox_failsafe.fms’
• ‘Settings’ → ‘Theme Settings’ → ‘Base Skin’ → ‘rockbox_failsafe.sbs’

(4) Use the following .wps-file as the “While Playing Screen” skin:

=⇒ # Two sublines:
Text1;Text2
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
# Another line of just text (Not needed to reproduce the bug, but if it is swapped with the long line above, the long line scrolles correctly):
Textline.
#### Here the following Bug appears:
# When the Line ‘Text1;Text2’ changes the sublines the first time, the subsequent line stops scrolling. It happens when the sublines change; as when you use ‘%t(5)Text1;Text2’, the scrolling stops only after 5 seconds, when the sublines actually change.
⇐=

Workaround:
(4a) Put the scrolling line not directly after a line with sublines. The following .wps as the “While Playing Screen” skin works:

=⇒ # Two sublines:
Text1;Text2
# Another line of just text. Needed to make the long line scrolling correctly:
Textline.
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
#### Here the bug does not appear, the long line scrolls corretly. But when the long scrolling line is put just below the line with the sublines, it stops scrolling as soon as the sublines change for the first time.
⇐=

svn-r31216

when deleting a directory with several files in it the splash screen, that is appearing when deleting the individual files, gets printed over the last one without clearing the screen prior to it.

When connected to PC.
While transferring files from PC to Sansa e280v2.
Both source and destination folders are open.
Sansa shuts off after some time. while transfer is still happening.
this does not happen with original firmware.

Today I've experience something which IMO should not happen.

I recorded vian the built in micro on my Sansa e200 v1, paused the recording (not stopped!). In this state, I plugged USB cable. After that, there was the following text in the system font on the display, and the player did not respond to any keys. It had to be restarted via very long pressing at On/Off.

The text is:

*PANIC*

usb_storage_init_connection
(): 00M
pc:0006B878 sp:000D3538

  A: 00069978
  A: 00069F80
  A: 0005326C

bt end

I've reproduced this three time in a row.

I have the official version 3.14 installed.

Sometimes my Clip Zip gets in a state where I can resume playback after booting it but then it doesn’t let me seek anymore (seek thingy still moves but then jumps back to where it was, playback is totally unaffected which in this case is bad of course). I also can’t pause or skip. I can go back to the main menu but I can’t move the cursor or go back to the WPS. When I go into the playlist by long-pressing down, the list usually appears but is not functional although here I can usually move the cursor up and down (sometimes I only get a kind of frame but rendering freezes at that point). Trying to shut down lets the “shutting down” popup appear but that’s it.

I seem to remember that going via “recent bookmarks” once was a workaround but in the current state this doesn’t work either.

This broken states persists between shutdowns (or well, switch-offs more like since shutting down doesn’t work). I also tried to recreate the playlist but that didn’t help either so I’m currently stuck with a player that will play but I can’t it make change what to play. I will also have to listen to the same podcast over and over again since no new resume position is saved.

The build I use is 42a725f.

Oh and sorry I didn’t choose the right player. Couldn’t find any Sansa Clip in the list in fact :/

Hello,

i think rockbox is very nice. I use ist for several years.

Now i found a bug:
The Car Adapter Mode or rather the power-off does not work in the Radio-Mode.
I tested it with the versions 3.4 and 3.10.

Creative ZEN device build 8fec364f6-170125

Steps:

1 Clear Running Time
2 Shutdown, to ensure Running Time clear takes effect
3 Launch Rockbox
4 Record wall clock time
5 Leave running for a few hours
6 View Running Time and compare with elapsed time on wall clock

Expected: Running Time equal to elapsed time
Observed: Running Time less than elapsed time by 2%

Note: battery_bench.txt times accord with elapsed time.

This patch adds does three related things:

- Adds *basic* support for seeking and buffering callbacks so different codecs may manage their buffer space differently
- Extends a few buffering and metadata structures to store information on two files rather than one
- Modifies the Wavpack codec to make use of these features to play back hybrid files with readable correction files losslessly.

This code should not in any way interfere with anything other than the situation where a Wavpack hybrid file is present AND its correction file is readable.

There are several things that need to be done before this patch may be committed:
1. Currently there are two ginormous linear buffers inside the Wavpack codec. They should be replaced with smaller dissimilarly-sized ring buffers.
2. The interspersal of primary and correction file chunks is currently 1/1/1/1. This should probably be more like 1/3/1/3 as that better matches the size rations of a .wv to its .wvc.
3. seek_wavpack needs to support seeking where rebuffering is required.
4. The wavpack hybrid decoding function needs to be modified to decode smaller chunks in a go so that the small ring buffers mentioned above won’t overflow.
5. Gracefully handle the end of a hybrid lossless file (currently it freezes the sim)

The volume settings are bypassed and is at max volume when the plugin is started. Even when putting it at -60DB it still has sound. After exiting and relaunching the app,the volume is maxed again,regardless of volume settings.

The manual offered by Rockbox Utility is not necessarily the version that accords with the installed (or to-be-installed) program.

E.g. select Release 3.13, and the Manual offered is http://download.rockbox.org/manual/rockbox-sansafuze.pdf not http://download.rockbox.org/release/3.13/rockbox-sansafuze-3.13.pdf .

http://www.rockbox.org/irc/log-20140124#15:41:22 says this is a bug. Since the user does reasonably expect a manual to accord with the program, I too think this is a bug. Whether it is a design bug or code bug, I cannot guess.

Note: this task says Operating System: All players but only because the actual player, Sansa Fuze, is not offered. Though this issue may indeed apply to all players.

This is basically a documentation update. For several years I generated accessibility voice files on my devices. Then one day I was reinstalling and it would generate a lot of the voice files but die from a weird error. For more than six months I combed the manual and the forums, trying to figure out what had changed, trying to debug it myself. Eventually I stumbled across the problem. I had noticed the “install on player” option in Rockbox Utility and started generating voice files while running from the player. Once I switched back to running Rockbox Utility by launching the utility from my regular PC disk, everything worked again. I again looked for any warning about this in the manual, and didn’t find anything.

The simplest fix is to include something about this in the section on accessibility and generating voice files.

Another fix, probably not worth it, would be for the voice files to use system tmp space for intermediate files. I suspect that the recursive generation of talk files on player ends up in some infinite regression as it generates talk files for temporary files.

This probably happens on all players, but I only experienced it on the iPod Nano 1st Gen.

When Playing with rockboy on sansa e200 V1 , Rom that have a size of more than 1m Bug and Rockbox often shutdown. And even if these roms run, the speed isn't playable.

After updating Rockbox from 3.10 to 3.11.2 on my Ipod Nano 1g i noticed the robotfindskitten game did not work as it should anymore. When robot has touched the first object, the text on the top does not change anymore when touching more objects until he finds kitten. The kitten animation also is hidden behind the text of the first object and the scrolling of the text starts at the end, not at the beginning.
I think it worked fine in 3.10, or at least in 3.9.

Please investigate this problem.
Thanks,
Hugo

r28528

This adds a bitmap to be shown as the output of the 3 modes of the calculator, similar to the color-codes on the color targets, except that it is a static image for the greyscale targets. Might as well use the screen space for something.

I tested this on a clip+ (3.13) and creative zen (rev cc64d9e), so assuming it’s the same for all devices.

Following setup:
- ReplayGain is configured to “Track if Shuffle” - “Prevent clipping” is set to on/off, does not matter

How to reproduce:
- make a copy of any RG scanned file which has track/album gain and peak tags
- remove the peak tags _only_, leaving gain tags intact

Expected result:
- player should be able to adjust the volume, but not prevent clipping

Actual result:
- player does not apply neither track not album gain.

Files containing only gain tags but not peak tags come from converting lossless → lossy and transferring gain info (since peaks will be different for the lossy file, peak tags are omitted.) With 11db of volume difference on some tracks, it’s impossible to not notice that. I am not sure why applying RG requires peak tags in rockbox, foobar2000 handles peak tag-less files without issue. Any chance to change this behavior to not rely on peak tags?

I use the attached custom WPS that displays the active Replaygain value and type next to the track number.

When playing mpc files created by foobar2000 with the tracknumber/totaltracks tag format, if the track# is 10 or higher and the applied gain negative (as in the attached mpc), mangled characters are displayed between the gain value and type, eg:

10/12 -2.00 dB *gibberish* (Album)

This is reproducible with the latest simulator build d0fffd6-150104 but I only recently noticed the issue and don't know when it began. I have an old sim build 935d8be-121229 and it works correctly there.

Continuing from FS#12240, these patches remove most of the rest of the dependencies librbcodec has on the rest of Rockbox.

When I skip backwards 3 songs, Rockbox aborts with the following dump:

Data abort at 60077EB8
FSR 0x1
(domain 0, fault 1)
address 0x00000005

It happens always, playing or in pause. At the 3rd song dumps.

RB version: 04cd1fd-120320

Regards!

Hi,

the random_folder_advance_config plugin fails to build the
folders on N900 / RaaA. I guess it suffers from the same
as the database update did in the past: It probably follows
starts over and over again in the /proc or /sys filesystem.

Only filetree.c should be allowed to call opendir(), anything that needs to recursively scan directories should be calling ft_load() which can smartly open, scan and close a directory.

The problem with this is that the filename buffer could get corrupted easily if its misused.

as of r18234 the following is using opendir() in the core
filetree.c:133: dir = opendir(c→currdir); ← not recursive
filetree.c:257: dir = opendir(tempdir); ← in ft_load() so ok
filetree.c:259: dir = opendir(c→currdir); ← “” “” “” misc.c:164: dir = opendir(pathlen ? buffer : “/”);
misc.c:1059: dir = opendir(BOOTDIR);
misc.c:1142: DIR* d = opendir(path);
onplay.c:466: dir = opendir(dirname);
onplay.c:817: srcdir = opendir(src);
tagcache.c:4075: dir = opendir(dirname);

the tagcache and the onplay.c ones are dangerous… the 3 in misc.c are not recursive so safe.

the following are uses in plugins, havnt checked them so I only know for sure that stats, disktidy and properties are unsafe
plugins/disktidy.c:203: dir = rb→opendir(name);
plugins/disktidy.c:270: dir = rb→opendir(name);
plugins/md5sum.c:78: dir = rb→opendir( path );
plugins/md5sum.c:113: DIR *dir = rb→opendir( newpath );
plugins/md5sum.c:209: dir = rb→opendir( arg );
plugins/properties.c:79: dir = rb→opendir(tstr);
plugins/properties.c:151: dir = rb→opendir(dps→dirname);
plugins/properties.c:276: dir = rb→opendir(str_dirname);
plugins/random_folder_advance_config.c:70: dir = rb→opendir(fullpath);
plugins/random_folder_advance_config.c:165: dir_check = rb→opendir(formatted_line);
plugins/rockpaint.c:740: d = rb→opendir( bbuf );
plugins/rockpaint.c:754: d = rb→opendir( “/” );
plugins/rockpaint.c:915: d = rb→opendir( FONT_DIR “/” );
plugins/sokoban.c:925: if(!(dir = rb→opendir(dirname)))
plugins/stats.c:139: dir = rb→opendir(fullpath);
plugins/test_codec.c:763: dir = rb→opendir(dirpath);
plugins/test_disk.c:356: dir = rb→opendir(testbasedir);
plugins/test_disk.c:359: rb→splash(HZ, “opendir() failed.”);
plugins/test_disk.c:421: if 1) == NULL)
plugins/wavrecord.c:3774: if 2) == NULL)

so,
The bad calls in the core should be changed to use ft_load, and the plugins should either get a new function in the lib to grab some ram and manage the whole thing, or maybe its safe to just call ft_load there also?

or alternatively, we can go on ignoring the issue.