Rockbox

I’ve noticed that many plugins don’t have the Playback Control menu even though they could. I’m going to have a go at fixing that.

I’ve categorised the plugins which could use the menu like so:

Already have a standard-ish menu (not bitmap), it just needs to be added:
bubbles
chessbox
chopper
minesweeper
reversi
superdom
wormlet
xobox
clock
fireworks
vu_meter

These are the easiest case, it’s just a matter of adding the menu item.

Don’t have a menu that makes sense to add Playback Control to (either they don’t have a menu at all, or they only have a start-menu that can’t be usefully returned to):
flipit
invadrox
maze
robotfindskitten
rockblox
rockblox1d
rocklife
sliding_puzzle
snake
snake2
spacerocks
star
stopwatch
mandelbrot
oscilloscope

These are a mixed bunch. Some could actually use a menu, and some could just have a key assigned to bring up the Playback Control menu. More involved than the first bunch in general.

Already have a menu, but it’s really custom in some way. They either need to be switched to more standard menus, or something special needs to be done:
brickmania
chessclock
pegbox
rockpaint

These will probably be the most work.

Let me know if I forgot any plugins, or if you think it doesn’t make sense to add the menu to a plugin that I’ve listed above.

Attached is a patch for the first bunch. The others will be coming eventually.

I’d appreciate it if you leave this FS entry open until I get to the second and third bunch, even if the first bunch happens to get commited to svn.

I have been using Rockbox for almost 2 years now on my X5L together with the remote and I have frequently updated to the current version, so I am familiar with how it works.

I have noticed that after updating to version 20090221, my X5’s remote’s LCD behaves erratically (strange lines being displayed all over, vertically shaky image) right after booting Rockbox, then the display turns off completely after a few seconds. Strangely though, the controls still work and the blue display light comes on when working the controls, but the display is turned off (there is nothing being displayed, as if the player were turned off). If I unplug and reconnect the remote, the remote’s LCD comes on, but soon turns off again. The X5’s main LCD is working just fine.

I thought that my remote was dying on me, but decided to check if it was somehow related to the development of Rockbox. I reverted back one build after another and found that the last build that works OK for my remote is 20090210. So, in all the builds starting with 20090211 (I have thoroughly checked all from 20090211 to 20090225), the remote is practically unusable. I looked at the changes done on that day (http://www.rockbox.org/daily/changelogs/changes-20090211.html), but could not single out the probable cause.

Great software, anyway!

Using a bootloader from  FS#9955 , a USB connection is not made if Start Screen is set to WPS, and the user boots Rockbox by inserting a USB cable.

This is possibly also true for other values of Start Screen.

Tested on e280, but I expect it’ll likely be the case on other PP targets with USB

The H10 5G MTP needs a different bootloader than the UMS version (see http://www.rockbox.org/twiki/bin/view/Main/IriverH10PortDevInfo#Build_a_Rockbox_Bootloader).
I’m not sure about the correct way to do this in configure, so I’ll leave it to someone who is.

The Rockbox firmware and cross compilers build by using MinGW.

It is necessary to use MSYS’s make (MinGW’s make (mingw32-make) does not used.).

The cross_compilers.zip is a patch file necessary to make cross compilers using by rockboxdev.sh.

I confirmed the Rockbox firmware, codecs and plugins was built by using the compiler on MinGW.
But I can not confirm whether the Rockbox executes excluding iPod video.

Could you confirm operation to various players?

This should hopefully make beatbox compile and run on any target with enough buttons.

All it needed was some key mappings (and some typo fixes). I’m assuming the function declaration for synthSamaples() simply changed over time, as the original code was missing an ‘s’ on the end of function name and looked like this:

  synthSamples(&synthtemp[0], &synthtemp[1]);

The second param should be the sample size or something, but it was passed an address.

If it doesn’t work on a particular target due to lack of a key map, please add one, or tell me the target and i’ll stick a keymap in

Patch from within root rockbox source folder.

Hopefully this works for you all, its many hours of fun =D

This patch will make an e200 present its SD card as an ipod mini 2G when queried by iTunes. It does this by changing a number of things:

1) Responding to SCSI inqueries
2) Using Ipod USB vid/pid and other usb details

The patch also enables logf for the usb_storage.c because I’m in a bit of a hurry.

To use this, make sure you have a partition on the SD card of type 0 (any size should do) and also the appropriate Ipod file structure (can be generated with e.g. gtkpod).

In the never ending saga of strnatcmp the fix for 10029 sorts as
001
002
01
02

Attached is yet another attempt to get it right.

This patch implements HAVE_LCD_SHUTDOWN functionality for Photo and Color iPods. It is in response to issue 2 in http://forums.rockbox.org/index.php?topic=20994 : “2. The LCD screen on the iPod is not cleared properly when I shut down rockbox. I see 1-2 horizontal lines remain on the screen (which do fade after a minute or so). Nothing is wrong with my IPod’s LCD screen as I did not experience this with Apple’s Firmware”

It seems the Color iPod can have 4 different LCDs. They’re detected via two GPIO bits in lcd-color_nano.c. Types 0 and 2 are the old LCD with an unknown controller and they use the same init, shutdown and update procedures, and they are reported as 0. Types 1 and 3 are similar to HD66789R. They have different init and shutdown procedures but they share the same update procedure. Both 1 and 3 were reported as 1 earlier.

To see what LCD type you have, from the main menu go to System → Debug (Keep Out) → View HW Info and then see the number after “LCD type:”.

This patch has only been tested with LCD type 3 so far.

I am submitting this as a patch because I feel it is not a significant bug. Theoretically, the DC voltage that’s left can degrade the LCD, but the line fades quickly and no negative after-effects were reported.

I would like to also add LCD initialization code and develop HAVE_LCD_SLEEP functionality.

Build 20399

The database_changelog.txt is corrupted in that the wrong filename is associated with a track, this has happened before (pre v3.0), I had to write ascript to correct it.

Exampe row from log:

artist=”Teach Yourself” album=”Polish Conversation (Disc 3)” genre=”Books & Spoken” title=”Conversation 1: Booking A Hotel In Krakow” filename=”/iPod_Control/Music/Blur/Blur - Blur/14 Essex Dogs.mp3” composer=”<Untagged>” comment=”<Untagged>” albumartist=”Teach Yourself” grouping=”Conversation 1: Booking A Hotel In Krakow” year=”2006” discnumber=”3” tracknumber=”2” bitrate=”71” length=”640824” playcount=”0” rating=”0” playtime=”0” lastplayed=”0” commitid=”12” mtime=”955689818”

to reproduce:

1. set playback settings–>fade on stop/pause to on.
2. play some music.
3. press the pause button to stop the music, and again to restart it. repeat that a few times, because this bug does not always occur.

you will notice that both “time-displays” sometimes change very to the previous second and then back to the normal one, e.g 3:32, then very short 3:31, and back to 3:32. the progressbar sometimes get smaller for a fraction of a second, too.

maybe i’ll search for the revision which introduced this in the next few days

this is an attempt to implement the idea suggested in the forum (http://forums.rockbox.org/index.php?topic=20120.0).
I take values from “skip length” setting for variable steps.

This first patch is a merge of Tremolo’s bitwise.c and bitwiseARM.s code into rockbox libtremor. As a naive version of the merge, I have taken out the previous rockbox optimisations to huffman decode (originally implemented in  FS#6848 ). Versus svn, decoding speed is worse with this patch. However something that incorporates both  FS#6848  and the Tremolo bitwise optimisations for little-endian ARM may well turn out better. This patch is seriously not committable, the arch-specific stuff is not done cleanly in the headers or the makefile

I’ve been reliably informed that Rockbox should stop scrolling when it gets to the bottom or top of a menu, only to wrap around when you initiate a new scrolling gesture. On a 2nd Generation iPod, however, it just keeps scrolling.

See http://bertram.bourdrez.org/buggyrockbox.avi (the video is recorded with an old Rockbox, but 3.2-090323 does the same thing)

Also, the bug tracking system is overcomplicated. I have to register an account?!
“Why the hell should *I* set up an account? It’s not like any bugs will be assigned to me or anything. Just store my e-mail address and move on. It’s completely fucking bogus that I should have to go digging through my mail for confirmation passwords.” (http://zork.net/~sneakums/fortunes/gar/215)

Then I have to click a link with a magic number in it *as well as* having to enter a confirmation code from the same email (!?) and then when I’ve finished, I’m not even logged in! I have to log in with the same password I just set! Can’t it just set a cookie?

Currently running r19940 but there doesn’t seem to have been any chage in the power code for the gigabeat S recently.

The issue is that there is a regular clicking noise heard if DC power is connected while the battery is fully charged. This noise is not heard while the battery is charging. The same power adapter doesn’t cause the same noise on an F.

This IS a duplicate of  FS#6904 .

My iaudio x5 hangs when changing directories via short+long direction button presses. It switches to the next directory, but no audio plays, and the WPS shows that it stops at 0:02 of the track.

I put up the three patches (before they expire on pastebin.com) that correspond to the three proposals of how the behaviour of PREV/NEXT could/should be changed. Note that only the situation described in the “subject” of this task is considered and changed.

The IRC discussion is at http://www.rockbox.org/irc/log-20090406#21:35:42

The start of the discussion on the mail list is at http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-04/0057.shtml

I brutally hacked the Oscilloscope to pieces and tried to make an x-y scope.

Please feel free to edit and contribute because I honestly have very limited knowledge of PCM data and the inner workings of rockbox =]

firmware/export/usb_ch9.h comes from linux (include/linux/usb/ch9.h) with only trivial changes. The original doesn’t mention a specific license, so it probably is GPLv2
file basically contains only structure declarations and defines for things straight from the USB specification though, so I’m not sure if there is a real problem.

If LCD_SLEEP is put on the backlight queue immediatly after BACKLIGHT_ON, the LCD will go to sleep immediately after the backlight turns on. On the 5G iPod, the next backlight_on() call will wake it, but on some other targets it might not wake again.

For example, consider the following sequence of events:
1) backlight_on() is called, putting BACKLIGHT_ON on the queue
2) The LCD sleep timeout from the previous backlight shutoff puts LCD_SLEEP on the queue
3) BACKLIGHT_ON is received and the backlight is turned on. The call of backlight_lcd_sleep_countdown(false) does nothing about the LCD_SLEEP on the queue.
5) The LCD_SLEEP is received, putting the LCD to sleep again.

This patch causes LCD_SLEEP to be ignored by backlight_thread() when the backlight is on. It also removes a workaround from 5G iPod LCD sleep code.

This issue is theoretical and very improbable. I am not able to trigger this bug in r20774.

When the battery is low, Rockbox is unable to charge iPod. When booting into Rockbox, the charging icon is displayed, but after a while the device shuts down.

Booting the OF and charging under it for few minutes is required.

Since FM stations list may require that the FM region is set to a certain value, it would be good if the FM region could be set along with the station list. The patch does just that.

The region is set by putting the line “region:N” into the FMR file (at any line there). N can be one of the values allowed for the fm_region setting.

The patch does not work on the simulators for e200 and h120 (the only two I tried) because, for some reason, the symbol HAVE_RADIO_REGION is not defined for them. Could anybody tell why?

Saving the region along with the station list is not implemented.

This is a plugin that locks your player with a 4-digit code. The default code is "0000", until you change it.

This plugin searches in the .rockbox/rocks/apps/drumkit directory for .raw sound files, loads them into memory, and assigns the keys to play them, creating a drumkit /sample trigger / instrument out of the player. Currently only designed for the Sansa e200.

Room for improvement:

- Add keymaps for all
Allow multiple samples to be played at the same time (by using
Allow for a variety of sound file types to be
Find a better name

this patch adds a setting to choose what to do on a usb connection. default is to connect. options are charge only or connect..

holding *any* button will swap the outcome…

it works, but not perfectly… and the manual patch needs to be checked

i asked some time ago why there is the buttontable in general settings –>bookmark. i wondered because the buttons are the same as in other lists. Marc Guay said "the delete button is unique", an i wondered why there is a dedicated delete button… in no other lists exists such a button afaik.

i changed the manual accordingly.
i also corrected some wrong (?) comments.
i hope i did everything right, at least for the e200 it compiles and works fine.

i would like to get some opinions about it.

The aim of this patch is to make releases as simple as possible... i.e the end goal would be to have someone run “$ ~/rockbox/tools/release/release.sh 3.3” and that would do everything except feed the cat...

the first version just modifies bins.pl to accept a version number which eventually gets passed to the Makefile and used in the source to set the version string in the source to “3.x-rBLAAA”.

This also defines RBRELEASE which can be used in the source to do stuff, for example, remove the debug menu in releases (if we decide to do that...) (RELEASE is defined in speex so had to add the RB prefix...)

Also, this changes the way configure is run to use command line args instead of passing input to it which is Just Wrong (TM) :p

Hello, here's my current contribution to the Rockbox project: initial work on a port to the Samsung YP-P2. Right now, it's mostly just copied from the Cowon D2 port, but with some changes to reflect the P2's different LCD.

The LCD shows the picture undistorted, but it seems that the G channel is too strong. Perhaps this is due to the LCD being set to rgb666 mode, so it expects 6 bits from R and B, while Rockbox only gives 5 bits? I tried setting the LCD to rgb565 mode, but that only distorted the colors even more. In any case, suggestion for a fix would be great.

This patch enables you to compile the Rockbox simulator with LLVM (you still need to alter the Makefile yourself though).

However, it fails at linking stage with 'file not recognized: File truncated' errors.

This task is to develop a stand alone command line interface for use with SAPI. This will be designed to run under Windows or WINE.

This will replace the platform dependent VB script currently in place adding new features and try to improve performance.

I have attached an initial release, run with -h option for usage info.

This is not completed had very litttle error handling and due to performance issues under wine I am considering a new server/client model for a future release.

Build 21245

I have ''Start Screen' set to 'Resume Playback'.

When connecting the Ipod (from OFF) to the PC the Ipod boots and USB mode starts but also playback (the play > sign is display on the title bar).

The Ipod is not shows and not mounted on the PC.

On disconnecting USB I get 'data abort' and have to hard reset.

In  FS#8894  (the original timestrech task), an updated version of the algorithm was uploaded.

The author said it performs and sounds better, so we should try to incorporate it.

I've tried building it, but I can't get a useful result, but I'm also not sure if I used it correctly. I used ./scale 2 < in.wav > out.wav. The result wasn't streched, but had crackling noises every few seconds.

This adds asplash and asplashf (and vasplashf for internal use) which normal splashes but can be aborted with button presses.

Additionally, they return the action received (for CONTEXT_STD) so that the caller may handle aborts differently depending on the button.

Also I converted a few annoying splashes to use it (when loading themes, wps, fonts etc and the resume failed splash)

When adding text via the keyboard, neither the selection function nor the done function work using the remote play button. Pressing 'play' on the main unit however, does work and has the correct behaviour.

I checked the keymap-m3.c source and I noticed that unlike the other entires, the last entry for these options refers to the main unit buttons and not the remote:

{ ACTION_KBD_SELECT, BUTTON_RC_PLAY|BUTTON_REL, BUTTON_PLAY },
{ ACTION_KBD_DONE, BUTTON_RC_PLAY|BUTTON_REPEAT, BUTTON_PLAY },

I changed the entries to the following:

{ ACTION_KBD_SELECT, BUTTON_RC_PLAY|BUTTON_REL, BUTTON_RC_PLAY },
{ ACTION_KBD_DONE, BUTTON_RC_PLAY|BUTTON_REPEAT, BUTTON_RC_PLAY },

After rebuilding and installing this change onto my M3 the keybord now works when using the remote.

Attached is the patch file for this change.

Hi,
There is a problem in the Chinese voicing. It says "number, bai fen ji" (number %), but it's supposed to say "bai fen ji number) (% #). I don't know if it happens in text because I'm blind. Could this be fixed?

If playback finished with repeat off, let you resume the last playlist by pressing play or selecting the 'resume playlist' option in the main menu instead of showing the dreaded "nothing to resume" splash.
As a side effect it will also resume if you restart the player and have it set to resume which you would probably want to fix. I didn't update to the latest revision (i have 21295) that has jdgordon's namechange thing so it will probably show 'nothing to resume' if you apply it but still actually resume.

This bug currently exists as of rev 21444.

If settings are modified on the recording screen they aren't persistent after a reboot unless another setting is changed somewhere in the menu system.

The problem is that global_settings is being modified without a subsequent call to settings_save().

Attached is a fix for this problem. I've so far only tested it on the h1x0 simulator but I think it's a pretty benign change, unlikely to cause problems on other targets.

After releasing hold after several minutes of playback with hold enabled, the backlight flickers on and off, if the following settings are enabled:

Backlight on hold: off
Backlight fade in: on
Backlight fade out: on
Caption backlight: on

My theory is that fade-in/out events from the caption backlight somehow get queued up, and happen once hold is released.

Happened as recently as today, with r21438. Reports in IRC said it appeared somewhere between 3.0 and 3.1.

I navigate to any directory in the file tree, enter the context menu and set it as the recording directory. Then I go to the recording screen, cancel out immediately and return to the file tree.

There is now a new directory, in the same place as the directory I just set for recording. The new directory has exactly the same name except the final 3 letters have been removed, and it is this directory that has become the recording directory. The original directory is still there too, but now it does nothing.

The workaround is to create a bogus directory with 3 extra letters, then delete it once the bug creates the new directory with the truncated name.

This patch adds a changable wheel scroll speed option on ipod video.

This patch implements a menu function to the playlist viewer's contextual menu that moves the selected track after the current playing track. It is especially useful as a simple queuing method.

I have tried to properly handle the situation in which the current playing track is the last in the playlist, but since I don't know exactly how (when) the playlist indexes are updated I wasn't able to do much in that respect, any help is very welcomed.

Since this patch adds the LANG_MOVE_AFTER_CURRENT string, I have also attached a diff with updates to the English and the Romanian translation file.

I installed release 3.3 on my Sansa e260. 3.2 worked. On 3.3, volume controls work fine in normal playback mode, but when I switch to FM Radio, they are ignored. If I switch back to normal playback mode, I can set the volume level again, just not while listening to the radio.

The FM Tuner appears to be very sensitive to noise and static compared to the original firmware radio.

Apart from the static and noise the Rockbox FM Tuner sounds much clearer and sharper than the original firmware, so I wonder if this may be related to the OF using a lower sampling rate or cutting off the higher frequencies to reduce noise.

This isn't a big problem because the MR-100 won't turn on if the hold switch is already engaged.

But if the user turns on the MR-100 and then engages the hold switch while the M:Robe logo is on the screen, a "Hold switch is on Shutting down…" message is displayed, but it does not shut down.

A reset is required at this point - disengaging the hold switch and holding down the power button in this state does not shut down the MR-100.

This patch adds does three related things:

- Adds *basic* support for seeking and buffering callbacks so different codecs may manage their buffer space differently
- Extends a few buffering and metadata structures to store information on two files rather than one
- Modifies the Wavpack codec to make use of these features to play back hybrid files with readable correction files losslessly.

This code should not in any way interfere with anything other than the situation where a Wavpack hybrid file is present AND its correction file is readable.

There are several things that need to be done before this patch may be committed:
1. Currently there are two ginormous linear buffers inside the Wavpack codec. They should be replaced with smaller dissimilarly-sized ring buffers.
2. The interspersal of primary and correction file chunks is currently 1/1/1/1. This should probably be more like 1/3/1/3 as that better matches the size rations of a .wv to its .wvc.
3. seek_wavpack needs to support seeking where rebuffering is required.
4. The wavpack hybrid decoding function needs to be modified to decode smaller chunks in a go so that the small ring buffers mentioned above won’t overflow.
5. Gracefully handle the end of a hybrid lossless file (currently it freezes the sim)

The uisimulator cannot be build by using the source of the latest version on MinGW.

I send this bug’s patch.

It is necessary to apply the patch of FS#10021 to build the firmware on MinGW.

As of r21894, the pitch changing mode (in the pitch screen) can only be toggled (cycled through) in one direction. However it would be handy to be able to cycle in the other direction to change procentual vs. semitone while still staying in the time stretch mode. This patch adds such a possibility.

The key mappings is only defined for H1xx and H3xx (as a long press of Mode). Please add keys for other platfroms.

Add support for two new scroll styles, STYLE_NODRAW and STYLE_CUSTOM, with STYLE_CUSTOM causing the draw to be done via a hook (set with lcd_set_style_hook). lcd_puts_stroll_style_offset also returns a struct scrollinfo pointer. This may be used in conjunction with STYLE_NODRAW to redraw the scrolling text in a plugin which draws other graphics to the same part of the screen, by drawing the text using the offset in the struct scrollinfo after the background graphics have been drawn. My latest patch from  FS#4817  is required, as it consolidates styled text drawing in one function, making it easier to replace the normal draw with a call to the hook, and reducing the binsize impact of this feature as well.

Support for core text scrolling in PictureFlow plugin to follow .

Seems pretty self-explanatory

I tried to make the first shot on adding fm radio support for the Samsung YH-* devices.

–