Rockbox

Added movement left/right through the date/time fields by the holdminus/holdplus buttons.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can’t post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Changed controls: moving selection to the left/right by minus/plus buttons, moving selection to the down/up by holdminus/holdplus buttons, choice symbol by the menu button, backspace - long holdmenu button (at release moment), moving cursor left/right by holdminus/holdplus buttons (at release moment), confirm by holding plus button (at release moment), abort by power switch.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can’t post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

This patch makes the graphic EQ usable in the absolute mode on touchscreen models.
Additionally I made the following changes:

* Add a menu in the touchscreen settings to select the touchscreen mode in the graphic EQ ( because in menus I prefer the grid mode, in the EQ the absolute mode is much better)

* Always try to use the UI_FONT , make the EQ filling the whole screen and add a little margin on the left and right side. In that way it can even used with fingers on a touchscreen (automatic adaption to fill the whole screen should work for all targets with EQ and LCD).

I tested on my Cowon D2 and Iriver H340 to make sure non touchscreen models stil work, both worked perfect.

Spider solitare game on easy level

uses solitare card suit

try it!

working on color and grayscale targets

Hi,

this patch, that takes some of the FS10494, improves dock detection and initialization.

It should correct the erratic behaviour on some hardware, and it also adds support for some remote buttons: menu, select, up_arrow and down_arrow.

The buttons arrow are not usable by now, even if they are defined. I tried severals things but i couldn't get it to work.

Any idea of which context I should use to use the button arrow to scroll through the main menu?

Steps to reproduce:

1. Start listening to a series of podcasts, say 1-5
2. After listening to >1 plug player into computer during playback of subsequent podcast
3. Delete the podcasts you have already listened to (not what your currently listening to)
4. Eject/Unplug player from computer
5. Attempt to resume playback

This fails for both resume and Recent Bookmarks functionality. I assume this is somehow tied in with playlist support as files from the playlist have been deleted.

Where does Recent Bookmarks keep it's information? Should the bookmark also keep the individual file referenced so it can resume in this case?

Tested on R21184M-090604

Will test on latest version once my main machine is back on internet.

The patch makes Rec+Vol{Up,Down} in wps and list (main menu) contexts chage backlight brighness. Just like with volume, brightness value is saved in config file. I find this feature quite useful when player is used both indoors and outdoors, eps. on sunny days.

Keymap changes are for Sansa C200 only. Check apps/keymaps/keymap-<you-target>.c and add necessary lines to button_context_{standard,wps} if you use different device.

Diff against SVN revision 22666.

A new background image for bubbles that looks a lot better.
Made using GIMP and images from frozen bubble.

Copy the attached file to ‘apps/plugins/bitmaps’.

Starting from the daily build from mid August (can’t exactly say when, because I don’t play MIDIs so often), the MIDI playback on my iPod 5G 30GB sounds distorted, especially the Piano sample.

It sounds as if the higher frequencies are chopped of and instead replaced by “alias frequencies”. Maybe something has been messed up in the mixing routine concerning decimation filter / interpolation.

I am using the original patchset provided here at rockbox.org.

Maybe somebody could check this - thank you!

Keep up the great work!

Hello! I made this patch to add a separate backlight setting for the viewer plugin. By default the viewer plugin use Rockbox global backlight setting. For battery life, the backlight length would be usually too short in viewer, since reading a page may take more than 10 seconds. Bring the backlight on again by pressing buttons or wheel could be painful since it may cause unwanted effects (e.g. scroll to top/bottom of the text).

I added two options: Use global setting (default) and Always on. When setting to "Use global setting", everything should remain the same as before. When setting to "Always on", the backlight should never dim off. Changing the option during reading will immediately applies effect. I use the helper functions "backlight_use_settings" and "backlight_force_on" to achieve this.

Warning: since I changed the preference struct, after installing the new viewer.rock, all previous viewer setting will be abandoned and revert to default settings. You can backup your old viewer.dat (36 bytes), wait the new viewer.dat (40 bytes) be generated, and overwrite the first 36 bytes from the old viewer.dat to restore the setting. I don't know if there is a painless way for the transition. Suggestions are welcomed.

Thank you!

This patch enables you to control the simulator using a named pipe to provide simulated keypresses, rather than the keyboard.

Unfortunately there is a bug that means that not all events seem to have any effect. On the e200 sim, I can use the scroll buttons to move in the main menu, but neither RIGHT nor SELECT lets me enter any of the entries. I suspect it's related to repeat or hold/release handling, but I'm not sure how to fake that properly.

These two scripts will, if you run them appropriately generate a few screenshots in an automatic fashion. Execute it like this, from inside a simulator: ./genscreenshots e200.xte /path/to/output

There are a few pitfalls:
* The simulator window MUST gain focus when it is run. If this doesn’t happen, everything breaks. Horribly.
* The method is rather timing sensitive. I had to put a pause of 250ms between each keypress to make sure they registred (too fast, and the sim/SDL would discard them). 250ms may not be the right amount for your computer.
* Rockbox itself is also timing sensitive. If you “push” a button at the wrong time, it may not register, so use plenty of sleeps to make sure things are settled.

Edit: Oops, the first version had a hardcoded filename. Hopefully of such things.

In the "Scroll bar width" screen, the value used to show the width selected is the previous one, not the current one. The first value change has no effect.
Anyway it seems that the right value is stored: if you select a value and exit by the screen, when you re-enter in it, the width is correct.

Priority low.

Referred to r22406.

The attached patch enables simultaneous buffering of multiple files in a minimally intrusive way. It also contains code to allow the playback of Wavpack hybrid files, both lossy and lossless. In the event that a Wavpack file is not a hybrid file, only original code paths are used. This patch will not affect users who do not use this file type.

How it works:
A handle may now be marked as "chunky". If a handle is so marked, adding a new handle will NOT reserve space in the buffer for the remaining portion of the file. Instead only a small amount of space (currently 2*BUFFERING_DEFAULT_FILECHUNK) is reserved. Additional checking is also added to ensure that buffer_handle will not allow one handle to overflow into another; in the event that a handle's widx would cross into the next handle's header, the handle is "extended" by calling add_handle a second time and linking from the original via file_next. Thus, there are two paths to iterate from a "chunky" handle - the next handle in the buffer layout (h→next), or the next handle containing data from the same file (h→file_next).

Key new methods:
extend_handle: used to create more space for a handle which is active but would overlap its successor if widx were advanced
clean_handle: remove pieces of a handle marked as "invalid", but don't remove the whole handle (as close_handle does)
bufopenchunky: as bufopen, but for a chunky handle
finish_handle: reserves either some or all space for a handle in the buffer
finish_chunky_handles: finishes all chunky handles

What works:
- Playback of lossless hybrid mono and stereo files in the sim functions mostly as expected. Occasional segfaults may occur - these are probably a thread safety issue. Trying on a unicore target would be productive.
- The functionality of any of rockbox other than hybrid wavpack files is not impaired
- Playback on an iPod 5.5G works as well, but is not yet real-time (apparently the hard disk isn't fast enough to buffer both files and keep up with playback, so priority should be given to the .wv file to fix this)
- Buffer space utilization is very efficient, the only waste is caused by the 300 bytes per struct memory_handle created. This could be minimized by only storing ridx, widx, and data in a minimal memory handle and copying the rest of the information to file_next as necessary (this is how open file descriptors are currently handled)

What doesn't work:
- Seeking does not always work, although seeks not requiring a rebuffer are usually OK (even those which must cross into file_next!). Especially unlikely to work is backwards seeking. This is because the Wavpack codec uses approximate seeking, which is fine when you don't have to worry about only one file but falls apart when you need to have the same block in both the wv and wvc files.
- Segmentation faults, especially at the end of very large hybrid files. These are almost all caused by the Wavpack codec in apps/codecs/libwavpack/words.c's response to reading extra 0 bytes. Wavpack does not check the validity of wvbits.ptr before reading from it! When combined with any error at all in the buffering code, or even any corruption in the input files, this leads to a segfault! There are also some issues in the original Rockbox buffering code. For example, in rebuffer_handle, h→next is used without first holding llist_mutex. This is a thread safety issue. On top of these, there's a bounds check I've missed somewhere in apps/buffering.c which can cause buffer corruption.

Most of the Wavpack decoding methods here were ported from those on http://wavpack.com with minor modifications. These files are under the GPL.

This patch contains commented printf statements as partial documentation and in case someone wishes to trace the flow of execution in the simulator.

I've started to write a new game, which is similiar to the popular freeware game Icytower. (http://en.wikipedia.org/wiki/Icy_Tower)
The basic game engine is ready, but there is much work on the adaption to the targets, so that the difficulty is likely.
By now I used just wildcards for the player and the floors, because I'm not talented in drawing something. I hope you can help me with the images.

I'm looking forward for any feedback.

The patch fix the multiple-language feature, maintaining the same behaviour in interactive and batch mode and with “make reconf”. Now it’s possible to build more than one voice language at once, specifying different engine and option set for each one.
So, running “make voice”, all the selected languages will be built.

To help the comprehension, here it is a batch mode sample:

../tools/configure –target=ipodvideo –ram=64 –type=av –language=italiano,espanol –tts=f,e –voice=lp_diphone –ttsopts=, –encopts=’-q 10 -c 10,-q 5 -c 5’

This is like to run:

../tools/configure –target=ipodvideo –ram=64 –type=av –language=italiano –tts=f –voice=lp_diphone –ttsopts=’ ' –encopts=’-q 10 -c 10’

../tools/configure –target=ipodvideo –ram=64 –type=av –language=espanol –tts=e –voice=lp_diphone –ttsopts=’ ' –encopts=’-q 5 -c 5’

In the first case, I set the language to italian, using festival with voice lp_diphone (female), no further festival options and some manual encoder options.
In the second case, I set the language to spanish, using espeak. Even if I set the voice, the value is ignored, since the selected TTS engine doesn’t use it.

I also added some cosmetics, like some very circumstantial indentation, blank check in rootdir too, simpler numbered menu generation, some terser command pipes.

The patch is applied to r22250.

I don’t know if it’s a really wanted feature, but the word in the script hurt me!

On the Official Test Build for the Sansa Fuze, when playing Doom, in middle of playing, Rockbox gives a Data Abort Error. If it doesn't happen in middle of playing, it is always reproducible by entering the second Map. The most recent error i got is "Data Abort at 307B32D4". My Version is "r21704-090707".

It happened once just browsing through the Menu, but is only reproduced every time by playing Doom, which is why I filed it under Doom.

I will try to try a later revision and see if it fixes the bug.

I tried to make the first shot on adding fm radio support for the Samsung YH-* devices.

–

Seems pretty self-explanatory

Add support for two new scroll styles, STYLE_NODRAW and STYLE_CUSTOM, with STYLE_CUSTOM causing the draw to be done via a hook (set with lcd_set_style_hook). lcd_puts_stroll_style_offset also returns a struct scrollinfo pointer. This may be used in conjunction with STYLE_NODRAW to redraw the scrolling text in a plugin which draws other graphics to the same part of the screen, by drawing the text using the offset in the struct scrollinfo after the background graphics have been drawn. My latest patch from  FS#4817  is required, as it consolidates styled text drawing in one function, making it easier to replace the normal draw with a call to the hook, and reducing the binsize impact of this feature as well.

Support for core text scrolling in PictureFlow plugin to follow .

As of r21894, the pitch changing mode (in the pitch screen) can only be toggled (cycled through) in one direction. However it would be handy to be able to cycle in the other direction to change procentual vs. semitone while still staying in the time stretch mode. This patch adds such a possibility.

The key mappings is only defined for H1xx and H3xx (as a long press of Mode). Please add keys for other platfroms.

The uisimulator cannot be build by using the source of the latest version on MinGW.

I send this bug’s patch.

It is necessary to apply the patch of FS#10021 to build the firmware on MinGW.

This patch adds does three related things:

- Adds *basic* support for seeking and buffering callbacks so different codecs may manage their buffer space differently
- Extends a few buffering and metadata structures to store information on two files rather than one
- Modifies the Wavpack codec to make use of these features to play back hybrid files with readable correction files losslessly.

This code should not in any way interfere with anything other than the situation where a Wavpack hybrid file is present AND its correction file is readable.

There are several things that need to be done before this patch may be committed:
1. Currently there are two ginormous linear buffers inside the Wavpack codec. They should be replaced with smaller dissimilarly-sized ring buffers.
2. The interspersal of primary and correction file chunks is currently 1/1/1/1. This should probably be more like 1/3/1/3 as that better matches the size rations of a .wv to its .wvc.
3. seek_wavpack needs to support seeking where rebuffering is required.
4. The wavpack hybrid decoding function needs to be modified to decode smaller chunks in a go so that the small ring buffers mentioned above won’t overflow.
5. Gracefully handle the end of a hybrid lossless file (currently it freezes the sim)

This isn't a big problem because the MR-100 won't turn on if the hold switch is already engaged.

But if the user turns on the MR-100 and then engages the hold switch while the M:Robe logo is on the screen, a "Hold switch is on Shutting down…" message is displayed, but it does not shut down.

A reset is required at this point - disengaging the hold switch and holding down the power button in this state does not shut down the MR-100.

The FM Tuner appears to be very sensitive to noise and static compared to the original firmware radio.

Apart from the static and noise the Rockbox FM Tuner sounds much clearer and sharper than the original firmware, so I wonder if this may be related to the OF using a lower sampling rate or cutting off the higher frequencies to reduce noise.

I installed release 3.3 on my Sansa e260. 3.2 worked. On 3.3, volume controls work fine in normal playback mode, but when I switch to FM Radio, they are ignored. If I switch back to normal playback mode, I can set the volume level again, just not while listening to the radio.

This patch implements a menu function to the playlist viewer's contextual menu that moves the selected track after the current playing track. It is especially useful as a simple queuing method.

I have tried to properly handle the situation in which the current playing track is the last in the playlist, but since I don't know exactly how (when) the playlist indexes are updated I wasn't able to do much in that respect, any help is very welcomed.

Since this patch adds the LANG_MOVE_AFTER_CURRENT string, I have also attached a diff with updates to the English and the Romanian translation file.

This patch adds a changable wheel scroll speed option on ipod video.

I navigate to any directory in the file tree, enter the context menu and set it as the recording directory. Then I go to the recording screen, cancel out immediately and return to the file tree.

There is now a new directory, in the same place as the directory I just set for recording. The new directory has exactly the same name except the final 3 letters have been removed, and it is this directory that has become the recording directory. The original directory is still there too, but now it does nothing.

The workaround is to create a bogus directory with 3 extra letters, then delete it once the bug creates the new directory with the truncated name.

After releasing hold after several minutes of playback with hold enabled, the backlight flickers on and off, if the following settings are enabled:

Backlight on hold: off
Backlight fade in: on
Backlight fade out: on
Caption backlight: on

My theory is that fade-in/out events from the caption backlight somehow get queued up, and happen once hold is released.

Happened as recently as today, with r21438. Reports in IRC said it appeared somewhere between 3.0 and 3.1.

This bug currently exists as of rev 21444.

If settings are modified on the recording screen they aren't persistent after a reboot unless another setting is changed somewhere in the menu system.

The problem is that global_settings is being modified without a subsequent call to settings_save().

Attached is a fix for this problem. I've so far only tested it on the h1x0 simulator but I think it's a pretty benign change, unlikely to cause problems on other targets.

If playback finished with repeat off, let you resume the last playlist by pressing play or selecting the 'resume playlist' option in the main menu instead of showing the dreaded "nothing to resume" splash.
As a side effect it will also resume if you restart the player and have it set to resume which you would probably want to fix. I didn't update to the latest revision (i have 21295) that has jdgordon's namechange thing so it will probably show 'nothing to resume' if you apply it but still actually resume.

Hi,
There is a problem in the Chinese voicing. It says "number, bai fen ji" (number %), but it's supposed to say "bai fen ji number) (% #). I don't know if it happens in text because I'm blind. Could this be fixed?

When adding text via the keyboard, neither the selection function nor the done function work using the remote play button. Pressing 'play' on the main unit however, does work and has the correct behaviour.

I checked the keymap-m3.c source and I noticed that unlike the other entires, the last entry for these options refers to the main unit buttons and not the remote:

{ ACTION_KBD_SELECT, BUTTON_RC_PLAY|BUTTON_REL, BUTTON_PLAY },
{ ACTION_KBD_DONE, BUTTON_RC_PLAY|BUTTON_REPEAT, BUTTON_PLAY },

I changed the entries to the following:

{ ACTION_KBD_SELECT, BUTTON_RC_PLAY|BUTTON_REL, BUTTON_RC_PLAY },
{ ACTION_KBD_DONE, BUTTON_RC_PLAY|BUTTON_REPEAT, BUTTON_RC_PLAY },

After rebuilding and installing this change onto my M3 the keybord now works when using the remote.

Attached is the patch file for this change.

This adds asplash and asplashf (and vasplashf for internal use) which normal splashes but can be aborted with button presses.

Additionally, they return the action received (for CONTEXT_STD) so that the caller may handle aborts differently depending on the button.

Also I converted a few annoying splashes to use it (when loading themes, wps, fonts etc and the resume failed splash)

In  FS#8894  (the original timestrech task), an updated version of the algorithm was uploaded.

The author said it performs and sounds better, so we should try to incorporate it.

I've tried building it, but I can't get a useful result, but I'm also not sure if I used it correctly. I used ./scale 2 < in.wav > out.wav. The result wasn't streched, but had crackling noises every few seconds.

Build 21245

I have ''Start Screen' set to 'Resume Playback'.

When connecting the Ipod (from OFF) to the PC the Ipod boots and USB mode starts but also playback (the play > sign is display on the title bar).

The Ipod is not shows and not mounted on the PC.

On disconnecting USB I get 'data abort' and have to hard reset.

This task is to develop a stand alone command line interface for use with SAPI. This will be designed to run under Windows or WINE.

This will replace the platform dependent VB script currently in place adding new features and try to improve performance.

I have attached an initial release, run with -h option for usage info.

This is not completed had very litttle error handling and due to performance issues under wine I am considering a new server/client model for a future release.

This patch enables you to compile the Rockbox simulator with LLVM (you still need to alter the Makefile yourself though).

However, it fails at linking stage with 'file not recognized: File truncated' errors.

Hello, here's my current contribution to the Rockbox project: initial work on a port to the Samsung YP-P2. Right now, it's mostly just copied from the Cowon D2 port, but with some changes to reflect the P2's different LCD.

The LCD shows the picture undistorted, but it seems that the G channel is too strong. Perhaps this is due to the LCD being set to rgb666 mode, so it expects 6 bits from R and B, while Rockbox only gives 5 bits? I tried setting the LCD to rgb565 mode, but that only distorted the colors even more. In any case, suggestion for a fix would be great.

The aim of this patch is to make releases as simple as possible... i.e the end goal would be to have someone run “$ ~/rockbox/tools/release/release.sh 3.3” and that would do everything except feed the cat...

the first version just modifies bins.pl to accept a version number which eventually gets passed to the Makefile and used in the source to set the version string in the source to “3.x-rBLAAA”.

This also defines RBRELEASE which can be used in the source to do stuff, for example, remove the debug menu in releases (if we decide to do that...) (RELEASE is defined in speex so had to add the RB prefix...)

Also, this changes the way configure is run to use command line args instead of passing input to it which is Just Wrong (TM) :p

i asked some time ago why there is the buttontable in general settings –>bookmark. i wondered because the buttons are the same as in other lists. Marc Guay said "the delete button is unique", an i wondered why there is a dedicated delete button… in no other lists exists such a button afaik.

i changed the manual accordingly.
i also corrected some wrong (?) comments.
i hope i did everything right, at least for the e200 it compiles and works fine.

i would like to get some opinions about it.

this patch adds a setting to choose what to do on a usb connection. default is to connect. options are charge only or connect..

holding *any* button will swap the outcome…

it works, but not perfectly… and the manual patch needs to be checked

This plugin searches in the .rockbox/rocks/apps/drumkit directory for .raw sound files, loads them into memory, and assigns the keys to play them, creating a drumkit /sample trigger / instrument out of the player. Currently only designed for the Sansa e200.

Room for improvement:

- Add keymaps for all
Allow multiple samples to be played at the same time (by using
Allow for a variety of sound file types to be
Find a better name

This is a plugin that locks your player with a 4-digit code. The default code is "0000", until you change it.

Since FM stations list may require that the FM region is set to a certain value, it would be good if the FM region could be set along with the station list. The patch does just that.

The region is set by putting the line “region:N” into the FMR file (at any line there). N can be one of the values allowed for the fm_region setting.

The patch does not work on the simulators for e200 and h120 (the only two I tried) because, for some reason, the symbol HAVE_RADIO_REGION is not defined for them. Could anybody tell why?

Saving the region along with the station list is not implemented.

When the battery is low, Rockbox is unable to charge iPod. When booting into Rockbox, the charging icon is displayed, but after a while the device shuts down.

Booting the OF and charging under it for few minutes is required.

If LCD_SLEEP is put on the backlight queue immediatly after BACKLIGHT_ON, the LCD will go to sleep immediately after the backlight turns on. On the 5G iPod, the next backlight_on() call will wake it, but on some other targets it might not wake again.

For example, consider the following sequence of events:
1) backlight_on() is called, putting BACKLIGHT_ON on the queue
2) The LCD sleep timeout from the previous backlight shutoff puts LCD_SLEEP on the queue
3) BACKLIGHT_ON is received and the backlight is turned on. The call of backlight_lcd_sleep_countdown(false) does nothing about the LCD_SLEEP on the queue.
5) The LCD_SLEEP is received, putting the LCD to sleep again.

This patch causes LCD_SLEEP to be ignored by backlight_thread() when the backlight is on. It also removes a workaround from 5G iPod LCD sleep code.

This issue is theoretical and very improbable. I am not able to trigger this bug in r20774.