Rockbox

This patchs modifies the simulator so that it can emulate the storage layer. More preciserly, it enables all the storage code and simply redirect all storage_{read,write, …} to a file. This way, all fs functions used are the one of rockbox, which allows to debug the FAT code for example.

To run this, apply the patch and modify the makefile to add this: -DROCKBOX_SIMULATE_STORAGE_LAYER
to the line:
export GCCOPTS=….

When running the simulator, it expects to read from file simdisk.raw. You can change this by using the –root option:
./rockboxui –root <file>

The code doesn’t work for me, FAT code seems to choke on something for now, I’m not sure why.

This patch adds an option to allow the Fastforward/Rewind buttons to be used to skip tracks entirely.

This is an itch of mine that I scratched and am offering up to others if you are interested.

I’ve been using audio lessons to learn Japanese and ran into issues navigating with the normal FF/RW buttons. The acceleration based on track length left me with no sense of time since I don’t keep track of how far I am into my 30 minute long lessons. Simply backing up 5 seconds to catch something I missed was a problem because I’d have to look at what I was doing to see how far I’d ff/rw. Kinda hard when one tick moves 30 seconds too. This is problematic when driving! The existing skip-length feature is really good for this. However, if I use that to skip 5 second increments then I abandon any way of skipping entire tracks. So I re-purposed the FF/RW buttons for skipping tracks and use skip-length for navigating within a track.

I’ve been using this in r27841 for about a week on my Gigabeat, but it seems like it should work for r27942 as well.

Obviously there is no one who wants to open a mp3 file with text viewer. With this patch applied, ‘Open With..’ only shows plugins that are associated in ‘viewers.config’. To see a full list of viewers plugin, just set the ‘Show Files’ option to ‘All’ and try again.

Some builtin filetypes are text file, so I added them into ‘viewers.config’ for the accessibility.

This patch contains several improvements to the Chopper game designed to make it run with a high framerate instead of a low, jerky one. Previously, the game depended on sleeping for a number cycles before drawing another frame, causing very jerky motion. Now the game should run at a high framerate all the time. The gameplay should be about the same, at least on targets with a display of >64px. I don’t have any of these smaller targets, so I wasn’t able to test. Please tell me what you think of my changes.

This patch reimplements FS#11541 using the skin engine.

new skin tag %Vx(params) will talk whatever is in the params (unlimited….)..
Params can be any string or other skin tag (no conditionals just yet).
if the first option is - it will shutup anything currently talking. otherwise - is a voiced pause.
otherwise the only special string is the word “text” which says to spell the next tag (used when the value of the tag is usable in a conditional, i.e %cP need talk or you will get “1” or “2” :/ ).

quick examples:
%?mh<%Vx(-, %cl,-, %cM, text, %cP)> ← Talk the current hour, minute, am/pm when hold is toggled.

%?pE(15)<%?It<%Tx(-, %Ia, -, %It)» ← untested but should spell the next tracks title and artist when there is 15s left of the current track

Hello, here's my current contribution to the Rockbox project: initial work on a port to the Samsung YP-P2. Right now, it's mostly just copied from the Cowon D2 port, but with some changes to reflect the P2's different LCD.

The LCD shows the picture undistorted, but it seems that the G channel is too strong. Perhaps this is due to the LCD being set to rgb666 mode, so it expects 6 bits from R and B, while Rockbox only gives 5 bits? I tried setting the LCD to rgb565 mode, but that only distorted the colors even more. In any case, suggestion for a fix would be great.

This patch enables display vsync on the iPod Nano 2G, currently only for the Type 1 (LDS176) display. It removes tearing and can make animation smoother. However, right now it uses an extremely CPU-unfriendly method of waiting for synchronization, which makes the display quite slow in some circumstances. I hope to implement DMA to copy the framebuffer, which should help somewhat. However, I am probably going to need some help to do this.

TheSeven gets all the credit for this patch, since he found where the Tearing Effect (vblank) signal was connected to the s5l8701 and wrote the vsync code. All I did was drop it into the display driver in the right spot.

Adds “Binary Skip” to the skip length menu,

This allows navigation by means of binary search within a track.

If no search key is pressed for 5 seconds, the current binary search is considered as having “finished” and pressing a search key subsequently initiates a new binary search.

Tracks played via a cuesheet are not recorded in .scrobbler Last.fm log.

So, when you compile and run the bootloader on VX767/VX757 or any other buttons-only model, it can only boot to the Rockbox or the OF. It cannot use USB mode or reset RB configuration.

Here is a patch.

When utilizing the database on the iPod Photo (as well as other 4G iPods I have used), on occasion when entering a directory or going to the parent directory, any button on the iPod will need to be pressed before the others will have effect. I.E. before I can scroll to select a song, I must press Select or one of the other wheel buttons. It is severely annoying, in part because it is too sporadic to even be assumed to be a “feature”.

A couple of config file options are missing from the manual appendix:

e.g.

backlight fade in: 2000
backlight fade out: 10000

This patch adds a sector-based read/write cache between the storage and fat drivers.
It has a static pool of 64 sector buffers which can be locked by the file handling code to replace the sector buffers in the file and dir structs, and serve as cache as long as they aren’t used. It can also be used to enforce exclusive access to a sector.

If requested using the STORAGE_NEEDS_ALIGN define, all storage accesses will be aligned to cacheline boundaries.

I am trying to use the last method mentioned on the ipodpatcher wiki page to write Rockbox directly into the OSOS image on my iPod Nano2G. Sometimes it works properly, but other times it fails saying that it couldn't read the header from the .ipodx file. I am following the instructions exactly, so that can't be an issue. I have tried hexediting the .ipodx file, and in some cases I can get ipodpatcher to read the header by editing the first four values, but this always causes a Checksum Error. Here is the exact output:

C:\Users\Michael Marley\Downloads>ipodpatcher.exe -wf rockbox.ipodx
ipodpatcher 5.0 with v4.0 bootloaders (v1.0 for 2nd Gen Nano)
(C) Dave Chapman 2006-2009
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[INFO] Scanning disk devices… [INFO] Read XML info (4 bytes)
[INFO] Ipod found - 2nd Generation Nano ("winpod") - disk device 1
[INFO] Reading partition table from \\.\PhysicalDrive1
[INFO] Sector size is 2048 bytes
[INFO] Part Start Sector End Sector Size (MB) Type
[INFO] 0 63 48194 94.0 Empty (0x00)
[INFO] 1 48195 1982462 3777.9 W95 FAT32 (0x0b)
[INFO] Read XML info (4 bytes)
[INFO] Ipod model: 2nd Generation Nano ("winpod")
[ERR] Failed to read header from rockbox.ipodx
[ERR] –write-firmware failed.

On the Sansa C240 V1, to switch on the line level audio output on the dock connector pin 8 needs to go high. So jumping 3V+ from pin 22 will activate the line level audio. This works fine with the Sansa firmware but Rockbox produces no sound through the line level outputs on the C240, with pin 8 jumped or not jumped.

This is a plugin designed to view the contents of either:
synchronised lyrics file (.snc/.lrc)
synchronised lyrics tag information (id3v2.3 SYLT - MP3 only)
unsynchronised lyrics file (.txt)
picture file containing lyrics (.bmp)

Button mappings currently coded for the following players:
iriver H1x0
iriver H3x0
iPod
iAudio X5
Toshiba Gigabeat

Attached:
sncviewer.txt - Instructions
sncviewer.patch - diff/patch file

Forum thread:
http://forums.rockbox.org/index.php?topic=2372.0 .

This patch wil allow the use of the power key to respond yes in the yes&no screen, cause if in absolute touch screen mode would be impossible to respond yes.
It also will enable the hotkey option.
Italian and english translation for the yes&no.

This patch adds a couple more lines to Track Info for Play Count and Rating.
Currently these don’t seem to show up anywhere else.

Tested against r26427 with Fuze v2 and USim.

Steps to reproduce:

1. Create a directory: /AUDIO;BOOKS
2. Place a file in it: /AUDIO;BOOKS/file.mp3
3. Start playing the file, and then create a bookmark
4. Do “List bookmarks” for the file
5. The bookmark menu lists something like this:

BOOKS/;file
0:02, 2, Shuffle

The problem seems to be that .bmark files use semicolons to separate the fields of information. If there’s a semicolon in the path, it thinks that it indicates the end of the path and the beginning of the filename.

This patch adds a changable wheel scroll speed option on ipod video.

- write a word like “مسمار” in a text file, or just use the word as the file name

- the last character “ر” will appear as the first one like this: “رمسما”

- this bug appeared only since r26019

- when reverting to r26018 the bug won’t show up

- for some combination of letters like “دليل” the issue happens for the last 2 characters

- for some other words the problem doesn’t happen at all

- the only common case is that this happens only with last word in a line appearing on the viewport

A mixed RTL with LTR text appears in a missed order not conforming to bidi logical to visual algorithm of unicdoe.

Implementation is ready in bidi_l2v() , but the “orientation” parameter is hardcoded and passed as “1” always

A suggested solution is either pass “orientation” as 0 for any RTL text, or tie the orientation parameter with the “alignment” option of the text viewer.

This patch implements HAVE_LCD_SHUTDOWN functionality for Photo and Color iPods. It is in response to issue 2 in http://forums.rockbox.org/index.php?topic=20994 : “2. The LCD screen on the iPod is not cleared properly when I shut down rockbox. I see 1-2 horizontal lines remain on the screen (which do fade after a minute or so). Nothing is wrong with my IPod’s LCD screen as I did not experience this with Apple’s Firmware”

It seems the Color iPod can have 4 different LCDs. They’re detected via two GPIO bits in lcd-color_nano.c. Types 0 and 2 are the old LCD with an unknown controller and they use the same init, shutdown and update procedures, and they are reported as 0. Types 1 and 3 are similar to HD66789R. They have different init and shutdown procedures but they share the same update procedure. Both 1 and 3 were reported as 1 earlier.

To see what LCD type you have, from the main menu go to System → Debug (Keep Out) → View HW Info and then see the number after “LCD type:”.

This patch has only been tested with LCD type 3 so far.

I am submitting this as a patch because I feel it is not a significant bug. Theoretically, the DC voltage that’s left can degrade the LCD, but the line fades quickly and no negative after-effects were reported.

I would like to also add LCD initialization code and develop HAVE_LCD_SLEEP functionality.

The attached patch adds an indication of the current touchscreen mode to the "classic_statusbar" skin. This is useful since some screens automatically change mode, and there's currently no indication the user when this happens. The patch does the following:

- Adds a new WPS tag (%Tm) to return the current touch mode (Absolute|Grid)
- Updates classic_statusbar.sbs to conditionally show the correct icon

The reason I've made this a Flyspray task rather than just committing it is because the additions to classic_statusbar.sbs will also apply to non-touchscreen targets (though nothing will appear on screen). While the impact on these targets is minimal, I'm not sure about committing it since it will at least cause the new touchmode.bmp to be loaded unneccesarily.

Also, feel free to design some better icons!

This task is to develop a stand alone command line interface for use with SAPI. This will be designed to run under Windows or WINE.

This will replace the platform dependent VB script currently in place adding new features and try to improve performance.

I have attached an initial release, run with -h option for usage info.

This is not completed had very litttle error handling and due to performance issues under wine I am considering a new server/client model for a future release.

This is a patch meant for Clip+ that adds a “Reflection” setting to
allows choosing if to show a reflection or not. When no reflection is shown the images are moved to bottom of screen allowing for title at top and keeping them in the blue
will work for other devices. I tested it on Fuze v2 but others may have unknown problems related to screen size differences. For screens > 100 high it doesn’t move the albums
against r26185 in UISim
you want this as a patch against my pictureflow-wps integration patch let me know as I have one

This very small mod changes the tracklist so it doesn't fade lines when on a mono display (bit depth 1). Tested against r26241 in Sim only (because I don't have a mono display device).
Please report back if problems.

I think this is good since now the plugins in the list appear in the order of their occurrence in viewers.config which is rather random.

this patch adds inline settings to the
any menu items are settings it will show a 2nd line for that menu which will show the value of the elected setting, or —→ for submenus/functions.

notes about this
uses too many hacky-tweaks to be considered
doesnt let you disable
item voiceing is probably
doesnt let you change the setting, you still have to enter the setting screen to change it

DONT send this topic off on a tangent like the last UI change tasks, and any requests for resyncs will be deleted. (I’m guessing this will stay here till at least devcon)

I’m using several SD-cards with my Sansa. When switching cards
and updating the database the db entries of other cards are lost
(unless saved to the database log).

In order to differentiate between files from different cards the
easiest way is to give them different path names. So instead of
mounting each card to <microSD1> this patch takes the volume label
i.e. ‘Classic1’ of the filesystem and mounts it to <Classic1>.

The database update is modified in a way that it erases only entries
for files with a filename of a mounted filesystem. So data of other
cards isn’t erased.

So far the database search isn’t modified to handle nonexisting files,
you still get albums etc. which are currently unavailable.
The patch only makes sure that nonexisting files aren’t entered into
the current playlist.

The patch is only activated for Sansa e200, as I couldn’t test it for
other players.

This adds the translatable string LANG_DISC for display in WPS themes. E.g. a theme could use the following to show “Disc 2” for a multidisc album:

%?ik<%Sx|Disc| %ik|>

Disc is a 4 or 5 letter word in most languages, so it won’t add much clutter in themes which would like to make use of this. A comparable example is the “Next:” (LANG_NEXT) which is used when displaying the next track in a playlist.

installed rockbox and doom (freedoom) all correctly. but problem is that the navigation keys dont work when the game starts. cant move. but i can bring up pause menu by flicking hold on then off but then only up(menu button) works in addition to the center button being able to select

to reproduce:install latest build for ipod classic 5th gen 30gb
install doom from the rockbox utilities program
run doom in ipod
game loads
face at bottom of screen moves, showing it isnt frozen… cannot move

and yes i have tried configuring the keys, it doesnt work

I've been working on PictureFlow - WPS Integration. I repeatedly had cases where showing a tracklist or playing for certain albums would cause a segfault. I tracked this down to a bug in the track list indexing. It only occurs under certain memory allocation circumstances that doesn't occur as readily with the std build. I have attached here a patch to fix it.

Explanation: the create_track_index requests memory for building a track index. The variable "tracks" references an array descending from the buffer top end. When a reallocation occurs it currently only moves the "tracks" position when a track count > 0. However, in some cases a reallocation occurs before the first track is stored and in that case the "tracks" position gets left in the middle of the track_names data causing corruption and then segfault. I've moved the (track_count > 0) decision so that it only controls moving tracks struct data. The "tracks" offset must happen even when track_count is 0.

This patch fixes the segfault on my Sansa Fuze v2 and in UISim. Tested against r26114.
I would expect the same result in other platforms.

I've also included this bug fix in my PictureFlow - WPS Integration patch until this bug fix gets accepted.

On the Official Test Build for the Sansa Fuze, when playing Doom, in middle of playing, Rockbox gives a Data Abort Error. If it doesn't happen in middle of playing, it is always reproducible by entering the second Map. The most recent error i got is "Data Abort at 307B32D4". My Version is "r21704-090707".

It happened once just browsing through the Menu, but is only reproduced every time by playing Doom, which is why I filed it under Doom.

I will try to try a later revision and see if it fixes the bug.

Hi,

I think that the problem reported on  FS#10919  is still here, or at least not completely solved.
But now, I get the feeling that the pause only happens when the buffer refill is triggered via a track skip. During normal playback, it don't seem to happen any more.

The build I tried it on is r25249.

TIA

On Gogear sa9200, when hold is switched to off(means in the middle), the play stops.
Maybe because the hold and the on/off share the same swtich.

New build target, for iriver E10.

A lot of target-specific functions are missing, so it doesn't compile when it reaches the linker. But I think it's about time to insert the build target into SVN, and #rockbox seems to agree.

Also, building a simulator build works quite well. The simulator BMP and the keymaps needs some work, but it works pretty well, including music playback.

I've done some testing with building for other targets and nothing seems to be broken by this patch. I couldn't figure out how to include the BMP in the patch so i attach it separately.

Tested on r24190-100105

To reproduce:
- Start Rockbox, default setting
- Play a file with ID3 tags which are encoded in some non-Latin locale (In my case, Hebrew). Notice that the strings are shown in Gibberish.
- Change Default Codepage to the other locale (e.g. Hebrew).
- Go back to WPS

Expected result: All strings that are encoded in the other locale are shown properly.
Current result: All these strings are shown in the original locale.

Workaround: Restart the player. The new locale is applied.

I will not have time to fix this myself, so I'll appreciate if someone else can take responsibility for this bug. Thanks.

Stereo width of >0% can cause stutter in the form of an audible click.

Bypassed by setting stereo width of 0% or monophonic channel configuration.

Initial support for showing input in the fft plugin. Now, on targets supporting recording, instead of quiting when no track is playing, fft starts monitoring the audio input (using the settings under Recording Settings).

The first patch is just the functional changes, the second patch fixes the indentation of the entire file.

I’m not sure if it works at all since I don’t have a device that can record.

This patch implement alternative hold mode, mentioned in FS#10698.
To enter this mode you must:
1) switch hold button to on position(this results in normal hold mode).
2) press menu button.
3) switch hold button to off position
4) release menu button
To leave alternative model:
1) switch hold button to off position
2) press menu button
3)switch hold button to on position
4)release menu button(now you in normal hold mode)

Additionally I implement simple keymap which working only in wps contex:
if hold button off:

 Plus button increase volume

Emuriver is an emulator (not simulator) for iriver ifp-7xx series. It’s part of the http://www.rockbox.org/wiki/IriverIfpPort and has until now been hosted at the main author’s (Tomek’s) site http://www.mimuw.edu.pl/~tmal/rockbox/ It includes a tool to create flash images for use with the emulator, and a tool to mount such images and do basic file management on them.

This version is almost identical to the last version from Tomek’s site, but I had to fix a few bugs to make it usable on my system. Changes are as follows:

flashimgtool.c: Outputs usage information on errors. (I didn’t do this; I don’t know where this code came from but it’s useful.)

hardware.c: Bug: Arguments were missing in a function call which would sometimes cause segmentation faults, and (I don’t know why or how) slow down the emulator.

main.c: Changed a default file name from prog_flash.bin to prog_flash.img (I didn’t do this)

main.c: Bug: Added explicit return value to nonvoid function. The implicit return value was sometimes -1 which indicated an error so emuriver aborted.

make_flash_img.c: Optimizations: “if” replaced with “else if”. (I didn’t do this)

uicurses.c: Rename a variable into someting more unique. (I didn’t do this)

The reason I’m submitting this patch is that I think the emulator could be useful as it is for those trying to build the ifp port from SVN, that it could (maybe) be worked on to support other players, and that my bugfixes should be included for those building emuriver.

There are a few issues: The flashimgtool subdir in emuriver duplicates a few (three years old) files from RB, disk.c, fat.c, and some more. You might not like the directory structure. It uses an ancient version of autotools. I haven’t been able to create flash images that actually work with flashimgtool. I haven’t built the RB port for ifp yet, so I don’t know if it will run in emuriver or not.

Yes I have discussed the patch in IRC.

When Playing with rockboy on sansa e200 V1 , Rom that have a size of more than 1m Bug and Rockbox often shutdown. And even if these roms run, the speed isn't playable.

This patch adds a per-thread runtime variable which indicates the ticks the particular thread has been running.

This can for example help identifying threads that occupy the CPU for a long period of time.

Steps to reproduce:

1. Start listening to a series of podcasts, say 1-5
2. After listening to >1 plug player into computer during playback of subsequent podcast
3. Delete the podcasts you have already listened to (not what your currently listening to)
4. Eject/Unplug player from computer
5. Attempt to resume playback

This fails for both resume and Recent Bookmarks functionality. I assume this is somehow tied in with playlist support as files from the playlist have been deleted.

Where does Recent Bookmarks keep it's information? Should the bookmark also keep the individual file referenced so it can resume in this case?

Tested on R21184M-090604

Will test on latest version once my main machine is back on internet.

This patch which is a small change in bidi.c contributes with the diacritics patch (http://www.rockbox.org/tracker/task/10720) to fix the diacritized Arabic text joining problem

sansa fuze v1 scroller doesn’t obey ‘first button press enables backlight only’

rockbox 3.5.1

Adds runtime calibrated from (numerous) battery_bench runs on ipod 5g 64mb (60gb)

Added new menu item under Settings.General.System, to select whether USB cable connection enters charging mode by default, or data transfer mode.

By default, the option is set to "No". Meaning, in order to have RB enter charging mode, a specific button should be pressed by the user.

If the option is set to "Yes", USB connection causes RB to enter charging mode, unless the specified button is pressed, causing RB to switch into data xfer mode.

I noticed that when filling the buffer my Video iPod (32MB RAM) does noticeable seeks at semi-regular intervals even if reading from a single non-fragmented file. It seems this is due to having to read the next FAT sector. In firmware/drivers/fat.c there is a FAT cache but no read-ahead of the FAT.

I created fat_preload( struct fat_file *file, long sectorcount ) in firmware/drivers/fat.c to preload the FAT cache. In firmware/common/file.c I created file_preloadfat(int fd, size_t count) because calling a fat_ function directly would be too much of a kludge. I use file_preloadfat in apps/buffering.c just before filling the buffer.

This got rid of that regular seeking and it seems to it can remove about two seconds from the time needed to fill the buffer when reading a single non-fragmented file. Currently the code is quite simple and unintelligent. Fragmentation or other activity can overwrite the pre-loaded FAT sectors in the cache, and in such cases the pre-load leads to needless extra reads. More work is probably needed before this can be included in Rockbox.

Currently this patch is for SW-codec only. I think file_preloadfat could be called from HW-codec buffering code also, though few seeks would be prevented with 2MB of RAM. This patch is also probably useless with flash storage.