Rockbox

IDTask TypeCategoryPrioritySummaryOpenedOpened byLast Edited  desc
9787PatchesDriversVery LowiPod 5G TV out2009-01-12Boris Gjenero222009-03-094 Task Description

Here is a preliminary patch for TV out on a 5th generation iPod. Play a BMP file and TV out will activate. NTSC is the default. If the file has 576 lines, the output will be in PAL. The image stays until another is loaded or TV output is disabled via the debug menu..

The following formats ought to work:
720×480, 24 bpp for NTSC
720×576, 24 bpp for PAL
Many programs including Windows Paint and ImageMagick convert can write such files. Other resolutions and bit depths may work. For example WPS background screens display properly but other WPS bitmaps don’t.

Known issues:
- More work needs to be done to integrate this with Rockbox. No, you cannot view the Rockbox interface, JPEGs or mpegplayer output yet.
- When the LCD is updated, there is a temporary disturbance on TV output
- http://en.wikipedia.org/wiki/Macrovision#Analog_copy_prevention is enabled. Yes, the hardware can disable it, but I haven’t figured out how to do that yet.
- The original firmware probably outputs images differently. It can load programs into the BCM which perform decoding there, and that is probably faster.

8295PatchesDatabaseVery Lowdatabase integration of pictureflow2007-12-10Robert Kukla32009-03-073 Task Description

This is the first step of being able to use the pictureflow plugin from a database search. The database now indexes the path to the coverimage for each audio file. In the database browser you can select “Cover by...” genre, artist, composer, year or all and will be presented with a list of cover image paths. (Imagine a call to the pictureflow plugin at this stage, so instead of a list of boring paths you get nice and shiny images). After selecting a path it will display the list of files that would be queued when a cover image is picked in the plugin.

Next step is to work out how to safely call the plugin without losing the context and utilise the return value from it to queue the files.

Issues so far are:

- the preferred size of 100×100 is hardcoded (this should be configurable or at least be consistent with the value in the pictureflow
the db update for covers has the same restrictions as the other tags, i.e. it will only detect changed cover art on
the coverflow plugin needs to work while music is playing (or stop playback if needs
since there is no guaranteed relation between album name and image file, the album name can’t be displayed

8226PatchesGamesVery LowEnable audio menu for pacbox; enable audio for ipod 5g ...2007-11-25Dave Hooper172009-03-039 Task Description

This patch puts the pacbox emulator onto the cop, leaving the main cpu for audio codec. The COP behaviour is controller by a #define in pacbox.h

If PACBOX_ON_COP is defined, then all iram usage is also turned off, to prevent interference with audio thread.

Additionally, this patch adds an Audio menu (using the playback_control library), which is enabled for all PACBOX_ON_COP and GIGABEAT F-Series builds.

Patch from directly within the apps/plugins/pacbox directory.

9966BugsBuild environmentVery LowH10 5G MTP bootloader can't be built from configure2009-02-27Frank Gevaerts22009-03-031 Task Description

The H10 5G MTP needs a different bootloader than the UMS version (see http://www.rockbox.org/twiki/bin/view/Main/IriverH10PortDevInfo#Build_a_Rockbox_Bootloader).
I’m not sure about the correct way to do this in configure, so I’ll leave it to someone who is.

9942BugsUser InterfaceVery Low"First Keypress Enables Backlight Only" broken on 5G an...2009-02-22Boris Gjenero352009-02-242 Task Description

“First Keypress Enables Backlight Only” doesn’t work on the 5G iPod. For example, if that’s enabled, the backlight is off and I press next track while at the WPS, Rockbox will go to the next track.

It seems like clickwheel event(s) generated when I touch the wheel turn on the backlight. When the button is pressed, the backlight is already considered to be on and the button press performs its usual action. If I carefully hold my finger still on the clickwheel, let the backlight fade, and then carefully press a button without moving my finger on the clickwheel, I am able to turn on the backlight without causing anything else to happen.

I don’t know what to do about this. Requiring a physical button press might be annoying. Removing this option on affected targets might be okay, because it’s easy to turn on the backlight by touching the clickwheel (and that doesn’t seem to cause anything else to happen). Another possibility is to require more or specific wheel events.

I set player type to iPod 5G because that’s all I have, but I expect this problem also exists on other clickwheel iPods. This problem exists on r20079 and r20033.

8830PatchesDriversVery LowSansa: DMA support for sd-card data access (experimenta...2008-03-30Toni62009-02-231 Task Description

First approach, to add dma read/write disk access to the sansa.

There are some restrictions on the dma functionality with this patch:
- only stabile at 80MHz ⇒ cpu boost control added to the driver
- only on 16byte aligned data ptr ⇒ all data are copied to/from aligned memory
- no interrupt support ⇒ using polling method

At 30MHz the driver is much more stable with the following PLL settings:
PLL_CONTROL = 0x8a221e0c; /* 30 MHz = (48MHz/12*30) / 4 */
CLOCK_SOURCE = 0×40007777; /* source #1, #2, #3, #4: PLL (#4 active) */

Reading seems to be in general more reliable than writing of the cards.
The data throughput is a little worse than in the current implementation.
This is partly due to the data copying.
The sporadical ‘2bytes inserted’ problem with the USB file transfer is still
there. Interestingly @30MHz with the above settings, there is another problem:
sporadically ‘2bytes missing’ and ‘2bytes inserted’. Perhaps the DMA transfer
needs some more initialization for proper synchronization.

7718PatchesPluginsVery LowNew Game/Plugin - Play Go and Pente (for 2 players)2007-09-06Alex dos Santos72009-02-164 Task Description

Hello,

This plugin is a game to be played in two.
I like to play go and pente and so is my wife (at least she plays pente) so I wrote this plugin.

I think the code is clear enough. I also used all the #ifdef that I knew.. so, I believe it wouldn’t break any compilation.

The plugin was tested on IPOD 5G (VIDEO) and works just fine. I also compiled it to a few more players without any problem.
I did not try to compile it for players that don’t have the lcd_update() function. It won’t work (at least this first version).

The board size in the LCD is based on WIDTH, since Sansa has width smaller than height you will lose part of the board (horizontally).
I just tested the code in sansa using the Simulator…

It is easy to fix and I will, but I’ll be traveling for a week (that’s why I wrote it, so I could play it while I wait in the airport/plane…) When I came back I will fix it.

Meanwhile, you guys can patch it or use it.
Feedbacks are also welcome.

Current Features:
- Save / Load games
- Pente / Go (Board 9×9, 13×13 and 19×19)
- Remove groups / stones automatically when they are dead

I attached the code and the “executable” for IPOD 5G (Video)

Enjoy!
Alex

9856PatchesPluginsVery LowMore robust patchset.cfg reader for midi player2009-02-01Corwyn Simpson22009-02-132 Task Description

I was reading http://forums.rockbox.org/index.php?topic=17079.0 and thought I’d take a swing at it. So far, I have added (potentially shaky?) support for the ‘#’ comments in the file posted, allowing both Windows and Linux line ending formats, and longer filename support.
Still having problems with the white space after each entry, and detecting or assuming the presence of the file extension.

9879PatchesPluginsVery LowQuit the lamp plugin by pressing a dedicated QUIT butto...2009-02-07Alexander Levin32009-02-091 Task Description

As of r19940, the lamp plugin is quit by pressing any key besides some which have a function in that plugin (or so is the intention –see bug report  FS#9877 ).

This patch changes the plugin so that it’s left with a special button only. The patch also adds key definitions for some players that haven’t been included before (players without color LCD). Key mappings were taken from the patch in FS#8934.

Essentially, this patch implements an atomic part of that patch.

Also, correct handling of USB has been added.

This is in preparation of a (separate) patch for toggling the light on and off without leaving the plugin.

9881PatchesPluginsVery LowEnable toggling the lamp on and off in the lamp plugin2009-02-07Alexander Levin12009-02-082 Task Description

This patch is a continuation of FS#9879 and includes it (but adds something more). It adds the possibility to switch the lamp on and off without leaving the plugin.

Key mappings were taken from FS#8934.

9440PatchesGamesVery LowAntibomb: Paratroopers varient2008-10-02Tony Huynh82009-02-0710 Task Description

This is a variant of an the classic Paratroopers.

It lacks the particles, planes and stacking men. Instead of solders, They're just falling bombs.

For more details about the source of inspiration:
http://en.wikipedia.org/wiki/Paratrooper_(video_game)

9802PatchesManualVery LowPlugin API documentation v22009-01-15Maurus Cuelenaere2009-01-151 Task Description

This is v2 of the Rockbox plugin API documentation generator.

See the mailing list for more information ( http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-01/0040.shtml ).

An example of what the output looks like is available here: http://mcuelenaere.alwaysdata.net/rockbox_api_example_3/

7652PatchesPlaylistsVery LowEXTM3U support2007-08-24Xinlu Huang212009-01-1211 Task Description

EXTM3U is a format based on the standard m3u format. It adds a comment line before filename in .m3u or .m3u8 file in the format of
#EXTINF:xxx,yyy
where xxx is track length in seconds, yyy is the title.

For more info, see: http://hanna.pyxidis.org/tech/m3u.html

Supporting EXTM3U format has several potential benefits:
1. Instead of displaying filenames, track title and length can easily be viewed when viewing playlist (currently I think there is a patch that does it by opening each file).
2. Length of playlist can be readily calculated by summing, which can have some interesting applications such as finding how much time is left in current playlist. (Currently this is not possible yet with this patch, but I’m still thinking of possible solutions).

Of course, you have to have playlists in EXTM3U format to get the benefits. There are widely available tools to generate EXTM3U or add information to existing normal m3u playlists. In the future I might add functionality to Rockbox to save EXTM3U playlists (only if database is enabled and ready) or a plugin.

The current patch is able to parse EXTM3U information and use it in playlist viewer. To see it work, you have to set your track display option in the playlist menu to display EXTM3U information; otherwise, filename will be displayed. Two display options are added: title only and title plus track length.

This patch should have very minimal impact on normal playlist usage. A parse function and a few booleans values to existing structures are added, but the parsed title and filename share the same buffer (since they won’t be displayed at the same time). Specifically, beside a quick initial reading of header to determine if a playlist is EXTM3U and a few boolean checks, current playlist parsing/viewing routines are not changed if playlist is not EXTM3U or EXTM3U information is not needed for display.

Enough of me babbling :D Here is the patch. I did some limited testing, so it probably is not foul-proof yet.

9765BugsMusic playbackVery Low"Beep" sounds very distorted and fuzzy.2009-01-06mike beauchamp42009-01-08 Task Description

After upgrading from 3.0 to 3.1, the “Beep” sound (enabled in Settings / Playback Settings / Beep Volume) now sounds very distorted and fuzzy.

It sounds this way on any setting. Strong, Moderate or Weak and with the player’s volume on any setting. It definitely sounded like a normal clean beep with 3.0

This is on an 80gb Ipod 5.5 with Rockbox r19569-081223

I’m not sure if this should be under “Music Playback”, as I don’t seem to hear the distortion and fuzziness when playing mp3’s.

Mike

9595PatchesUser InterfaceVery LowCorrect thai font display2008-12-01Phinitnun Chanasabaeng52008-12-302 Task Description

This patch will correct how thai vowels and tonal makers display.

9407PatchesPlaylistsVery Lowbookmarks overhaul2008-09-16Jonathan Gordon162008-12-227 Task Description

this patch is a WIP to update the bookmark system.

the change is to save “resume points” into the current .playlist_control file and copy that as a .bmark file. Right now it works fine to load and save (And even list the bookmark resume points).

What doesn’t work yet (in bmark.3.diff) is the recent bookmarks menu item.

So far, the only downside I have found is that when you open a .bmark file the current playlist has to be stopped (it gets bookmarked automatically so if you cancel the .bmark it will resume anyway).
I’m hopeing that this isnt a big enough issue to reject the patch.

5519PatchesGamesVery LowSudoku: Ability to chose which difficulty to generate2006-06-08Jonas Häggqvist82008-12-204 Task Description

It would be nice if the “Generate” menu-option opened a submenu where you could pick which difficulty to generate.

I’ve had a quick glance at the code, and it looks like it’d have to generate until a suitable difficulty is found, but that’s no different from what users have to do now, if they’re after a specific difficulty, except it’d happen automatically.

If I get the time/motivation, I may have another look at it in the next couple of days.

9673PatchesPluginsVery LowImprove mpegplayer ( add pitch )2008-12-19Sanggon, Lee2008-12-191 Task Description

I found  FS#8521 (permanent pitch setting) can successfully combined with mpeg player.
Add  FS#8521  and some fix, we can use pitch function in mpeg player. This means, we can control mpeg play speed.

With  FS#8894 (speed control without pitch change) can produce similar effect and more attractive, but  FS#8894  have serious problem with gigabeat s30 and require more processer power and have lower sound quality.

This patch can patched with  FS#8607 (mpegplayer playlist).

6083PatchesMusic playbackVery LowAnnouncing tracks (DJ feature)2006-09-28Jonas Häggqvist22008-12-161 Task Description

This patch was meant to add a DJ type feature, that would announce each song if a “.talk” clip exists for it. Unfortunately, it’s not as simple as calling talk_file() each time the track changes, because that breaks playback because of CPU inadequacy. Works mostly fine for WAV files though.

The solution is probably to halt playback until the clip has been played, but that’s beyond me.

I have not added a settings interface to this, since the feature is really very incomplete. I’d love if someone would pick it up from here though.

9628BugsMusic playbackVery LowSound sometimes doesn't work on mr100 if booted without...2008-12-12Frank Gevaerts2008-12-12 Task Description

Tested with r19410

If I boot with the headphones plugged in, sound always works (at least I didn’t have it fail yet). If I boot without headhones plugged in, and plug them in later, sound often doesn’t work. This may also depend on whether the player was turned off for a long time, whether the previous boot was USB mode, and whether the headphones were unplugged before or after shutting down.

9329PatchesID3 / meta dataVery LowRemove total tracks and total discs from ID3v2 tags.2008-08-27Magnus Holmgren52008-12-121 Task Description

This patch removes any total tracks and total discs number from the track and disc number fields in ID3v2 tags, so that track and disc numbers are displayed consistently across different tagging formats.

What happens is that if a number larger than zero can be parsed from the start of the field, then the field is terminated on the first “/” char.

Added as a patch as I don’t know if this behavior is wanted.

7877PatchesPluginsVery LowBeing able to adjust volume while using stopwatch plugi...2007-10-01Håkan Hagström22008-12-121 Task Description

It would be nice to be able to change volume while using the stopwatch plugin. If I don’t have the volume perfectly adjusted when starting my jogging round, I have to choose between running the rest of my laps with too low/high volume or discarding my times to change it, as the scroll wheel doesn’t have any function in the plugin.

6041PatchesDriversVery LowH10 Scrollpad2006-09-21Holger Winnemoeller172008-12-122 Task Description

The scrollpad on the H10 (20gb, not sure about 5/10gb) has always bothered me with being jumpy, inaccurate, and unintuitive. At the moment (in rockbox) it seems as though it is working as a simple two button device (up/down), with no real dragging capabilities. I am wondering if this is a limitation of the hardware or current software implementation.

The original firmware seemed to work as follows:
split slider into upper and lower field. Tapping in either upper or lower half would create click-type event for up/down. Dragging in upper half would produce scroll up, draggin in lower half would produce scroll down events. The problem was that upper and lower halves are really kinda arbitrary and not easily distinguishable.

What I think would work nicely:
Tapping top and bottom, as before. Remove upper and lower restrictions for dragging, i.e. if dragging down (anywhere on the scrollpad) create scroll down event, if dragging up (again, anywhere) create scroll up event. Drag and hold will scroll in desired direction proportional to the drag speed (as in pushing a puck on ice). Hold (just hold, no tap or drag) on the touchpad creates a sliding value that can be used as a coordinate for different types of continuous input.

To implement this, we’d need some kind of knowledge about what signals the actual hardware provides, what resolution the pad has, i.e. what the physical and logical implementations of the device are. I am not sure how the Ipod scrollwheel works, but it seems that some of that code could be re-purposed, maybe?

9202PatchesBootloaderVery Lowiriver H300 bootloader power/usb fixes2008-07-16Matthew Haun22008-12-092 Task Description

This patch changes the iriver H300 series bootloader's power and usb handling. When a USB or Power plug are inserted into the H300, it will now boot as normal, not stop in the bootloader usb/charging modes. This was mainly for use in my car, but is also helpful for people with charging cradles for their computers.

Forum thread can be found here http://forums.rockbox.org/index.php?topic=17202.0

8913BugsBuild environmentVery Lowcompilation error due to GNU core utils BLOCK_SIZE valu...2008-04-20Peter D.12008-12-02 Task Description

Hi,

There is a compilation problem when the environment variable BLOCK_SIZE is set. It gave me errors about a comma.

This can be set or cleared systematically or on a command by command basis.

Suggestion one; unset BLOCK_SIZE and its relatives high in the build chain, but be prepared for POSIX to bite with 512 byte blocks.

Suggestion two; set LS_BLOCK_SIZE=1 high in the build chain. (And DF_BLOCK_SIZE=1024 and DU_BLOCK_SIZE=1024 ?)

Suggestion three; edit apps/lang/Makefile so that

$(SILENT)echo “#define MAX_LANGUAGE_SIZE `ls -ln $(OBJDIR)/* | awk ‘{print $$5}’ | sort -n | tail -1`” > $(HEADER)

becomes

$(SILENT)echo “#define MAX_LANGUAGE_SIZE `ls -ln –block-size=1 $(OBJDIR)/* | awk ‘{print $$5}’ | sort -n | tail -1`” > $(HEADER)

or

$(SILENT)echo “#define MAX_LANGUAGE_SIZE `LS_BLOCK_SIZE=1 ls -ln $(OBJDIR)/* | awk ‘{print $$5}’ | sort -n | tail -1`” > $(HEADER)

Suggestion four; just tell people that they are not allowed to have commas in their core utilities output (and be prepared to be bitten badly if the default block size ever changes).

BTW I *like* having thousands separators on my command line, so I have

export BLOCK_SIZE=\'1
export DF_BLOCK_SIZE=\'M

in my /etc/bashrc file.

9571PatchesGamesVery Lownew plugin for AEG style for roll and keep style dice r...2008-11-22Tom Bogue12008-11-221 Task Description

This patch adds a new plugin called aegdice, which allows for AEG style (i.e. 5k3) dice rolling.

8372BugsBootloaderVery LowIdle Poweroff only reboots my 1G iPod2007-12-25bil jeschke62008-11-12 Task Description

The Idle Poweroff only reboots my 1G iPod. I assume it should power it off or put it into a power saving mode. This forces it to use up the battery faster then normal unless I set the Hold button to boot into the iPod firmware to do a proper suspend when Rockbox reboots.

9514PatchesOperating System/DriversVery Lowmake simple list accept a viewport2008-10-30Jonathan Gordon2008-10-301 Task Description

this is part of a different patch which was changed to use the menu api instead of simplelist so im putting it up here incase anyone decides to make simplelist draw in a viewport.

The patch works (or did last time i tried it) but isnt commited because its not really needed just yet.

9513PatchesBuild environmentVery LowSmarter release scripts2008-10-29Jonas Häggqvist12008-10-291 Task Description

This patch modifies bins.pl, manuals.pl and voices.pl to be smarter, just like the new w32sims.pl, adding a -r commandline switch, allowing the same script to be used for building both daily and release versions.

9501BugsApplicationsVery Lowsevere screen corruption on H3002008-10-21Khashayar Naderehvandi32008-10-22 Task Description

I have just now installed the latest stable version of rockbox (that would be 3.0) on an iriver h340. Unfortunately, it’s unusable at the moment due to some serious screen corruption. It sort of looks like this picture: http://img54.imageshack.us/img54/2263/iriver3qs.jpg, but is so much worse that it’s impossible to navigate the menus. If I wait for the backlight to go off, and then press a button, the screen looks fine until I start navigating, at which point the corruption resurfaces.

I’m really excited about rockbox, but this bug is a showstopper for me at the moment.

Thanks for looking into it!

Regards.

9381PatchesUser InterfaceVery LowGigabeat S Play/Pause/Menu Keymap Change2008-09-08Marc Guay62008-10-111 Task Description

This patch modifies the Gigabeat S keymap so that it can be used almost solely using the buttons on the face of the player.

Currently, there is an unused button in the WPS screen (the BACK button, up-left from the cross) which in my mind makes more sense as the “back to the menu” button, while the MENU button (up-right from the cross) is the logical Play/Pause button (at least to a right-handed individual). It’s unfortunate that the button with the Windows logo has been called the MENU button in the code, thus making this rather confusing to read, but if enough people agree with the feel of this change, that could be modified as well.

9330PatchesRbutilVery Lowpatch for openBSD support for ipodpatcher2008-08-28Brian22008-10-083 Task Description

The following patches will allow someone running openBSD to run ipodpatcher. This is my first pass at these patches, so they cannot be integrated without some problems.

A few outstanding questions remain:

1) should I use /dev/sd0c or /dev/rsd0c?

2) why do byteorder(3) functions exist in fat32format.c?

3) how do the developers want to handle disk geometry?

I ask the last question because my patch overwrites the existing ioctl with what works for openBSD, rather than separate it out. And the patch doesn't fully use what is available in struct disklabel. I plan to re-write this one.

The fat32format.diff comments out byteorder(3) functions. The ipodio-posix.diff converts the file to openBSD disk geometry. The ipodpatcher.diff corrects the device used.

I have only tested the patches above for ipodpatcher on iPod nano 1st gen.

9413BugsBattery/ChargingVery LowRockbox (and bootloader) mistakes battery for USB.2008-09-22Paul Skinner72008-09-24 Task Description

This may represent other players as well.

I installed a new battery on my iriver, a 2100 mAh that is working perfectly. The problem however, is that when fully charged, the voltage holds up to 4.12 volts, and until it drains to somewhere under 3.9 volts, Rockbox thinks that it is powered via USB, so naturally Rockbox gets stuck in USB mode until the battery is drained enough for Rockbox to realize that it IS a battery. With this problem at hand, I have to charge my iriver to only less than seventy percent of its battery life, or else wait for an hour or so to drain it to that point. I HAVE tested it in its original firmware, like I said, works perfectly. The problem lies with Rockbox thinking that the battery is a USB charger. I am asking for a fix around this. Is there a way that I can modify Rockbox so that it may understand that it is running off of a battery that will get up to 4.12 volts and not mistake that for USB power? I just now thought to turn off the “Charge During USB Connection,” maybe that will solve the problem; I will get back when I find out whether or not that works. However, I would still like to request a work around for this problem. Any help is much appreciated. Thanks.

9273PatchesLanguageVery LowChanging sapi_voice.pl To make japanese.voice sound bet...2008-08-13Taktak202008-09-2318 Task Description

I would like to change voice strings to make them sound better with a specific SAPI voice.

I don’t intend to change string in *.lang directly.
It should be done in voice.pl dinamically while building voice, shouldn’t it?

9356PatchesApplicationsVery LowAllow to set the delay before button repeat is activate...2008-09-02Alexander Levin12008-09-031 Task Description

The patch allows to set the delay after which the button repeat event is generated. Since this event is used to detect a long button press, it effectively sets this 'threshold.'

Slow fingered users may often hold the select button too long and (unintentionally) get the context menu. For instance, from the WPS screen. But they actually wanted to go to the file browser.

The patch adds a setting for that delay. Its default value is 30 ticks (=0.3s). The menu entry is in Settings → General Settings → System → Long Button Press Duration.

9295PatchesBattery/ChargingVery LowCharger detection for iPod 2G (and 1G?)2008-08-18Mark Fawcus2008-08-181 Task Description

This patch adds detection of the charger connection. Not tested on a 1G, but should work if the ipodlinux GPIO documentation is correct.

NOTE: 'Charging' is not detected, just the presence of external power. See http://forums.rockbox.org/index.php?topic=18196.0 for forum topic.

7497PatchesApplicationsVery LowAdd a magic string to bootloader version to enable loca...2007-07-28Dave Hooper52008-08-121 Task Description

Simple patch to add RBBLver prefix + suffix to the bootloader version string. rbutil can scan the binary bootloader file to locate this string to determine the bootloader version. download.rockbox.org can now be updated to include bootloader.version files alongside the binaries (e.g. extract the bootloader version from the binary using od -S 6 | grep RBBLver )

8794BugsOperating System/DriversVery LowFreeze/Long duration when auto-creating bookmark if the...2008-03-24T12008-08-11 Task Description

Rockbox Version:r16780-080324

Description:
If the “Bookmark on Stop” option is set to “Yes” and there is no free space left on the storage, rockbox freezes/takes a REALLY long time if pressing the Poweoff(=Stop) button, because it cannot save the bookmark(or has to push out the less recent?).

I wondered why rockbox crashed if doing this til I discovered this bug.

Expected behavoiur: Instantls notify user there’s no space left and don’t save the bookmark

How to reproduce:
1. Power on the player, launch rockbox. Make sure there’s enough disk space.
2. Go Settings→General Settings→Bookmarking→Bookmark on Stop→Set to “Yes” 3. Reboot, connect to PC
4. Create a text file which is big enough to consume the rest of your free disk space
5. Restart Sansa into rockbox
6. Play a track
7. Press poweroff (short)

9260BugsApplicationsVery Lowr18234 - core + plugins shouldnt be calling opendir() d...2008-08-10Jonathan Gordon2008-08-10 Task Description

Only filetree.c should be allowed to call opendir(), anything that needs to recursively scan directories should be calling ft_load() which can smartly open, scan and close a directory.

The problem with this is that the filename buffer could get corrupted easily if its misused.

as of r18234 the following is using opendir() in the core
filetree.c:133: dir = opendir(c→currdir); ← not recursive
filetree.c:257: dir = opendir(tempdir); ← in ft_load() so ok
filetree.c:259: dir = opendir(c→currdir); ← “” “” “” misc.c:164: dir = opendir(pathlen ? buffer : “/”);
misc.c:1059: dir = opendir(BOOTDIR);
misc.c:1142: DIR* d = opendir(path);
onplay.c:466: dir = opendir(dirname);
onplay.c:817: srcdir = opendir(src);
tagcache.c:4075: dir = opendir(dirname);

the tagcache and the onplay.c ones are dangerous… the 3 in misc.c are not recursive so safe.

the following are uses in plugins, havnt checked them so I only know for sure that stats, disktidy and properties are unsafe
plugins/disktidy.c:203: dir = rb→opendir(name);
plugins/disktidy.c:270: dir = rb→opendir(name);
plugins/md5sum.c:78: dir = rb→opendir( path );
plugins/md5sum.c:113: DIR *dir = rb→opendir( newpath );
plugins/md5sum.c:209: dir = rb→opendir( arg );
plugins/properties.c:79: dir = rb→opendir(tstr);
plugins/properties.c:151: dir = rb→opendir(dps→dirname);
plugins/properties.c:276: dir = rb→opendir(str_dirname);
plugins/random_folder_advance_config.c:70: dir = rb→opendir(fullpath);
plugins/random_folder_advance_config.c:165: dir_check = rb→opendir(formatted_line);
plugins/rockpaint.c:740: d = rb→opendir( bbuf );
plugins/rockpaint.c:754: d = rb→opendir( “/” );
plugins/rockpaint.c:915: d = rb→opendir( FONT_DIR “/” );
plugins/sokoban.c:925: if(!(dir = rb→opendir(dirname)))
plugins/stats.c:139: dir = rb→opendir(fullpath);
plugins/test_codec.c:763: dir = rb→opendir(dirpath);
plugins/test_disk.c:356: dir = rb→opendir(testbasedir);
plugins/test_disk.c:359: rb→splash(HZ, “opendir() failed.”);
plugins/test_disk.c:421: if 1) == NULL)
plugins/wavrecord.c:3774: if 2) == NULL)

so,
The bad calls in the core should be changed to use ft_load, and the plugins should either get a new function in the lib to grab some ram and manage the whole thing, or maybe its safe to just call ft_load there also?

or alternatively, we can go on ignoring the issue.

1) dir = rb→opendir(testbasedir
2) dir = rb→opendir(recbasedir
8589PatchesBuild environmentVery LowAllow to choose Loquendo and ViaVoice TTS2008-02-11Chelo Sacristán72008-08-072 Task Description

It would be useful to change the configure and voice.pl files in order to allow the user to choose also the Loquendo and ViaVoice TTS

9064BugsMusic playbackVery LowiRiver H340 skips when battery low2008-06-02Antony Stone72008-08-05 Task Description

- What behaviour you are seeing

Rockbox 17612-080523 on an iRiver H340 skips entire tracks, and also skips within tracks, when the battery level falls below 30%

- What behaviour you expected

No skipping.

- How to reproduce the bug

Allow the battery level to fall below 30% and start playing a directory of files. Some files will be skipped, some files will have parts skipped in the middle.

- The SVN revision you are using and if possible the particular SVN revision in which you think the bug was introduced.

17612-080523, no idea when the bug started.

If you need any further info on this bug, please ask and I’ll give more details. I have no other hardware to test whether this behaviour occurs on other Rockbox platforms.

9171PatchesApplicationsVery LowReplace the CUBE in cube with COBRA MK III2008-07-08Dave Hooper42008-07-182 Task Description

Dumb patch but introduces handling for non triangular faces (by triangulating them when rendering). Vertices courtesy of http://mackayj.doosh.net/eliteships.html (in particular I hand-converted http://mackayj.doosh.net/files/vrml/eliteships/cobra3.wrl)

9169PatchesUser InterfaceVery LowAllow seek speed limiting to be optional2008-07-08Steve Bavin12008-07-152 Task Description

This patch adds an option to disable the speed limiting that slows down seeking as you approach the end or beginning of a track.

It defaults to limiting enabled, to maintain compatibility. Personally, I prefer the fast seeking without the limiting.

The manual is not included, I can't compile them still…

9177BugsRbutilVery LowRBUtil reports a successful install on the e200R when i...2008-07-09Marc Guay12008-07-12 Task Description

Unsure if this is an RBUtil isssue or a sansapatcher issue, or even a Sansa issue that can’t be solved, but according to this (http://www.rockbox.org/irc/log-20080709#02:36:38), it reports a successful install on the e200R when it hasn’t. Related to  FS#7526 ?

8396PatchesMusic playbackVery Lownext_dir within playlist2008-01-03Lee Kang Hyuk162008-06-298 Task Description

This patch is inspired by FS7571.

Currently we can move to next/prev directory with <short left/right + long left/right>. This patch changes two part of this functionality:

1. If <Auto-Change Directory> is not enabled, move to first track of current/next directory only within the playlist.
So you can maintain dynamic playlist. This was very annoying problem for me.

2. do not wait till <long left/right> is released.

So ffwd or rewind will not be performed at new track.
7252PatchesVideoVery LowSubRip (srt) subtitle support in MPEG Player. (Edit: +o...2007-06-02Antoine Cellerier252008-06-288 Task Description

This patch adds SubRip subtitle support to MPEG Player.
http://wiki.multimedia.cx/index.php?title=SubRip

Files need to have the same name as the video file with a “.srt” extension.

I know that the OSD rendering is not implement in a way that linuxstb and jhMikeS would like but I still wanted to post the patch here in case anyone felt like adapting it. (Current OSD only renders on top of the video area, it can be adapted to add other OSD channels … like display a seek bar, volume control, playback state, etc.)

Enjoy,

Edit: I’ve also added a timebar display (when changing the volume)

8305PatchesOperating System/DriversVery Lowc200: support docking stations with audio2007-12-12Jerry52008-06-163 Task Description

When the c200 is docked (as detected by the charger discrete being active), switch to line out. This was necessary for the Griffen “iTrip Auto for Sansa” adapter to produce output. I would assume this is necessary for other docking stations.

This is *NOT* a perfect patch, but it is a start and is necessary to make docking stations with audio output work.

Limitations:
* I mute the headphone output, so plugging in a non-docking charger will prevent listening via the headphones while charging. Both can be enabled… if the charger is plugged in, it probably isn’t an issue but that is what the Sansa firmware does.

* The charger/headphones detection is done only on power up. This is suboptimal, but usually “correct.” A better technique would be to hook into the charger status announcements, but I don’t have time right now. :-(

9078PatchesPluginsVery LowThinkfast - A plugin to measure your reaction speed2008-06-06Clément Pit--Claudel2008-06-061 Task Description

The purpose of the game is to press one of the four direction keys as fast as possible when randomly asked to do so. At the end of the game, min/max/average values are displayed.

9060PatchesFont/charsetVery LowWenQuanYi Bitmap Song fonts2008-05-31William Poetra Yoga Hadisoeseno2008-05-3114 Task Description

This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2]. This font is similar to the WenQuanYi Unibit font (FS#9059) and focuses mostly on ASCII and CJK, but I’m also posting this font for inclusion because this one has different point sizes, like for example the nimbus, Sazanami and ProFont fonts already included in Rockbox. With the different point sizes, especially lower point sizes, this font is great for small screens such as my iPod Nano.

I’m attaching some screenshots of this font under various point sizes and weights. I’ve also taken screenshots with the simulator to show how it would look like in Rockbox.

Additionally, this font is available from the original website at [3]. There is also an online README file at [4]. The source BDF files are available from the project’s SourceForge page at [5], and the BDF files I’m attaching come from the source package at [6].

According to the project[4], this font is a derivation of older free fonts and enhanced with bitmaps made by online users. As such, it is licensed under the GPLv2 with a font embedding exception[4]:

[quote]
** GPL v2 license with font embedding exception:

As a special exception, if you create a document which uses this
font, and embed this font or unaltered portions of this font into
the document, this font does not by itself cause the resulting
document to be covered by the GNU General Public License. This
exception does not however invalidate any other reasons why the
document might be covered by the GNU General Public License. If you
modify this font, you may extend this exception to your version of
the font, but you are not obligated to do so. If you do not wish to
do so, delete this exception statement from your version.
[/quote]

It’s up to Rockbox developers whether to strip off this exception. Either way, the font is compatible with Rockbox’s license (GPLv2).

Links:
[1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?BitmapSong [4] http://www.wenq.org/index.cgi?Hero_README [5] http://sourceforge.net/projects/wqy/ [6] http://downloads.sourceforge.net/wqy/wqy-bitmapfont-bdf-gb18030-0.9.9-0.tar.gz?modtime=1194227675&big_mirror=0

9059PatchesFont/charsetVery LowWenQuanYi Unibit font2008-05-31William Poetra Yoga Hadisoeseno2008-05-313 Task Description

This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2].

I’m adding this font because:
1. Currently there is no good Chinese font for Rockbox.
2. The best Chinese font (unifont) has unevenly sized Chinese characters, while this font has uniformly sized Chinese characters.

The attachments contain screenshots of the simulator, to show how this font would look like on the iPod Nano. I’ve also attached a screenshot using the Unifont font to show the uneven sizes of Chinese characters, for comparison. I don’t know about other languages, but I’d think other CJK languages work better in this font as well, due to the merging of WenQuanYi Bitmap Song.

According to the project[3], this font is made by combining the GNU Unifont (GPL), WenQuanYi Bitmap Song (GPL) and Fixed-16×8 (Public Domain) fonts. The maintainer of GNU Unifont also acknowledges this fact at [4].

This font is licensed under the GPLv2 with a font embedding exception[3]:

[quote]
** GPL v2 license with font embedding exception:

As a special exception, if you create a document which uses this
font, and embed this font or unaltered portions of this font into
the document, this font does not by itself cause the resulting
document to be covered by the GNU General Public License. This
exception does not however invalidate any other reasons why the
document might be covered by the GNU General Public License. If you
modify this font, you may extend this exception to your version of
the font, but you are not obligated to do so. If you do not wish to
do so, delete this exception statement from your version.
[/quote]

I don’t mind either way, but it would be up to Rockbox developers whether to strip off this exception. And either way, the font is compatible with Rockbox’s license (GPLv2).

The font I’m attaching is a modified version (and only the bdf); you can download the original version from [5]. My modification is:

— wqy-unibit.bdf.orig 2008-06-01 04:47:36.839752214 +0800
+++ wqy-unibit.bdf 2008-06-01 05:01:51.031748178 +0800
@@ -64,7 +64,7 @@
CHARSET_ENCODING “-1” CHARSET_COLLECTIONS “ASCII ISO8859-5 GB2312.1980 BIG5-0 KSC5601.1989-0 JISX0208.1997 ISO10646-1” ENDPROPERTIES
-CHARS 46443
+CHARS 46444
STARTCHAR uni0000
ENCODING 0
SWIDTH 500 0

This is because convbdf will emit a warning “Warning: DWIDTH spec > max FONTBOUNDINGBOX” when converting the font. This is because there are actually 46444 STARTCHAR entries, but only 46443 glyphs – the character “mu” is encoded as 181 and 956, with the exact same glyph. The generated .fnt file is exactly the same with or without my modification.

Additionally, this font is quite big so it’s a bit big on the screen of the iPod Nano. But it would be great on larger screens. Please take a look at the screenshots in the attachments.

Links:
[1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?Unibit_README [4] http://www.unifoundry.com/unifont.html [5] http://downloads.sourceforge.net/wqy/wqy-unibit-bdf-1.1.0-1.tar.gz?use_mirror=osdn

Showing tasks 601 - 650 of 669 Page 13 of 14<<First - 10 - 11 - 12 - 13 - 14 -

Available keyboard shortcuts

Tasklist

Task Details

Task Editing