Rockbox

The (software-)equalizer is adding high noises to the playback.

I made a recording, the first part with eq enabled the second one with disabled equalizer.

I could also make a test on my older H110, on which I never used the sw-eq though.

Hi there,

first of all: this is my first contribution to rockbox and I tried my best to make myself familiar with the way things work there. I am sure, not everything is where it belongs. Please help me to get things in order :).

second: thanks to the author of Patch  FS#1803  that made this possible.

The purpose of this patch is to watch the tuner reported field strength (estimate) and mute, when it drops below a customizable threshold. Wether muting or not as well as the threshold are customizable in the fm tuner menu. It should not interfere with manual muting and should not affect recording (i didn’t test that yet). THe threshold is specified in pseudo-dBuV.
It also adjusts frequency display to display as MMM.KKK instead of MMM.KK. This is for people who adjust region settings and channel widths.

My testing conditions were limited to the sansa c250.  FS#1803  reports to work on the tuner chips LV24020LP (e.g. sansa c250) and TEA5767. I only tested the first. Please report back possible field strength values you see on devices using these chips.

This code should not break anything. I did a testbuild for some iPods (without tuner) that compiled cleanly. Simulator also works.

Currently only english and german translation are done.

User guide:
This patch conditionally adds 1 or 2 lines to the tuner main window that look like this:

Sig: [-M] -235dBuV
Automute below -555dBuV

The second line is only displayed if automute is enabled. The first line shows the status of the tuner. The 2 characters in the braces exlain as [ab]:

a: either 'O' or '-' 
   'O': current field strength is above threshold
   '-': current field strength is equal to or below threshold
b: either 'M' or '-'
   'M': will mute on or below threshold
   '-': automute disabled.
(both are only updated on field strength change)

The second line should be selfexplaining, same for the menu entries.

Request for comments!

How to reproduce this:-

Use the remote to turn on the player while the hold switch is set to lock on the player. Backlight on both the player and the remote stay on constantly (timeout is set to 5s presently).

If you set the hold switch to unlock the backlight goes off after the timeout has expired and thereafter will turn off however the hold switch is set.

Hi all.

I have found a funny thing, which should get fixed. In set_prescaled_volume there is this call:
audiohw_set_lineout_vol(tenthdb2master(0), tenthdb2master(0));

As far as I can see this call is not needed here. So this patch removes it, but as I own only a sansa e280 I can not test this change. I hope to commit this soon.

If this call is needed… do we need it every time audio changes or only once at init?

Thanks,
AustrianCOder

When recording, as file size reaches 25.2MB and again at 52.4MB respectively, disk thrashing noise drowns out the recording for about 2 minutes.
This occurs at about 27.5 minutes if recording as mp3.
And about 5.25 minutes if recording as wav.

I am assuming that Rockbox is filling a cache and then dumping the file to disk all at once.

I would expect it to write quietly. Even if it where to write on the fly, the noise would be reduced to short bursts. 2 minutes of interruption is just not acceptable. I missed out on important information during those 2 minute periods.

How can we eliminate write noise altogether? Or at least in the recording itself.

Select ‘FM Radio’ Choose your station.
Then from the menu select ‘Recording’ Press ‘play’ or ‘Rec’ to begin recording.
Wait for file size to reach about 28MB. Then stop.

I can also provide recordings if necessary.

*note: I also had the USB cord attached to give better FM reception.
tested on e260 & e280
Rockbox Version: r15988-080102

Thanks

This Patch changes the way that ratings work. It’s pretty simple, it reads the rating info from an MP3 files ID3 POPM tag, and converts that to a Rockbox rating value (0 to 10).

You can then use patch  FS#6301  - new tags for WPS and tagcache patch 4 (4_rating.patch) to display the rating on the WPS (tag is %rr). Some Themes use this tag already so I’m not sure if it is in SVN already.

The patch is written for MediaMonkey (alpha 3), but it should work with other version of MediaMonkey, and other programs that put ratings in the ID3 tag (not iTunes).

Tested on iPod nano.

One thing I’m not sure of is what value to return for bufferpos - should this return an int ponting to the next id3 tag position, or is it OK to return it as is? it dosen’t seem to make any difference either way.

Comments are welcome.

This patch decouples playlist editting from the play/stop state. So,
you get the same playlist menu independent of whether rockbox is
playing or stopped (and all the commands do the same things). Also,
editting the playlist while stopped does not restart playback.

The idea behind this is that now the current playlist appears to
the user to be ‘still there’ when stopped (ie you can view it and
resume it), it doesn’t make sense for an insert while stopped to
insert to an empty playlist.

I have done two patches, the first just makes the current playlist
menu available when stopped (no changes to the menu). The only changes
are to onplay.c and most of the changes were deletes, so the new code
is ~30 lines shorter than the original.

The second patch does the same as the first, but also:

1) it renames “Play Next” to “Replace” 2) it adds a “Replace shuffled” command
3) it renames “Insert” to “Insert in order” (and the same for queue)
4) it does not show the “Insert in order” order command until it is

   useful: after an "Insert next" has already been done.

I think these changes make the playlist editing much easier to
understand for people new to rockbox (and easier to remember for those
not so new). In particular, the current “Insert” can do one of 3 different things (add to empty, insert next or insert after previous insert/ insert next). With the second patch all commands always do the same thing, and the renaming makes it a bit clearer what that thing is.

Anyone who wants to test this should probably also install http://www.rockbox.org/tracker/task/7898 - which fixes a bug in the “Insert next” code.

I'm using the newest build of Rockbox (2007-07-21) with an iAudio X5 20 GB and I have my tuner set to the European region. I encounter two little flaws in the FM-radio. I think they partially have to do with the player's hardware, but maybe Rockbox can improve the quality a bit.

1. The player is really sensitive to movement. The signal strength differs with every meter that you take the player with you. On top of that, most stations sound like they're not correctly tuned, but I can't get them any better. Maybe Rockbox could be more accurate in frequency selection? (Like 101.100, 101.125, 101.150.) I can get these stations quite well on my home radio. I don't expect the same quality from such a small device, but some finetuning would be great. The only problem is that it would take a while to scroll through the frequencies, but once set it'd be fine.
2. (I assume this is very hardware related.) The radio signal may change between stereo and mono. I have it set to stereo, but sometimes it just picks mono. I guess this is because of the hardware, since it is place related. I also didn't find any potential bugs in the source code.

What are your thoughts on this?

Oh, and keep up this good work! I really enjoy Rockbox!

Before you get carried away, this is the script that will build talk clips in /.rockbox/talkclips/* for all tags and labels (reading tagnavi.config as well as the database_[0-9]*.tcd files).

The idea is that the database code will then look here for talk clips.

In the long term, the same method could be used for the file browser if desired.

Hopefully someone will help me out with the database code side of things, as I don’t think I’m up to that challenge.

The patch reorganizes Rockboy to use the same method for storing GB frame buffer data on greyscale targets as color targets. As a result, support for greyscale iPods is much easier and has been implemented (inspired by FS #5282).

Some other changes include:
- Enable the menu for iRiver H100
- Ability to “Show Stats” on all targets
- Screen is redrawn all at once on greyscale instead of line by line
- Elimination of fb.mode (all targets use options.scaling for scaling options)
- Elimination of fb.cc on non-color targets
- Minor variable renaming
- Unification of LCD variables (vdest vs frameb)
- Move greyscale LCD code into lcd.c
- ifdef out vid_update() on greyscale and color targets

Since I don’t have an iPod, I’m curious to see how well this works. It should be fine since the patch my work is based on seems to work for people.

I really need iRiver H1X0 users to test this. There are significant changes to the LCD code and I’d like to know if the is any speed change, whether its an improvement or not. I’d guess that it’s slightly faster or the same as SVN but there’s always a chance that it is slower.

Patch changes controls for Doom:

Forward: rec/up
Left/Right: scrollwheel (it needs a lot of scrolls for large turns, but hopefully it can be modified to work better in the future)
Back: down
Shoot/Enter (menu): select
Change weapon: left
Open: right
Esc: power

Some improvements for voicebox on windows. Mainly an option to voice file extensions. Not perfect yet. Instead of an option to voice file extensions there are two voice files options in the hta file. Anyone know what is wrong with this?
Thanks

If you’re willing to produce a Human voice file (spoken by you or someone you know), this script will be particularly helpful. It expects you to put it in a directory with a subdirectory containing .wav files for all voice strings, named by the contents of the string (this will be problematic on FAT/NTFS, but could be fixed).

When run, it will check to see if all needed strings are available, and if they are, it will generate a voice-file for all targets. If they aren’t, it will print out a list of strings missing (to be recorded and put in the subdirectory). This list will also be put in the file “missingstrings.txt”, one on each line.

This might be suitable for inclusion in tools/

Edit: Script deleted. Will upload again soonish.

This is the first plugin I’ve ever written from scratch, and well, it was fun. I haven’t worked out how to use bitmaps yet, bear with me, for now it uses coloured rectangles. Still learning :p.

If this were to get committed, please wait until I’ve added better support for more targets, commented as many lines as are possible to help other people new to making plugins, potentially add AI (Although that would kinda ruin it as it would probably force a draw every time), and figured out how to use bitmaps properly.

If people are willing to test this out for me and tell me any bugs, please do so. I have tested this on the H10, the Gigabeat, and, using the simulator, the iPod mini G2 (Which displays it but out of alignment, will work on that soon.

I realize it’s not too exciting, but for my first real bit of work in C I’m happy :p.

This is the game Squarebloxx. It works on Color-LCDs only because colors are an essential part of the game. I tested it in the Simulator for all the color Boxes. I also tested it on my H340.
In the game you have to mark parts of an array of tiles. If the tiles in the corners of the mark are the same color, the marked area is done. If all tiles are done the level is finished.
Please give me feedback and report bugs.

Thanks Krush

This is a rockbox version of the simple word game called “Target”.
Rules: (stolen from The Age newspaper website)
“See how many words of four letters or more can you make from the letters shown in the grids.
In making a word, each letter must be used once only.
The word must contain the centre letter and there must be at least one nine-letter word in the list.
No plurals or verb forms ending with “s”; no words with initial capitals and no words with a hyphen or apostrophe are permitted. The first word of a phrase is permitted (eg inkjet in inkjet printer).”

Currently it only works on H300, iPod Photo and iPod 5g DAPs, but I plan to expand this to all bitmap targets soon enough.
The games are either user selected or loaded from the file target_wordlist.dat, I’ve included 10 puzzles, but there are heaps more on The Age newpaper’s site (www.theage.com.au).

This is a sequel for  FS#5736 . It correctly displays the OEM-encoded short DOS file names.

Following code pages are supported: cp850 (western Europe), cp852 (central Europe), cp737 (greek), cp866 (cyriliic), cp862 (hebrew).

If you change the default code page (in the settings menu) and there are files that are displayed with the short DOS names, you’d better rebuild the dir cache (if it’s activated) since the UTF8-name of the file changes.

When I compile the modified sources, I get the following warning which I don’t understand:
CC common/unicode.c
common/unicode.c:136: warning: function declaration isn’t a prototype

Could anyone tell me what that means and what the reason is?

In the "Scroll bar width" screen, the value used to show the width selected is the previous one, not the current one. The first value change has no effect.
Anyway it seems that the right value is stored: if you select a value and exit by the screen, when you re-enter in it, the width is correct.

Priority low.

Referred to r22406.

The OF ide_power_enable routine sets some GPIO _ENABLE bits to zero when enabling power and sets them to 1 when disabling power. This makes a difference of about 1 in 4066_ISTAT ( FS#9728 ) on my 30 gig iPod, which probably means saving about 0.75 mA. But if 1 is enable, why does enabling pins save power?