The attached proof-of-concept patch highlights (places the cursor at) each album's last-played track in database views. The intention is to allow easy resuming of multi-track audiobooks or podcasts where they were last left off. This works best when autoresume has also been enabled.

The patch relies on runtime statistics gathering being enabled (and the DB needs to be enables as well, of course).

The current patch has some caveats that I plan to address in future revisions:

Right now, it's unconditionally enabled for all database-based track views. We might consider allowing to turn this off for regular music albums.

When the last-played track has been completed (played through to its end), we should actually highlight the next track (or the first track if the last-played track was the final track of the album). [EDIT: fixed – see latest patch in comments section]

It would be great if a similar feature was available for the file browser. I'd find it acceptable if that would require the DB as well (as that's the place where the last-played info is stored). It could benefit from an add-to-DB-as-files-are-played feature (aka FS#12073).

Comments?

[EDIT: Clarified summary. Fixed a rather severe bug in the patch to make it actually work. :) ]
[ EDIT 2: Linked to FS#12073. Addressed one caveat. ]

The patch allows to use the persistent dircache even in targets that do not define HAVE_EEPROM_SETTINGS.

Starting trying to implement such a feature for my iPod Video, I "discovered" the functions dircache_load/save (I have a slight knowledge of the RB software). Investigating why it was not used on my target, I saw that it's conditioned to the define HAVE_EEPROM_SETTINGS without an apparently reason to limit them just to some targets.
So, I simply "detach" the functions definition and use from the define.
I'm using it since an hour, starting up and shutting down the DAP various times, jumping back and forth inside the dynamic play list, and I got no problems at all.

If I guess correctly the code, the dircache should be updated also when changing the DAP content, if the USB connection is done by RB and not the OF.

It's applied to r29907.

This patch makes some changes to codec_api to help remove dependencies for my project.

The unused strcasestr callback is removed.

The global_settings pointer was being used by several codecs to check whether REPEAT_ONE mode is on; this has been replaced with a callback "should_loop()".

The MOD codec has been modified not to restart the file when it reaches the end. This does not affect MOD files that use "position jump" to loop part of the song. Ideally the MOD codec would only follow such loops if should_loop() returns 1, but detecting loops is nontrivial.

This patch changes some of the settings of the AS3515 to highest audio quality, similar to  FS#11304  but for AMSv1.

AUDIOSET2_IBR_DAC_50 → AUDIOSET2_IBR_DAC_0

0% reduction (instead of 50%) of DAC bias. This will probably increase power consumption.

Not set AUDIOSET3_IBR_HPH.

Increases HP amp bias. Recommended by the data sheet for 16Ohm loads (and will probably reduce THD).

Would be great if these settings could be changed during audio playback to listen for any actual changes in quality :)

in svn settings_apply() is called whenever a config is loaded (after boot) regardless of what is in the file. even an empty one will cause a full settings_apply() (which is slow, causes disk access and will stop music thanks to the buflib users).

This patch will apply settings individually if they have a callback registered, and if no settings without a callback are applied it doesnt bother calling settings_apply().

While I am playing some song on my iPod classic 2G, and scrolling through a list (even the main menu, but the glitch there is somehow different), if I unplug and then replug the headphones, some of the WPS UI gets drawn over the current view. I'm attaching a screenshot to make it more clear. It only happens while playing a song.
I'm using build bf6abf7 (most recent at the moment).
Also attaching my config.

Android:
The Notification bar which use "Remoteviews" may be not suitable for some ICS Roms (see Attachment).
So I change the Remoteviews to "Notification.setLatestEventInfo" to display the track information.

The patch may have some offsets.

Hi,

I’m experiencing an issue with WMA Pro playback on my Clip Zip.

I’ve got the lastest stable build of Rockbox 3.13. Files were encoded with dbpoweramp.

Some files playback normally, but majority of tracks skips. Always at the same point if not forwarding or rewinding.

Here’s a sample. The track skips at 2.15.

build 00a3658. files dont list or play alphabetically regardless of setting in file view menu.

Build 575bd89 2016-12-19

Playing the attached zero-duration WMA '_ length 0.0s WMA.wma' causes crash:

Divide by zero at 6008D274
pc:6008D2&4 sp:600CC7DC
bt end

This WMA file was created by Goldwave and plays without crash in Windows Media Player, GoldWave and MediaMonkey.

Zero-length WAV and MP3 files (examples attached) don't cause a crash.

On the latest development iPod Video and ZEN simulators, MP3 and WAV are reported 'failed' and WMA crashes http://i.imgur.com/k3dKaSN.png http://i.imgur.com/CiYnVuH.png

The scrollpad on the H10 (20gb, not sure about 5/10gb) has always bothered me with being jumpy, inaccurate, and unintuitive. At the moment (in rockbox) it seems as though it is working as a simple two button device (up/down), with no real dragging capabilities. I am wondering if this is a limitation of the hardware or current software implementation.

The original firmware seemed to work as follows:
split slider into upper and lower field. Tapping in either upper or lower half would create click-type event for up/down. Dragging in upper half would produce scroll up, draggin in lower half would produce scroll down events. The problem was that upper and lower halves are really kinda arbitrary and not easily distinguishable.

What I think would work nicely:
Tapping top and bottom, as before. Remove upper and lower restrictions for dragging, i.e. if dragging down (anywhere on the scrollpad) create scroll down event, if dragging up (again, anywhere) create scroll up event. Drag and hold will scroll in desired direction proportional to the drag speed (as in pushing a puck on ice). Hold (just hold, no tap or drag) on the touchpad creates a sliding value that can be used as a coordinate for different types of continuous input.

To implement this, we’d need some kind of knowledge about what signals the actual hardware provides, what resolution the pad has, i.e. what the physical and logical implementations of the device are. I am not sure how the Ipod scrollwheel works, but it seems that some of that code could be re-purposed, maybe?

Patch changes controls for Doom:

Forward: rec/up
Left/Right: scrollwheel (it needs a lot of scrolls for large turns, but hopefully it can be modified to work better in the future)
Back: down
Shoot/Enter (menu): select
Change weapon: left
Open: right
Esc: power

This is the first plugin I’ve ever written from scratch, and well, it was fun. I haven’t worked out how to use bitmaps yet, bear with me, for now it uses coloured rectangles. Still learning :p.

If this were to get committed, please wait until I’ve added better support for more targets, commented as many lines as are possible to help other people new to making plugins, potentially add AI (Although that would kinda ruin it as it would probably force a draw every time), and figured out how to use bitmaps properly.

If people are willing to test this out for me and tell me any bugs, please do so. I have tested this on the H10, the Gigabeat, and, using the simulator, the iPod mini G2 (Which displays it but out of alignment, will work on that soon.

I realize it’s not too exciting, but for my first real bit of work in C I’m happy :p.

The patch reorganizes Rockboy to use the same method for storing GB frame buffer data on greyscale targets as color targets. As a result, support for greyscale iPods is much easier and has been implemented (inspired by FS #5282).

Some other changes include:
- Enable the menu for iRiver H100
- Ability to “Show Stats” on all targets
- Screen is redrawn all at once on greyscale instead of line by line
- Elimination of fb.mode (all targets use options.scaling for scaling options)
- Elimination of fb.cc on non-color targets
- Minor variable renaming
- Unification of LCD variables (vdest vs frameb)
- Move greyscale LCD code into lcd.c
- ifdef out vid_update() on greyscale and color targets

Since I don’t have an iPod, I’m curious to see how well this works. It should be fine since the patch my work is based on seems to work for people.

I really need iRiver H1X0 users to test this. There are significant changes to the LCD code and I’d like to know if the is any speed change, whether its an improvement or not. I’d guess that it’s slightly faster or the same as SVN but there’s always a chance that it is slower.

Some improvements for voicebox on windows. Mainly an option to voice file extensions. Not perfect yet. Instead of an option to voice file extensions there are two voice files options in the hta file. Anyone know what is wrong with this?
Thanks

The attached patch slightly modifies the keymap of the H300 non-LCD remote to allow access to the browser from the WPS (by use of LONG PLAY).

I know that it works ok from an H300 with a non-LCD remote, but I don’t know if I’ve broken the LCD remotes completely.

Please could users of both the H100 and H300 LCD remotes try this patch and tell me that the WPS context keymap is unaffected. For reference, you can see the intended mapping here: http://www.rockbox.org/twiki/bin/view/Main/KeymapIriverHSeries

It would be useful to change the configure and voice.pl files in order to allow the user to choose also the Loquendo and ViaVoice TTS

When recording, as file size reaches 25.2MB and again at 52.4MB respectively, disk thrashing noise drowns out the recording for about 2 minutes.
This occurs at about 27.5 minutes if recording as mp3.
And about 5.25 minutes if recording as wav.

I am assuming that Rockbox is filling a cache and then dumping the file to disk all at once.

I would expect it to write quietly. Even if it where to write on the fly, the noise would be reduced to short bursts. 2 minutes of interruption is just not acceptable. I missed out on important information during those 2 minute periods.

How can we eliminate write noise altogether? Or at least in the recording itself.

Select ‘FM Radio’ Choose your station.
Then from the menu select ‘Recording’ Press ‘play’ or ‘Rec’ to begin recording.
Wait for file size to reach about 28MB. Then stop.

I can also provide recordings if necessary.

*note: I also had the USB cord attached to give better FM reception.
tested on e260 & e280
Rockbox Version: r15988-080102

Thanks

Hi all.

I have found a funny thing, which should get fixed. In set_prescaled_volume there is this call:
audiohw_set_lineout_vol(tenthdb2master(0), tenthdb2master(0));

As far as I can see this call is not needed here. So this patch removes it, but as I own only a sansa e280 I can not test this change. I hope to commit this soon.

If this call is needed… do we need it every time audio changes or only once at init?

Thanks,
AustrianCOder

This patch adds an option to disable the speed limiting that slows down seeking as you approach the end or beginning of a track.

It defaults to limiting enabled, to maintain compatibility. Personally, I prefer the fast seeking without the limiting.

The manual is not included, I can't compile them still…

Dumb patch but introduces handling for non triangular faces (by triangulating them when rendering). Vertices courtesy of http://mackayj.doosh.net/eliteships.html (in particular I hand-converted http://mackayj.doosh.net/files/vrml/eliteships/cobra3.wrl)

This patch changes the iriver H300 series bootloader's power and usb handling. When a USB or Power plug are inserted into the H300, it will now boot as normal, not stop in the bootloader usb/charging modes. This was mainly for use in my car, but is also helpful for people with charging cradles for their computers.

Forum thread can be found here http://forums.rockbox.org/index.php?topic=17202.0

Hello World :)
Attached is a VBR WMA music file, which fails to play correctly on my “RockPod” iPod Nano.
The same file decodes perfectly using the latest ffmpeg build.
Therefore I can only assume there is something about this file which triggers a bug in the Rockbox-specific WMA decoder.
Also attached is a microphone recording of the sound which comes out of my iPod when Rockbox attempts to play the faulty WMA.

I have over 3000 WMA tracks, all encoded using an identical method, all of which will not play correctly in rock box, so if you would like any more examples, or information, please ask.

Thanks for all your help :)
(If there is any way I can help debug/update the code for the wma decoder, please let me know where to start, I understand the C source code pretty well)

~Andrew

I’d like to suggest the following new WPS feature(s):

1. A viewport can be assigned an image as a “backdrop”.

 a. A viewport may be assigned an image dynamically via the WPS tag "%VX<identifier>"
   (i.e. %VXa for image a, %VXZ for image Z, etc.)
  b. As a viewport is being processed and drawn, its backdrop would be drawn "first", followed by any other normal images/characters.

2. Viewport may define FF00FF as a background color, which would then be “transparent”. This would allow overlapping viewports.

3. Fonts drawn in a viewport with a backdrop would automatically be drawn with DRMODE_FG.

Notes on the attached patch file:
+ It was created from the SVN revision 18997 on Nov 3, 2008.
+ Although I stubbed in the new functions for all the LCD drivers, I’ve only flushed out the 16 bit driver so far.

Cheers!

This patch will correct how thai vowels and tonal makers display.

Building Rockbox fails if assert() (in firmware/include/assert.h) is used.

Then, I reworked assert.h.

changes:
When assert() failed, the correction that displayed the file name, the number of lines, and the condition of failing was done.
Moreover, when the log was enabled, the log was output to the file.

Please select the following to make assert() enabled when you make Rockbox.

1) Run tools/configure

2) Build (N)ormal, (A)dvanced, (S)imulator, (B)ootloader, …

    Select "A"

3) (D)EBUG, (L)ogf, (A)ssert, (S)imulator, (P)rofile, (V)oice

   Select "A"

4) make

I was reading http://forums.rockbox.org/index.php?topic=17079.0 and thought I’d take a swing at it. So far, I have added (potentially shaky?) support for the ‘#’ comments in the file posted, allowing both Windows and Linux line ending formats, and longer filename support.
Still having problems with the white space after each entry, and detecting or assuming the presence of the file extension.

This patch is a continuation of FS#9879 and includes it (but adds something more). It adds the possibility to switch the lamp on and off without leaving the plugin.

Key mappings were taken from FS#8934.

Here’s a patch to have a functional usb_serial driver allowing the use of “Logf over Usb” debug function.

“First Keypress Enables Backlight Only” doesn’t work on the 5G iPod. For example, if that’s enabled, the backlight is off and I press next track while at the WPS, Rockbox will go to the next track.

It seems like clickwheel event(s) generated when I touch the wheel turn on the backlight. When the button is pressed, the backlight is already considered to be on and the button press performs its usual action. If I carefully hold my finger still on the clickwheel, let the backlight fade, and then carefully press a button without moving my finger on the clickwheel, I am able to turn on the backlight without causing anything else to happen.

I don’t know what to do about this. Requiring a physical button press might be annoying. Removing this option on affected targets might be okay, because it’s easy to turn on the backlight by touching the clickwheel (and that doesn’t seem to cause anything else to happen). Another possibility is to require more or specific wheel events.

I set player type to iPod 5G because that’s all I have, but I expect this problem also exists on other clickwheel iPods. This problem exists on r20079 and r20033.

I have been using Rockbox for almost 2 years now on my X5L together with the remote and I have frequently updated to the current version, so I am familiar with how it works.

I have noticed that after updating to version 20090221, my X5’s remote’s LCD behaves erratically (strange lines being displayed all over, vertically shaky image) right after booting Rockbox, then the display turns off completely after a few seconds. Strangely though, the controls still work and the blue display light comes on when working the controls, but the display is turned off (there is nothing being displayed, as if the player were turned off). If I unplug and reconnect the remote, the remote’s LCD comes on, but soon turns off again. The X5’s main LCD is working just fine.

I thought that my remote was dying on me, but decided to check if it was somehow related to the development of Rockbox. I reverted back one build after another and found that the last build that works OK for my remote is 20090210. So, in all the builds starting with 20090211 (I have thoroughly checked all from 20090211 to 20090225), the remote is practically unusable. I looked at the changes done on that day (http://www.rockbox.org/daily/changelogs/changes-20090211.html), but could not single out the probable cause.

Great software, anyway!

Using a bootloader from  FS#9955 , a USB connection is not made if Start Screen is set to WPS, and the user boots Rockbox by inserting a USB cable.

This is possibly also true for other values of Start Screen.

Tested on e280, but I expect it’ll likely be the case on other PP targets with USB

Since FM stations list may require that the FM region is set to a certain value, it would be good if the FM region could be set along with the station list. The patch does just that.

The region is set by putting the line “region:N” into the FMR file (at any line there). N can be one of the values allowed for the fm_region setting.

The patch does not work on the simulators for e200 and h120 (the only two I tried) because, for some reason, the symbol HAVE_RADIO_REGION is not defined for them. Could anybody tell why?

Saving the region along with the station list is not implemented.

This plugin searches in the .rockbox/rocks/apps/drumkit directory for .raw sound files, loads them into memory, and assigns the keys to play them, creating a drumkit /sample trigger / instrument out of the player. Currently only designed for the Sansa e200.

Room for improvement:

- Add keymaps for all
Allow multiple samples to be played at the same time (by using
Allow for a variety of sound file types to be
Find a better name

This patch enables you to compile the Rockbox simulator with LLVM (you still need to alter the Makefile yourself though).

However, it fails at linking stage with 'file not recognized: File truncated' errors.

This bug currently exists as of rev 21444.

If settings are modified on the recording screen they aren't persistent after a reboot unless another setting is changed somewhere in the menu system.

The problem is that global_settings is being modified without a subsequent call to settings_save().

Attached is a fix for this problem. I've so far only tested it on the h1x0 simulator but I think it's a pretty benign change, unlikely to cause problems on other targets.

As of r21894, the pitch changing mode (in the pitch screen) can only be toggled (cycled through) in one direction. However it would be handy to be able to cycle in the other direction to change procentual vs. semitone while still staying in the time stretch mode. This patch adds such a possibility.

The key mappings is only defined for H1xx and H3xx (as a long press of Mode). Please add keys for other platfroms.

I tried to make the first shot on adding fm radio support for the Samsung YH-* devices.

–

The patch fix the multiple-language feature, maintaining the same behaviour in interactive and batch mode and with “make reconf”. Now it’s possible to build more than one voice language at once, specifying different engine and option set for each one.
So, running “make voice”, all the selected languages will be built.

To help the comprehension, here it is a batch mode sample:

../tools/configure –target=ipodvideo –ram=64 –type=av –language=italiano,espanol –tts=f,e –voice=lp_diphone –ttsopts=, –encopts=’-q 10 -c 10,-q 5 -c 5’

This is like to run:

../tools/configure –target=ipodvideo –ram=64 –type=av –language=italiano –tts=f –voice=lp_diphone –ttsopts=’ ' –encopts=’-q 10 -c 10’

../tools/configure –target=ipodvideo –ram=64 –type=av –language=espanol –tts=e –voice=lp_diphone –ttsopts=’ ' –encopts=’-q 5 -c 5’

In the first case, I set the language to italian, using festival with voice lp_diphone (female), no further festival options and some manual encoder options.
In the second case, I set the language to spanish, using espeak. Even if I set the voice, the value is ignored, since the selected TTS engine doesn’t use it.

I also added some cosmetics, like some very circumstantial indentation, blank check in rootdir too, simpler numbered menu generation, some terser command pipes.

The patch is applied to r22250.

I don’t know if it’s a really wanted feature, but the word in the script hurt me!

Added seeking by holdplus/holdminus buttons, pause/play by holdmenu button, hiding the OSD panel by briefly pressing power switch.

This is a first attempt at creating an entry for the new fft plugin. The button table was automatically generated with the attached python script.

The script takes a file (or - for stdin), looks for an #ifdef CONFIG_KEYPAD….#endif block and if it finds one (and it is relatively simple), it parses it and creates the corresponding LaTeX table.

The script is extremely simple but it does provide a good basis for further work.

When loading a saved Brickmania game, the game is loaded corrupted. Please see screenshot attached to see for yourself. There is one brick in the right side which is shown corrupted, and one corrupted rectangle in the left side of the screen which drops like a power object, and stays at the bottom of the screen.

This issue happens on Cowon D2 target. It doesn't happen on the D2's simulator.

Looking at the code and comparing the loading/saving function against the Bubble's game functions, I can see that the return value of file operations is not checked (I'll fix that).
In Bubbles, there's a single file operation of reading/writing the game context struct. In Brickmania there are several consequent file operation to read/write each variable. Maybe the drivers doesn't handle this well on this target. A workaround for that could possibly be to join all saved variables under one game context struct as in Bubbles, but that could mask a real bug somewhere else.

New build target, for iriver E10.

A lot of target-specific functions are missing, so it doesn't compile when it reaches the linker. But I think it's about time to insert the build target into SVN, and #rockbox seems to agree.

Also, building a simulator build works quite well. The simulator BMP and the keymaps needs some work, but it works pretty well, including music playback.

I've done some testing with building for other targets and nothing seems to be broken by this patch. I couldn't figure out how to include the BMP in the patch so i attach it separately.

Hi all,

Currently for all models, the Morse Code input method can only type lowercased letters. Here I provide a patch which enables people to switch between lower cased and upper cased letters, I implemented this for Fuze and Fuze v2, and further fixes will be provided soon (or someone else want to add some key mapping options into your keymaps?)

The patch (also attached):

Index: apps/action.h

   ACTION_KBD_DOWN,
   ACTION_KBD_MORSE_INPUT,
   ACTION_KBD_MORSE_SELECT,

   /* the following are helper actions for touchscreen targets,

   "abcdefghijklmnopqrstuvwxyz1234567890,.?-@ ";

                       state.morse_code |= 0x01;
               }
               break;

           case ACTION_KBD_SELECT:

                   /* turn off hangul input */
                   state.hangul = false;

               }

               break;

           int morse_code;

           outline[0] = morse_alphabets[i];

           sc->putsxy(x, y, outline);

           morse_code = morse_codes[i];

   { ACTION_KBD_DONE,         BUTTON_UP,                        BUTTON_NONE },
   { ACTION_KBD_ABORT,        BUTTON_HOME|BUTTON_REPEAT,        BUTTON_NONE },
   { ACTION_KBD_MORSE_SELECT, BUTTON_SELECT|BUTTON_REL,         BUTTON_NONE },

   LAST_ITEM_IN_LIST

This patch adds a couple more lines to Track Info for Play Count and Rating.
Currently these don’t seem to show up anywhere else.

Tested against r26427 with Fuze v2 and USim.

This patch adds a sector-based read/write cache between the storage and fat drivers.
It has a static pool of 64 sector buffers which can be locked by the file handling code to replace the sector buffers in the file and dir structs, and serve as cache as long as they aren’t used. It can also be used to enforce exclusive access to a sector.

If requested using the STORAGE_NEEDS_ALIGN define, all storage accesses will be aligned to cacheline boundaries.

I am trying to use the last method mentioned on the ipodpatcher wiki page to write Rockbox directly into the OSOS image on my iPod Nano2G. Sometimes it works properly, but other times it fails saying that it couldn't read the header from the .ipodx file. I am following the instructions exactly, so that can't be an issue. I have tried hexediting the .ipodx file, and in some cases I can get ipodpatcher to read the header by editing the first four values, but this always causes a Checksum Error. Here is the exact output:

C:\Users\Michael Marley\Downloads>ipodpatcher.exe -wf rockbox.ipodx
ipodpatcher 5.0 with v4.0 bootloaders (v1.0 for 2nd Gen Nano)
(C) Dave Chapman 2006-2009
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[INFO] Scanning disk devices… [INFO] Read XML info (4 bytes)
[INFO] Ipod found - 2nd Generation Nano ("winpod") - disk device 1
[INFO] Reading partition table from \\.\PhysicalDrive1
[INFO] Sector size is 2048 bytes
[INFO] Part Start Sector End Sector Size (MB) Type
[INFO] 0 63 48194 94.0 Empty (0x00)
[INFO] 1 48195 1982462 3777.9 W95 FAT32 (0x0b)
[INFO] Read XML info (4 bytes)
[INFO] Ipod model: 2nd Generation Nano ("winpod")
[ERR] Failed to read header from rockbox.ipodx
[ERR] –write-firmware failed.

This patch contains several improvements to the Chopper game designed to make it run with a high framerate instead of a low, jerky one. Previously, the game depended on sleeping for a number cycles before drawing another frame, causing very jerky motion. Now the game should run at a high framerate all the time. The gameplay should be about the same, at least on targets with a display of >64px. I don’t have any of these smaller targets, so I wasn’t able to test. Please tell me what you think of my changes.

at least in the 16bit lcd drivers, all functions which use transparency (or clear pixels) get the pixel colour from the backdrop image, completly ignoring the bg_pattern.

This isnt a problem except in skins where it is perfectly reasonable to want a background image for most of the screen but a solid colour for one or two viewports.

There is a tiny problem though, bg_pattern is set to LCD_DEFAULT_BG which is a valid colour, so we probably need to add a flag to the viewport struct to say if it should ignore the background image or not.

This patch adds a frequency response graph below the equalizer's controls, making it an EQ that is actually "graphical".

I'm still not sure about the accuracy of the represented curve, in particular the Q factor on the peaking filters seems to have an effect opposite to the expected, though the equations are taken from the same "audio EQ cookbook" the equalizer is based on, any help is appreciated!

The user interface is still incomplete, I want to add proper tags on the axes and bars. I also thought about re-enabling the theme on this screen (why is it disabled?) and change the behavior of the "right" button, making it consistent with other menus.

Tested on a Sansa e200.