Rockbox

In the "Scroll bar width" screen, the value used to show the width selected is the previous one, not the current one. The first value change has no effect.
Anyway it seems that the right value is stored: if you select a value and exit by the screen, when you re-enter in it, the width is correct.

Priority low.

Referred to r22406.

This patch makes the graphic EQ usable in the absolute mode on touchscreen models.
Additionally I made the following changes:

* Add a menu in the touchscreen settings to select the touchscreen mode in the graphic EQ ( because in menus I prefer the grid mode, in the EQ the absolute mode is much better)

* Always try to use the UI_FONT , make the EQ filling the whole screen and add a little margin on the left and right side. In that way it can even used with fingers on a touchscreen (automatic adaption to fill the whole screen should work for all targets with EQ and LCD).

I tested on my Cowon D2 and Iriver H340 to make sure non touchscreen models stil work, both worked perfect.

Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Changed controls: moving selection to the left/right by minus/plus buttons, moving selection to the down/up by holdminus/holdplus buttons, choice symbol by the menu button, backspace - long holdmenu button (at release moment), moving cursor left/right by holdminus/holdplus buttons (at release moment), confirm by holding plus button (at release moment), abort by power switch.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can’t post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added movement left/right through the date/time fields by the holdminus/holdplus buttons.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can’t post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added seeking by holdplus/holdminus buttons, pause/play by holdmenu button, hiding the OSD panel by briefly pressing power switch.

This has been (slightly) discussed before, but this is a new take on the matter, not a repeat of  FS#10683 .

With this patch applied, the following functionality is recognised with the hold switch in place:

On any list/menu screen or the while playing screen;
pressing MINUS decreases volume by one,
pressing PLUS increases volume by one,
pressing MENU switches between Play and Pause,
holding MINUS skips back a track,
holding PLUS skips forward a track,
holding MENU advances to the next folder.

I feel that anybody using a Cowon D2 will find this functionality essential, not only because it is present in the original firmware, but because it is necessary for in-pocket operation.
With a small DAP like this, with tactile buttons as well as a touch screen, it makes sense to maximize convenience.

I have added as much functionality as I could without requiring pressing multiple buttons at once. I have made several similar patches and built them for members on the iAudiophile forums, and this configuration has consistently been the most popular.

I welcome any comments/suggestions.
-Andrew

This patch is for the Sansa Fuze but easily modified for other players with scroll wheels.
apps/keymaps/keymap-[your player].c needs to be modified

This patch changes the keyboard input method for scroll wheel players to this:

Scrolling the wheel forward selects the column of the desired character moving right.
Reversing the wheel moves the keyboard cursor down (not left) to select the character.
Reversing again inserts the letter and resets the row and column to the top left.
Repeat…(right, down, right, down…)

The benefit is not leaving the scroll wheel or stopping to click anything.

The center select button is now always mapped to delete.
Left and right always move the edit position.
To make overshoot more forgiving reverse scrolling past the bottom of the keyboard moves the cursor to the top of the previous column.

The posted patch includes keymap changes for the Sansa Fuze. These are the changes required for a different target:
- { ACTION_KBD_UP, BUTTON_SCROLL_BACK, BUTTON_NONE },
- { ACTION_KBD_UP, BUTTON_SCROLL_BACK|BUTTON_REPEAT, BUTTON_NONE },
- { ACTION_KBD_DOWN, BUTTON_SCROLL_FWD, BUTTON_NONE },
- { ACTION_KBD_DOWN, BUTTON_SCROLL_FWD|BUTTON_REPEAT, BUTTON_NONE },
+ { ACTION_KBD_SCROLL_BACK, BUTTON_SCROLL_BACK, BUTTON_NONE },
+ { ACTION_KBD_SCROLL_BACK, BUTTON_SCROLL_BACK|BUTTON_REPEAT, BUTTON_NONE },
+ { ACTION_KBD_SCROLL_FWD, BUTTON_SCROLL_FWD, BUTTON_NONE },
+ { ACTION_KBD_SCROLL_FWD, BUTTON_SCROLL_FWD|BUTTON_REPEAT, BUTTON_NONE },

This patch will remove Morse code but preserves the unicode capability (not tested)

The attached patch adds an indication of the current touchscreen mode to the "classic_statusbar" skin. This is useful since some screens automatically change mode, and there's currently no indication the user when this happens. The patch does the following:

- Adds a new WPS tag (%Tm) to return the current touch mode (Absolute|Grid)
- Updates classic_statusbar.sbs to conditionally show the correct icon

The reason I've made this a Flyspray task rather than just committing it is because the additions to classic_statusbar.sbs will also apply to non-touchscreen targets (though nothing will appear on screen). While the impact on these targets is minimal, I'm not sure about committing it since it will at least cause the new touchmode.bmp to be loaded unneccesarily.

Also, feel free to design some better icons!

I have started an discussion about the virtual keyboard in the mailing list.

In my opinion the text_editor’s control should be similar to the calculator:
- use the whole screen (no tiny font)
- support for touchscreen (raster map)
- separate characters into categories

I adjust the calculator plugin to show my concept.

during my research on FS#10883 i found out that it would be better do disable slide actions on ipods for yes no decisons. slides are too easy done and often cause an unwanted abort.

this patch solves this issue by only accepting pressed keys for abort actions. the solution for FS#10883 has been appended on the bug report seperately.

This patch which is a small change in bidi.c contributes with the diacritics patch (http://www.rockbox.org/tracker/task/10720) to fix the diacritized Arabic text joining problem

sansa fuze v1 scroller doesn’t obey ‘first button press enables backlight only’

rockbox 3.5.1

This patch implement alternative hold mode, mentioned in FS#10698.
To enter this mode you must:
1) switch hold button to on position(this results in normal hold mode).
2) press menu button.
3) switch hold button to off position
4) release menu button
To leave alternative model:
1) switch hold button to off position
2) press menu button
3)switch hold button to on position
4)release menu button(now you in normal hold mode)

Additionally I implement simple keymap which working only in wps contex:
if hold button off:

 Plus button increase volume

On Gogear sa9200, when hold is switched to off(means in the middle), the play stops.
Maybe because the hold and the on/off share the same swtich.

A mixed RTL with LTR text appears in a missed order not conforming to bidi logical to visual algorithm of unicdoe.

Implementation is ready in bidi_l2v() , but the “orientation” parameter is hardcoded and passed as “1” always

A suggested solution is either pass “orientation” as 0 for any RTL text, or tie the orientation parameter with the “alignment” option of the text viewer.

- write a word like “مسمار” in a text file, or just use the word as the file name

- the last character “ر” will appear as the first one like this: “رمسما”

- this bug appeared only since r26019

- when reverting to r26018 the bug won’t show up

- for some combination of letters like “دليل” the issue happens for the last 2 characters

- for some other words the problem doesn’t happen at all

- the only common case is that this happens only with last word in a line appearing on the viewport

This patch wil allow the use of the power key to respond yes in the yes&no screen, cause if in absolute touch screen mode would be impossible to respond yes.
It also will enable the hotkey option.
Italian and english translation for the yes&no.

This patch adds an additional menu option to the list of WPS hotkey choices, “Announce Information”. This voices basic information about the player, currently playing file and current tracklist.

This feature reads a simple definition with a single line of no more than 20 characters from the file “announce.cfg” in the .rockbox directory.

This definition consists of a string of single character tokens, each of which announces a particular canned piece of information.

The tokens are:

A - current time
B - elapsed time and total length of the current track
C - current track number and total tracks in playlist
D - battery level as a percentage
E - battery remaining in hours and minutes
F - sleep timer remaining in minutes

If more than one token is specified, more than one piece of information is announced, so:

AB

would announce the time followed by elapsed time and track length

Multiple announcements may be bound to the hotkey by separating one or more groups of tokens with a “:”

A:DF

In this example, the first time the hotkey is pressed, the time is announced. If it is pressed again within 10 seconds, the battery level and sleep timer are announced and so on.

A space between tokens adds a short pause to the announcement.

If no announce.cfg file is present, the time is announced by default.

This bug already stands for a while and was reported in IRC but since nothing happened so far, I’m going to report it here.

On targets with early USB (”usual” looking USB screen when plugging from off-state and probably only hardware bridge USB) the statusbar that should be there in the screen is missing and when you disconnect the player so that the “rest” of Rockbox would start, it crashes.

The address where the crash happens with the build currently flashed to my Ondio is in “lib/libskin_parser.a(skin_parser.o)” - more exactly “9035954: 8b fb bf 903594e <_skin_parse+0×152>”. I pastebinned the complete disassembly of the _skin_parse function here: http://pastebin.com/LZMNW96a .

I will also try to find the exact revision that introduced the bug but that’ll take a while. If I remember correctly it came with some statusbar skinning commit which is already a while ago now and crept up twice in a row (first was fixed, then it came back). Plus it is not the easiest and no quick task testing flashed builds on the Ondio….

Overview:

This adds the hotkey [short home], and allows you to stop/start play more or less anywhere [long home] which I find quite useful. Hopefully, it’s a little more consistent too, though it still needs a bit of polish.

Problems:

I’d quite like [short power] to stop play in the menus by calling ACTION_TREE_STOP, but unfortunately that only works for local files, not for the radio, which feels inconsistent. I’ve put in a feature request; http://forums.rockbox.org/index.php?topic=25657.0

The recording screen isn’t very consistent with the rest of the keymap - you can press [left] or [home] to get back to the menu, and [short power] and [right] both open the recording menu. This seems to be a peculiarity of the way the recording screen is designed, though I’ll try to improve it.

There is a ‘glitch’ in that when you press [long home] deep in the menus, it’ll sometimes jump through another menu before dropping back to the WPS / Radio screen.

Some users prefer to have a free button with which to turn the backlight back on - they are seemingly used to using [short down], which is bound to playlist here. However, if they don’t set the WPS hotkey, they’ll still have a ‘functionless’ button, so no functionality is lost.

I haven’t touched the HID part at all, because I have no clue what it does…

Details of major changes:
WPS:
[Long up] Pitch screen
[Short down] Playlist screen
[Long down] Quick screen
[Short home] Hotkey
[Long home] Stop

Pitch screen:
[Short select] Cycle mode
[Long select] Reset

Recording screen: (troublesome)
[Short select] Start / pause
[Short left] / [Short home] New file / exit
[Short right] / [Short power] Recording menu
[Volume] Adjust settings

Radio screen:
[Short select] Scan / search
[Long select] Presets
[Short down] Radio menu

Built against r2799. All comments and suggestions welcome, and thanks for reading.

This attempts to implement the idea in http://forums.rockbox.org/index.php?topic=25169.0 this only works for the Settings menu in the main menu.

With this patch, if you reenter the Settings menu, it shows the menu shown when you leave the menu just like when you return to the browser or the database.

This patch adds a frequency response graph below the equalizer's controls, making it an EQ that is actually "graphical".

I'm still not sure about the accuracy of the represented curve, in particular the Q factor on the peaking filters seems to have an effect opposite to the expected, though the equations are taken from the same "audio EQ cookbook" the equalizer is based on, any help is appreciated!

The user interface is still incomplete, I want to add proper tags on the axes and bars. I also thought about re-enabling the theme on this screen (why is it disabled?) and change the behavior of the "right" button, making it consistent with other menus.

Tested on a Sansa e200.

3.7.1, r29372, tested on Sansa e270

The idea is that when connected via USB, devices with button/wheel lights will indicate disk activity using the light, similar to a USB flash drive.

This works, sort of.
One real problem has been encountered:
The calls to buttonlight_on() and _off() seem to override the backlight_timeout_plugged setting, preventing the backlight from shutting off when this is enabled.

I suspect this bug has appeared since r29333, r29341, r29342 but I'm not 100% sure, it worked fine a few days back.

When I delete a file it goes well, but after I delete a file after first switching to another application or to the Android main screen deleting a file locks the main screen, it also locks up for other Android native screens like the keyboard you get when you create a directory.

I use Android 2.1 on a Cowon D3 device.

I didn't like that the "Backlight on first keypress" function ignores the first keypress no matter which key was pressed. For example, I want the volume keys to work normally even when the backlight is off (that is, they should turn on the backlight *and* change the volume).

This patch restricts "Backlight on first keypress" to certain buttons only. in other words, these buttons work normally only when the backlight is on; otherwise, they just turn on the backlight. As a proof of concept, it changes the Clip and Clip+ behavior to filter out only the Home key when the backlight is off, allowing the other keys to function normally.

It works by allowing button-target.h to define the buttons that are filtered by the "Backlight on first keypress" function. If left undefined, the function filters all buttons when the backlight is off, as in the status quo.

[EDIT: Clarified that there is no overlap with  FS#9305  - Context sensitive backlight on key press]

Split out from  FS#11748 .

This patch adds an option to prevent rewinding to the beginning of a track to avoid losing the current playback and resume position by accidentally pressing the Left key. Instead, Left always directly skips back to the previous track. This behavior can be enabled for all tracks or only for those tracks that can be autoresumed on automatic track change (which already is separately configurable).

I'm dropping this patch here for now because I see little chance right now of this being accepted into the trunk. Some developers have complained about the considerable configuration complexity of autoresume as it is, and although this additional behavior can be convenient, there is no ultimate need for it because the resume position prior to the rewind to 0:00 is preserved as long as another skip occurs within the first 15 seconds of the rewound track's playback (for example, by pressing Left again to skip to the previous track).

This change was originally contributed by Dave Slusher in  FS#11748 . I just added the configuration logic.

Patch relative to r29484.

Hello,

empty menu items crash rockbox due to NULL pointer access.
Easily reproducable with the "LCD settings" in RaaA / SDL app build.

The resulting valgrind trace looks like this:
==22619== Invalid read of size 4
==22619== at 0x407FDA: do_menu (menu.c:555)
==22619== by 0x41B198: miscscrn (root_menu.c:323)
==22619== by 0x41B377: load_screen (root_menu.c:520)
==22619== by 0x41B72A: root_menu (root_menu.c:688)
==22619== by 0x406DFA: main (main.c:196)
==22619== Address 0x0 is not stack'd, malloc'd or (recently) free'd

Question:
Should we protect against "menu→submenus" being NULL or
should the menu system hide empty menus without any items at all?

Cheers,
Thomas

On my iPod video, when I choose to load the WPS on startup (either in the Settings menu or in the alarm menu), it doesn't work. The player stays on the main (root?) screen.

I had to tweak root_menu.c (which I join) to get the alarm to work with the WPS. This is not a patch, but a quick and dirty workaround that I did just to be waked up on time tomorrow…

On the default FM radio screen only the pre-set name line appears to scroll if wider than the screen. Other lines don't. This occurs on all releases tested up to current r29824-110504.

To reproduce, set to a large font and go to the FM Radio (I use 32 Terminus Bold - I want to read the screen when not wearing glasses, but it still occurs to a degree with fonts smaller than this).

Example display:
Station: 101.3 ("MHz" not visible - no scrolling)
Stereo
Mode: Scan
Signal Strength (": nn dBμV" not visible - no scrolling)

Attached is a patch that:

* adds an option to chose the date format in the system menu (choice between YMD, DMY and MDY)
* adds a %cF theme tag so that theme can know in which order to display the date

There are a few new strings that I only added in English.

This is my very first rockbox patch so please let me know if anything should be improved.

I did the patch against svn 29827 and tested it in a simulated Fuze v2 as well as a real one.

After upgrading my 1st generation iPod Nano from Rockbox 3.6 to 3.9 the cover art display does not seem to be working consistently.

When using a playlist the first track will always show the correct cover art, but any tracks after that will continue to show the first track's cover. This also happens if I skip forward or backward between tracks in the playlist.

If I manually select a file to play the correct cover will show, and if I manually select another track during the play-back of the first the cover art will change to the new track.

I have also tried this with current build r30334 (2011-08-20T13:14:30) with the same results.

The key lock feature on my clip+ can be circumvented. Select the last title in a directory using the file browser. Then activate the software hold. When the song finishes the Player skips to the file browser and the key lock is turned off after a button press. You can navigate around the menus until you return to the playing screen, then the key lock turns on again.

SVN r30720

Hello, all
There's a problem with viewing files in some circumstances in iPod 5.5G last 3.9 release.

When I:
playing something in /Music/Artist/Track.flac,
pause playback,
connect USB cable.
rename /Music/Artist to /Music/ArtistSOMETHING, then disconnect USB cable

I just cannot turn playback on ("~Do not exist" or something message appears, it's OK, I know),
BUT
when I trying to enter in "Files" menu - there's no reaction at all. Just nothing. I can't play of any other existing track or change to any directory without restarting device, or:

just go to Playlists → VIew catalog → select some playlist, then some music appears. But it's too long imho.

Is "it" bug or not?.. :)

Thanks,
sorry for my english,

To reproduce, ensure car adapter mode is enabled, start playback, and leave the now playing screen. If the charger isn't connected, connect it now. Then, disconnect the charger, causing a car adapter mode pause. Some parts of the now playing screen will overwrite the current screen. I see this in file view, main menu and settings. The main menu is quickly redrawn and back to normal, but the file view is only redrawn after I do something. Now, reconnect the charger, which causes a car adapter mode unpause after a short delay. The same thing happens.

I've seen this on:
- 5G iPod using Firewire power, running 3.10RC and r31106
- Archos Recorder V2 using charger, running 3.10RC and r31106

Edit: The same thing happens with headphone plug-in unpause (but not headphone unplug pause). I expect the problem also happens when using BUTTON_MULTIMEDIA_PLAYPAUSE, but I did not test that.

The problem is due to the pause_action() and unpause_action() calls in apps/misc.c. The second parameter is "bool updatewps". It is true in all cases except headphone unplug pause. I don't know why it's false in that particular case.

The second parameter probably shouldn't be there. The WPS should simply update itself if it is currently displayed.

svn-r31216

when deleting a directory with several files in it the splash screen, that is appearing when deleting the individual files, gets printed over the last one without clearing the screen prior to it.

Languages like Thai use combining diacritical marks which display above or below the adjoining character. When text scrolls off the screen, the text jerks back and re-scrolls what seems to be the width of the diacritical mark. It seems that the scrolling algorithm is counting the width of the diacritical mark, where it should be ignored.

Hello!
Not very long ago I got iPod Nano 2 gen 8gb, installed rockbox and encountered this strange behavior:

After pushing and releasing Hold button player doesn't react on wheel. When I'm trying to use some other button(Menu, for example), nothing happens. After third attempt to use a button Rockbox does button context properly, showing me what I wanted to see a few clicks ago. What happens with interface after using Hold? When I return to 'Now playing' screen throughout Menu, all works fine. But right after using Hold button I can't nor increase/decrease volume, neither move in a menu list.

There are some problems with the quickscreen on the Sansa Fuze. I traced it back to r31246, a text alignment bugfix:

- Quickscreen items flicker a lot and sometimes vanish for half a second on each change of an option.

- Setting the right option (Repeat) to "Shuffle" and then back to something else causes "Shuffle" to stick on screen. Leaving the quickscreen and returning to it reveals the correct setting.

This only happens for longer scrolling strings of text, e.g. "Shuffle" is "Zufallswiedergabe" in German.

When turning on my Sansa with Rockbox 3.10, the display sometimes goes all white and stays that way until the screensaver kicks in. The player works fine during that time and can be controlled blindly. After the screen turns off and I turn it on again, the screen works as expected. This does not happen all the time, but very often.

I know keymap changes can be a difficult topic, this one however is just a small change - which, I hope, improves usability of Clip players quite a bit.

I just swapped the behavior of two functions when browsing lists: short press on the power button returns to WPS, and pressing menu + center stops playback while in lists. Return to WPS is arguably the much more often used functionality of the two, and this change makes it easier to do that.

The %pb tag has a small problem. If an image is specified but no height, the tag draws the size of a line even if larger than the the image. This leads to pixel garbage below the progressbar.

The test.wps reproduces the problem in the 320x480 sdl app The default font, 27-adobe, has to be selected probably. The wps works if a height, i.e. 20 in this case as the image height, is specified

Test.png shows the problem. test.zip is the small test theme.

Using the %pL Tag (in WPS) in order to simply display it or use it in a conditional tag (like in the “analog” theme yields very high values (let call it spikes) - where they should not be, while the bar-type peak meter is working fine.

Within the simulator, everithing is running smooth, as far as I could see.

I tried to have a look at the sources but that’s too much at the moment.

Does somebody have a clue ?

Regards

  Ralf

When you configure Shortcuts to replace the Quick Screen then there is this unwanted behaviour:
Exiting the Shortcuts menu always returns to the Main Menu, not to the screen from which the Shortcuts menu was invoked by pressing the Quick Screen key combination.

Tested on: Sansa Clip+
Builds tested: latest daily - b7bc240-120409

			latest current -	2406005-120410

In Rockbox for Android it is not possible to highlight an entry in a list without selecting (entering) it.

For example, if I am in the playlist viewer showing the list of just playing songs with my ipod (running rockbox) I was able to scroll through the list which moved the higligting bar through the list and then I could select the desired entry by pressing enter. With the touchscreen I found no way only to highlight a certain entry.

This is important if all entries are very long and have the same starting text. For example "Ludwig von Beethoven, Symphony No. 9 - 1. Adagio" cannot be distinguished from "Ludwig von Beethoven, Symphony No. 9 - 2. Andante" in the playlist viewer since the distinguishing part is cut off. With my ipod I could highlight the entries with the scroll wheel and the highlighted line started horizontally scrolling so I could see the complete text. With the Android port I can only touch the line, but touching the line does not only highlight it but also selects it and so starts playing.

This problem also exists in other list with long entries and happens with all version I compiled until now (latest was a12b2a5).

The settings submenu with the playlist viewer settings like “show icons”, “show indices” and “track display” to select between file name only and full path for playlist entries is not available in the playlist viewer menu in the Android version.

So these settings cannot be changed.

This happens in all version I tried until now (latest was a12b2a5).

While I am playing some song on my iPod classic 2G, and scrolling through a list (even the main menu, but the glitch there is somehow different), if I unplug and then replug the headphones, some of the WPS UI gets drawn over the current view. I'm attaching a screenshot to make it more clear. It only happens while playing a song.
I'm using build bf6abf7 (most recent at the moment).
Also attaching my config.

I'm running Rockbox 3.11.2 on a Sansa Clip+.
I followed these steps:
- go to the Main Menu
- Files
- long press on <microSD1>
- Playlist Catalogue
- Add to New Playlist
I tried to save the playlist with a long press of the select button (not sure of the button's actual name; it is the button in the middle of the 4-way controller and the one that is usually used to select the highlighted option). I was returned to the Files menu. The playlist did not get saved, and there was no error explaining why.

As a result, I spent a long time assuming that long press of select was a "cancel" action, and tried short and long presses of every other button trying to save the playlist.

Workaround: instead of accepting the suggested filename, remove the "<" and ">" characters from the auto-entered filename ("/Playlists/<microSD1>.m3u8") to be able to save the playlist.

Suggested fixes: The filename suggested by Rockbox should not include "<", ">", or other un-saveable characters. In addition, if the user tries to save a file with invalid characters, a warning or error message should be posted (like the "Cancelled" message that briefly pops up when the power button is pressed to exit from the set-filename screen).

As the title suggests, fun things like: https://plus.google.com/102855057878446061693/posts/FkQ4wQZb8VD can happen in this instance.

Initially reported here: http://www.rockbox.org/irc/log-20130113#07:14:49

[Saint]