Rockbox

This attempts to implement the idea in http://forums.rockbox.org/index.php?topic=25169.0 this only works for the Settings menu in the main menu.

With this patch, if you reenter the Settings menu, it shows the menu shown when you leave the menu just like when you return to the browser or the database.

Hello,

empty menu items crash rockbox due to NULL pointer access.
Easily reproducable with the "LCD settings" in RaaA / SDL app build.

The resulting valgrind trace looks like this:
==22619== Invalid read of size 4
==22619== at 0x407FDA: do_menu (menu.c:555)
==22619== by 0x41B198: miscscrn (root_menu.c:323)
==22619== by 0x41B377: load_screen (root_menu.c:520)
==22619== by 0x41B72A: root_menu (root_menu.c:688)
==22619== by 0x406DFA: main (main.c:196)
==22619== Address 0x0 is not stack'd, malloc'd or (recently) free'd

Question:
Should we protect against "menu→submenus" being NULL or
should the menu system hide empty menus without any items at all?

Cheers,
Thomas

This adds asplash and asplashf (and vasplashf for internal use) which normal splashes but can be aborted with button presses.

Additionally, they return the action received (for CONTEXT_STD) so that the caller may handle aborts differently depending on the button.

Also I converted a few annoying splashes to use it (when loading themes, wps, fonts etc and the resume failed splash)

The %pb tag has a small problem. If an image is specified but no height, the tag draws the size of a line even if larger than the the image. This leads to pixel garbage below the progressbar.

The test.wps reproduces the problem in the 320x480 sdl app The default font, 27-adobe, has to be selected probably. The wps works if a height, i.e. 20 in this case as the image height, is specified

Test.png shows the problem. test.zip is the small test theme.

I would like to leave my player charging overnight and have it resume playback in the morning to wake me.

My player remains on when charging and cannot be turned off.

The alarm does not resume playing if the player is already on when the alarm time passes.

I suspect this probably applies to all players, mine is a Sandisk Sansa Clip+.

Rockbox info says v. 3.13 - the stable build grabbed by RockboxUtility, which this bugtracker doesn’t seem to know about yet.

When you configure Shortcuts to replace the Quick Screen then there is this unwanted behaviour:
Exiting the Shortcuts menu always returns to the Main Menu, not to the screen from which the Shortcuts menu was invoked by pressing the Quick Screen key combination.

Tested on: Sansa Clip+
Builds tested: latest daily - b7bc240-120409

			latest current -	2406005-120410

While I am playing some song on my iPod classic 2G, and scrolling through a list (even the main menu, but the glitch there is somehow different), if I unplug and then replug the headphones, some of the WPS UI gets drawn over the current view. I'm attaching a screenshot to make it more clear. It only happens while playing a song.
I'm using build bf6abf7 (most recent at the moment).
Also attaching my config.

The key lock feature on my clip+ can be circumvented. Select the last title in a directory using the file browser. Then activate the software hold. When the song finishes the Player skips to the file browser and the key lock is turned off after a button press. You can navigate around the menus until you return to the playing screen, then the key lock turns on again.

SVN r30720

svn-r31216

when deleting a directory with several files in it the splash screen, that is appearing when deleting the individual files, gets printed over the last one without clearing the screen prior to it.

Whenever screendump is enabled,It gets a panic error.
Error Message:
*PANIC*
Stkov usb
pc:080739ac sp:080f5458

Update to my tools/talkclips.py script. Minor updates which include:
- Better handling of logfile eg. we don't leave it open as was the case
before
- Report a few more details in the log eg. start/end time, duration, and
number of talk clips created. This is useful to dettect how many files
had problems…
- Summarise output for user at end, of processing, number of talkclips
created and how long this took (in seconds).
- Report to user how many talk clips will need to be created to give
them an indication of potential waiting time etc. This is calculated by
first determining how many files are on the device excluding .talk files, and how many .talk
files there are, and calculating the difference.
- This information allows a percentage indication to be drawn throughout
the script, so now the user can track the percentage as processing takes
place.

Patch is attached.

Thanks.

The aim of this patch is to make releases as simple as possible... i.e the end goal would be to have someone run “$ ~/rockbox/tools/release/release.sh 3.3” and that would do everything except feed the cat...

the first version just modifies bins.pl to accept a version number which eventually gets passed to the Makefile and used in the source to set the version string in the source to “3.x-rBLAAA”.

This also defines RBRELEASE which can be used in the source to do stuff, for example, remove the debug menu in releases (if we decide to do that...) (RELEASE is defined in speex so had to add the RB prefix...)

Also, this changes the way configure is run to use command line args instead of passing input to it which is Just Wrong (TM) :p

Emuriver is an emulator (not simulator) for iriver ifp-7xx series. It’s part of the http://www.rockbox.org/wiki/IriverIfpPort and has until now been hosted at the main author’s (Tomek’s) site http://www.mimuw.edu.pl/~tmal/rockbox/ It includes a tool to create flash images for use with the emulator, and a tool to mount such images and do basic file management on them.

This version is almost identical to the last version from Tomek’s site, but I had to fix a few bugs to make it usable on my system. Changes are as follows:

flashimgtool.c: Outputs usage information on errors. (I didn’t do this; I don’t know where this code came from but it’s useful.)

hardware.c: Bug: Arguments were missing in a function call which would sometimes cause segmentation faults, and (I don’t know why or how) slow down the emulator.

main.c: Changed a default file name from prog_flash.bin to prog_flash.img (I didn’t do this)

main.c: Bug: Added explicit return value to nonvoid function. The implicit return value was sometimes -1 which indicated an error so emuriver aborted.

make_flash_img.c: Optimizations: “if” replaced with “else if”. (I didn’t do this)

uicurses.c: Rename a variable into someting more unique. (I didn’t do this)

The reason I’m submitting this patch is that I think the emulator could be useful as it is for those trying to build the ifp port from SVN, that it could (maybe) be worked on to support other players, and that my bugfixes should be included for those building emuriver.

There are a few issues: The flashimgtool subdir in emuriver duplicates a few (three years old) files from RB, disk.c, fat.c, and some more. You might not like the directory structure. It uses an ancient version of autotools. I haven’t been able to create flash images that actually work with flashimgtool. I haven’t built the RB port for ifp yet, so I don’t know if it will run in emuriver or not.

Yes I have discussed the patch in IRC.

Neither of the tools, ipodpatcher or Rockbox Utility 1.4.0, work on macOS Catalina.

Catalina removed 32bit support.

Using ipodpatcher generates the following error:

bash-3.2$ ./ipodpatcher
bash: ./ipodpatcher: Bad CPU type in executable

And Rockbox Utility has a white circle with a line through it indicating that it does not work with this version of the OS.

(see attached file)

The following set of WPS tags demonstrates:

# WPS Document
%wd
%V(0,0,-,10,2)%Vb(000000)%Vf(FFF000)
%aL%cH:%cM %ac%pv %aR%bt
%V(0,11,-,30,2)%Vb(000000)%Vf(FFF000)
%it

If you alternately insert and remove a space between the second occurence of %Vb/%Vf, the track title text appears and disappears. It appears to happen in a few other variations, but this is the shortest concrete example.

The attached patch fixes a minor compiler warning on 64 bit platforms.

Create database application.

1) At first FS9349 patch file (http://www.rockbox.org/tracker/task/9349?getfile=17401) apply.

2) After this task’s patch apply.

This patch adds SubRip subtitle support to MPEG Player.
http://wiki.multimedia.cx/index.php?title=SubRip

Files need to have the same name as the video file with a “.srt” extension.

I know that the OSD rendering is not implement in a way that linuxstb and jhMikeS would like but I still wanted to post the patch here in case anyone felt like adapting it. (Current OSD only renders on top of the video area, it can be adapted to add other OSD channels … like display a seek bar, volume control, playback state, etc.)

Enjoy,

Edit: I’ve also added a timebar display (when changing the volume)

Right now if the voice file fails to load, there’s a splash message but blind users won’t be able to see it.

(usually this happens because they upgraded rockbox without upgrading the voice file too)

It would be useful if we could embed a failsafe voice file, containing only that one prompt, so the user will know what is going on.

Just English for now, though ideally one for every language we support.

(Oh, and a pony too. Please?)