Rockbox

Split out from  FS#11748 .

This patch adds an option to prevent rewinding to the beginning of a track to avoid losing the current playback and resume position by accidentally pressing the Left key. Instead, Left always directly skips back to the previous track. This behavior can be enabled for all tracks or only for those tracks that can be autoresumed on automatic track change (which already is separately configurable).

I'm dropping this patch here for now because I see little chance right now of this being accepted into the trunk. Some developers have complained about the considerable configuration complexity of autoresume as it is, and although this additional behavior can be convenient, there is no ultimate need for it because the resume position prior to the rewind to 0:00 is preserved as long as another skip occurs within the first 15 seconds of the rewound track's playback (for example, by pressing Left again to skip to the previous track).

This change was originally contributed by Dave Slusher in  FS#11748 . I just added the configuration logic.

Patch relative to r29484.

The key lock feature on my clip+ can be circumvented. Select the last title in a directory using the file browser. Then activate the software hold. When the song finishes the Player skips to the file browser and the key lock is turned off after a button press. You can navigate around the menus until you return to the playing screen, then the key lock turns on again.

SVN r30720

To reproduce, ensure car adapter mode is enabled, start playback, and leave the now playing screen. If the charger isn't connected, connect it now. Then, disconnect the charger, causing a car adapter mode pause. Some parts of the now playing screen will overwrite the current screen. I see this in file view, main menu and settings. The main menu is quickly redrawn and back to normal, but the file view is only redrawn after I do something. Now, reconnect the charger, which causes a car adapter mode unpause after a short delay. The same thing happens.

I've seen this on:
- 5G iPod using Firewire power, running 3.10RC and r31106
- Archos Recorder V2 using charger, running 3.10RC and r31106

Edit: The same thing happens with headphone plug-in unpause (but not headphone unplug pause). I expect the problem also happens when using BUTTON_MULTIMEDIA_PLAYPAUSE, but I did not test that.

The problem is due to the pause_action() and unpause_action() calls in apps/misc.c. The second parameter is "bool updatewps". It is true in all cases except headphone unplug pause. I don't know why it's false in that particular case.

The second parameter probably shouldn't be there. The WPS should simply update itself if it is currently displayed.

svn-r31216

when deleting a directory with several files in it the splash screen, that is appearing when deleting the individual files, gets printed over the last one without clearing the screen prior to it.

Languages like Thai use combining diacritical marks which display above or below the adjoining character. When text scrolls off the screen, the text jerks back and re-scrolls what seems to be the width of the diacritical mark. It seems that the scrolling algorithm is counting the width of the diacritical mark, where it should be ignored.

When turning on my Sansa with Rockbox 3.10, the display sometimes goes all white and stays that way until the screensaver kicks in. The player works fine during that time and can be controlled blindly. After the screen turns off and I turn it on again, the screen works as expected. This does not happen all the time, but very often.

I know keymap changes can be a difficult topic, this one however is just a small change - which, I hope, improves usability of Clip players quite a bit.

I just swapped the behavior of two functions when browsing lists: short press on the power button returns to WPS, and pressing menu + center stops playback while in lists. Return to WPS is arguably the much more often used functionality of the two, and this change makes it easier to do that.

Using the %pL Tag (in WPS) in order to simply display it or use it in a conditional tag (like in the “analog” theme yields very high values (let call it spikes) - where they should not be, while the bar-type peak meter is working fine.

Within the simulator, everithing is running smooth, as far as I could see.

I tried to have a look at the sources but that’s too much at the moment.

Does somebody have a clue ?

Regards

  Ralf

When you configure Shortcuts to replace the Quick Screen then there is this unwanted behaviour:
Exiting the Shortcuts menu always returns to the Main Menu, not to the screen from which the Shortcuts menu was invoked by pressing the Quick Screen key combination.

Tested on: Sansa Clip+
Builds tested: latest daily - b7bc240-120409

			latest current -	2406005-120410

The settings submenu with the playlist viewer settings like “show icons”, “show indices” and “track display” to select between file name only and full path for playlist entries is not available in the playlist viewer menu in the Android version.

So these settings cannot be changed.

This happens in all version I tried until now (latest was a12b2a5).

I would like to leave my player charging overnight and have it resume playback in the morning to wake me.

My player remains on when charging and cannot be turned off.

The alarm does not resume playing if the player is already on when the alarm time passes.

I suspect this probably applies to all players, mine is a Sandisk Sansa Clip+.

Rockbox info says v. 3.13 - the stable build grabbed by RockboxUtility, which this bugtracker doesn’t seem to know about yet.

## This was tried out with Sansa Fuzev2 simulator version d392da8-140922, built from git on a 64 bit Linux system ##

I discovered something which seems to be a bug somewhere in the place where WPS get interpreted or rendered.

When I use a scrolling line just after a line containing sublines, the scrolling line stops scrolling as soon as the sublines change the first time.

Below are steps to reproduce it on the UI simulator for the Sansa Fuzev2. I think it also works without using a clear configuration. I haven’t tested with a real device, only with the simulator.

Attached are a .wps-file showing the buggy behaviour (’scrollline_after_sublines_bug.buggy.wps’), and a .wps-file working correctly (’scrollline_after_sublines_bug.workaround.wps’), which are the same files as quoted below.

STEPS TO REPRODUCE:

(0) Use Sansa Fuzev2 simulator version d392da8-140922, build from git on a 64 bit Linux system.

(1) Use a clear configuration, so erase

    .rockbox/.playlist_control
    .rockbox/config.cfg
    .rockbox/nvram.bin
    .rockbox/database.ignore
  in your 'simdisk' directory.

(2) Start the rockbox UI simulator

(3) Change the theme to ‘rockbox_failsafe’, i.e. in the menu, do the following:

• ‘Settings’ → ‘Theme Settings’ → ‘Browse Theme Files’ → ‘rockbox_failsafe.cfg’
• ‘Settings’ → ‘Theme Settings’ → ‘While Playing Screen’ → ‘rockbox_failsafe.wps’
• ‘Settings’ → ‘Theme Settings’ → ‘Radio Screen’ → ‘rockbox_failsafe.fms’
• ‘Settings’ → ‘Theme Settings’ → ‘Base Skin’ → ‘rockbox_failsafe.sbs’

(4) Use the following .wps-file as the “While Playing Screen” skin:

=⇒ # Two sublines:
Text1;Text2
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
# Another line of just text (Not needed to reproduce the bug, but if it is swapped with the long line above, the long line scrolles correctly):
Textline.
#### Here the following Bug appears:
# When the Line ‘Text1;Text2’ changes the sublines the first time, the subsequent line stops scrolling. It happens when the sublines change; as when you use ‘%t(5)Text1;Text2’, the scrolling stops only after 5 seconds, when the sublines actually change.
⇐=

Workaround:
(4a) Put the scrolling line not directly after a line with sublines. The following .wps as the “While Playing Screen” skin works:

=⇒ # Two sublines:
Text1;Text2
# Another line of just text. Needed to make the long line scrolling correctly:
Textline.
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
#### Here the bug does not appear, the long line scrolls corretly. But when the long scrolling line is put just below the line with the sublines, it stops scrolling as soon as the sublines change for the first time.
⇐=

I use the attached custom WPS that displays the active Replaygain value and type next to the track number.

When playing mpc files created by foobar2000 with the tracknumber/totaltracks tag format, if the track# is 10 or higher and the applied gain negative (as in the attached mpc), mangled characters are displayed between the gain value and type, eg:

10/12 -2.00 dB *gibberish* (Album)

This is reproducible with the latest simulator build d0fffd6-150104 but I only recently noticed the issue and don't know when it began. I have an old sim build 935d8be-121229 and it works correctly there.

Revision a8758c9 and Stable (3.13)

If you use the Hold Switch to Lock Keys and remove it again to unlock, buttons doesn't work.
Move around with finger at touchpad work. After this bottons work without problems.

Short:
Start Rockbox
Move the curser over Settings (Example)
Move Hold switch to Lock
Move Hold switch to Unlock
Press Middle Button (Doesnt work)
Move around on Touchpad
Press Middle Button (work)

Rockbox doesn't speak in the FM mode with voice configured. I tried it in my local language (spanish) and in english with same results. Apparently it is not a problem of the translation, because sometimes (only 2 or 3 times in at about one year that I'm using the player) the player speak some words. This works correctly in release version.
My actual version is 0f89b04, but it happend in all dev versions.

On my X3, it triggers the MIPS equivalent of a segfault. (directory has 792 entries, tried to access it with only 500 allowed)

Rather than crashing outright, I think it would be better to detect this and somehow error out gracefully?

The aim of this patch is to make releases as simple as possible... i.e the end goal would be to have someone run “$ ~/rockbox/tools/release/release.sh 3.3” and that would do everything except feed the cat...

the first version just modifies bins.pl to accept a version number which eventually gets passed to the Makefile and used in the source to set the version string in the source to “3.x-rBLAAA”.

This also defines RBRELEASE which can be used in the source to do stuff, for example, remove the debug menu in releases (if we decide to do that...) (RELEASE is defined in speex so had to add the RB prefix...)

Also, this changes the way configure is run to use command line args instead of passing input to it which is Just Wrong (TM) :p

The attached patch fixes a minor compiler warning on 64 bit platforms.

Right now if the voice file fails to load, there’s a splash message but blind users won’t be able to see it.

(usually this happens because they upgraded rockbox without upgrading the voice file too)

It would be useful if we could embed a failsafe voice file, containing only that one prompt, so the user will know what is going on.

Just English for now, though ideally one for every language we support.

(Oh, and a pony too. Please?)