Rockbox

This patch adds an additional menu option to the list of WPS hotkey choices, “Announce Information”. This voices basic information about the player, currently playing file and current tracklist.

This feature reads a simple definition with a single line of no more than 20 characters from the file “announce.cfg” in the .rockbox directory.

This definition consists of a string of single character tokens, each of which announces a particular canned piece of information.

The tokens are:

A - current time
B - elapsed time and total length of the current track
C - current track number and total tracks in playlist
D - battery level as a percentage
E - battery remaining in hours and minutes
F - sleep timer remaining in minutes

If more than one token is specified, more than one piece of information is announced, so:

AB

would announce the time followed by elapsed time and track length

Multiple announcements may be bound to the hotkey by separating one or more groups of tokens with a “:”

A:DF

In this example, the first time the hotkey is pressed, the time is announced. If it is pressed again within 10 seconds, the battery level and sleep timer are announced and so on.

A space between tokens adds a short pause to the announcement.

If no announce.cfg file is present, the time is announced by default.

This bug already stands for a while and was reported in IRC but since nothing happened so far, I’m going to report it here.

On targets with early USB (”usual” looking USB screen when plugging from off-state and probably only hardware bridge USB) the statusbar that should be there in the screen is missing and when you disconnect the player so that the “rest” of Rockbox would start, it crashes.

The address where the crash happens with the build currently flashed to my Ondio is in “lib/libskin_parser.a(skin_parser.o)” - more exactly “9035954: 8b fb bf 903594e <_skin_parse+0×152>”. I pastebinned the complete disassembly of the _skin_parse function here: http://pastebin.com/LZMNW96a .

I will also try to find the exact revision that introduced the bug but that’ll take a while. If I remember correctly it came with some statusbar skinning commit which is already a while ago now and crept up twice in a row (first was fixed, then it came back). Plus it is not the easiest and no quick task testing flashed builds on the Ondio….

Overview:

This adds the hotkey [short home], and allows you to stop/start play more or less anywhere [long home] which I find quite useful. Hopefully, it’s a little more consistent too, though it still needs a bit of polish.

Problems:

I’d quite like [short power] to stop play in the menus by calling ACTION_TREE_STOP, but unfortunately that only works for local files, not for the radio, which feels inconsistent. I’ve put in a feature request; http://forums.rockbox.org/index.php?topic=25657.0

The recording screen isn’t very consistent with the rest of the keymap - you can press [left] or [home] to get back to the menu, and [short power] and [right] both open the recording menu. This seems to be a peculiarity of the way the recording screen is designed, though I’ll try to improve it.

There is a ‘glitch’ in that when you press [long home] deep in the menus, it’ll sometimes jump through another menu before dropping back to the WPS / Radio screen.

Some users prefer to have a free button with which to turn the backlight back on - they are seemingly used to using [short down], which is bound to playlist here. However, if they don’t set the WPS hotkey, they’ll still have a ‘functionless’ button, so no functionality is lost.

I haven’t touched the HID part at all, because I have no clue what it does…

Details of major changes:
WPS:
[Long up] Pitch screen
[Short down] Playlist screen
[Long down] Quick screen
[Short home] Hotkey
[Long home] Stop

Pitch screen:
[Short select] Cycle mode
[Long select] Reset

Recording screen: (troublesome)
[Short select] Start / pause
[Short left] / [Short home] New file / exit
[Short right] / [Short power] Recording menu
[Volume] Adjust settings

Radio screen:
[Short select] Scan / search
[Long select] Presets
[Short down] Radio menu

Built against r2799. All comments and suggestions welcome, and thanks for reading.

This attempts to implement the idea in http://forums.rockbox.org/index.php?topic=25169.0 this only works for the Settings menu in the main menu.

With this patch, if you reenter the Settings menu, it shows the menu shown when you leave the menu just like when you return to the browser or the database.

This patch adds a frequency response graph below the equalizer's controls, making it an EQ that is actually "graphical".

I'm still not sure about the accuracy of the represented curve, in particular the Q factor on the peaking filters seems to have an effect opposite to the expected, though the equations are taken from the same "audio EQ cookbook" the equalizer is based on, any help is appreciated!

The user interface is still incomplete, I want to add proper tags on the axes and bars. I also thought about re-enabling the theme on this screen (why is it disabled?) and change the behavior of the "right" button, making it consistent with other menus.

Tested on a Sansa e200.

3.7.1, r29372, tested on Sansa e270

The idea is that when connected via USB, devices with button/wheel lights will indicate disk activity using the light, similar to a USB flash drive.

This works, sort of.
One real problem has been encountered:
The calls to buttonlight_on() and _off() seem to override the backlight_timeout_plugged setting, preventing the backlight from shutting off when this is enabled.

I suspect this bug has appeared since r29333, r29341, r29342 but I'm not 100% sure, it worked fine a few days back.

When I delete a file it goes well, but after I delete a file after first switching to another application or to the Android main screen deleting a file locks the main screen, it also locks up for other Android native screens like the keyboard you get when you create a directory.

I use Android 2.1 on a Cowon D3 device.

I didn't like that the "Backlight on first keypress" function ignores the first keypress no matter which key was pressed. For example, I want the volume keys to work normally even when the backlight is off (that is, they should turn on the backlight *and* change the volume).

This patch restricts "Backlight on first keypress" to certain buttons only. in other words, these buttons work normally only when the backlight is on; otherwise, they just turn on the backlight. As a proof of concept, it changes the Clip and Clip+ behavior to filter out only the Home key when the backlight is off, allowing the other keys to function normally.

It works by allowing button-target.h to define the buttons that are filtered by the "Backlight on first keypress" function. If left undefined, the function filters all buttons when the backlight is off, as in the status quo.

[EDIT: Clarified that there is no overlap with  FS#9305  - Context sensitive backlight on key press]

Split out from  FS#11748 .

This patch adds an option to prevent rewinding to the beginning of a track to avoid losing the current playback and resume position by accidentally pressing the Left key. Instead, Left always directly skips back to the previous track. This behavior can be enabled for all tracks or only for those tracks that can be autoresumed on automatic track change (which already is separately configurable).

I'm dropping this patch here for now because I see little chance right now of this being accepted into the trunk. Some developers have complained about the considerable configuration complexity of autoresume as it is, and although this additional behavior can be convenient, there is no ultimate need for it because the resume position prior to the rewind to 0:00 is preserved as long as another skip occurs within the first 15 seconds of the rewound track's playback (for example, by pressing Left again to skip to the previous track).

This change was originally contributed by Dave Slusher in  FS#11748 . I just added the configuration logic.

Patch relative to r29484.

Hello,

empty menu items crash rockbox due to NULL pointer access.
Easily reproducable with the "LCD settings" in RaaA / SDL app build.

The resulting valgrind trace looks like this:
==22619== Invalid read of size 4
==22619== at 0x407FDA: do_menu (menu.c:555)
==22619== by 0x41B198: miscscrn (root_menu.c:323)
==22619== by 0x41B377: load_screen (root_menu.c:520)
==22619== by 0x41B72A: root_menu (root_menu.c:688)
==22619== by 0x406DFA: main (main.c:196)
==22619== Address 0x0 is not stack'd, malloc'd or (recently) free'd

Question:
Should we protect against "menu→submenus" being NULL or
should the menu system hide empty menus without any items at all?

Cheers,
Thomas

On my iPod video, when I choose to load the WPS on startup (either in the Settings menu or in the alarm menu), it doesn't work. The player stays on the main (root?) screen.

I had to tweak root_menu.c (which I join) to get the alarm to work with the WPS. This is not a patch, but a quick and dirty workaround that I did just to be waked up on time tomorrow…

On the default FM radio screen only the pre-set name line appears to scroll if wider than the screen. Other lines don't. This occurs on all releases tested up to current r29824-110504.

To reproduce, set to a large font and go to the FM Radio (I use 32 Terminus Bold - I want to read the screen when not wearing glasses, but it still occurs to a degree with fonts smaller than this).

Example display:
Station: 101.3 ("MHz" not visible - no scrolling)
Stereo
Mode: Scan
Signal Strength (": nn dBμV" not visible - no scrolling)

Attached is a patch that:

* adds an option to chose the date format in the system menu (choice between YMD, DMY and MDY)
* adds a %cF theme tag so that theme can know in which order to display the date

There are a few new strings that I only added in English.

This is my very first rockbox patch so please let me know if anything should be improved.

I did the patch against svn 29827 and tested it in a simulated Fuze v2 as well as a real one.

After upgrading my 1st generation iPod Nano from Rockbox 3.6 to 3.9 the cover art display does not seem to be working consistently.

When using a playlist the first track will always show the correct cover art, but any tracks after that will continue to show the first track's cover. This also happens if I skip forward or backward between tracks in the playlist.

If I manually select a file to play the correct cover will show, and if I manually select another track during the play-back of the first the cover art will change to the new track.

I have also tried this with current build r30334 (2011-08-20T13:14:30) with the same results.

The key lock feature on my clip+ can be circumvented. Select the last title in a directory using the file browser. Then activate the software hold. When the song finishes the Player skips to the file browser and the key lock is turned off after a button press. You can navigate around the menus until you return to the playing screen, then the key lock turns on again.

SVN r30720

Hello, all
There's a problem with viewing files in some circumstances in iPod 5.5G last 3.9 release.

When I:
playing something in /Music/Artist/Track.flac,
pause playback,
connect USB cable.
rename /Music/Artist to /Music/ArtistSOMETHING, then disconnect USB cable

I just cannot turn playback on ("~Do not exist" or something message appears, it's OK, I know),
BUT
when I trying to enter in "Files" menu - there's no reaction at all. Just nothing. I can't play of any other existing track or change to any directory without restarting device, or:

just go to Playlists → VIew catalog → select some playlist, then some music appears. But it's too long imho.

Is "it" bug or not?.. :)

Thanks,
sorry for my english,

To reproduce, ensure car adapter mode is enabled, start playback, and leave the now playing screen. If the charger isn't connected, connect it now. Then, disconnect the charger, causing a car adapter mode pause. Some parts of the now playing screen will overwrite the current screen. I see this in file view, main menu and settings. The main menu is quickly redrawn and back to normal, but the file view is only redrawn after I do something. Now, reconnect the charger, which causes a car adapter mode unpause after a short delay. The same thing happens.

I've seen this on:
- 5G iPod using Firewire power, running 3.10RC and r31106
- Archos Recorder V2 using charger, running 3.10RC and r31106

Edit: The same thing happens with headphone plug-in unpause (but not headphone unplug pause). I expect the problem also happens when using BUTTON_MULTIMEDIA_PLAYPAUSE, but I did not test that.

The problem is due to the pause_action() and unpause_action() calls in apps/misc.c. The second parameter is "bool updatewps". It is true in all cases except headphone unplug pause. I don't know why it's false in that particular case.

The second parameter probably shouldn't be there. The WPS should simply update itself if it is currently displayed.

svn-r31216

when deleting a directory with several files in it the splash screen, that is appearing when deleting the individual files, gets printed over the last one without clearing the screen prior to it.

Languages like Thai use combining diacritical marks which display above or below the adjoining character. When text scrolls off the screen, the text jerks back and re-scrolls what seems to be the width of the diacritical mark. It seems that the scrolling algorithm is counting the width of the diacritical mark, where it should be ignored.

Hello!
Not very long ago I got iPod Nano 2 gen 8gb, installed rockbox and encountered this strange behavior:

After pushing and releasing Hold button player doesn't react on wheel. When I'm trying to use some other button(Menu, for example), nothing happens. After third attempt to use a button Rockbox does button context properly, showing me what I wanted to see a few clicks ago. What happens with interface after using Hold? When I return to 'Now playing' screen throughout Menu, all works fine. But right after using Hold button I can't nor increase/decrease volume, neither move in a menu list.

There are some problems with the quickscreen on the Sansa Fuze. I traced it back to r31246, a text alignment bugfix:

- Quickscreen items flicker a lot and sometimes vanish for half a second on each change of an option.

- Setting the right option (Repeat) to "Shuffle" and then back to something else causes "Shuffle" to stick on screen. Leaving the quickscreen and returning to it reveals the correct setting.

This only happens for longer scrolling strings of text, e.g. "Shuffle" is "Zufallswiedergabe" in German.

When turning on my Sansa with Rockbox 3.10, the display sometimes goes all white and stays that way until the screensaver kicks in. The player works fine during that time and can be controlled blindly. After the screen turns off and I turn it on again, the screen works as expected. This does not happen all the time, but very often.

I know keymap changes can be a difficult topic, this one however is just a small change - which, I hope, improves usability of Clip players quite a bit.

I just swapped the behavior of two functions when browsing lists: short press on the power button returns to WPS, and pressing menu + center stops playback while in lists. Return to WPS is arguably the much more often used functionality of the two, and this change makes it easier to do that.

The %pb tag has a small problem. If an image is specified but no height, the tag draws the size of a line even if larger than the the image. This leads to pixel garbage below the progressbar.

The test.wps reproduces the problem in the 320x480 sdl app The default font, 27-adobe, has to be selected probably. The wps works if a height, i.e. 20 in this case as the image height, is specified

Test.png shows the problem. test.zip is the small test theme.

Using the %pL Tag (in WPS) in order to simply display it or use it in a conditional tag (like in the “analog” theme yields very high values (let call it spikes) - where they should not be, while the bar-type peak meter is working fine.

Within the simulator, everithing is running smooth, as far as I could see.

I tried to have a look at the sources but that’s too much at the moment.

Does somebody have a clue ?

Regards

  Ralf

When you configure Shortcuts to replace the Quick Screen then there is this unwanted behaviour:
Exiting the Shortcuts menu always returns to the Main Menu, not to the screen from which the Shortcuts menu was invoked by pressing the Quick Screen key combination.

Tested on: Sansa Clip+
Builds tested: latest daily - b7bc240-120409

			latest current -	2406005-120410

In Rockbox for Android it is not possible to highlight an entry in a list without selecting (entering) it.

For example, if I am in the playlist viewer showing the list of just playing songs with my ipod (running rockbox) I was able to scroll through the list which moved the higligting bar through the list and then I could select the desired entry by pressing enter. With the touchscreen I found no way only to highlight a certain entry.

This is important if all entries are very long and have the same starting text. For example "Ludwig von Beethoven, Symphony No. 9 - 1. Adagio" cannot be distinguished from "Ludwig von Beethoven, Symphony No. 9 - 2. Andante" in the playlist viewer since the distinguishing part is cut off. With my ipod I could highlight the entries with the scroll wheel and the highlighted line started horizontally scrolling so I could see the complete text. With the Android port I can only touch the line, but touching the line does not only highlight it but also selects it and so starts playing.

This problem also exists in other list with long entries and happens with all version I compiled until now (latest was a12b2a5).

The settings submenu with the playlist viewer settings like “show icons”, “show indices” and “track display” to select between file name only and full path for playlist entries is not available in the playlist viewer menu in the Android version.

So these settings cannot be changed.

This happens in all version I tried until now (latest was a12b2a5).

While I am playing some song on my iPod classic 2G, and scrolling through a list (even the main menu, but the glitch there is somehow different), if I unplug and then replug the headphones, some of the WPS UI gets drawn over the current view. I'm attaching a screenshot to make it more clear. It only happens while playing a song.
I'm using build bf6abf7 (most recent at the moment).
Also attaching my config.

I'm running Rockbox 3.11.2 on a Sansa Clip+.
I followed these steps:
- go to the Main Menu
- Files
- long press on <microSD1>
- Playlist Catalogue
- Add to New Playlist
I tried to save the playlist with a long press of the select button (not sure of the button's actual name; it is the button in the middle of the 4-way controller and the one that is usually used to select the highlighted option). I was returned to the Files menu. The playlist did not get saved, and there was no error explaining why.

As a result, I spent a long time assuming that long press of select was a "cancel" action, and tried short and long presses of every other button trying to save the playlist.

Workaround: instead of accepting the suggested filename, remove the "<" and ">" characters from the auto-entered filename ("/Playlists/<microSD1>.m3u8") to be able to save the playlist.

Suggested fixes: The filename suggested by Rockbox should not include "<", ">", or other un-saveable characters. In addition, if the user tries to save a file with invalid characters, a warning or error message should be posted (like the "Cancelled" message that briefly pops up when the power button is pressed to exit from the set-filename screen).

As the title suggests, fun things like: https://plus.google.com/102855057878446061693/posts/FkQ4wQZb8VD can happen in this instance.

Initially reported here: http://www.rockbox.org/irc/log-20130113#07:14:49

[Saint]

Key lock (activated by pressing Power in the WPS) deactivates when music playback stops (end of playlist). The keypad then becomes active again. It shouldn’t get activated until Power is pressed again.

Hi,
I am using a Sansa Clip Zip with Rockbox 3.13.
I’ve noticed, when I lock or unlock the device, the message, which indicates the current state, does not disappear completely. Its still there.

Cheers,
Conrad

I would like to leave my player charging overnight and have it resume playback in the morning to wake me.

My player remains on when charging and cannot be turned off.

The alarm does not resume playing if the player is already on when the alarm time passes.

I suspect this probably applies to all players, mine is a Sandisk Sansa Clip+.

Rockbox info says v. 3.13 - the stable build grabbed by RockboxUtility, which this bugtracker doesn’t seem to know about yet.

I’m using the latest Dev build for the Fuze+. SanDisk Sansa Fuze+ 5ef1e2d. Same issues experienced in v3.12 stable.

The screen, for lack of a better term, jumps when navigating in upside-down mode.

http://youtu.be/dRfiBtMx2to

## This was tried out with Sansa Fuzev2 simulator version d392da8-140922, built from git on a 64 bit Linux system ##

I discovered something which seems to be a bug somewhere in the place where WPS get interpreted or rendered.

When I use a scrolling line just after a line containing sublines, the scrolling line stops scrolling as soon as the sublines change the first time.

Below are steps to reproduce it on the UI simulator for the Sansa Fuzev2. I think it also works without using a clear configuration. I haven’t tested with a real device, only with the simulator.

Attached are a .wps-file showing the buggy behaviour (’scrollline_after_sublines_bug.buggy.wps’), and a .wps-file working correctly (’scrollline_after_sublines_bug.workaround.wps’), which are the same files as quoted below.

STEPS TO REPRODUCE:

(0) Use Sansa Fuzev2 simulator version d392da8-140922, build from git on a 64 bit Linux system.

(1) Use a clear configuration, so erase

    .rockbox/.playlist_control
    .rockbox/config.cfg
    .rockbox/nvram.bin
    .rockbox/database.ignore
  in your 'simdisk' directory.

(2) Start the rockbox UI simulator

(3) Change the theme to ‘rockbox_failsafe’, i.e. in the menu, do the following:

• ‘Settings’ → ‘Theme Settings’ → ‘Browse Theme Files’ → ‘rockbox_failsafe.cfg’
• ‘Settings’ → ‘Theme Settings’ → ‘While Playing Screen’ → ‘rockbox_failsafe.wps’
• ‘Settings’ → ‘Theme Settings’ → ‘Radio Screen’ → ‘rockbox_failsafe.fms’
• ‘Settings’ → ‘Theme Settings’ → ‘Base Skin’ → ‘rockbox_failsafe.sbs’

(4) Use the following .wps-file as the “While Playing Screen” skin:

=⇒ # Two sublines:
Text1;Text2
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
# Another line of just text (Not needed to reproduce the bug, but if it is swapped with the long line above, the long line scrolles correctly):
Textline.
#### Here the following Bug appears:
# When the Line ‘Text1;Text2’ changes the sublines the first time, the subsequent line stops scrolling. It happens when the sublines change; as when you use ‘%t(5)Text1;Text2’, the scrolling stops only after 5 seconds, when the sublines actually change.
⇐=

Workaround:
(4a) Put the scrolling line not directly after a line with sublines. The following .wps as the “While Playing Screen” skin works:

=⇒ # Two sublines:
Text1;Text2
# Another line of just text. Needed to make the long line scrolling correctly:
Textline.
# A long line, scrolling:
%sA very long text which is meant to scroll because it is longer than the screen is wide.
#### Here the bug does not appear, the long line scrolls corretly. But when the long scrolling line is put just below the line with the sublines, it stops scrolling as soon as the sublines change for the first time.
⇐=

I use the attached custom WPS that displays the active Replaygain value and type next to the track number.

When playing mpc files created by foobar2000 with the tracknumber/totaltracks tag format, if the track# is 10 or higher and the applied gain negative (as in the attached mpc), mangled characters are displayed between the gain value and type, eg:

10/12 -2.00 dB *gibberish* (Album)

This is reproducible with the latest simulator build d0fffd6-150104 but I only recently noticed the issue and don't know when it began. I have an old sim build 935d8be-121229 and it works correctly there.

This patch will add a setting, called "Scroll Bar Border", which will determine whether menus / lists will have scrollbars with borders or not.

The default value for this setting is "yes", so that it matches previous behavior.

Revision a8758c9 and Stable (3.13)

If you use the Hold Switch to Lock Keys and remove it again to unlock, buttons doesn't work.
Move around with finger at touchpad work. After this bottons work without problems.

Short:
Start Rockbox
Move the curser over Settings (Example)
Move Hold switch to Lock
Move Hold switch to Unlock
Press Middle Button (Doesnt work)
Move around on Touchpad
Press Middle Button (work)

On my X3, it triggers the MIPS equivalent of a segfault. (directory has 792 entries, tried to access it with only 500 allowed)

Rather than crashing outright, I think it would be better to detect this and somehow error out gracefully?

With my theme “lebellium Samsung-like” for Clip Zip there are some display issues in FMS, more precisely the status bar, while the code is the same as in WPS and SBS. See the pics in attachment.

How it should look like instead:
http://themes.rockbox.org/themes/96x96/lebellium_samsung-like_%28big_aa%29_96x96_v1.00/3-FM_radio_bigAA.png http://themes.rockbox.org/themes/96x96/lebellium_samsung-like_96x96_v1.45/2-FM_radio3.png

After bisecting, I found out that the 1st bad commit is acf3af4 by JdGordon: radio: fix  FS#12747  http://git.rockbox.org/?p=rockbox.git;a=commit;h=acf3af4

Add an tag to the viewports that allow text/items to be aligned
top/centre/bottom (vertical alignment)

Currently, it is possible to align left/centre/right (horizontal alignment)

The main reason I want to do this is to centre fonts in the middle of a viewport to allow my WPS to allow for multiple fonts - all lined up correctly. I’m sure there can be many other uses

I’d like to suggest the following new WPS feature(s):

1. A viewport can be assigned an image as a “backdrop”.

 a. A viewport may be assigned an image dynamically via the WPS tag "%VX<identifier>"
   (i.e. %VXa for image a, %VXZ for image Z, etc.)
  b. As a viewport is being processed and drawn, its backdrop would be drawn "first", followed by any other normal images/characters.

2. Viewport may define FF00FF as a background color, which would then be “transparent”. This would allow overlapping viewports.

3. Fonts drawn in a viewport with a backdrop would automatically be drawn with DRMODE_FG.

Notes on the attached patch file:
+ It was created from the SVN revision 18997 on Nov 3, 2008.
+ Although I stubbed in the new functions for all the LCD drivers, I’ve only flushed out the 16 bit driver so far.

Cheers!

to reproduce:

1. set playback settings–>fade on stop/pause to on.
2. play some music.
3. press the pause button to stop the music, and again to restart it. repeat that a few times, because this bug does not always occur.

you will notice that both “time-displays” sometimes change very to the previous second and then back to the normal one, e.g 3:32, then very short 3:31, and back to 3:32. the progressbar sometimes get smaller for a fraction of a second, too.

maybe i’ll search for the revision which introduced this in the next few days

(Replacing  FS#10527 )
Peakmeter on ipod video 5g uses too much CPU, such that audible glitches occur during even flac/wav decoding .

This small patch adds a “jump to time” function to wps context menu. After clicking on jump 2 time item user, can specify time in mmmss format E.G:
- 130: jump to 1:30 in currently playing track
- 90: jump to 1:30 in currently playing track (shorter version of previous example)
- 1529: jump to 15:29
- 12345: jump to 123:45 (2 hours, 3 mins, 45 seconds)

I use it to easily transfer “last played position” time from computer to rockbox. Can be useful for audio books listeners.

There should be another option on the list of prioritized options for where to place Album Art images and the filenames. There are currently 7:
http://www.rockbox.org/wiki/AlbumArt

My suggested addition would become the new option 2, pushing all others down.
The first option is currently the only option to allow for song-specific artwork to be displayed, but this requires naming the image files *exactly* like the corresponding sound file, which screws up directory sorting.

Therefore the option should be added that if no image file has an identical name to the sound file playing, it then looks for an image file which matches the current song's Title metadata, similarly to how the following option looks for a match to the Album metadata.

This could cause conflicts when two songs have the same name, or when a song shares the album's name, or the song name contains unusable characters, but such conflicts are rare and minimal, and if anyone cares all that much about such things there is already the built-in flexibility to get around such issues. The additional code required should be minimal (and already blueprinted within the other options), and have essentially zero impact on any other functionality.

I may try to write this patch myself (as i did with "shuffle + track skip"), but if anyone beats me to it, it would be appreciated :)

In my customized rockbox theme, there is a short (half second?) but irritating delay before the progressbar is drawn. This delay is apparent when pressing a button to turn on the backlight, so it doesn’t show up in the simulator. Here is a video of the issue happening: http://www.youtube.com/watch?v=1LAfW8-BjjE

I’ve tried moving the progressbar to the very top of the wps. I also tried changing the wps around to have each icon in a seperate viewport which didn’t help.

I’m using rockbox version 27667.

This patch reimplements FS#11541 using the skin engine.

new skin tag %Vx(params) will talk whatever is in the params (unlimited….)..
Params can be any string or other skin tag (no conditionals just yet).
if the first option is - it will shutup anything currently talking. otherwise - is a voiced pause.
otherwise the only special string is the word “text” which says to spell the next tag (used when the value of the tag is usable in a conditional, i.e %cP need talk or you will get “1” or “2” :/ ).

quick examples:
%?mh<%Vx(-, %cl,-, %cM, text, %cP)> ← Talk the current hour, minute, am/pm when hold is toggled.

%?pE(15)<%?It<%Tx(-, %Ia, -, %It)» ← untested but should spell the next tracks title and artist when there is 15s left of the current track

This patch introduces 2 new activities, one which lists available themes for a specified target and another which lists more details and the option to install the specific theme. Currently this is more a proof-of-concept, as the communication with the theme server is handled by the same API RBUtil uses, which isn't perfect for the intended usage (e.g. offers no possibility to filter by screen size, only uses INI as output format, ..).

(this also includes some minor unrelated changes to the main Rockbox extraction functionality which won't be in the final patch)

TODO:
- make translatable
- better UI
- uninstall/update functionality
- show only themes fit for the displays' resolution
- use different protocol to communicate with theme server to get rid of iniparser dependency (XML, JSON, .. ?)