|
12639 | Bugs | Themes | Very Low | Certain themes cause the WPS to not load properly and U... | 2012-04-08 | Ludovic Jacques | 2013-08-15 | 2 |
Task Description
Both issues seem to appear with any version of my theme and with any build. Let's try it with the latest version 1.30 of my theme (in attachment but also here: http://themes.rockbox.org/index.php?themeid=1585 ) and a recent build (I use version: 0c4bd3a-120406)
-Theme loading
When you load the theme for the 1st time, the WPS will never load properly (failsafe). The workaround is to turn off the device and turn it on again and then the WPS will always load properly until you reload the theme for some reasons (trying another theme and revert back to mine etc). I tried both with the full theme version and this "light" version of WPS: http://pastie.org/3747546
-USB connection (tested on Windows 7, with or without a microSD, and there isn't such an issue with the other themes)
If I plug the USB cable while the player is on or off, it will almost never mount properly. Usually the USB screen appears on my SBS, the computer recognizes a USB device is connected but either nothing appears in "my computer" or the device appears but is not accessible. When I unplug the USB cable, the Zip gets stuck on the USB screen and only reset can turn it off. Sometimes it even displays some erros like that when plugging the USB cable: "data abort at 30FSR 0x8 (domain 0, fault address 0x964176 bt pc: 0x3006AC3 bt end" , sometimes it doesn't display the USB on SBS but gets stuck on the main menu. And rarely in the same conditions it also mounts properly…
Like for WPS, I made a "light" version of SBS without the status bar and that way the Zip seems to mount and unmout properly every time! http://pastie.org/private/cauhxelaip7hrpqpcwdbxw So maybe a tag in the status bar causes the issue with USB connection?
|
|
10192 | Patches | Plugins | Very Low | Drumkit / Drumpad / Sample Trigger / Instrument Plugin | 2009-05-08 | Marc Guay | 2009-06-17 | 2 |
Task Description
This plugin searches in the .rockbox/rocks/apps/drumkit directory for .raw sound files, loads them into memory, and assigns the keys to play them, creating a drumkit /sample trigger / instrument out of the player. Currently only designed for the Sansa e200.
Room for improvement:
- Add keymaps for all Allow multiple samples to be played at the same time (by using Allow for a variety of sound file types to be Find a better name
|
|
13097 | Bugs | Operating System/Drivers | Very Low | PANIC white screen when plugging a non supported SD car... | 2017-01-12 | Mario C. | 2020-07-07 | 2 |
Task Description
Creative ZEN Daily build: rockbox-creativezen-20170112
Bug description: When plugging any dummy plastic or a non supported SD card, the device freezes and displays a white screen with a “PANIC” error message. Plugging a standard SD card works fine. To restore the system, you have to use a paper clip to do a hardware reset and turn the device on again.
|
|
9202 | Patches | Bootloader | Very Low | iriver H300 bootloader power/usb fixes | 2008-07-16 | Matthew Haun | 2008-12-09 | 2 |
Task Description
This patch changes the iriver H300 series bootloader's power and usb handling. When a USB or Power plug are inserted into the H300, it will now boot as normal, not stop in the bootloader usb/charging modes. This was mainly for use in my car, but is also helpful for people with charging cradles for their computers.
Forum thread can be found here http://forums.rockbox.org/index.php?topic=17202.0
|
|
10292 | Patches | Simulator | Very Low | Compile Rockbox simulator with LLVM | 2009-06-07 | Maurus Cuelenaere | 2009-10-30 | 2 |
Task Description
This patch enables you to compile the Rockbox simulator with LLVM (you still need to alter the Makefile yourself though).
However, it fails at linking stage with 'file not recognized: File truncated' errors.
|
|
9917 | Patches | Drivers | Very Low | Cowon D2 Usb Serial | 2009-02-16 | Michaël Burtin | 2010-10-26 | 2 |
Task Description
Here’s a patch to have a functional usb_serial driver allowing the use of “Logf over Usb” debug function.
|
|
11499 | Bugs | Bootloader | Very Low | ipodpatcher sometimes fails when attempting to write ro... | 2010-07-26 | Michael Marley | 2010-07-26 | 2 |
Task Description
I am trying to use the last method mentioned on the ipodpatcher wiki page to write Rockbox directly into the OSOS image on my iPod Nano2G. Sometimes it works properly, but other times it fails saying that it couldn't read the header from the .ipodx file. I am following the instructions exactly, so that can't be an issue. I have tried hexediting the .ipodx file, and in some cases I can get ipodpatcher to read the header by editing the first four values, but this always causes a Checksum Error. Here is the exact output:
C:\Users\Michael Marley\Downloads>ipodpatcher.exe -wf rockbox.ipodx ipodpatcher 5.0 with v4.0 bootloaders (v1.0 for 2nd Gen Nano) (C) Dave Chapman 2006-2009 This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
[INFO] Scanning disk devices… [INFO] Read XML info (4 bytes) [INFO] Ipod found - 2nd Generation Nano ("winpod") - disk device 1 [INFO] Reading partition table from \\.\PhysicalDrive1 [INFO] Sector size is 2048 bytes [INFO] Part Start Sector End Sector Size (MB) Type [INFO] 0 63 48194 94.0 Empty (0x00) [INFO] 1 48195 1982462 3777.9 W95 FAT32 (0x0b) [INFO] Read XML info (4 bytes) [INFO] Ipod model: 2nd Generation Nano ("winpod") [ERR] Failed to read header from rockbox.ipodx [ERR] –write-firmware failed.
|
|
11545 | Patches | Games | Very Low | Chopper improvements | 2010-08-16 | Michael Marley | 2010-08-26 | 2 |
Task Description
This patch contains several improvements to the Chopper game designed to make it run with a high framerate instead of a low, jerky one. Previously, the game depended on sleeping for a number cycles before drawing another frame, causing very jerky motion. Now the game should run at a high framerate all the time. The gameplay should be about the same, at least on targets with a display of >64px. I don’t have any of these smaller targets, so I wasn’t able to test. Please tell me what you think of my changes.
|
|
11429 | Patches | Operating System/Drivers | Very Low | Improved sector cache / Remove on-stack and in-struct s... | 2010-06-21 | Michael Sparmann | 2010-07-31 | 2 |
Task Description
This patch adds a sector-based read/write cache between the storage and fat drivers. It has a static pool of 64 sector buffers which can be locked by the file handling code to replace the sector buffers in the file and dir structs, and serve as cache as long as they aren’t used. It can also be used to enforce exclusive access to a sector.
If requested using the STORAGE_NEEDS_ALIGN define, all storage accesses will be aligned to cacheline boundaries.
|
|
13178 | Bugs | Database | Very Low | all titles in database 2x, even after several rebuilts | 2019-09-08 | mike | 2019-09-11 | 2 |
Task Description
Version 9e186e34ab-190820
i have an ipod 7th gen rockbox installed 140.000 titles
database contains in unpredictable many cases of the folders 2 times the same title not in all folders, but it happens very often that i open one and i see all titles 2x although they are only 1x on the sd card
the files exist only ONCE but the database keeps listing them all 2 times
i rebuilt it several times, but the database keeps on doing that
any hint what i can do?
start as apple / itunes and delete rockbox folder / install new did not help
|
|
12350 | Bugs | Recording | Very Low | Clipv2 - Rockbox duplicates samples - effectively halve... | 2011-10-26 | neum | 2011-10-27 | 2 |
Task Description
What the title says. At whatever sample rate I use (24k & 48k tested), each sample is duplicated.
|
|
13003 | Bugs | User Interface | Very Low | Scrolling line broken if put directly after sublines. | 2014-09-24 | Oid Maps | 2014-09-24 | 2 |
Task Description
## This was tried out with Sansa Fuzev2 simulator version d392da8-140922, built from git on a 64 bit Linux system ##
I discovered something which seems to be a bug somewhere in the place where WPS get interpreted or rendered.
When I use a scrolling line just after a line containing sublines, the scrolling line stops scrolling as soon as the sublines change the first time.
Below are steps to reproduce it on the UI simulator for the Sansa Fuzev2. I think it also works without using a clear configuration. I haven’t tested with a real device, only with the simulator.
Attached are a .wps-file showing the buggy behaviour (’scrollline_after_sublines_bug.buggy.wps’), and a .wps-file working correctly (’scrollline_after_sublines_bug.workaround.wps’), which are the same files as quoted below.
STEPS TO REPRODUCE:
(0) Use Sansa Fuzev2 simulator version d392da8-140922, build from git on a 64 bit Linux system.
(1) Use a clear configuration, so erase
.rockbox/.playlist_control
.rockbox/config.cfg
.rockbox/nvram.bin
.rockbox/database.ignore
in your 'simdisk' directory.
(2) Start the rockbox UI simulator
(3) Change the theme to ‘rockbox_failsafe’, i.e. in the menu, do the following:
‘Settings’ → ‘Theme Settings’ → ‘Browse Theme Files’ → ‘rockbox_failsafe.cfg’
‘Settings’ → ‘Theme Settings’ → ‘While Playing Screen’ → ‘rockbox_failsafe.wps’
‘Settings’ → ‘Theme Settings’ → ‘Radio Screen’ → ‘rockbox_failsafe.fms’
‘Settings’ → ‘Theme Settings’ → ‘Base Skin’ → ‘rockbox_failsafe.sbs’
(4) Use the following .wps-file as the “While Playing Screen” skin:
=⇒ # Two sublines: Text1;Text2 # A long line, scrolling: %sA very long text which is meant to scroll because it is longer than the screen is wide. # Another line of just text (Not needed to reproduce the bug, but if it is swapped with the long line above, the long line scrolles correctly): Textline. #### Here the following Bug appears: # When the Line ‘Text1;Text2’ changes the sublines the first time, the subsequent line stops scrolling. It happens when the sublines change; as when you use ‘%t(5)Text1;Text2’, the scrolling stops only after 5 seconds, when the sublines actually change. ⇐=
Workaround: (4a) Put the scrolling line not directly after a line with sublines. The following .wps as the “While Playing Screen” skin works:
=⇒ # Two sublines: Text1;Text2 # Another line of just text. Needed to make the long line scrolling correctly: Textline. # A long line, scrolling: %sA very long text which is meant to scroll because it is longer than the screen is wide. #### Here the bug does not appear, the long line scrolls corretly. But when the long scrolling line is put just below the line with the sublines, it stops scrolling as soon as the sublines change for the first time. ⇐=
|
|
11218 | Patches | Operating System/Drivers | Very Low | New build target: iriver E10 | 2010-04-25 | Olle Bergkvist | 2010-05-08 | 2 |
Task Description
New build target, for iriver E10.
A lot of target-specific functions are missing, so it doesn't compile when it reaches the linker. But I think it's about time to insert the build target into SVN, and #rockbox seems to agree.
Also, building a simulator build works quite well. The simulator BMP and the keymaps needs some work, but it works pretty well, including music playback.
I've done some testing with building for other targets and nothing seems to be broken by this patch. I couldn't figure out how to include the BMP in the patch so i attach it separately.
|
|
9595 | Patches | User Interface | Very Low | Correct thai font display | 2008-12-01 | Phinitnun Chanasabaeng | 2008-12-30 | 2 |
Task Description
This patch will correct how thai vowels and tonal makers display.
|
|
6467 | Patches | Games | Very Low | New control scheme for Doom on Sansa e200 | 2006-12-21 | Piotr Jafiszow | 2007-10-10 | 2 |
Task Description
Patch changes controls for Doom:
Forward: rec/up Left/Right: scrollwheel (it needs a lot of scrolls for large turns, but hopefully it can be modified to work better in the future) Back: down Shoot/Enter (menu): select Change weapon: left Open: right Esc: power
|
|
12074 | Patches | Settings | Very Low | Add setting to enable/disable lineout on Sansa Fuze V2 | 2011-04-19 | Rob Walker | 2019-08-02 | 2 |
Task Description
This patch allows the line out on the Sansa Fuze V2 to be enable/disabled by means of the existing Lineout poweroff setting (previously used on some iPods).
By assigning this setting to the quickscreen I can switch between headphones and lineout after plugging into the dock. Still no luck in finding out how to autodetect the dock.
I'm not 100% sure that re-using the "Lineout Poweroff" setting is the right thing to do here as it's not powering on/off the line-out - just switching between headphones and line out
|
|
12076 | Bugs | Database | Very Low | Autoresume feature can start from wrong offset due to r... | 2011-04-19 | Rob Walker | 2011-08-08 | 2 |
Task Description
I've found a problem with the new autoresume feature in 3.8. I use it when listening to podcasts and sometimes find that it resumes from near the end of a new episode - e.g. on a 30 minute podcast it will resume from 28 or 29 minutes - usually about the place where a previous epidsode finished and I skipped past the end credits.
What I think is happening is that there is some code in the database that tries to resurrect the runtime statistics for files that have been deleted and then restored - as the last offset is in this data, it is reusing the last offset from an old episode.
I've put some more logf()s in tagcache.c in build_numeric_indices(). I can see that if the filenames don't match (line 2306) it then tries to match any 2 tags out of the 3: artist, album or title. For the podcasts, the artist and album are always the same (i.e. the producer and which one of their podcasts it is), but the title is different (i.e. "Episode 100", "Episode 101", etc). So if I've listened to Episode 100 and then deleted the file, and then add Episode 102 to the player, it matches the artist and album and so resurrects the wrong data from Episode 100.
I've disabled the resurrection based on tags (just commented it out) and the problem seems to have gone away. A better fix would be to ensure that all 3 tags or matched or to ensure that title is one of the matched tags
|
|
10511 | Patches | Build environment | Very Low | Fixed multiple-language feature in tools/configure | 2009-08-11 | Rosso Maltese | 2020-07-14 | 2 |
Task Description
The patch fix the multiple-language feature, maintaining the same behaviour in interactive and batch mode and with “make reconf”. Now it’s possible to build more than one voice language at once, specifying different engine and option set for each one. So, running “make voice”, all the selected languages will be built.
To help the comprehension, here it is a batch mode sample:
../tools/configure –target=ipodvideo –ram=64 –type=av –language=italiano,espanol –tts=f,e –voice=lp_diphone –ttsopts=, –encopts=’-q 10 -c 10,-q 5 -c 5’
This is like to run:
../tools/configure –target=ipodvideo –ram=64 –type=av –language=italiano –tts=f –voice=lp_diphone –ttsopts=’ ' –encopts=’-q 10 -c 10’
../tools/configure –target=ipodvideo –ram=64 –type=av –language=espanol –tts=e –voice=lp_diphone –ttsopts=’ ' –encopts=’-q 5 -c 5’
In the first case, I set the language to italian, using festival with voice lp_diphone (female), no further festival options and some manual encoder options. In the second case, I set the language to spanish, using espeak. Even if I set the voice, the value is ignored, since the selected TTS engine doesn’t use it.
I also added some cosmetics, like some very circumstantial indentation, blank check in rootdir too, simpler numbered menu generation, some terser command pipes.
The patch is applied to r22250.
I don’t know if it’s a really wanted feature, but the word in the script hurt me!
|
|
12758 | Bugs | Language | Very Low | Incorrect display of labels in Russian | 2012-09-28 | Sergey Gubanov | 2012-10-06 | 2 |
Task Description
In the "Graphic Equalizer" menu and when I connect the player to a computer to transfer the data labels are displayed incorrectly (instead of letters symbols, as in the screenshot). The problem occurs when I use the Russian language. The problem I see for a long time, please fix it.
Screenshot of the screen that is displayed when transferring data, I could not do. P.S. Sorry for my bad English.
|
|
11877 | Bugs | Operating System/Drivers | Very Low | Filesystem corruption after entering USB mode | 2011-01-14 | sideral | 2011-04-18 | 2 |
Task Description
Various users on IRC recently reported cases of filesystem corruption. I have seen them as well, especially when using USB mode (I'm using a Sansa ClipV2, USB-enabled through FS#11664 ).
One strangeness I've experienced is that when my system has detected filesystem corruption, it is often enough to remove the player from USB and then replug it, without repairing the filesystem and without rebooting Rockbox; on the next USB mount, the filesystem is clean. This might indicate that some buffer is flushed too late for the USB host to see.
[EDIT: Removed previously attached patch, which is now tracked separately as FS#11883.]
|
|
12073 | Patches | Database | Very Low | Dynamically add files to database as they are played | 2011-04-18 | sideral | 2011-04-19 | 2 |
Task Description
These experimental patches dynamically add new tracks to the database when they are played. This allows users who (for various reasons [1]) prefer to not fully initialize the database to take advantage of database-based features such as autoresume (remember a resume position for each file), runtime statistics, or track ratings.
The current patch set is only a prototype. It's still somewhat inefficient because it does a full database commit and reload for each new track that is played.
The actual database-extension patch (patch 0002) works by refactoring tagcache_build to create a new interface, tagcache_add_file, that adds a single file to the database. This new function runs in the database thread and takes a dircache_entry pointer, which is provided by way of a Q_UPDATE event. The audio thread generates this event in tagtree_buffer_event when the initial DB lookup fails, and later checks the database again in tagtree_track_finish_event. If the DB commit and reload have succeeded in the meantime, this second lookup will succeed and the runtime information the user is interested in (stats, resume info) can be stored in the DB.
Patch 0001 changes the DB commit's buffer-allocation preference from using the dircache buffer to using the RAM DB's buffer. (This used to be the preference until r10003 reversed it, supposedly because the dircache buffer typically is bigger. I don't know yet how valid this argument is today.) This reversal avoids needlessly flushing and refilling the dircache and makes the Q_UPDATE event-passing mechanism more robust (because in-flight update events contain dircache_entry pointers, which would have to be invalidated when the dircache is flushed – which is not done yet).
Current limitations/caveats: * Requires dircache and Load-DB-to-RAM enabled (and only works on targets that include these features) * tagcache_add_file does not respect any database.[un]ignore files in the directory hierarchy above the added new file. * DB needs to be initialized to begin with. There's no UI function for a basic DB initialization (without scanning and adding all files) yet. * Not very thoroughly tested (mostly in simulator, with small file sets)
Possible improvements: * Delay committing DB changes if more track-add events are in the tagcache queue * Incremental commit: Could be optimized for add-one-track case * Incremental load_tagcache: Avoid flushing and reloading full database * Add function to initialize an empty DB
Comments welcome!
Footnote: [1] Reasons for not using the database, or not keeping it up to date, include: metadata parser instability; prefer not keep tags up to date; prefer file browser over database browser
|
|
13193 | Patches | Configuration | Very Low | Add option to disable settings reset on startup | 2020-04-01 | Stefan Ott | 2020-04-03 | 2 |
Task Description
I would like to run my iPod with its keypad locked all the time, thus I wrote a little patch to an option to disable the settings reset during startup regardless of the hold button's position.
You will find the patch attached to this message. I'm not entirely convinced by the name of the new option (or my wording in general) so if you have a better idea, feel free to rename things.
|
|
8569 | Patches | Remote | Very Low | Iriver remote keymap changes | 2008-02-09 | Steve Bavin | 2011-07-12 | 2 |
Task Description
The attached patch slightly modifies the keymap of the H300 non-LCD remote to allow access to the browser from the WPS (by use of LONG PLAY).
I know that it works ok from an H300 with a non-LCD remote, but I don’t know if I’ve broken the LCD remotes completely.
Please could users of both the H100 and H300 LCD remotes try this patch and tell me that the WPS context keymap is unaffected. For reference, you can see the intended mapping here: http://www.rockbox.org/twiki/bin/view/Main/KeymapIriverHSeries
|
|
9169 | Patches | User Interface | Very Low | Allow seek speed limiting to be optional | 2008-07-08 | Steve Bavin | 2008-07-15 | 2 |
Task Description
This patch adds an option to disable the speed limiting that slows down seeking as you approach the end or beginning of a track.
It defaults to limiting enabled, to maintain compatibility. Personally, I prefer the fast seeking without the limiting.
The manual is not included, I can't compile them still…
|
|
11927 | Patches | Database | Very Low | Queue overflow during database initialisation | 2011-02-11 | Steve Bavin | 2011-04-14 | 2 |
Task Description
While the database initialisation is running, the tagcache queue can overflow due to system broadcast messages. This can be seen by running a simulator (it will crash with KERNEL_ASSERT after a while) or on a target by enabling KERNEL_OBJECT_CHECKS, then initialising the database and repeatedly connecting/disconnecting a charger.
The same problem may well happen with other queues (dircache, for example).
|
|
12608 | Bugs | User Interface | Very Low | %pb tag draws larger area than bitmap, showing pixel ga... | 2012-03-07 | Thomas Martitz | 2012-03-07 | 2 |
Task Description
The %pb tag has a small problem. If an image is specified but no height, the tag draws the size of a line even if larger than the the image. This leads to pixel garbage below the progressbar.
The test.wps reproduces the problem in the 320x480 sdl app The default font, 27-adobe, has to be selected probably. The wps works if a height, i.e. 20 in this case as the image height, is specified
Test.png shows the problem. test.zip is the small test theme.
|
|
13040 | Patches | Playlists | Very Low | Playlist becomes one item shorter when shuffled | 2015-03-21 | Thomas White | 2015-05-30 | 2 |
Task Description
I noticed that the playlist seems to become one item shorter when I shuffle it, using the latest Git master branch (commit 70d57080) on a Sansa Clip+.
Steps to reproduce: 1. Clear the playlist by pressing Stop (power button) 2. Add a small number of tracks to the playlist 3. Shuffle the playlist (playlist view, menu, Shuffle) 4. Observe that playlist is one item shorter than before
I tracked the reason for this down, and attach a patch. This isn't a "proper" fix, and is a bit hacky, but it does illustrate what causes the problem.
|
|
7546 | Patches | Applications | Very Low | Rockboy LCD Unifications (+ iPod Greyscale Support) | 2007-08-06 | Tom Ross | 2007-10-19 | 2 |
Task Description
The patch reorganizes Rockboy to use the same method for storing GB frame buffer data on greyscale targets as color targets. As a result, support for greyscale iPods is much easier and has been implemented (inspired by FS #5282).
Some other changes include: - Enable the menu for iRiver H100 - Ability to “Show Stats” on all targets - Screen is redrawn all at once on greyscale instead of line by line - Elimination of fb.mode (all targets use options.scaling for scaling options) - Elimination of fb.cc on non-color targets - Minor variable renaming - Unification of LCD variables (vdest vs frameb) - Move greyscale LCD code into lcd.c - ifdef out vid_update() on greyscale and color targets
Since I don’t have an iPod, I’m curious to see how well this works. It should be fine since the patch my work is based on seems to work for people.
I really need iRiver H1X0 users to test this. There are significant changes to the LCD code and I’d like to know if the is any speed change, whether its an improvement or not. I’d guess that it’s slightly faster or the same as SVN but there’s always a chance that it is slower.
|
|
11031 | Bugs | Plugins | Very Low | Brickmania: Game doesn't load well | 2010-02-17 | Tomer Shalev | 2010-02-19 | 2 |
Task Description
When loading a saved Brickmania game, the game is loaded corrupted. Please see screenshot attached to see for yourself. There is one brick in the right side which is shown corrupted, and one corrupted rectangle in the left side of the screen which drops like a power object, and stays at the bottom of the screen.
This issue happens on Cowon D2 target. It doesn't happen on the D2's simulator.
Looking at the code and comparing the loading/saving function against the Bubble's game functions, I can see that the return value of file operations is not checked (I'll fix that). In Bubbles, there's a single file operation of reading/writing the game context struct. In Brickmania there are several consequent file operation to read/write each variable. Maybe the drivers doesn't handle this well on this target. A workaround for that could possibly be to join all saved variables under one game context struct as in Bubbles, but that could mask a real bug somewhere else.
|
|
11249 | Patches | Operating System/Drivers | Very Low | Fixed Morse Code case switching (on Sansa Fuze / FuzeV2... | 2010-05-07 | Wenyu "Hearson" Zhang | 2020-06-29 | 2 |
Task Description
Hi all,
Currently for all models, the Morse Code input method can only type lowercased letters. Here I provide a patch which enables people to switch between lower cased and upper cased letters, I implemented this for Fuze and Fuze v2, and further fixes will be provided soon (or someone else want to add some key mapping options into your keymaps?)
The patch (also attached):
Index: apps/action.h
— apps/action.h (revision 25886) +++ apps/action.h (working copy) @@ -239,6 +239,7 @@
ACTION_KBD_DOWN,
ACTION_KBD_MORSE_INPUT,
ACTION_KBD_MORSE_SELECT,
+ ACTION_KBD_MORSE_CASE_SWITCH,
#ifdef HAVE_TOUCHSCREEN
/* the following are helper actions for touchscreen targets,
Index: apps/recorder/keyboard.c
— apps/recorder/keyboard.c (revision 25886) +++ apps/recorder/keyboard.c (working copy) @@ -148,6 +148,7 @@ #ifdef HAVE_MORSE_INPUT /* : We should put this to a configuration file. */ +static bool morse_uppercase = false; static const char *morse_alphabets =
"abcdefghijklmnopqrstuvwxyz1234567890,.?-@ ";
static const unsigned char morse_codes[] = { @@ -573,6 +574,11 @@
state.morse_code |= 0x01;
}
break;
+ case ACTION_KBD_MORSE_CASE_SWITCH: + if (state.morse_mode) { + morse_uppercase = !morse_uppercase; + } + break; #endif /* HAVE_MORSE_INPUT */
case ACTION_KBD_SELECT:
@@ -626,7 +632,8 @@
/* turn off hangul input */
state.hangul = false;
- kbd_inschar(&state, morse_alphabets[j]); + kbd_inschar(&state, + morse_uppercase ? toupper(morse_alphabets[j]) : morse_alphabets[j]);
}
#endif /* HAVE_MORSE_INPUT */
break;
@@ -862,6 +869,10 @@
int morse_code;
outline[0] = morse_alphabets[i];
+ + if (morse_uppercase) + outline[0] = toupper(outline[0]); +
sc->putsxy(x, y, outline);
morse_code = morse_codes[i];
Index: apps/keymaps/keymap-fuze.c
— apps/keymaps/keymap-fuze.c (revision 25886) +++ apps/keymaps/keymap-fuze.c (working copy) @@ -269,6 +269,7 @@
{ ACTION_KBD_DONE, BUTTON_UP, BUTTON_NONE },
{ ACTION_KBD_ABORT, BUTTON_HOME|BUTTON_REPEAT, BUTTON_NONE },
{ ACTION_KBD_MORSE_SELECT, BUTTON_SELECT|BUTTON_REL, BUTTON_NONE },
+ { ACTION_KBD_MORSE_CASE_SWITCH, BUTTON_HOME, BUTTON_NONE },
LAST_ITEM_IN_LIST
}; /* button_context_keyboard */
|
|
9779 | Patches | Build environment | Very Low | rework of assert | 2009-01-11 | Yoshihisa Uchida | 2010-02-17 | 2 |
Task Description
Building Rockbox fails if assert() (in firmware/include/assert.h) is used.
Then, I reworked assert.h.
changes: When assert() failed, the correction that displayed the file name, the number of lines, and the condition of failing was done. Moreover, when the log was enabled, the log was output to the file.
Please select the following to make assert() enabled when you make Rockbox.
1) Run tools/configure
2) Build (N)ormal, (A)dvanced, (S)imulator, (B)ootloader, …
Select "A"
3) (D)EBUG, (L)ogf, (A)ssert, (S)imulator, (P)rofile, (V)oice
Select "A"
4) make
|
|
11388 | Patches | Playlists | Very Low | Bookmark file doesn't work for a directory with a semic... | 2010-06-09 | Aaron Wells | 2010-07-09 | 1 |
Task Description
Steps to reproduce:
1. Create a directory: /AUDIO;BOOKS 2. Place a file in it: /AUDIO;BOOKS/file.mp3 3. Start playing the file, and then create a bookmark 4. Do “List bookmarks” for the file 5. The bookmark menu lists something like this:
BOOKS/;file 0:02, 2, Shuffle
The problem seems to be that .bmark files use semicolons to separate the fields of information. If there’s a semicolon in the path, it thinks that it indicates the end of the path and the beginning of the filename.
|
|
11943 | Bugs | Themes | Very Low | EQ settings changed via Touchscreen setting_inc & setti... | 2011-02-15 | Adam Sugerman | 2012-02-10 | 1 |
Task Description
EQ settings changed via Touchscreen WPS action setting_inc & setting_dec are not reflected in the sound output of the device even though they display having been changed in the menus. The changes are also not written to the main config file on disk so they do not "stick" after Rockbox has been rebooted.
example syntax to toggle EQ on/off (display DOES get toggled): %T(148,520,54,46,setting_dec,eq enabled) %T(148,520,54,46,&setting_inc,eq enabled) %xl(E,eq.bmp,0,0) %V(148,520,54,46,-) %?St(eq enabled)<%xd(E)|>
I'm not sure if this problem is specific to Android or if the problem applies to all targets. APK Build: Feb 4, 2011
|
|
12678 | Bugs | Music playback | Very Low | Unable to play WMA Pro (possibly VBR) | 2012-05-18 | Albert Meltzer | 2012-05-20 | 1 |
Task Description
The player (Sansa Clip Zip) appears to refuse or unable to play some of my WMA tracks; as far as I can tell, the problem is specific to my WMA Pro files only as it plays none of them (but works with WMA2 successfully). I have attached one of the examples.
I understand that a similar issue was reported recently (in FS#12619 ) although, in my case, the player doesn’t start playing and skips to the next immediately, rather than playing part of the track.
|
|
10601 | Patches | LCD | Very Low | Keyboard shortcuts to change backlight brightness | 2009-09-11 | Alex Suykov | 2009-09-12 | 1 |
Task Description
The patch makes Rec+Vol{Up,Down} in wps and list (main menu) contexts chage backlight brighness. Just like with volume, brightness value is saved in config file. I find this feature quite useful when player is used both indoors and outdoors, eps. on sunny days.
Keymap changes are for Sansa C200 only. Check apps/keymaps/keymap-<you-target>.c and add necessary lines to button_context_{standard,wps} if you use different device.
Diff against SVN revision 22666.
|
|
9356 | Patches | Applications | Very Low | Allow to set the delay before button repeat is activate... | 2008-09-02 | Alexander Levin | 2008-09-03 | 1 |
Task Description
The patch allows to set the delay after which the button repeat event is generated. Since this event is used to detect a long button press, it effectively sets this 'threshold.'
Slow fingered users may often hold the select button too long and (unintentionally) get the context menu. For instance, from the WPS screen. But they actually wanted to go to the file browser.
The patch adds a setting for that delay. Its default value is 30 ticks (=0.3s). The menu entry is in Settings → General Settings → System → Long Button Press Duration.
|
|
9879 | Patches | Plugins | Very Low | Quit the lamp plugin by pressing a dedicated QUIT butto... | 2009-02-07 | Alexander Levin | 2009-02-09 | 1 |
Task Description
As of r19940, the lamp plugin is quit by pressing any key besides some which have a function in that plugin (or so is the intention –see bug report FS#9877 ).
This patch changes the plugin so that it’s left with a special button only. The patch also adds key definitions for some players that haven’t been included before (players without color LCD). Key mappings were taken from the patch in FS#8934.
Essentially, this patch implements an atomic part of that patch.
Also, correct handling of USB has been added.
This is in preparation of a (separate) patch for toggling the light on and off without leaving the plugin.
|
|
11129 | Patches | Manual | Very Low | Make screenshots in the manual non-floating | 2010-03-19 | Alexander Levin | 2010-03-19 | 1 |
Task Description
Screenshots in the manual are nested into a 'figure' environment, but the only purpose of this is to be able to have a caption. The floating feature of 'figure' by using the placement attribute 'H' (='Here!').
This patch makes screenshots non-floating while keeping captions below the images. This is done via the LaTeX package 'caption2'.
Placement attribute for figures is set back to the LaTeX default so that figures can really float should we need it.
|
|
11847 | Bugs | Themes | Very Low | Rockbox tries to open files "-.kbd", "-.sbs" and "-.rsb... | 2010-12-30 | Alexander Levin | 2011-02-01 | 1 |
Task Description
r28936, sim build for iriver H120, fresh installation folder, i.e. no file “config.cfg”
I modified the function “sim_open” to ouput what files it’s opening, and got the following output (see attached text file). Note that there are files “-.kbd”, “-.sbs” and “-.rsbs”. I think these files should not be opened, even tried.
|
|
12530 | Patches | Manual | Very Low | Add a note and a warning about the location for recordi... | 2012-01-10 | Alexander Levin | 2012-01-12 | 1 |
Task Description
The location for recordings can be set, but the only way to see the current value for the setting is to look into the config file. The patch adds a note stating that to the manual.
Also, there is a known bug ( FS#12517 , FS#12500 ) preventing saving the recorded files in the root directory (maybe this applies only to some targets, not all). The patch adds a warning about that.
|
|
11599 | Patches | Simulator | Very Low | Make simulator able to emulate storage with a file inst... | 2010-09-03 | amaury pouly | 2010-09-03 | 1 |
Task Description
This patchs modifies the simulator so that it can emulate the storage layer. More preciserly, it enables all the storage code and simply redirect all storage_{read,write, …} to a file. This way, all fs functions used are the one of rockbox, which allows to debug the FAT code for example.
To run this, apply the patch and modify the makefile to add this: -DROCKBOX_SIMULATE_STORAGE_LAYER to the line: export GCCOPTS=….
When running the simulator, it expects to read from file simdisk.raw. You can change this by using the –root option: ./rockboxui –root <file>
The code doesn’t work for me, FAT code seems to choke on something for now, I’m not sure why.
|
|
8867 | Bugs | Music playback | Very Low | Equalizer is adding high noises | 2008-04-10 | André Scheffler | 2008-04-10 | 1 |
Task Description
The (software-)equalizer is adding high noises to the playback.
I made a recording, the first part with eq enabled the second one with disabled equalizer.
I could also make a test on my older H110, on which I never used the sw-eq though.
|
|
7203 | Patches | Plugins | Very Low | New game for Color-LCD-Rockboxes | 2007-05-22 | Andreas Kruschinski | 2007-06-28 | 1 |
Task Description
This is the game Squarebloxx. It works on Color-LCDs only because colors are an essential part of the game. I tested it in the Simulator for all the color Boxes. I also tested it on my H340. In the game you have to mark parts of an array of tiles. If the tiles in the corners of the mark are the same color, the marked area is done. If all tiles are done the level is finished. Please give me feedback and report bugs.
Thanks Krush
|
|
12982 | Bugs | Operating System/Drivers | Very Low | partition table unsupported (and bugfully ignored) on s... | 2014-06-03 | Andrew Engelbrecht | 2014-06-06 | 1 |
Task Description
if i format the clip+'s microsd card to contain a DOS partition table, then the vfat formatted partition is not recognized.
if i format the sd card with a vfat fs starting at the first block, then the fs is recognized by rockbox.
** if i then reformat the sd card with a partition table like above, then the second fs i created is still recognized by rockbox, even though the first 512 bytes or so have been clobbered. the result is that rb and my laptop see different fs structures, and clobber each other's metadata, causing corrupt file systems.
the work-around is to dd if=/dev/zero the beginning of the sd card and format without partitions.
i kindly request that rb support dos, or some other, partition table, and maybe that rb doesn't mount fs'es which appear to be clobbered by a partition table. one problem with this change is that some people may be using a clobbered fs without knowing. with such a patch, they could end up seeing a corrupt fs instead.
i don't consider this very high priority. thanks for the awesome firmware!
|
|
10461 | Patches | Plugins | Very Low | Support for custom drawing of styled/scrolled text in p... | 2009-07-24 | Andrew Mahone | 2009-09-14 | 1 |
Task Description
Add support for two new scroll styles, STYLE_NODRAW and STYLE_CUSTOM, with STYLE_CUSTOM causing the draw to be done via a hook (set with lcd_set_style_hook). lcd_puts_stroll_style_offset also returns a struct scrollinfo pointer. This may be used in conjunction with STYLE_NODRAW to redraw the scrolling text in a plugin which draws other graphics to the same part of the screen, by drawing the text using the offset in the struct scrollinfo after the background graphics have been drawn. My latest patch from FS#4817 is required, as it consolidates styled text drawing in one function, making it easier to replace the normal draw with a call to the hook, and reducing the binsize impact of this feature as well.
Support for core text scrolling in PictureFlow plugin to follow .
|
|
11891 | Patches | Codecs | Very Low | Add mp3 gap skipping support to improve gapless playbac... | 2011-01-18 | Andrew Tefft | 2011-09-02 | 1 |
Task Description
As we know, rockbox will use the information provided by "good" mp3 encoders (e.g. LAME) to ignore the extra padding that occurs at the beginning and end of each mp3 file, so that true gapless playback can occur. Unfortunately we do not always have the luxury of encoding our mp3 files in this way but we might still want true gapless playback. This patch compensates for the use of "dumb" mp3 encoders that do not record the necessary information for this feature.
In cases where it does not detect the proper header information to trim off the extra padding, it will optionally skip up to a full frame of silence (or near silence) at the beginning and end of each track (if the trimming is already specified, this patch does not do any additional trimming).
This can potentially eliminate up to a frame of "real" silence at the beginning or end of a track, but in terms of audibility, that would be completely unnoticeable (and it would only happen on these badly-encoded tracks), while the extra silence is an audible annoyance.
I have added an option to the Playback Settings menu so that the user can disable it if desired.
|
|
13053 | Patches | User Interface | Very Low | Add option to make scrollbars borderless | 2015-07-29 | Andrey Maluy | 2015-07-30 | 1 |
Task Description
This patch will add a setting, called "Scroll Bar Border", which will determine whether menus / lists will have scrollbars with borders or not.
The default value for this setting is "yes", so that it matches previous behavior.
|
|
8991 | Patches | Plugins | Very Low | caps+symbol shifts for ZXBox | 2008-05-14 | Anton Romanov | 2008-05-14 | 1 |
Task Description
adds ability to use “Caps Shift” (displayed as ‘C’ in vkeyboard) and “Symbol Shift” ( ‘H’ ) so Jumping Jack can be played http://forums.rockbox.org/index.php?topic=16817.0
|
|
10644 | Patches | User Interface | Very Low | Cowon D2: JPEG viewer control using hardware buttons an... | 2009-10-04 | Arago | 2011-06-05 | 1 |
Task Description
Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.
Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)
|
|
10645 | Patches | User Interface | Very Low | Cowon D2: PNG viewer control using hardware buttons and... | 2009-10-04 | Arago | 2009-10-04 | 1 |
Task Description
Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.
Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)
|