Rockbox

The purpose of the game is to press one of the four direction keys as fast as possible when randomly asked to do so. At the end of the game, min/max/average values are displayed.

This patch adds detection of the charger connection. Not tested on a 1G, but should work if the ipodlinux GPIO documentation is correct.

NOTE: 'Charging' is not detected, just the presence of external power. See http://forums.rockbox.org/index.php?topic=18196.0 for forum topic.

This patch removes any total tracks and total discs number from the track and disc number fields in ID3v2 tags, so that track and disc numbers are displayed consistently across different tagging formats.

What happens is that if a number larger than zero can be parsed from the start of the field, then the field is terminated on the first “/” char.

Added as a patch as I don’t know if this behavior is wanted.

The patch allows to set the delay after which the button repeat event is generated. Since this event is used to detect a long button press, it effectively sets this 'threshold.'

Slow fingered users may often hold the select button too long and (unintentionally) get the context menu. For instance, from the WPS screen. But they actually wanted to go to the file browser.

The patch adds a setting for that delay. Its default value is 30 ticks (=0.3s). The menu entry is in Settings → General Settings → System → Long Button Press Duration.

This patch modifies the Gigabeat S keymap so that it can be used almost solely using the buttons on the face of the player.

Currently, there is an unused button in the WPS screen (the BACK button, up-left from the cross) which in my mind makes more sense as the “back to the menu” button, while the MENU button (up-right from the cross) is the logical Play/Pause button (at least to a right-handed individual). It’s unfortunate that the button with the Windows logo has been called the MENU button in the code, thus making this rather confusing to read, but if enough people agree with the feel of this change, that could be modified as well.

also category:
Some containers, like Matroska MKA or like Ogg can contain numerous audio tracks, for example the whole AudioCD contained within single Ogg file.

For example VideoLAN.org plays such files ok, while fails to show separate tracks/tags in playlist.

However, RockBox justs freezes and until reboot can no longer play music (each file is detected as having zero duration)

example can be found: [link deleted - it was a full copyrighted album]

This patch modifies bins.pl, manuals.pl and voices.pl to be smarter, just like the new w32sims.pl, adding a -r commandline switch, allowing the same script to be used for building both daily and release versions.

this is part of a different patch which was changed to use the menu api instead of simplelist so im putting it up here incase anyone decides to make simplelist draw in a viewport.

The patch works (or did last time i tried it) but isnt commited because its not really needed just yet.

This patch adds a new plugin called aegdice, which allows for AEG style (i.e. 5k3) dice rolling.

I found  FS#8521 (permanent pitch setting) can successfully combined with mpeg player.
Add  FS#8521  and some fix, we can use pitch function in mpeg player. This means, we can control mpeg play speed.

With  FS#8894 (speed control without pitch change) can produce similar effect and more attractive, but  FS#8894  have serious problem with gigabeat s30 and require more processer power and have lower sound quality.

This patch can patched with  FS#8607 (mpegplayer playlist).

While examining disk performance with  FS#9708 , I found one album where the disk stayed spinning with no activity for 5 s longer when using PIO. This is repeatable with that particular album. With the downloaded r19739-090109 build, this did not happen with the default settings but it started happening as soon as I enabled dircache. Prolonging the disk timeout prolongs the extra sleeping time.

Experimentation with shows that the storage_sleep() part of fill_buffer() (in apps/buffering.c) is executed early in the buffering and it is not executed at the end. With another album where spindown happens properly, ata_sleep() is called twice. Note that ata_sleep() just sets last_disk_activity, and sleep happens over half a second later if there is no disk activity during that period and last_user_activity has timed out.

I think this is a race condition based on how dircache and transfer rates change things. I wonder if it is related to  FS#9541 .

The data mentioned is located at http://spreadsheets.google.com/ccc?key=pkeRcfM0sg949P3a5EYXtew and the delayed spindown is seen in the EP7 PIO test. In that data, also note how sectors written are 5, 10 or 15, with differences between different tests with the same album.

I have a 30GB 5th generation iPod, but I expect this issue affects all SW-codec players.

This is v2 of the Rockbox plugin API documentation generator.

See the mailing list for more information ( http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-01/0040.shtml ).

An example of what the output looks like is available here: http://mcuelenaere.alwaysdata.net/rockbox_api_example_3/

Sometimes when I shut my unit off and then turn it on again and resume playback, RB resumes from a different place than where it left off, and even though when I resume shuffle is on (as indicated by its icon), it isn’t. It’ll play the current track, then the next track in the playlist (which in my case is in order by track number, so it’ll play the next track on the album), and so on.

If I turn shuffle off and then on again, shuffle works correctly again.

I’m using a build from January 19 (19800-090119) on an Archos Recorder. I
noticed this bug occurring in the 3.1 build as well.

It seems to happen randomly – I can’t figure out anything specifically that I can do to always make it happen.

This is a new plugin that mimics the open source PC program mnemosyne (http://www.mnemosyne-proj.org/), a program that assists with memorizing flash cards. The plugin is fully functional, but it still needs a menu and assumes that the user has setup the folders it needs for storing cards before running (if you don’t create them it will crash). I’ll fix these issues in the near future, but in the mean time any feedback is appreciated :)

As of r19940, the lamp plugin is quit by pressing any key besides some which have a function in that plugin (or so is the intention –see bug report  FS#9877 ).

This patch changes the plugin so that it’s left with a special button only. The patch also adds key definitions for some players that haven’t been included before (players without color LCD). Key mappings were taken from the patch in FS#8934.

Essentially, this patch implements an atomic part of that patch.

Also, correct handling of USB has been added.

This is in preparation of a (separate) patch for toggling the light on and off without leaving the plugin.

For 15-Adobe-Helvetica.bdf:

STARTCHAR ETHIOPIC SYLLABLE NO
ENCODING 4758
SWIDTH 1520 0
DWIDTH 19 0

The above value of SWIDTH, DWIDTH is too larger than that of other Ethiopian characters (This character protrudes from bounding box).

I send this bug’s patch.

This patch attempts to permanently fix the inconsistent mixture of “Title Case” and “Sentence case” in english.lang by applying “Sentence case” to the entire file.

I suggested we do this in a post to the rockbox-dev mailing list last year, but that just ended in a very split discussion with no conclusion.

I’m not sure if this patch wil result in anything different, but I made it for my own use, and thought I would post it, as there were a fair number of posters to that discussion that also prefered sentence case.

The old discussion:

http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-08/0034.shtml

EDIT: I forgot to say this patch also changes a couple of uses of “center” to “centre”…

The H10 5G MTP needs a different bootloader than the UMS version (see http://www.rockbox.org/twiki/bin/view/Main/IriverH10PortDevInfo#Build_a_Rockbox_Bootloader).
I’m not sure about the correct way to do this in configure, so I’ll leave it to someone who is.

this is an attempt to implement the idea suggested in the forum (http://forums.rockbox.org/index.php?topic=20120.0).
I take values from “skip length” setting for variable steps.

i asked some time ago why there is the buttontable in general settings –>bookmark. i wondered because the buttons are the same as in other lists. Marc Guay said "the delete button is unique", an i wondered why there is a dedicated delete button… in no other lists exists such a button afaik.

i changed the manual accordingly.
i also corrected some wrong (?) comments.
i hope i did everything right, at least for the e200 it compiles and works fine.

i would like to get some opinions about it.

The aim of this patch is to make releases as simple as possible... i.e the end goal would be to have someone run “$ ~/rockbox/tools/release/release.sh 3.3” and that would do everything except feed the cat...

the first version just modifies bins.pl to accept a version number which eventually gets passed to the Makefile and used in the source to set the version string in the source to “3.x-rBLAAA”.

This also defines RBRELEASE which can be used in the source to do stuff, for example, remove the debug menu in releases (if we decide to do that...) (RELEASE is defined in speex so had to add the RB prefix...)

Also, this changes the way configure is run to use command line args instead of passing input to it which is Just Wrong (TM) :p

In  FS#8894  (the original timestrech task), an updated version of the algorithm was uploaded.

The author said it performs and sounds better, so we should try to incorporate it.

I've tried building it, but I can't get a useful result, but I'm also not sure if I used it correctly. I used ./scale 2 < in.wav > out.wav. The result wasn't streched, but had crackling noises every few seconds.

When adding text via the keyboard, neither the selection function nor the done function work using the remote play button. Pressing 'play' on the main unit however, does work and has the correct behaviour.

I checked the keymap-m3.c source and I noticed that unlike the other entires, the last entry for these options refers to the main unit buttons and not the remote:

{ ACTION_KBD_SELECT, BUTTON_RC_PLAY|BUTTON_REL, BUTTON_PLAY },
{ ACTION_KBD_DONE, BUTTON_RC_PLAY|BUTTON_REPEAT, BUTTON_PLAY },

I changed the entries to the following:

{ ACTION_KBD_SELECT, BUTTON_RC_PLAY|BUTTON_REL, BUTTON_RC_PLAY },
{ ACTION_KBD_DONE, BUTTON_RC_PLAY|BUTTON_REPEAT, BUTTON_RC_PLAY },

After rebuilding and installing this change onto my M3 the keybord now works when using the remote.

Attached is the patch file for this change.

After releasing hold after several minutes of playback with hold enabled, the backlight flickers on and off, if the following settings are enabled:

Backlight on hold: off
Backlight fade in: on
Backlight fade out: on
Caption backlight: on

My theory is that fade-in/out events from the caption backlight somehow get queued up, and happen once hold is released.

Happened as recently as today, with r21438. Reports in IRC said it appeared somewhere between 3.0 and 3.1.

This patch adds does three related things:

- Adds *basic* support for seeking and buffering callbacks so different codecs may manage their buffer space differently
- Extends a few buffering and metadata structures to store information on two files rather than one
- Modifies the Wavpack codec to make use of these features to play back hybrid files with readable correction files losslessly.

This code should not in any way interfere with anything other than the situation where a Wavpack hybrid file is present AND its correction file is readable.

There are several things that need to be done before this patch may be committed:
1. Currently there are two ginormous linear buffers inside the Wavpack codec. They should be replaced with smaller dissimilarly-sized ring buffers.
2. The interspersal of primary and correction file chunks is currently 1/1/1/1. This should probably be more like 1/3/1/3 as that better matches the size rations of a .wv to its .wvc.
3. seek_wavpack needs to support seeking where rebuffering is required.
4. The wavpack hybrid decoding function needs to be modified to decode smaller chunks in a go so that the small ring buffers mentioned above won’t overflow.
5. Gracefully handle the end of a hybrid lossless file (currently it freezes the sim)

The uisimulator cannot be build by using the source of the latest version on MinGW.

I send this bug’s patch.

It is necessary to apply the patch of FS#10021 to build the firmware on MinGW.

Add support for two new scroll styles, STYLE_NODRAW and STYLE_CUSTOM, with STYLE_CUSTOM causing the draw to be done via a hook (set with lcd_set_style_hook). lcd_puts_stroll_style_offset also returns a struct scrollinfo pointer. This may be used in conjunction with STYLE_NODRAW to redraw the scrolling text in a plugin which draws other graphics to the same part of the screen, by drawing the text using the offset in the struct scrollinfo after the background graphics have been drawn. My latest patch from  FS#4817  is required, as it consolidates styled text drawing in one function, making it easier to replace the normal draw with a call to the hook, and reducing the binsize impact of this feature as well.

Support for core text scrolling in PictureFlow plugin to follow .

Seems pretty self-explanatory

The attached patch enables simultaneous buffering of multiple files in a minimally intrusive way. It also contains code to allow the playback of Wavpack hybrid files, both lossy and lossless. In the event that a Wavpack file is not a hybrid file, only original code paths are used. This patch will not affect users who do not use this file type.

How it works:
A handle may now be marked as "chunky". If a handle is so marked, adding a new handle will NOT reserve space in the buffer for the remaining portion of the file. Instead only a small amount of space (currently 2*BUFFERING_DEFAULT_FILECHUNK) is reserved. Additional checking is also added to ensure that buffer_handle will not allow one handle to overflow into another; in the event that a handle's widx would cross into the next handle's header, the handle is "extended" by calling add_handle a second time and linking from the original via file_next. Thus, there are two paths to iterate from a "chunky" handle - the next handle in the buffer layout (h→next), or the next handle containing data from the same file (h→file_next).

Key new methods:
extend_handle: used to create more space for a handle which is active but would overlap its successor if widx were advanced
clean_handle: remove pieces of a handle marked as "invalid", but don't remove the whole handle (as close_handle does)
bufopenchunky: as bufopen, but for a chunky handle
finish_handle: reserves either some or all space for a handle in the buffer
finish_chunky_handles: finishes all chunky handles

What works:
- Playback of lossless hybrid mono and stereo files in the sim functions mostly as expected. Occasional segfaults may occur - these are probably a thread safety issue. Trying on a unicore target would be productive.
- The functionality of any of rockbox other than hybrid wavpack files is not impaired
- Playback on an iPod 5.5G works as well, but is not yet real-time (apparently the hard disk isn't fast enough to buffer both files and keep up with playback, so priority should be given to the .wv file to fix this)
- Buffer space utilization is very efficient, the only waste is caused by the 300 bytes per struct memory_handle created. This could be minimized by only storing ridx, widx, and data in a minimal memory handle and copying the rest of the information to file_next as necessary (this is how open file descriptors are currently handled)

What doesn't work:
- Seeking does not always work, although seeks not requiring a rebuffer are usually OK (even those which must cross into file_next!). Especially unlikely to work is backwards seeking. This is because the Wavpack codec uses approximate seeking, which is fine when you don't have to worry about only one file but falls apart when you need to have the same block in both the wv and wvc files.
- Segmentation faults, especially at the end of very large hybrid files. These are almost all caused by the Wavpack codec in apps/codecs/libwavpack/words.c's response to reading extra 0 bytes. Wavpack does not check the validity of wvbits.ptr before reading from it! When combined with any error at all in the buffering code, or even any corruption in the input files, this leads to a segfault! There are also some issues in the original Rockbox buffering code. For example, in rebuffer_handle, h→next is used without first holding llist_mutex. This is a thread safety issue. On top of these, there's a bounds check I've missed somewhere in apps/buffering.c which can cause buffer corruption.

Most of the Wavpack decoding methods here were ported from those on http://wavpack.com with minor modifications. These files are under the GPL.

This patch contains commented printf statements as partial documentation and in case someone wishes to trace the flow of execution in the simulator.

Hello! I made this patch to add a separate backlight setting for the viewer plugin. By default the viewer plugin use Rockbox global backlight setting. For battery life, the backlight length would be usually too short in viewer, since reading a page may take more than 10 seconds. Bring the backlight on again by pressing buttons or wheel could be painful since it may cause unwanted effects (e.g. scroll to top/bottom of the text).

I added two options: Use global setting (default) and Always on. When setting to "Use global setting", everything should remain the same as before. When setting to "Always on", the backlight should never dim off. Changing the option during reading will immediately applies effect. I use the helper functions "backlight_use_settings" and "backlight_force_on" to achieve this.

Warning: since I changed the preference struct, after installing the new viewer.rock, all previous viewer setting will be abandoned and revert to default settings. You can backup your old viewer.dat (36 bytes), wait the new viewer.dat (40 bytes) be generated, and overwrite the first 36 bytes from the old viewer.dat to restore the setting. I don't know if there is a painless way for the transition. Suggestions are welcomed.

Thank you!

A new background image for bubbles that looks a lot better.
Made using GIMP and images from frozen bubble.

Copy the attached file to ‘apps/plugins/bitmaps’.

The patch makes Rec+Vol{Up,Down} in wps and list (main menu) contexts chage backlight brighness. Just like with volume, brightness value is saved in config file. I find this feature quite useful when player is used both indoors and outdoors, eps. on sunny days.

Keymap changes are for Sansa C200 only. Check apps/keymaps/keymap-<you-target>.c and add necessary lines to button_context_{standard,wps} if you use different device.

Diff against SVN revision 22666.

Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Changed controls: moving selection to the left/right by minus/plus buttons, moving selection to the down/up by holdminus/holdplus buttons, choice symbol by the menu button, backspace - long holdmenu button (at release moment), moving cursor left/right by holdminus/holdplus buttons (at release moment), confirm by holding plus button (at release moment), abort by power switch.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can’t post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added movement left/right through the date/time fields by the holdminus/holdplus buttons.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can’t post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

(Replacing  FS#10527 )
Peakmeter on ipod video 5g uses too much CPU, such that audible glitches occur during even flac/wav decoding .

This is a very early patch to enable USB on the mini2440.

This patch let rockbox react on USB, but unfortunatly i dont get further then the first reset interrupt from USB. Something in the init has to be wrong, so i dont get ep0 interrupt which should follow the reset.

Because of this problems, no attempt has been made to implement the acutal data transfer functions.

If someone wants to step in and debug.. feel free !

This patch adds a secondary backlight timeout (similar to what the the iPod OF does).

It adds two extra settings: secondary backlight timeout and secondary brightness (I'm not sure wrt the naming of those, any suggestions?)

The code isn't very clean, but it works (except for CONFIG_BACKLIGHT_FADING == BACKLIGHT_FADING_PWM targets, for which I haven't implemented this).

Please test this.

I have started an discussion about the virtual keyboard in the mailing list.

In my opinion the text_editor’s control should be similar to the calculator:
- use the whole screen (no tiny font)
- support for touchscreen (raster map)
- separate characters into categories

I adjust the calculator plugin to show my concept.

to reproduce:

1. start a big (20mb or more) track. delete it immidiately after starting it.
2. let the song play until it stops. i guess it stops at the end of the buffer. as an alternative you can ff to the end of the track (which shouldn't be buffered)
3. now you're not able to play any track. if you select a new one from the file browser or database, the wps will show up, but nothing is played and the progress bar won't progress. ff and rw also don 't work. only rebooting helps. shutting down needs really long (~15s).

if you delete a fully buffered song, everything works as expected (well, the song continues till the end, and the next song starts. some devs call that "expected" :D ).

tested with r24091 and an e200, although i guess that the bug is target independent and occurs in the last few thousand revisions :)

if bookmark=ask is set and the mpeg is stopped, the user is asked for pressing select (for make bookark) or any key (for discard)
on apple devices: if the clickwheel is used for discarding, the bookmark is not set (as intended) but the clickwheel is not working anymore.
to get the clickwheel working again, the keyboard lock has to be set and unset and select has to be pressed.

during my research on FS#10883 i found out that it would be better do disable slide actions on ipods for yes no decisons. slides are too easy done and often cause an unwanted abort.

this patch solves this issue by only accepting pressed keys for abort actions. the solution for FS#10883 has been appended on the bug report seperately.

This patch enables changing the fractal's colors.

Currently, not all targets have proper keymaps defined. This is a work in progress.

I would appreciate any comments.

This patch tries to avoid the \opt / \nopt hell in manual's tex files, by concentrating all different action definitions together in the platforms keymap file.

Current patch contains changes only to the jpegviewer plugin, in order to demonstrate functionality. Please provide feedback before I spend a lot of time converting all other locations in the manual to this proposed form.

I think this way of organizing keymap assignments is better because it is neater, and each platform has its button assignment all in one place. Adding new platform is much easier this way.

The patch also use one keymap file to all ipod brands, because they are similar to each other (the ipod4g adds some keymappings, but it doesn't matter if they are defined in other ipod brands).

Screenshots in the manual are nested into a 'figure' environment, but the only purpose of this is to be able to have a caption. The floating feature of 'figure' by using the placement attribute 'H' (='Here!').

This patch makes screenshots non-floating while keeping captions below the images. This is done via the LaTeX package 'caption2'.

Placement attribute for figures is set back to the LaTeX default so that figures can really float should we need it.

This patch adds a per-thread runtime variable which indicates the ticks the particular thread has been running.

This can for example help identifying threads that occupy the CPU for a long period of time.

Emuriver is an emulator (not simulator) for iriver ifp-7xx series. It’s part of the http://www.rockbox.org/wiki/IriverIfpPort and has until now been hosted at the main author’s (Tomek’s) site http://www.mimuw.edu.pl/~tmal/rockbox/ It includes a tool to create flash images for use with the emulator, and a tool to mount such images and do basic file management on them.

This version is almost identical to the last version from Tomek’s site, but I had to fix a few bugs to make it usable on my system. Changes are as follows:

flashimgtool.c: Outputs usage information on errors. (I didn’t do this; I don’t know where this code came from but it’s useful.)

hardware.c: Bug: Arguments were missing in a function call which would sometimes cause segmentation faults, and (I don’t know why or how) slow down the emulator.

main.c: Changed a default file name from prog_flash.bin to prog_flash.img (I didn’t do this)

main.c: Bug: Added explicit return value to nonvoid function. The implicit return value was sometimes -1 which indicated an error so emuriver aborted.

make_flash_img.c: Optimizations: “if” replaced with “else if”. (I didn’t do this)

uicurses.c: Rename a variable into someting more unique. (I didn’t do this)

The reason I’m submitting this patch is that I think the emulator could be useful as it is for those trying to build the ifp port from SVN, that it could (maybe) be worked on to support other players, and that my bugfixes should be included for those building emuriver.

There are a few issues: The flashimgtool subdir in emuriver duplicates a few (three years old) files from RB, disk.c, fat.c, and some more. You might not like the directory structure. It uses an ancient version of autotools. I haven’t been able to create flash images that actually work with flashimgtool. I haven’t built the RB port for ifp yet, so I don’t know if it will run in emuriver or not.

Yes I have discussed the patch in IRC.

This patch implement alternative hold mode, mentioned in FS#10698.
To enter this mode you must:
1) switch hold button to on position(this results in normal hold mode).
2) press menu button.
3) switch hold button to off position
4) release menu button
To leave alternative model:
1) switch hold button to off position
2) press menu button
3)switch hold button to on position
4)release menu button(now you in normal hold mode)

Additionally I implement simple keymap which working only in wps contex:
if hold button off:

 Plus button increase volume

This is actually release 3.5.1

I have quite a few low bitrate .wma audio files that play fine in the original firmware, play fine in VLC, but skip, stutter, and hiss in Rockbox.

The file is 20kbps, 22 kHz, mono, Windows Media Audio V2.

I have attached a sample cut from a larger file. Like the original files, it plays fine in the original firmware and in VLC.