|
11665 | Patches | LCD | Very Low | LCD functions ignore viewport bg_pattern if a backgroun... | 2010-10-11 | Jonathan Gordon | 2010-10-11 | 2 |
Task Description
at least in the 16bit lcd drivers, all functions which use transparency (or clear pixels) get the pixel colour from the backdrop image, completly ignoring the bg_pattern.
This isnt a problem except in skins where it is perfectly reasonable to want a background image for most of the screen but a solid colour for one or two viewports.
There is a tiny problem though, bg_pattern is set to LCD_DEFAULT_BG which is a valid colour, so we probably need to add a flag to the viewport struct to say if it should ignore the background image or not.
|
|
12026 | Bugs | LCD | Very Low | iaudio m3: display/screen goes blank after a while and ... | 2011-03-23 | arne anka | 2011-04-03 | |
Task Description
- iaudio both with 3.8 and build r29635
since 3.8 after a while the display blanks totally, no gui. only restarting the device makes it available again for a short screen, navigation is basically impossible.
|
|
9802 | Patches | Manual | Very Low | Plugin API documentation v2 | 2009-01-15 | Maurus Cuelenaere | 2009-01-15 | 1 |
Task Description
This is v2 of the Rockbox plugin API documentation generator.
See the mailing list for more information ( http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-01/0040.shtml ).
An example of what the output looks like is available here: http://mcuelenaere.alwaysdata.net/rockbox_api_example_3/
|
|
10850 | Bugs | Manual | Very Low | Manual: Code duplication | 2009-12-13 | Tomer Shalev | 2009-12-15 | |
Task Description
Duplicate table and some text found in manual/main_menu/main.tex in section Recent Bookmarks, and in manual/configure_rockbox/bookbarking.tex in section Bookmarking.
These duplicate code sections should be joined, and the two files should share it.
|
|
10979 | Patches | Manual | Very Low | Manual: Have all keymap actions defined in one place fo... | 2010-02-07 | Tomer Shalev | 2010-02-09 | 1 |
Task Description
This patch tries to avoid the \opt / \nopt hell in manual's tex files, by concentrating all different action definitions together in the platforms keymap file.
Current patch contains changes only to the jpegviewer plugin, in order to demonstrate functionality. Please provide feedback before I spend a lot of time converting all other locations in the manual to this proposed form.
I think this way of organizing keymap assignments is better because it is neater, and each platform has its button assignment all in one place. Adding new platform is much easier this way.
The patch also use one keymap file to all ipod brands, because they are similar to each other (the ipod4g adds some keymappings, but it doesn't matter if they are defined in other ipod brands).
|
|
11005 | Patches | Manual | Very Low | Manual: FFT plugin entry & basic conversion script | 2010-02-12 | Delyan Kratunov | 2010-02-12 | 2 |
Task Description
This is a first attempt at creating an entry for the new fft plugin. The button table was automatically generated with the attached python script.
The script takes a file (or - for stdin), looks for an #ifdef CONFIG_KEYPAD….#endif block and if it finds one (and it is relatively simple), it parses it and creates the corresponding LaTeX table.
The script is extremely simple but it does provide a good basis for further work.
|
|
11129 | Patches | Manual | Very Low | Make screenshots in the manual non-floating | 2010-03-19 | Alexander Levin | 2010-03-19 | 1 |
Task Description
Screenshots in the manual are nested into a 'figure' environment, but the only purpose of this is to be able to have a caption. The floating feature of 'figure' by using the placement attribute 'H' (='Here!').
This patch makes screenshots non-floating while keeping captions below the images. This is done via the LaTeX package 'caption2'.
Placement attribute for figures is set back to the LaTeX default so that figures can really float should we need it.
|
|
11512 | Bugs | Manual | Very Low | backlight fade in and fade out times missing from confi... | 2010-08-01 | Alex Parker | 2010-08-01 | |
Task Description
A couple of config file options are missing from the manual appendix:
e.g.
backlight fade in: 2000 backlight fade out: 10000
|
|
11672 | Bugs | Manual | Very Low | manual, sansa clip+: No keys for actions | 2010-10-12 | Timo Paulssen | 2011-06-10 | 1 |
Task Description
On page 51, which is in Section 6.8, there is a table for keys/actions. The Key column is completely empty, though.
On page 77, in Section 11.1.1, the blackjack game plugin, there table is similarly broken. Same for BrickMania in Section 11.1.2. Chessbox, in section 11.1.4 has a similar problem with only the "direction keys" being in the table. There are many more games with this problem.
This is for a manual I downloaded 2010-10-11.
Thank you for your attention.
|
|
11744 | Bugs | Manual | Very Low | warning about \float@addtolists when building manual | 2010-11-08 | Marcin Bukat | 2010-11-08 | |
Task Description
(./version.tex)) [2] [3] 1.
Class scrreprt Warning: \float@addtolists You should use the features of package instead of Support for \float@addtolists may be removed `scrreprt’ soon .
This is the warning text I get. We should probably update the syntax before it get broken.
|
|
11972 | Bugs | Manual | Very Low | touchregion changes arent in the manual | 2011-02-28 | Jonathan Gordon | 2011-03-02 | |
Task Description
recent %Tl and %T changes need adding to the manual… didnt want to fiddle with the table.
The change is now that both those tags accept as their first param a label which links them.
%T(foo, 0,50,25,25, volup) %?Tl(foo, 1)<helllo|goodbye>
So that conditional will only go true when that foo region is pressed. the label is optional on both, if it is missing on the %Tl then it acts as now (timeout since last press on anywhere on the screen)
|
|
12260 | Bugs | Manual | Very Low | skinned lists tags needs adding to the manual | 2011-09-06 | Jonathan Gordon | 2011-09-06 | |
Task Description
see http://svn.rockbox.org/viewvc.cgi?view=rev;revision=30461 and http://www.rockbox.org/wiki/Main/CustomWPS#Drawing_the_lists_using_a_skin and bug me on IRC when someone finds the time to add it. hopefully the wiki has enough info though - Jd
|
|
12491 | Bugs | Manual | Very Low | [clip v2] version is attached to the player name wich c... | 2011-12-28 | Jean-Louis Biasini | 2011-12-29 | 1 |
Task Description
2. Installation Installing Rockbox is generally a quick and easy procedure. However before beginning there are a few important things to know. 2.1. Before Starting Supported hardware versions. The Clip v2 is available in multiple versions…
this should read :”The Clip is available in multiple versions…”
|
|
12530 | Patches | Manual | Very Low | Add a note and a warning about the location for recordi... | 2012-01-10 | Alexander Levin | 2012-01-12 | 1 |
Task Description
The location for recordings can be set, but the only way to see the current value for the setting is to look into the config file. The patch adds a note stating that to the manual.
Also, there is a known bug ( FS#12517 , FS#12500 ) preventing saving the recorded files in the root directory (maybe this applies only to some targets, not all). The patch adds a warning about that.
|
|
12549 | Bugs | Manual | Very Low | Addittion info in manual about using talkclip for short... | 2012-01-19 | Marek Salaba | 2012-01-19 | |
Task Description
Hello.
Can you somebody add some info about using talkclip for shortcuts.txt in manual section 5.14 Shortcuts.
I'd recommend replace this
"talkclip: <filename clip of a talk that speak When voice menus are enabled>"
for this
"talkclip: <filename clip with full path of a talk that speak When voice menus are enabled
(example /.rockbox/filename.talk)>"
I suggest this because I took a long time before I figured out how it should be properly.
|
|
12603 | Bugs | Manual | Very Low | "root menu order" item missing from "Config file option... | 2012-02-28 | Thomas Martitz | 2012-02-28 | |
Task Description
All settings should be listed there (even more so settings which cannot be set through the UI), but root menu order is only described in advanced_topic/main.tex as of now.
|
|
12827 | Bugs | Manual | Very Low | Rockbox Utility cannot generate voice files when instal... | 2013-02-15 | A. Lester Buck III | 2013-02-15 | |
Task Description
This is basically a documentation update. For several years I generated accessibility voice files on my devices. Then one day I was reinstalling and it would generate a lot of the voice files but die from a weird error. For more than six months I combed the manual and the forums, trying to figure out what had changed, trying to debug it myself. Eventually I stumbled across the problem. I had noticed the “install on player” option in Rockbox Utility and started generating voice files while running from the player. Once I switched back to running Rockbox Utility by launching the utility from my regular PC disk, everything worked again. I again looked for any warning about this in the manual, and didn’t find anything.
The simplest fix is to include something about this in the section on accessibility and generating voice files.
Another fix, probably not worth it, would be for the voice files to use system tmp space for intermediate files. I suspect that the recursive generation of talk files on player ends up in some infinite regression as it generates talk files for temporary files.
This probably happens on all players, but I only experienced it on the iPod Nano 1st Gen.
|
|
13038 | Bugs | Manual | Very Low | playlist viewer settings not present where described in... | 2015-03-16 | Björn Kautler | 2015-03-16 | |
Task Description
The manual says in page 31 chapter 4.3.3. that you can get to the Playlist Viewer Settings from the Playlist Viewer Menu (which should probably be named Playlist Viewer Context Menu), but there is no such entry on the actual player. Just via the settings menu from the main menu.
|
|
13083 | Bugs | Music playback | Very Low | Ipod Classic playback jumping | 2016-09-16 | Emanuel | 2019-10-24 | |
Task Description
Hi, I've been using the development version of Rockbox in my ipod classic 6th generation for about two years I think, but from some time, like a month or two, I'm experiencing playback issues as the track I'm listening suddenly skip forward or backward, or even jump for a few seconds on another mp3 file inside the ipod I was just listening before. I don't think is a ipod issue because I can listen the file inside the ipod with my computer player without problems.
There some way I can check older development revisions for the classic? It appears that it doesn't show in the dev build link on the site because is not fully supported. Thanks
|
|
13108 | Bugs | Music playback | Very Low | Random crashes when playing music | 2017-03-16 | somedude | 2017-12-16 | |
Task Description
For a couple of months my Sansa Fuze v2 has been crashing randomly when playing music. Most of the time I just get a white screen with an error message. The last message I got was :
'undefined instruction at 0006DC8C'
(I think that last number varies at each crash)
This didn't happen with v3.13, but it's been happening with every daily build I've tested IIRC.
It doesn't happen very often so it's hard to reproduce. I listen to music in public transports about twice a day and this happens not more than once a week. It seems to happen more often when the battery is low (less than 10%). It generally happens early in a playback session, when the first or second track is played.
Sometimes I don't get a white screen, but the program freezes and some parts of the interface are surrounded with white frames. I don't know if it's the same bug or if it's unrelated.
Note that I'm always listening to music on a microSD card, and I haven't tried on the main memory.
PS: I chose "Sansa Fuze+" in the OS list because I couldn't find Sansa Fuse v2.
|
|
13011 | Bugs | Music playback | Very Low | MPIO HD300 volume keys locked after a Hold ON - Hold OF... | 2014-11-02 | sandor | 2014-11-02 | |
Task Description
Hi.
I noted a strange bug on mpio hd300 player. 2/3 of the times ,when i lock the player with HOLD ON button, and return to HOLD OFF, the volume keys do not work anymore,however, the others keys works OK (menu, FF,REW,PLAY and REC). only after a reset, these keys (volume) works again.
The release of RB is 3.13
I try other releases, from 3.11 to 3.12, and the problem is the same.
thanks
|
|
13066 | Bugs | Music playback | Very Low | ibasso dx90 When playing music sometimes crackling soun... | 2016-02-04 | yong xu | 2016-02-04 | |
Task Description
When playing music sometimes crackling sound especially when playing bass
|
|
13118 | Bugs | Music playback | Very Low | Incorrect playback position when seeking AAC files down... | 2017-05-31 | R O | 2017-05-31 | |
Task Description
I downloaded this: https://www.youtube.com/watch?v=Lrb0dHKJBR4 using the youtube-dl python program. The file plays and seeks correctly in foobar2000 and MPC-HC. But, on my clip+, whether I seek 10 seconds or 10 minutes into the file, it ends up playing a position of the file previous to the one displayed. For example, if I seek 50 seconds forward from the beginning, it will play the file from the start, while the screen still displays as if it's playing from 50 seconds onwards. Seeking to the end of the file will have it play a section from about 2 minutes earlier than it should be, while the time display and music will continue until 1:14:20, with the file actually being 1:12:46.
I did not hear the files being played slower than they should be, so it seems it's only an issue when seeking.
I've confirmed this happens on every AAC file downloaded by youtube-dl, and that re-encoding the same file to AAC using NERO encoder makes the problem dissapear.
|
|
13158 | Bugs | Music playback | Very Low | Unable to play for ibasso dx 90 | 2018-05-23 | yong xu | 2018-05-23 | |
Task Description
Click on the music file and die
|
|
12958 | Bugs | Music playback | Very Low | data abort crash when toggling crossfeed from quickscre... | 2014-03-06 | alexbobp | 2014-03-18 | |
Task Description
Using release 3.13 on the clip zip, if I were to put the main crossfeed setting on the right button of the quickscreen, it would cycle through to custom but then stop. If I use the left button of the quickscreen, then after custom there is a data abort crash.
Using build c64b59f-140304, both the left and right quickscreen buttons work to cycle through all 3 settings for crossfeed, but I can still trigger the crash if I use the left button. It seems to be sporadic and timing dependent, because if I click through the options quickly it works fine, but if I slow down and hold the buttons for longer at a time then it will eventually trigger.
Here is a picture of the crash: http://i.imgur.com/wS1CqVr.jpg The text is: Data abort at 30800E FSR 0x8 (domain 0, fault 8) address 0xB00Fb5D pc:30800BA8 sp:300<snip> the screen is too narrow, here bt end
|
|
13055 | Bugs | Music playback | Very Low | In "Database -> Album Artist" songs sorting by alphabet... | 2015-09-15 | Anton Iliyn | 2015-09-15 | |
Task Description
Expected sorting by artist name, then by album and then by track number, but now all songs by all artists sorting by track names in alphabetical order.
|
|
13088 | Bugs | Music playback | Very Low | Ibasso DX90 Crackling last FW | 2016-11-01 | aditya | 2016-11-01 | |
Task Description
When playing music sometimes crackling sound exist but after 5-6 secs playing it dissappear i tried to update until the last rockbox firmware (ver.b045e4d date 2016-11-01) the problem still there
but if i boot to mango (stock fw) no crackling sound remains
Device : Ibasso DX90
|
|
13106 | Bugs | Music playback | Very Low | Resume Playback broken on iPod Classic | 2017-02-17 | Tony Carter | 2019-10-24 | |
Task Description
After upgrading from "Version: 33856d9-161111" to "Version: 6436c6e-170211" Resume Playback from the main menu does not work. Here are the steps taken to verify the problem:
Running Version: 6436c6e-170211… Reset config Using default settings, enabled Shuffle via Shortcuts Started playlist; track identified as 1 of 5330 Skipped ahead to the 5th track Paused @ 1:01 Forced shutdown Enabled Hold switch Waited ~1 min., then booted via disengaging Hold switch Clicked Resume Playback… resumed on the same first track (1 of 5330) This behavior occurred every time I attempted to Resume Playback.
Restored previous version (Version: 33856d9-161111) Rebooted Reset Settings Using default settings, enabled Shuffle via Shortcuts Started playlist; track identified as 1 of 5330 Skipped ahead to the 5th track Paused @ 1:01 Forced shutdown Enabled Hold switch Waited ~1 min., then booted via disengaging Hold switch Clicked Resume Playback… resumed on the fifth track @ 1:01
FWIW: No Bookmarking used (never have). Database not initialized (never use it).
|
|
13122 | Bugs | Music playback | Very Low | Annoying beeps when playing ogg vorbis files | 2017-07-04 | Jérémy Caruso | 2017-07-04 | |
Task Description
After upgrading from 3.13 to 3.14, when playing most of the ogg vorbis files in my library, a "beeping" sound sporadically occurs.
The sound is random (2 consecutive playbacks of the same track will beep on the same time).
All the files played fine with 3.13. MP3 files play just fine (I have not tested other formats yet).
Possibly interesting facts : Vorbis files with a lower bitrate (<100kpbs) seem to be less subject to this beep. It seems beep never occurs when screen is on.
|
|
482 | Feature Requests | Music playback | Very Low | "Single" playmode | 2002-10-27 | | 2020-05-24 | |
Task Description
HI, is there a way that you could add a “Single” playmode, so it stops after playing one song, instead of repeating all, or repeating single? That way, it could also be used as an “auto-off”, where it shuts off after one song. Also, and maybe this isnt possible, but you could have an option to play X number of songs and then stop, where the X is configurable.
|
|
6083 | Patches | Music playback | Very Low | Announcing tracks (DJ feature) | 2006-09-28 | Jonas Häggqvist | 2008-12-16 | 1 |
Task Description
This patch was meant to add a DJ type feature, that would announce each song if a “.talk” clip exists for it. Unfortunately, it’s not as simple as calling talk_file() each time the track changes, because that breaks playback because of CPU inadequacy. Works mostly fine for WAV files though.
The solution is probably to halt playback until the clip has been played, but that’s beyond me.
I have not added a settings interface to this, since the feature is really very incomplete. I’d love if someone would pick it up from here though.
|
|
8029 | Bugs | Music playback | Very Low | Selecting a buffered track in the current playlist forc... | 2007-10-26 | Steve Bavin | 2009-07-02 | |
Task Description
Recipe: 1) Play an album. Wait until buffering completes. 2) Skip from track 1 to track 2. No buffering occurs. 3) Skip from track 2 to track 1. No buffering occurs. 4) In the playlist viewer, select track 2. Rebuffering occurs, even though the track is buffered.
The same problem occurs in the opposite direction (e.g. after step 2, it should be possible to switch to track 1 using the playlist viewer without rebuffering).
|
|
8396 | Patches | Music playback | Very Low | next_dir within playlist | 2008-01-03 | Lee Kang Hyuk | 2008-06-29 | 8 |
Task Description
This patch is inspired by FS7571.
Currently we can move to next/prev directory with <short left/right + long left/right>. This patch changes two part of this functionality:
1. If <Auto-Change Directory> is not enabled, move to first track of current/next directory only within the playlist. So you can maintain dynamic playlist. This was very annoying problem for me.
2. do not wait till <long left/right> is released.
So ffwd or rewind will not be performed at new track.
|
|
8867 | Bugs | Music playback | Very Low | Equalizer is adding high noises | 2008-04-10 | André Scheffler | 2008-04-10 | 1 |
Task Description
The (software-)equalizer is adding high noises to the playback.
I made a recording, the first part with eq enabled the second one with disabled equalizer.
I could also make a test on my older H110, on which I never used the sw-eq though.
|
|
9064 | Bugs | Music playback | Very Low | iRiver H340 skips when battery low | 2008-06-02 | Antony Stone | 2008-08-05 | |
Task Description
- What behaviour you are seeing
Rockbox 17612-080523 on an iRiver H340 skips entire tracks, and also skips within tracks, when the battery level falls below 30%
- What behaviour you expected
No skipping.
- How to reproduce the bug
Allow the battery level to fall below 30% and start playing a directory of files. Some files will be skipped, some files will have parts skipped in the middle.
- The SVN revision you are using and if possible the particular SVN revision in which you think the bug was introduced.
17612-080523, no idea when the bug started.
If you need any further info on this bug, please ask and I’ll give more details. I have no other hardware to test whether this behaviour occurs on other Rockbox platforms.
|
|
9332 | Patches | Music playback | Very Low | Read audio data directly from flash memory | 2008-08-28 | Nicolas Pennequin | 2010-01-25 | 7 |
Task Description
This patch provides a replacement for buffering.c, where there is only minimal buffering (one 32K buffer for audio data and some static buffers for metadata). It is a proof of concept for how this could work on targets with very little RAM.
I would be interested in feedback on the kind of impact this has on runtime, so if you have a flash target please consider giving it a try and reporting your results :)
Note that you will need to disable album art in your build for this to work. I don't even know what would happen if you don't, but it'd probably be bad. To disable it you need to comment or remove the #define HAVE_ALBUMART line in your target's configuration file (firmware/export/config-[TARGET].h).
|
|
9427 | Bugs | Music playback | Very Low | Playback from cuesheet not scrobbled | 2008-09-28 | kf | 2010-08-12 | |
Task Description
Tracks played via a cuesheet are not recorded in .scrobbler Last.fm log.
|
|
9628 | Bugs | Music playback | Very Low | Sound sometimes doesn't work on mr100 if booted without... | 2008-12-12 | Frank Gevaerts | 2008-12-12 | |
Task Description
Tested with r19410
If I boot with the headphones plugged in, sound always works (at least I didn’t have it fail yet). If I boot without headhones plugged in, and plug them in later, sound often doesn’t work. This may also depend on whether the player was turned off for a long time, whether the previous boot was USB mode, and whether the headphones were unplugged before or after shutting down.
|
|
9719 | Bugs | Music playback | Very Low | Playback skips and hangs badly on iPod Video 80GB on st... | 2008-12-27 | Jeremy Cayot | 2011-09-26 | |
Task Description
This is a recurring problem with this target it seems. With 3.1 installed and resume playback on start up enabled, playback hangs and skips badly while the hard drive is being scanned during start up.
The same behavior occurs when resume on start up is disabled, but playback is resumed by the user during the hard drive scan.
|
|
9765 | Bugs | Music playback | Very Low | "Beep" sounds very distorted and fuzzy. | 2009-01-06 | mike beauchamp | 2009-01-08 | |
Task Description
After upgrading from 3.0 to 3.1, the “Beep” sound (enabled in Settings / Playback Settings / Beep Volume) now sounds very distorted and fuzzy.
It sounds this way on any setting. Strong, Moderate or Weak and with the player’s volume on any setting. It definitely sounded like a normal clean beep with 3.0
This is on an 80gb Ipod 5.5 with Rockbox r19569-081223
I’m not sure if this should be under “Music Playback”, as I don’t seem to hear the distortion and fuzziness when playing mp3’s.
Mike
|
|
9775 | Bugs | Music playback | Very Low | Premature and multiple storage_sleep() in buffering.c | 2009-01-10 | Boris Gjenero | 2011-11-11 | 1 |
Task Description
While examining disk performance with FS#9708 , I found one album where the disk stayed spinning with no activity for 5 s longer when using PIO. This is repeatable with that particular album. With the downloaded r19739-090109 build, this did not happen with the default settings but it started happening as soon as I enabled dircache. Prolonging the disk timeout prolongs the extra sleeping time.
Experimentation with shows that the storage_sleep() part of fill_buffer() (in apps/buffering.c) is executed early in the buffering and it is not executed at the end. With another album where spindown happens properly, ata_sleep() is called twice. Note that ata_sleep() just sets last_disk_activity, and sleep happens over half a second later if there is no disk activity during that period and last_user_activity has timed out.
I think this is a race condition based on how dircache and transfer rates change things. I wonder if it is related to FS#9541 .
The data mentioned is located at http://spreadsheets.google.com/ccc?key=pkeRcfM0sg949P3a5EYXtew and the delayed spindown is seen in the EP7 PIO test. In that data, also note how sectors written are 5, 10 or 15, with differences between different tests with the same album.
I have a 30GB 5th generation iPod, but I expect this issue affects all SW-codec players.
|
|
10109 | Bugs | Music playback | Very Low | Directory skip hangs iaudio x5 | 2009-04-08 | philip kao | 2009-04-09 | |
Task Description
This IS a duplicate of FS#6904 .
My iaudio x5 hangs when changing directories via short+long direction button presses. It switches to the next directory, but no audio plays, and the WPS shows that it stops at 0:02 of the track.
|
|
10117 | Patches | Music playback | Very Low | Behaviour of PREV/NEXT when "skip length" > 0 and "prev... | 2009-04-09 | Alexander Levin | 2009-04-09 | 3 |
Task Description
I put up the three patches (before they expire on pastebin.com) that correspond to the three proposals of how the behaviour of PREV/NEXT could/should be changed. Note that only the situation described in the “subject” of this task is considered and changed.
The IRC discussion is at http://www.rockbox.org/irc/log-20090406#21:35:42
The start of the discussion on the mail list is at http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-04/0057.shtml
|
|
10320 | Patches | Music playback | Very Low | Timestretch: Update algorithm | 2009-06-12 | Thomas Martitz | 2010-01-08 | 1 |
Task Description
In FS#8894 (the original timestrech task), an updated version of the algorithm was uploaded.
The author said it performs and sounds better, so we should try to incorporate it.
I've tried building it, but I can't get a useful result, but I'm also not sure if I used it correctly. I used ./scale 2 < in.wav > out.wav. The result wasn't streched, but had crackling noises every few seconds.
|
|
10434 | Patches | Music playback | Very Low | Rudimentary support for codec-specific buffering | 2009-07-12 | Bryan Jacobs | 2009-07-12 | 1 |
Task Description
This patch adds does three related things:
- Adds *basic* support for seeking and buffering callbacks so different codecs may manage their buffer space differently - Extends a few buffering and metadata structures to store information on two files rather than one - Modifies the Wavpack codec to make use of these features to play back hybrid files with readable correction files losslessly.
This code should not in any way interfere with anything other than the situation where a Wavpack hybrid file is present AND its correction file is readable.
There are several things that need to be done before this patch may be committed: 1. Currently there are two ginormous linear buffers inside the Wavpack codec. They should be replaced with smaller dissimilarly-sized ring buffers. 2. The interspersal of primary and correction file chunks is currently 1/1/1/1. This should probably be more like 1/3/1/3 as that better matches the size rations of a .wv to its .wvc. 3. seek_wavpack needs to support seeking where rebuffering is required. 4. The wavpack hybrid decoding function needs to be modified to decode smaller chunks in a go so that the small ring buffers mentioned above won’t overflow. 5. Gracefully handle the end of a hybrid lossless file (currently it freezes the sim)
|
|
10537 | Patches | Music playback | Very Low | Multifile Buffering and Wavpack hybrid support | 2009-08-17 | Bryan Jacobs | 2009-08-17 | 1 |
Task Description
The attached patch enables simultaneous buffering of multiple files in a minimally intrusive way. It also contains code to allow the playback of Wavpack hybrid files, both lossy and lossless. In the event that a Wavpack file is not a hybrid file, only original code paths are used. This patch will not affect users who do not use this file type.
How it works: A handle may now be marked as "chunky". If a handle is so marked, adding a new handle will NOT reserve space in the buffer for the remaining portion of the file. Instead only a small amount of space (currently 2*BUFFERING_DEFAULT_FILECHUNK) is reserved. Additional checking is also added to ensure that buffer_handle will not allow one handle to overflow into another; in the event that a handle's widx would cross into the next handle's header, the handle is "extended" by calling add_handle a second time and linking from the original via file_next. Thus, there are two paths to iterate from a "chunky" handle - the next handle in the buffer layout (h→next), or the next handle containing data from the same file (h→file_next).
Key new methods: extend_handle: used to create more space for a handle which is active but would overlap its successor if widx were advanced clean_handle: remove pieces of a handle marked as "invalid", but don't remove the whole handle (as close_handle does) bufopenchunky: as bufopen, but for a chunky handle finish_handle: reserves either some or all space for a handle in the buffer finish_chunky_handles: finishes all chunky handles
What works: - Playback of lossless hybrid mono and stereo files in the sim functions mostly as expected. Occasional segfaults may occur - these are probably a thread safety issue. Trying on a unicore target would be productive. - The functionality of any of rockbox other than hybrid wavpack files is not impaired - Playback on an iPod 5.5G works as well, but is not yet real-time (apparently the hard disk isn't fast enough to buffer both files and keep up with playback, so priority should be given to the .wv file to fix this) - Buffer space utilization is very efficient, the only waste is caused by the 300 bytes per struct memory_handle created. This could be minimized by only storing ridx, widx, and data in a minimal memory handle and copying the rest of the information to file_next as necessary (this is how open file descriptors are currently handled)
What doesn't work: - Seeking does not always work, although seeks not requiring a rebuffer are usually OK (even those which must cross into file_next!). Especially unlikely to work is backwards seeking. This is because the Wavpack codec uses approximate seeking, which is fine when you don't have to worry about only one file but falls apart when you need to have the same block in both the wv and wvc files. - Segmentation faults, especially at the end of very large hybrid files. These are almost all caused by the Wavpack codec in apps/codecs/libwavpack/words.c's response to reading extra 0 bytes. Wavpack does not check the validity of wvbits.ptr before reading from it! When combined with any error at all in the buffering code, or even any corruption in the input files, this leads to a segfault! There are also some issues in the original Rockbox buffering code. For example, in rebuffer_handle, h→next is used without first holding llist_mutex. This is a thread safety issue. On top of these, there's a bounds check I've missed somewhere in apps/buffering.c which can cause buffer corruption.
Most of the Wavpack decoding methods here were ported from those on http://wavpack.com with minor modifications. These files are under the GPL.
This patch contains commented printf statements as partial documentation and in case someone wishes to trace the flow of execution in the simulator.
|
|
10614 | Bugs | Music playback | Very Low | Deleting files in USB mode can confuse resume playback/... | 2009-09-23 | Alex Bennee | 2010-04-09 | |
Task Description
Steps to reproduce:
1. Start listening to a series of podcasts, say 1-5 2. After listening to >1 plug player into computer during playback of subsequent podcast 3. Delete the podcasts you have already listened to (not what your currently listening to) 4. Eject/Unplug player from computer 5. Attempt to resume playback
This fails for both resume and Recent Bookmarks functionality. I assume this is somehow tied in with playlist support as files from the playlist have been deleted.
Where does Recent Bookmarks keep it's information? Should the bookmark also keep the individual file referenced so it can resume in this case?
Tested on R21184M-090604
Will test on latest version once my main machine is back on internet.
|
|
10754 | Patches | Music playback | Very Low | Amend Sleep Timeout to Pause Timeout | 2009-11-02 | Sean Inglis | 2012-01-04 | 3 |
Task Description
Amend the sleep timeout behaviour to pause when the timeout matures.
This allows the idle timeout to power off the player if it remains untouched, or the sleep / pause timeout to recycle if the user unpauses before idle timeout kicks in.
|
|
10766 | Patches | Music playback | Very Low | Enable Binary Skip / Search as an option for Skip Lengt... | 2009-11-06 | Sean Inglis | 2010-08-15 | 5 |
Task Description
Adds “Binary Skip” to the skip length menu,
This allows navigation by means of binary search within a track.
If no search key is pressed for 5 seconds, the current binary search is considered as having “finished” and pressing a search key subsequently initiates a new binary search.
|
|
10874 | Bugs | Music playback | Very Low | no track will play after playing a deleted, semi-buffer... | 2009-12-24 | Johannes Linke | 2012-05-03 | 1 |
Task Description
to reproduce:
1. start a big (20mb or more) track. delete it immidiately after starting it. 2. let the song play until it stops. i guess it stops at the end of the buffer. as an alternative you can ff to the end of the track (which shouldn't be buffered) 3. now you're not able to play any track. if you select a new one from the file browser or database, the wps will show up, but nothing is played and the progress bar won't progress. ff and rw also don 't work. only rebooting helps. shutting down needs really long (~15s).
if you delete a fully buffered song, everything works as expected (well, the song continues till the end, and the next song starts. some devs call that "expected" :D ).
tested with r24091 and an e200, although i guess that the bug is target independent and occurs in the last few thousand revisions :)
|