|
11661 | Bugs | Plugins | Very Low | Messages and Heads up display fonts are unreadable in d... | 2010-10-09 | Christian Blackburn | 2016-11-29 | |
Task Description
While playing doom, I can definitely read the amount of ammo, shield status, and health of my character. However, I cannot read the messages like you need the key first to open this door. Also, if you set the screen size to the maximum and turn on the heads up display the font there is also illegible.
|
|
11655 | Bugs | Database | Very Low | Data abort In sansa Fuze v2 when I insert 2 albums to t... | 2010-10-05 | Haim | 2011-08-04 | 1 |
Task Description
In my sansa Fuze v2 build 28208 when I insert some album to the playlist and after that I insert another album to the playlist I got this error massege:
Data abort at 3001AE90 FSR 0x8 (domain 0, fault 8) address 0xB0166244
thanks!
|
|
11639 | Patches | Themes | Very Low | Android port: add theme downloader activity | 2010-09-22 | Maurus Cuelenaere | 2011-08-15 | 3 |
Task Description
This patch introduces 2 new activities, one which lists available themes for a specified target and another which lists more details and the option to install the specific theme. Currently this is more a proof-of-concept, as the communication with the theme server is handled by the same API RBUtil uses, which isn't perfect for the intended usage (e.g. offers no possibility to filter by screen size, only uses INI as output format, ..).
(this also includes some minor unrelated changes to the main Rockbox extraction functionality which won't be in the final patch)
TODO: - make translatable - better UI - uninstall/update functionality - show only themes fit for the displays' resolution - use different protocol to communicate with theme server to get rid of iniparser dependency (XML, JSON, .. ?)
|
|
11622 | Patches | Rbutil | Very Low | Improved Synthesis of talk clips for CamelCased files a... | 2010-09-11 | Steve Clarke | 2010-09-11 | 1 |
Task Description
The Rockbox utility generates its talk files and directory files using the filename and directory names.
If the filenames do not contain spaces, but are CamelCased, they are currently synthesized badly, for example: “I Do I Do I Do” gets pronounced eeedoyeeedoyeeedoy.
The patch to the rbutil/base/talkfile.cpp processes CamelCased filenames and directory names just before synthesis and produces much better sounding talk clips.
|
|
11619 | Patches | Music playback | Very Low | Restore pitch and speed settings on resume | 2010-09-10 | Frank Gevaerts | 2017-12-10 | 3 |
Task Description
This patch should save pitch and speed settings to nvram, and restore them after reboot if needed.
If I read the code correctly, there should be enough room in nvram (and anyway, the way this is done doesn't apply to any targets that actually use real nvram)
This code compiles, but apart from that it's completely untested.
Of course, since this patch increments the nvram data version, you'll lose resume info the first time you reboot.
|
|
11615 | Patches | Operating System/Drivers | Very Low | Dynamic screen size | 2010-09-07 | Maurus Cuelenaere | 2011-10-15 | 14 |
Task Description
This patch converts LCD_{WIDTH,HEIGHT} into variables, allowing Rockbox to change screen size at runtime.
I’ve tried to make the changes as less intrusive as possible, but still, there will be some binsize increases.
Most of the #if’s were converted to C if()’s which should be functionally equivalent (and if the compiler is smart enough, no increase in binsize should occur).
In order to use this, just define DYNAMIC_LCD_SIZE in your target config and compile without plugins (if the preprocessor spits errors, try clearing ENABLEDPLUGINS in your Makefile).
What still needs to be done: * figure a way out how to compile several rockbox logos into the binary and choose the correct one at runtime * do something about the hacks in apps/bitmaps/SOURCES and apps/settings_list.c * get the Android port working
|
|
11605 | Patches | User Interface | Very Low | Clip+ new keymap | 2010-09-05 | Michael Gentry | 2011-07-19 | 14 |
Task Description
Overview:
This adds the hotkey [short home], and allows you to stop/start play more or less anywhere [long home] which I find quite useful. Hopefully, it’s a little more consistent too, though it still needs a bit of polish.
Problems:
I’d quite like [short power] to stop play in the menus by calling ACTION_TREE_STOP, but unfortunately that only works for local files, not for the radio, which feels inconsistent. I’ve put in a feature request; http://forums.rockbox.org/index.php?topic=25657.0
The recording screen isn’t very consistent with the rest of the keymap - you can press [left] or [home] to get back to the menu, and [short power] and [right] both open the recording menu. This seems to be a peculiarity of the way the recording screen is designed, though I’ll try to improve it.
There is a ‘glitch’ in that when you press [long home] deep in the menus, it’ll sometimes jump through another menu before dropping back to the WPS / Radio screen.
Some users prefer to have a free button with which to turn the backlight back on - they are seemingly used to using [short down], which is bound to playlist here. However, if they don’t set the WPS hotkey, they’ll still have a ‘functionless’ button, so no functionality is lost.
I haven’t touched the HID part at all, because I have no clue what it does…
Details of major changes: WPS: [Long up] Pitch screen [Short down] Playlist screen [Long down] Quick screen [Short home] Hotkey [Long home] Stop
Pitch screen: [Short select] Cycle mode [Long select] Reset
Recording screen: (troublesome) [Short select] Start / pause [Short left] / [Short home] New file / exit [Short right] / [Short power] Recording menu [Volume] Adjust settings
Radio screen: [Short select] Scan / search [Long select] Presets [Short down] Radio menu
Built against r2799. All comments and suggestions welcome, and thanks for reading.
|
|
11599 | Patches | Simulator | Very Low | Make simulator able to emulate storage with a file inst... | 2010-09-03 | amaury pouly | 2010-09-03 | 1 |
Task Description
This patchs modifies the simulator so that it can emulate the storage layer. More preciserly, it enables all the storage code and simply redirect all storage_{read,write, …} to a file. This way, all fs functions used are the one of rockbox, which allows to debug the FAT code for example.
To run this, apply the patch and modify the makefile to add this: -DROCKBOX_SIMULATE_STORAGE_LAYER to the line: export GCCOPTS=….
When running the simulator, it expects to read from file simdisk.raw. You can change this by using the –root option: ./rockboxui –root <file>
The code doesn’t work for me, FAT code seems to choke on something for now, I’m not sure why.
|
|
11594 | Bugs | Music playback | Very Low | Last.fm scrobbling when nothing listened to | 2010-09-01 | Simon Olson | 2011-01-14 | 1 |
Task Description
The Last.fm scrobbler lists in the scrobble log songs that ive never listened to
|
|
11589 | Bugs | User Interface | Very Low | Early USB broken (no statusbar & crash after disconnect... | 2010-08-31 | Marianne Arnold | 2010-11-07 | 1 |
Task Description
This bug already stands for a while and was reported in IRC but since nothing happened so far, I’m going to report it here.
On targets with early USB (”usual” looking USB screen when plugging from off-state and probably only hardware bridge USB) the statusbar that should be there in the screen is missing and when you disconnect the player so that the “rest” of Rockbox would start, it crashes.
The address where the crash happens with the build currently flashed to my Ondio is in “lib/libskin_parser.a(skin_parser.o)” - more exactly “9035954: 8b fb bf 903594e <_skin_parse+0×152>”. I pastebinned the complete disassembly of the _skin_parse function here: http://pastebin.com/LZMNW96a .
I will also try to find the exact revision that introduced the bug but that’ll take a while. If I remember correctly it came with some statusbar skinning commit which is already a while ago now and crept up twice in a row (first was fixed, then it came back). Plus it is not the easiest and no quick task testing flashed builds on the Ondio….
|
|
11582 | Patches | Music playback | Very Low | Use Fastforward/Rewind (FF/RW) to skip tracks quickly. | 2010-08-29 | Chad Joan | 2010-08-29 | 1 |
Task Description
This patch adds an option to allow the Fastforward/Rewind buttons to be used to skip tracks entirely.
This is an itch of mine that I scratched and am offering up to others if you are interested.
I’ve been using audio lessons to learn Japanese and ran into issues navigating with the normal FF/RW buttons. The acceleration based on track length left me with no sense of time since I don’t keep track of how far I am into my 30 minute long lessons. Simply backing up 5 seconds to catch something I missed was a problem because I’d have to look at what I was doing to see how far I’d ff/rw. Kinda hard when one tick moves 30 seconds too. This is problematic when driving! The existing skip-length feature is really good for this. However, if I use that to skip 5 second increments then I abandon any way of skipping entire tracks. So I re-purposed the FF/RW buttons for skipping tracks and use skip-length for navigating within a track.
I’ve been using this in r27841 for about a week on my Gigabeat, but it seems like it should work for r27942 as well.
|
|
11564 | Patches | Themes | Very Low | new tag to talk other tags | 2010-08-23 | Jonathan Gordon | 2010-08-24 | 1 |
Task Description
This patch reimplements FS#11541 using the skin engine.
new skin tag %Vx(params) will talk whatever is in the params (unlimited….).. Params can be any string or other skin tag (no conditionals just yet). if the first option is - it will shutup anything currently talking. otherwise - is a voiced pause. otherwise the only special string is the word “text” which says to spell the next tag (used when the value of the tag is usable in a conditional, i.e %cP need talk or you will get “1” or “2” :/ ).
quick examples: %?mh<%Vx(-, %cl,-, %cM, text, %cP)> ← Talk the current hour, minute, am/pm when hold is toggled.
%?pE(15)<%?It<%Tx(-, %Ia, -, %It)» ← untested but should spell the next tracks title and artist when there is 15s left of the current track
|
|
11549 | Bugs | Utils | Very Low | Theme Editor doesn't render Vf/Vb correctly | 2010-08-18 | Sean Inglis | 2010-11-08 | |
Task Description
The following set of WPS tags demonstrates:
# WPS Document %wd %V(0,0,-,10,2)%Vb(000000)%Vf(FFF000) %aL%cH:%cM %ac%pv %aR%bt %V(0,11,-,30,2)%Vb(000000)%Vf(FFF000) %it
If you alternately insert and remove a space between the second occurence of %Vb/%Vf, the track title text appears and disappears. It appears to happen in a few other variations, but this is the shortest concrete example.
|
|
11545 | Patches | Games | Very Low | Chopper improvements | 2010-08-16 | Michael Marley | 2010-08-26 | 2 |
Task Description
This patch contains several improvements to the Chopper game designed to make it run with a high framerate instead of a low, jerky one. Previously, the game depended on sleeping for a number cycles before drawing another frame, causing very jerky motion. Now the game should run at a high framerate all the time. The gameplay should be about the same, at least on targets with a display of >64px. I don’t have any of these smaller targets, so I wasn’t able to test. Please tell me what you think of my changes.
|
|
11544 | Patches | LCD | Very Low | iPod Nano2G Display Vsync | 2010-08-15 | Michael Marley | 2010-08-15 | 1 |
Task Description
This patch enables display vsync on the iPod Nano 2G, currently only for the Type 1 (LDS176) display. It removes tearing and can make animation smoother. However, right now it uses an extremely CPU-unfriendly method of waiting for synchronization, which makes the display quite slow in some circumstances. I hope to implement DMA to copy the framebuffer, which should help somewhat. However, I am probably going to need some help to do this.
TheSeven gets all the credit for this patch, since he found where the Tearing Effect (vblank) signal was connected to the s5l8701 and wrote the vsync code. All I did was drop it into the display driver in the right spot.
|
|
11541 | Patches | User Interface | Very Low | Add Voice Announcement of Summary Info to WPS hotkey | 2010-08-15 | Sean Inglis | 2020-07-15 | 4 |
Task Description
This patch adds an additional menu option to the list of WPS hotkey choices, “Announce Information”. This voices basic information about the player, currently playing file and current tracklist.
This feature reads a simple definition with a single line of no more than 20 characters from the file “announce.cfg” in the .rockbox directory.
This definition consists of a string of single character tokens, each of which announces a particular canned piece of information.
The tokens are:
A - current time B - elapsed time and total length of the current track C - current track number and total tracks in playlist D - battery level as a percentage E - battery remaining in hours and minutes F - sleep timer remaining in minutes
If more than one token is specified, more than one piece of information is announced, so:
AB
would announce the time followed by elapsed time and track length
Multiple announcements may be bound to the hotkey by separating one or more groups of tokens with a “:”
A:DF
In this example, the first time the hotkey is pressed, the time is announced. If it is pressed again within 10 seconds, the battery level and sleep timer are announced and so on.
A space between tokens adds a short pause to the announcement.
If no announce.cfg file is present, the time is announced by default.
|
|
11529 | Bugs | Themes | Very Low | Sansa e200v2 progressbar lags when backlight activated | 2010-08-10 | JT Hundley | 2010-10-11 | 1 |
Task Description
In my customized rockbox theme, there is a short (half second?) but irritating delay before the progressbar is drawn. This delay is apparent when pressing a button to turn on the backlight, so it doesn’t show up in the simulator. Here is a video of the issue happening: http://www.youtube.com/watch?v=1LAfW8-BjjE
I’ve tried moving the progressbar to the very top of the wps. I also tried changing the wps around to have each icon in a seperate viewport which didn’t help.
I’m using rockbox version 27667.
|
|
11522 | Patches | Plugins | Very Low | Make Rockbox recognize Game of Life configurations with... | 2010-08-06 | Justin Hannigan | 2011-05-06 | 6 |
Task Description
Some collections (such as ftp://sunsite.unc.edu/pub/Linux/games/amusements/life/dblifelib-2.tgz) use an extension of “.l” instead of “.cells” for what appears to be the same file format (same comment character and same characters for dead and live cell).
This patch just adds an entry to viewers.config so that Rockbox will treat .l files as supported and open them with Rocklife.
|
|
11512 | Bugs | Manual | Very Low | backlight fade in and fade out times missing from confi... | 2010-08-01 | Alex Parker | 2010-08-01 | |
Task Description
A couple of config file options are missing from the manual appendix:
e.g.
backlight fade in: 2000 backlight fade out: 10000
|
|
11510 | Patches | Bootloader | Very Low | Onda VX 7X7 series Bootload cannot used through buttons | 2010-07-31 | PurlingNayuki | 2010-08-08 | 1 |
Task Description
So, when you compile and run the bootloader on VX767/VX757 or any other buttons-only model, it can only boot to the Rockbox or the OF. It cannot use USB mode or reset RB configuration.
Here is a patch.
|
|
11499 | Bugs | Bootloader | Very Low | ipodpatcher sometimes fails when attempting to write ro... | 2010-07-26 | Michael Marley | 2010-07-26 | 2 |
Task Description
I am trying to use the last method mentioned on the ipodpatcher wiki page to write Rockbox directly into the OSOS image on my iPod Nano2G. Sometimes it works properly, but other times it fails saying that it couldn't read the header from the .ipodx file. I am following the instructions exactly, so that can't be an issue. I have tried hexediting the .ipodx file, and in some cases I can get ipodpatcher to read the header by editing the first four values, but this always causes a Checksum Error. Here is the exact output:
C:\Users\Michael Marley\Downloads>ipodpatcher.exe -wf rockbox.ipodx ipodpatcher 5.0 with v4.0 bootloaders (v1.0 for 2nd Gen Nano) (C) Dave Chapman 2006-2009 This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
[INFO] Scanning disk devices… [INFO] Read XML info (4 bytes) [INFO] Ipod found - 2nd Generation Nano ("winpod") - disk device 1 [INFO] Reading partition table from \\.\PhysicalDrive1 [INFO] Sector size is 2048 bytes [INFO] Part Start Sector End Sector Size (MB) Type [INFO] 0 63 48194 94.0 Empty (0x00) [INFO] 1 48195 1982462 3777.9 W95 FAT32 (0x0b) [INFO] Read XML info (4 bytes) [INFO] Ipod model: 2nd Generation Nano ("winpod") [ERR] Failed to read header from rockbox.ipodx [ERR] –write-firmware failed.
|
|
11486 | Bugs | Database | Very Low | Bookmarks from tagcache don't work | 2010-07-18 | Marek Salaba | 2011-02-19 | 1 |
Task Description
Hello.
I found that bookmarks which was automaticaly created (by the function Bookmark on Stop with set to Ask) from tagcache don’t work. Problem is in missing path to file in bmark file. I made more test and now I attach bmark where first line/bookmark is from tagcache and second line/bookmark is from files browser. Both are on approximately same time.
I testted on Sansa c250 and Sansa Fuse2 with Rockbox r27481-100718.
Can anybody from developers focused on it, please.
Much more thanks. Salaba
|
|
11478 | Patches | User Interface | Very Low | ONDA VX777 yes&no screen and hot key | 2010-07-14 | Giovanni Zilli | 2010-07-14 | 1 |
Task Description
This patch wil allow the use of the power key to respond yes in the yes&no screen, cause if in absolute touch screen mode would be impossible to respond yes. It also will enable the hotkey option. Italian and english translation for the yes&no.
|
|
11465 | Bugs | FM Tuner | Very Low | Volume needs to be turned down on FM radio when voice i... | 2010-07-07 | Scott Berry | 2012-02-29 | |
Task Description
when the FM tuner is turned on and say that you want to go to Add a Preset you cannot hear thevoice over the radio. this should be controlled where the Fm volume is turned down and the volume of the voice is turned up just like in playing regular music.
|
|
11463 | Bugs | FM Tuner | Very Low | ONDA VX777 volume in FM-Radio | 2010-07-07 | Giovanni Zilli | 2011-01-28 | |
Task Description
ONDA VX777 While in FM-Radio it isn’t possible to change the volume value, nor from the context menu, nor from the virtual 3×3 touch screen grid and nor from the .fms %T tag in absolute mode.
|
|
11449 | Bugs | Settings | Very Low | WPS is not loaded if the .wps file is not in the WPS di... | 2010-06-30 | Alexander Levin | 2011-10-22 | |
Task Description
Seen with r27199 on the e200 simulator.
If I place a .wps file in the root directory and “play” it from the file browser, the WPS is not loaded. I’d expect it to load but not to be saved as the setting.
The same file is loaded if it’s in the directory /.rockbox/wps, i.e. it’s not the wrong file contents that’s causing the error.
|
|
11429 | Patches | Operating System/Drivers | Very Low | Improved sector cache / Remove on-stack and in-struct s... | 2010-06-21 | Michael Sparmann | 2010-07-31 | 2 |
Task Description
This patch adds a sector-based read/write cache between the storage and fat drivers. It has a static pool of 64 sector buffers which can be locked by the file handling code to replace the sector buffers in the file and dir structs, and serve as cache as long as they aren’t used. It can also be used to enforce exclusive access to a sector.
If requested using the STORAGE_NEEDS_ALIGN define, all storage accesses will be aligned to cacheline boundaries.
|
|
11388 | Patches | Playlists | Very Low | Bookmark file doesn't work for a directory with a semic... | 2010-06-09 | Aaron Wells | 2010-07-09 | 1 |
Task Description
Steps to reproduce:
1. Create a directory: /AUDIO;BOOKS 2. Place a file in it: /AUDIO;BOOKS/file.mp3 3. Start playing the file, and then create a bookmark 4. Do “List bookmarks” for the file 5. The bookmark menu lists something like this:
BOOKS/;file 0:02, 2, Shuffle
The problem seems to be that .bmark files use semicolons to separate the fields of information. If there’s a semicolon in the path, it thinks that it indicates the end of the path and the beginning of the filename.
|
|
11367 | Patches | Operating System/Drivers | Very Low | e200v2 enable line out and detect dock connection | 2010-06-07 | Michael Chicoine | 2011-03-18 | 9 |
Task Description
This is a beginning of support for line out and dock connection detection for the e200v2 (and possibly fuze).
The first patch enables line out in as3514.c. Line out is always enabled at this point, so battery life may suffer. Line out volume is set to 0dB and does not change unless the volume is set below -40dB at which point the DAC volume begins to decrease. This patch does not support as3525v2 at this time.
The second patch detects a connection to a dock on e200v2 (and possibly Fuze) and prevents switching to USB mode and rebooting to the OF. For this to work properly, you need to have Rockbox already booted. There is no need to press any button on connection. If a normal USB cable is attached, the OF will be booted.
TODO: 1. Only enable line out when connected to a dock and disable line out when the dock is disconnected. 2. Provide support for additional as3525 and as3525v2 devices. Information on IO port changes when connecting a dock is needed for this.
|
|
11361 | Patches | Language | Very Low | Add string "Disc" for multidisc albums in WPS | 2010-06-06 | Hinrik Örn Sigurðsson | 2010-06-06 | 1 |
Task Description
This adds the translatable string LANG_DISC for display in WPS themes. E.g. a theme could use the following to show “Disc 2” for a multidisc album:
%?ik<%Sx|Disc| %ik|>
Disc is a 4 or 5 letter word in most languages, so it won’t add much clutter in themes which would like to make use of this. A comparable example is the “Next:” (LANG_NEXT) which is used when displaying the next track in a playlist.
|
|
11356 | Patches | Games | Very Low | improvements for game "jewels" | 2010-06-05 | Michael Stummvoll | 2020-06-29 | 4 |
Task Description
preamble first :) I am new at the rockbox-project, so this is my first commit. I hope that I am right here with that. If not, please notify, and say, where somewhat would be better. Strictly speaking this is my first contribition to an opensource-project ever. I am a friend of OSS since years and now I want to give something back ;) I am thinking, rockbox is a nice project to get in the open source scene.
To get in the rockbox-project I tried to improve the jewels-game. First I changed the controls for the Sansa Fuse in the Simulator. The old controls are good for the real Fuse, but very unconfortable at simulator.
Then I wanted jewels to get more difficult with higher levels. To do so I changed it to start with 4 types of jewels only and get one more each three levels till they are 7 types.
Greetings, Michael
|
|
11355 | Bugs | Music playback | Very Low | Auto-Change Directory crashes hardwarecodec players | 2010-06-05 | Marianne Arnold | 2012-01-14 | 1 |
Task Description
When the option “Auto-change directory” is enabled, my Ondio crashes at the end of the current folder’s playlist when it would have to create a new one.
The error it shows is “I09: CPUAdrEr at 09010FF8”. The address varies a bit with the actual revision, this example is with r26246 and an OndioFM backlight build (but the problem is present in plain SVN builds too). Looking at the map file shows that the crash happens in the cue_find_current_track function.
Bisecting build turned up that the error was introduced with the cuesheet rework in r21978/9 and the fix in 21982 fixed usual folder playback but not auto-change directory. It is reproducible on the Archos Recorder so I assume a general hwcodec problem.
|
|
11343 | Bugs | User Interface | Very Low | last Arabic character in a line appears as the first fo... | 2010-05-31 | Amr Medhat | 2010-06-28 | 7 |
Task Description
- write a word like “مسمار” in a text file, or just use the word as the file name
- the last character “ر” will appear as the first one like this: “رمسما”
- this bug appeared only since r26019
- when reverting to r26018 the bug won’t show up
- for some combination of letters like “دليل” the issue happens for the last 2 characters
- for some other words the problem doesn’t happen at all
- the only common case is that this happens only with last word in a line appearing on the viewport
|
|
11342 | Bugs | User Interface | Very Low | bidi orientation | 2010-05-31 | Amr Medhat | 2010-06-26 | |
Task Description
A mixed RTL with LTR text appears in a missed order not conforming to bidi logical to visual algorithm of unicdoe.
Implementation is ready in bidi_l2v() , but the “orientation” parameter is hardcoded and passed as “1” always
A suggested solution is either pass “orientation” as 0 for any RTL text, or tie the orientation parameter with the “alignment” option of the text viewer.
|
|
11339 | Bugs | Battery/Charging | Very Low | Volume is turned up to the maximum when the battery lev... | 2010-05-31 | Max Bargiel | 2011-10-01 | |
Task Description
When the battery is nearly empty and the iriver H10 is about to shutdown, the volume sometimes suddenly increases progressively, as if the volume UP button was pressed and held down, all the way up to the maximum.
This has happened to me about 3-4 times so far. Pressing the volume DOWN button somewhat counters this bug, but only for as long as the DOWN button is used - the volume keeps increasing.
This occurs with Rockbox Release 3.5 (not 3.4 as the Report Version field of the ticket says).
|
|
11337 | Patches | ID3 / meta data | Very Low | Play Count / Rating Info for Trackinfo Screen | 2010-05-31 | Chris Savery | 2010-07-09 | 2 |
Task Description
This patch adds a couple more lines to Track Info for Play Count and Rating. Currently these don’t seem to show up anywhere else.
Tested against r26427 with Fuze v2 and USim.
|
|
11310 | Patches | Plugins | Very Low | PictureFlow - mono tracklist for mono displays | 2010-05-24 | Chris Savery | 2010-06-10 | 7 |
Task Description
This very small mod changes the tracklist so it doesn't fade lines when on a mono display (bit depth 1). Tested against r26241 in Sim only (because I don't have a mono display device). Please report back if problems.
|
|
11300 | Patches | Plugins | Very Low | PictureFlow - Reflection Setting for small screens, Cli... | 2010-05-21 | Chris Savery | 2010-06-11 | 5 |
Task Description
This is a patch meant for Clip+ that adds a “Reflection” setting to allows choosing if to show a reflection or not. When no reflection is shown the images are moved to bottom of screen allowing for title at top and keeping them in the blue will work for other devices. I tested it on Fuze v2 but others may have unknown problems related to screen size differences. For screens > 100 high it doesn’t move the albums against r26185 in UISim you want this as a patch against my pictureflow-wps integration patch let me know as I have one
|
|
11297 | Patches | Drivers | Very Low | as3525v2: set_cpu_frequency | 2010-05-19 | Rafaël Carré | 2011-06-03 | 13 |
Task Description
This patch modifies hardware registers for pclk & fclk in one instruction.
I’m currently testing it on Clipv2 to see if it gets rid of crashes
|
|
11291 | Bugs | User Interface | Very Low | stop playing when switch hold to off on SA9200 | 2010-05-18 | Li Jie | 2010-05-20 | |
Task Description
On Gogear sa9200, when hold is switched to off(means in the middle), the play stops. Maybe because the hold and the on/off share the same swtich.
|
|
11286 | Bugs | Plugins | Very Low | PictureFlow segfault when showing tracklist or playing ... | 2010-05-17 | Chris Savery | 2010-05-25 | 1 |
Task Description
I've been working on PictureFlow - WPS Integration. I repeatedly had cases where showing a tracklist or playing for certain albums would cause a segfault. I tracked this down to a bug in the track list indexing. It only occurs under certain memory allocation circumstances that doesn't occur as readily with the std build. I have attached here a patch to fix it.
Explanation: the create_track_index requests memory for building a track index. The variable "tracks" references an array descending from the buffer top end. When a reallocation occurs it currently only moves the "tracks" position when a track count > 0. However, in some cases a reallocation occurs before the first track is stored and in that case the "tracks" position gets left in the middle of the track_names data causing corruption and then segfault. I've moved the (track_count > 0) decision so that it only controls moving tracks struct data. The "tracks" offset must happen even when track_count is 0.
This patch fixes the segfault on my Sansa Fuze v2 and in UISim. Tested against r26114. I would expect the same result in other platforms.
I've also included this bug fix in my PictureFlow - WPS Integration patch until this bug fix gets accepted.
|
|
11249 | Patches | Operating System/Drivers | Very Low | Fixed Morse Code case switching (on Sansa Fuze / FuzeV2... | 2010-05-07 | Wenyu "Hearson" Zhang | 2020-06-29 | 2 |
Task Description
Hi all,
Currently for all models, the Morse Code input method can only type lowercased letters. Here I provide a patch which enables people to switch between lower cased and upper cased letters, I implemented this for Fuze and Fuze v2, and further fixes will be provided soon (or someone else want to add some key mapping options into your keymaps?)
The patch (also attached):
Index: apps/action.h
— apps/action.h (revision 25886) +++ apps/action.h (working copy) @@ -239,6 +239,7 @@
ACTION_KBD_DOWN,
ACTION_KBD_MORSE_INPUT,
ACTION_KBD_MORSE_SELECT,
+ ACTION_KBD_MORSE_CASE_SWITCH,
#ifdef HAVE_TOUCHSCREEN
/* the following are helper actions for touchscreen targets,
Index: apps/recorder/keyboard.c
— apps/recorder/keyboard.c (revision 25886) +++ apps/recorder/keyboard.c (working copy) @@ -148,6 +148,7 @@ #ifdef HAVE_MORSE_INPUT /* : We should put this to a configuration file. */ +static bool morse_uppercase = false; static const char *morse_alphabets =
"abcdefghijklmnopqrstuvwxyz1234567890,.?-@ ";
static const unsigned char morse_codes[] = { @@ -573,6 +574,11 @@
state.morse_code |= 0x01;
}
break;
+ case ACTION_KBD_MORSE_CASE_SWITCH: + if (state.morse_mode) { + morse_uppercase = !morse_uppercase; + } + break; #endif /* HAVE_MORSE_INPUT */
case ACTION_KBD_SELECT:
@@ -626,7 +632,8 @@
/* turn off hangul input */
state.hangul = false;
- kbd_inschar(&state, morse_alphabets[j]); + kbd_inschar(&state, + morse_uppercase ? toupper(morse_alphabets[j]) : morse_alphabets[j]);
}
#endif /* HAVE_MORSE_INPUT */
break;
@@ -862,6 +869,10 @@
int morse_code;
outline[0] = morse_alphabets[i];
+ + if (morse_uppercase) + outline[0] = toupper(outline[0]); +
sc->putsxy(x, y, outline);
morse_code = morse_codes[i];
Index: apps/keymaps/keymap-fuze.c
— apps/keymaps/keymap-fuze.c (revision 25886) +++ apps/keymaps/keymap-fuze.c (working copy) @@ -269,6 +269,7 @@
{ ACTION_KBD_DONE, BUTTON_UP, BUTTON_NONE },
{ ACTION_KBD_ABORT, BUTTON_HOME|BUTTON_REPEAT, BUTTON_NONE },
{ ACTION_KBD_MORSE_SELECT, BUTTON_SELECT|BUTTON_REL, BUTTON_NONE },
+ { ACTION_KBD_MORSE_CASE_SWITCH, BUTTON_HOME, BUTTON_NONE },
LAST_ITEM_IN_LIST
}; /* button_context_keyboard */
|
|
11231 | Bugs | Codecs | Very Low | Skipping and stuttering in low bitrate .WMA files | 2010-04-30 | Michael Bauminger | 2011-10-27 | 1 |
Task Description
This is actually release 3.5.1
I have quite a few low bitrate .wma audio files that play fine in the original firmware, play fine in VLC, but skip, stutter, and hiss in Rockbox.
The file is 20kbps, 22 kHz, mono, Windows Media Audio V2.
I have attached a sample cut from a larger file. Like the original files, it plays fine in the original firmware and in VLC.
|
|
11219 | Patches | Plugins | Very Low | FFT: add support for input visualization. | 2010-04-26 | Delyan Kratunov | 2010-04-28 | 6 |
Task Description
Initial support for showing input in the fft plugin. Now, on targets supporting recording, instead of quiting when no track is playing, fft starts monitoring the audio input (using the settings under Recording Settings).
The first patch is just the functional changes, the second patch fixes the indentation of the entire file.
I’m not sure if it works at all since I don’t have a device that can record.
|
|
11218 | Patches | Operating System/Drivers | Very Low | New build target: iriver E10 | 2010-04-25 | Olle Bergkvist | 2010-05-08 | 2 |
Task Description
New build target, for iriver E10.
A lot of target-specific functions are missing, so it doesn't compile when it reaches the linker. But I think it's about time to insert the build target into SVN, and #rockbox seems to agree.
Also, building a simulator build works quite well. The simulator BMP and the keymaps needs some work, but it works pretty well, including music playback.
I've done some testing with building for other targets and nothing seems to be broken by this patch. I couldn't figure out how to include the BMP in the patch so i attach it separately.
|
|
11215 | Bugs | Plugins | Very Low | not able to move in DOOM! | 2010-04-23 | jeremy seidel | 2010-06-05 | |
Task Description
installed rockbox and doom (freedoom) all correctly. but problem is that the navigation keys dont work when the game starts. cant move. but i can bring up pause menu by flicking hold on then off but then only up(menu button) works in addition to the center button being able to select
to reproduce:install latest build for ipod classic 5th gen 30gb install doom from the rockbox utilities program run doom in ipod game loads face at bottom of screen moves, showing it isnt frozen… cannot move
and yes i have tried configuring the keys, it doesnt work
|
|
11213 | Patches | User Interface | Very Low | Alternative hold mode | 2010-04-20 | Ivan Goncharov | 2010-04-21 | 1 |
Task Description
This patch implement alternative hold mode, mentioned in FS#10698. To enter this mode you must: 1) switch hold button to on position(this results in normal hold mode). 2) press menu button. 3) switch hold button to off position 4) release menu button To leave alternative model: 1) switch hold button to off position 2) press menu button 3)switch hold button to on position 4)release menu button(now you in normal hold mode)
Additionally I implement simple keymap which working only in wps contex: if hold button off:
Plus button increase volume
|
|
11205 | Patches | Utils | Very Low | emuriver - emulator for iriver ifp-7xx | 2010-04-17 | Olle Bergkvist | 2010-04-19 | 1 |
Task Description
Emuriver is an emulator (not simulator) for iriver ifp-7xx series. It’s part of the http://www.rockbox.org/wiki/IriverIfpPort and has until now been hosted at the main author’s (Tomek’s) site http://www.mimuw.edu.pl/~tmal/rockbox/ It includes a tool to create flash images for use with the emulator, and a tool to mount such images and do basic file management on them.
This version is almost identical to the last version from Tomek’s site, but I had to fix a few bugs to make it usable on my system. Changes are as follows:
flashimgtool.c: Outputs usage information on errors. (I didn’t do this; I don’t know where this code came from but it’s useful.)
hardware.c: Bug: Arguments were missing in a function call which would sometimes cause segmentation faults, and (I don’t know why or how) slow down the emulator.
main.c: Changed a default file name from prog_flash.bin to prog_flash.img (I didn’t do this)
main.c: Bug: Added explicit return value to nonvoid function. The implicit return value was sometimes -1 which indicated an error so emuriver aborted.
make_flash_img.c: Optimizations: “if” replaced with “else if”. (I didn’t do this)
uicurses.c: Rename a variable into someting more unique. (I didn’t do this)
The reason I’m submitting this patch is that I think the emulator could be useful as it is for those trying to build the ifp port from SVN, that it could (maybe) be worked on to support other players, and that my bugfixes should be included for those building emuriver.
There are a few issues: The flashimgtool subdir in emuriver duplicates a few (three years old) files from RB, disk.c, fat.c, and some more. You might not like the directory structure. It uses an ancient version of autotools. I haven’t been able to create flash images that actually work with flashimgtool. I haven’t built the RB port for ifp yet, so I don’t know if it will run in emuriver or not.
Yes I have discussed the patch in IRC.
|
|
11202 | Bugs | Games | Very Low | Rocboy isn't playable for Rom that have a size of more ... | 2010-04-15 | David trembley | 2010-04-15 | |
Task Description
When Playing with rockboy on sansa e200 V1 , Rom that have a size of more than 1m Bug and Rockbox often shutdown. And even if these roms run, the speed isn't playable.
|
|
11192 | Bugs | Music playback | Very Low | FLAC with CUEsheet playback issues (reopening of FS#735... | 2010-04-09 | Matthieu Mambrini | 2012-07-27 | |
Task Description
This is a reopening of issue FS#7354 (quoted below) related to playback problems involving cuesheet support and flac files (labelled #1 in the original post). Jumps to certain positions in flac file according to the cuesheet fail consistently.
The bug is extensivelly described in the original report and can be easily reproduced in current versions. I reproduced it in many situations with the following configuration:
Equipment used: Cowon D2 and Cowon D2 simulation Rockbox version: tested on r25508-100407 and r24777-100219 (simulation) Rockbox settings: Cuesheet support ON, other on default FLAC files: Ripped form my original CDs with EAC (to WAV and cuesheet) in secure mode and processed with FLAC 1.12 and/or 1.14 compression level 8. MD5 checksums on cuesheets and FLACS checked. Cuesheet syntax OK, cuesheet file encoding UTF8-DOS and/or DOS. Works properly my on computer.
Quote of the original post
Full description of issue #1: While playing certain (but not all) FLAC files with CUE support (played by navigating to FLAC file in “FILES” mode and pressing play), the “skip to next track” command won’t work on certain tracks on that cuesheet, but will skip to other tracks on that CUE just fine. It occurs while in both “now playing” or “browse cuesheet” screen. When I try to skip to certain tracks on CUE, the current playback will stop for a moment and the icon indicates disk usage (just like normal) but it wont skip to appropriate position, just resume playback at current track/position. I have experienced this on multiple files, encoded with FLAC 1.12 and 1.14.
Issue #1 - Tested: * Found two cases (FLAC + CUE files) in my collection (but I’m sure there are many more) that have this problem. * These files play without a problem on my computer with Foobar2k and were securely ripped form original CD and encoded (with differnet FLAC versions), MD5 checksum-ed and CUEsheets checked for proper syntax - ALL FINE.
1.) I verified that the issue occurs while trying to navigate to track #9 in case of FLAC file A, and track #7 on FLAC file B. Track start times on both files are different, different lengths and don’t seem to have some kind of “pattern” or to differ (in terms of length, index position,..) from tracks on cuesheet that skip-to normally.
2.) I substituted the A and B FLAC files with FLAC file C (which is a FLAC from a different CD) and preserved the original cuesheets A and B and tried to play FLAC C with these two cuesheets to confirm if it is a problem with a cuesheet. Everytrhing worked as it should and the problem did not occur. So I think that rules out the cuesheet as the only cause of the problem.
3.) I used both cuesheets A and B and both FLAC files A and B, but played FLAC A with cue B and vice-versa. Everything played OK, even on previously problematic positions. (of course the cuesheet info wasn’t correct for that FLAC, since they were swapped, but skipping to tracks worked) That seemed to indicate that there might be a problem with a specific position/time in the FLAC file that the playback wont jump to.)
4) I altered both cuesheets from previous (3.) test so that I entered the correct/problematic INDEX of _one_ of the cuesheet tracks to match the track index of original cuesheet, so that it “hit” that problematic position. So While I played FLAC A with modified cue B (entered the problematic time/index of cue A to one of the tracks) the problem reoccured! I could not skip to that (altered) track position. This led me to believe that this problem occurs when the track index in cuesheet “hits” a certain time/spot on a specific FLAC file.
5.) This time I checked what will happen if I use a third CUESHEET (from some other CD) on original A and B FLAC files. Everything worked OK. No surprise, as that third cuesheet did not have the track index time of that problematic position.
4.) This time I reencoded both A and B FLAC files with a different FLAC version (now 1.14, was 1.12) and tested again. Previously problematic tracked worked OK! BUT problem started occuring on other tracks now, on file A on track #13, while FLAC B now had multiple problems: track #2, 5, 8, 14! This suggest that it is not an encoding problem.
Once again, these files work flawlessly on my computer and are proper lossless conversions (I also always use the VERIFY function while converting to/from FLAC)
So the conclusion would be: When cuesheet index of a track “hits” just the right position in a FLAC file, regardless of its encoding the issue will occur. Also, this also isn’t an uncommon problem since I experienced it on 4 occasions and seems to be not-that-hard to find if you test several FLAC + cue combos.
I realize that this happens only with certain FLAC and track indexes COMBOS so it might be harder to recreate, but it really seems not that uncommon. And if not otherwise, I could supply the FLACS in questions (but each is several hundred MBs long and may be illegal to distribute it). I believe it can be recreated with just about any FLAC file, by finding a proper CUEsheet track index. It would be highly unusual that it would happen so frequent in my collection if it was an “isolated case” and I honestly believe it has nothing to do with FLAC or CUE files and that they are encoded correctly and accurately.
|