Rockbox

Right now if the voice file fails to load, there’s a splash message but blind users won’t be able to see it.

(usually this happens because they upgraded rockbox without upgrading the voice file too)

It would be useful if we could embed a failsafe voice file, containing only that one prompt, so the user will know what is going on.

Just English for now, though ideally one for every language we support.

(Oh, and a pony too. Please?)

This patch adds SubRip subtitle support to MPEG Player.
http://wiki.multimedia.cx/index.php?title=SubRip

Files need to have the same name as the video file with a “.srt” extension.

I know that the OSD rendering is not implement in a way that linuxstb and jhMikeS would like but I still wanted to post the patch here in case anyone felt like adapting it. (Current OSD only renders on top of the video area, it can be adapted to add other OSD channels … like display a seek bar, volume control, playback state, etc.)

Enjoy,

Edit: I’ve also added a timebar display (when changing the volume)

Neither of the tools, ipodpatcher or Rockbox Utility 1.4.0, work on macOS Catalina.

Catalina removed 32bit support.

Using ipodpatcher generates the following error:

bash-3.2$ ./ipodpatcher
bash: ./ipodpatcher: Bad CPU type in executable

And Rockbox Utility has a white circle with a line through it indicating that it does not work with this version of the OS.

(see attached file)

Create database application.

1) At first FS9349 patch file (http://www.rockbox.org/tracker/task/9349?getfile=17401) apply.

2) After this task’s patch apply.

The aim of this patch is to make releases as simple as possible... i.e the end goal would be to have someone run “$ ~/rockbox/tools/release/release.sh 3.3” and that would do everything except feed the cat...

the first version just modifies bins.pl to accept a version number which eventually gets passed to the Makefile and used in the source to set the version string in the source to “3.x-rBLAAA”.

This also defines RBRELEASE which can be used in the source to do stuff, for example, remove the debug menu in releases (if we decide to do that...) (RELEASE is defined in speex so had to add the RB prefix...)

Also, this changes the way configure is run to use command line args instead of passing input to it which is Just Wrong (TM) :p

Emuriver is an emulator (not simulator) for iriver ifp-7xx series. It’s part of the http://www.rockbox.org/wiki/IriverIfpPort and has until now been hosted at the main author’s (Tomek’s) site http://www.mimuw.edu.pl/~tmal/rockbox/ It includes a tool to create flash images for use with the emulator, and a tool to mount such images and do basic file management on them.

This version is almost identical to the last version from Tomek’s site, but I had to fix a few bugs to make it usable on my system. Changes are as follows:

flashimgtool.c: Outputs usage information on errors. (I didn’t do this; I don’t know where this code came from but it’s useful.)

hardware.c: Bug: Arguments were missing in a function call which would sometimes cause segmentation faults, and (I don’t know why or how) slow down the emulator.

main.c: Changed a default file name from prog_flash.bin to prog_flash.img (I didn’t do this)

main.c: Bug: Added explicit return value to nonvoid function. The implicit return value was sometimes -1 which indicated an error so emuriver aborted.

make_flash_img.c: Optimizations: “if” replaced with “else if”. (I didn’t do this)

uicurses.c: Rename a variable into someting more unique. (I didn’t do this)

The reason I’m submitting this patch is that I think the emulator could be useful as it is for those trying to build the ifp port from SVN, that it could (maybe) be worked on to support other players, and that my bugfixes should be included for those building emuriver.

There are a few issues: The flashimgtool subdir in emuriver duplicates a few (three years old) files from RB, disk.c, fat.c, and some more. You might not like the directory structure. It uses an ancient version of autotools. I haven’t been able to create flash images that actually work with flashimgtool. I haven’t built the RB port for ifp yet, so I don’t know if it will run in emuriver or not.

Yes I have discussed the patch in IRC.

The following set of WPS tags demonstrates:

# WPS Document
%wd
%V(0,0,-,10,2)%Vb(000000)%Vf(FFF000)
%aL%cH:%cM %ac%pv %aR%bt
%V(0,11,-,30,2)%Vb(000000)%Vf(FFF000)
%it

If you alternately insert and remove a space between the second occurence of %Vb/%Vf, the track title text appears and disappears. It appears to happen in a few other variations, but this is the shortest concrete example.

The attached patch fixes a minor compiler warning on 64 bit platforms.

Update to my tools/talkclips.py script. Minor updates which include:
- Better handling of logfile eg. we don't leave it open as was the case
before
- Report a few more details in the log eg. start/end time, duration, and
number of talk clips created. This is useful to dettect how many files
had problems…
- Summarise output for user at end, of processing, number of talkclips
created and how long this took (in seconds).
- Report to user how many talk clips will need to be created to give
them an indication of potential waiting time etc. This is calculated by
first determining how many files are on the device excluding .talk files, and how many .talk
files there are, and calculating the difference.
- This information allows a percentage indication to be drawn throughout
the script, so now the user can track the percentage as processing takes
place.

Patch is attached.

Thanks.

Whenever screendump is enabled,It gets a panic error.
Error Message:
*PANIC*
Stkov usb
pc:080739ac sp:080f5458

Rockbox version 3.13
Wenn I delete a file being played, it continues to play (which is OK for me). But when I rewind in this file while playing, Rockbox hangs and does not respond to any key presses. The screen light stays on. I have to press the hard reset or wait until the battery is empty.

This also sometimes happens when I press fastforward, but it always happens when pressing rewind.

Desired behavior:
- Preferred: permit rewinding/fastforwarding (and really delete the file only after stopping the replay)
- ignore rewind/fast forward; alternatively
- skip to the next file immediately after deleting.

Thanks for reading, and please contact me if you cannot reproduce this! I have a Iriver H140 and I must say that all my recordings are in wavpack (recordings made using SPDIF-IN), so I do not know whether this also happens with other file formats and with other players.

-Stefan

build 00a3658. files dont list or play alphabetically regardless of setting in file view menu.

Rockbox doesn't speak in the FM mode with voice configured. I tried it in my local language (spanish) and in english with same results. Apparently it is not a problem of the translation, because sometimes (only 2 or 3 times in at about one year that I'm using the player) the player speak some words. This works correctly in release version.
My actual version is 0f89b04, but it happend in all dev versions.

I store the album art by putting a folder.jpg file in the album's directory.
Any WPS on other players shows the cover pictures properly if album art is enabled in the theme.

I am aware of caveats like progressive jpgs, that are not supported by RB.

In the attached zip file, there are four directories with a folder.jpg file and a free opus file for demonstration purposes.

All pictures show up fine on my Sansa E200 (v1) using CabbieV2 or lebellium_Samsung-like.
However, on my XduOO x3ii the pictures are not displayed for the examples 1 - 3, but show for example 4.

None of the jpgs are progressive and I cannot figure out a difference between 1-3 and 4.

I don't know how to debug this further myself, but would be happy doing any furter experiments.

This is true for the current dev builds, e.g. b450707955.

Whenever the HOLD switch is turned off, the hold icon in rockbox disappears, but hold actually doesn’t let go. I can’t use any keys until scroling is used. Scrolling left or right is the only thing that actually switches off hold. It can be pretty annoying as I use HOLD a lot.

This patch adds fairly decent support for the sliderbar on the front of the iRiver H10 series players. This functionality is prominently displayed on the H10 wiki as something that is significant and missing.

With this patch the user can slide his finger over the slider to produce a scrolling effect. Or, they may also tap or hold down the upper or lower 30% of the slider for the older up/down behaviour with auto-repeat provided by the common code. This basically mimics the OF’s functionality.

The physical slider is very sensitive, so the values that come back from it are fairly spastic. I’ve attempted to tone down any wild behaviour, and I’ve added #defines in the patch that can be used to tune the behaviour. But frankly, even the user’s thumb size will affect what “good” values are. I believe what I have is good for the time being, but more tweaking may be necessary as time goes on.

When utilizing the database on the iPod Photo (as well as other 4G iPods I have used), on occasion when entering a directory or going to the parent directory, any button on the iPod will need to be pressed before the others will have effect. I.E. before I can scroll to select a song, I must press Select or one of the other wheel buttons. It is severely annoying, in part because it is too sporadic to even be assumed to be a “feature”.

this patch adds inline settings to the
any menu items are settings it will show a 2nd line for that menu which will show the value of the elected setting, or —→ for submenus/functions.

notes about this
uses too many hacky-tweaks to be considered
doesnt let you disable
item voiceing is probably
doesnt let you change the setting, you still have to enter the setting screen to change it

DONT send this topic off on a tangent like the last UI change tasks, and any requests for resyncs will be deleted. (I’m guessing this will stay here till at least devcon)

Obviously there is no one who wants to open a mp3 file with text viewer. With this patch applied, ‘Open With..’ only shows plugins that are associated in ‘viewers.config’. To see a full list of viewers plugin, just set the ‘Show Files’ option to ‘All’ and try again.

Some builtin filetypes are text file, so I added them into ‘viewers.config’ for the accessibility.

This patch adds an option to disable the speed limiting that slows down seeking as you approach the end or beginning of a track.

It defaults to limiting enabled, to maintain compatibility. Personally, I prefer the fast seeking without the limiting.

The manual is not included, I can't compile them still…

This patch modifies the Gigabeat S keymap so that it can be used almost solely using the buttons on the face of the player.

Currently, there is an unused button in the WPS screen (the BACK button, up-left from the cross) which in my mind makes more sense as the “back to the menu” button, while the MENU button (up-right from the cross) is the logical Play/Pause button (at least to a right-handed individual). It’s unfortunate that the button with the Windows logo has been called the MENU button in the code, thus making this rather confusing to read, but if enough people agree with the feel of this change, that could be modified as well.

Where possible (i.e. the buttons aren’t needed for somethinig else), the PLAY button should go straight to the WPS (resuming as required) or radio.

These are almost the case, but on the H300 there are the following exceptions:

- Rockbox Info (PLAY performs the disk free space scan, same as SELECT)
- Playlist Viewer when selected from the Main > Playlists menu (PLAY returns to the menu above, same as LEFT)
- Sleep Timer (PLAY does nothing)
- Debug Manu (PLAY enters the selected item, same as SELECT)
- Browse x in Settings, where x = Themes, Fonts or .cfg/.wps/.rwps Files (PLAY returns to the menu above, same as LEFT). (Note that the plugin browser works fine!)

Similarly, the STOP button should stop playback, which is largely ok, except:

- In the Playlist Viewer (STOP does nothing)

I don’t have any other targets handy, but feel free to add any other suspect screens here.

This patch will correct how thai vowels and tonal makers display.

“First Keypress Enables Backlight Only” doesn’t work on the 5G iPod. For example, if that’s enabled, the backlight is off and I press next track while at the WPS, Rockbox will go to the next track.

It seems like clickwheel event(s) generated when I touch the wheel turn on the backlight. When the button is pressed, the backlight is already considered to be on and the button press performs its usual action. If I carefully hold my finger still on the clickwheel, let the backlight fade, and then carefully press a button without moving my finger on the clickwheel, I am able to turn on the backlight without causing anything else to happen.

I don’t know what to do about this. Requiring a physical button press might be annoying. Removing this option on affected targets might be okay, because it’s easy to turn on the backlight by touching the clickwheel (and that doesn’t seem to cause anything else to happen). Another possibility is to require more or specific wheel events.

I set player type to iPod 5G because that’s all I have, but I expect this problem also exists on other clickwheel iPods. This problem exists on r20079 and r20033.

Using a bootloader from  FS#9955 , a USB connection is not made if Start Screen is set to WPS, and the user boots Rockbox by inserting a USB cable.

This is possibly also true for other values of Start Screen.

Tested on e280, but I expect it’ll likely be the case on other PP targets with USB

In the never ending saga of strnatcmp the fix for 10029 sorts as
001
002
01
02

Attached is yet another attempt to get it right.

I’ve been reliably informed that Rockbox should stop scrolling when it gets to the bottom or top of a menu, only to wrap around when you initiate a new scrolling gesture. On a 2nd Generation iPod, however, it just keeps scrolling.

See http://bertram.bourdrez.org/buggyrockbox.avi (the video is recorded with an old Rockbox, but 3.2-090323 does the same thing)

Also, the bug tracking system is overcomplicated. I have to register an account?!
“Why the hell should *I* set up an account? It’s not like any bugs will be assigned to me or anything. Just store my e-mail address and move on. It’s completely fucking bogus that I should have to go digging through my mail for confirmation passwords.” (http://zork.net/~sneakums/fortunes/gar/215)

Then I have to click a link with a magic number in it *as well as* having to enter a confirmation code from the same email (!?) and then when I’ve finished, I’m not even logged in! I have to log in with the same password I just set! Can’t it just set a cookie?

i asked some time ago why there is the buttontable in general settings –>bookmark. i wondered because the buttons are the same as in other lists. Marc Guay said "the delete button is unique", an i wondered why there is a dedicated delete button… in no other lists exists such a button afaik.

i changed the manual accordingly.
i also corrected some wrong (?) comments.
i hope i did everything right, at least for the e200 it compiles and works fine.

i would like to get some opinions about it.

This adds asplash and asplashf (and vasplashf for internal use) which normal splashes but can be aborted with button presses.

Additionally, they return the action received (for CONTEXT_STD) so that the caller may handle aborts differently depending on the button.

Also I converted a few annoying splashes to use it (when loading themes, wps, fonts etc and the resume failed splash)

After releasing hold after several minutes of playback with hold enabled, the backlight flickers on and off, if the following settings are enabled:

Backlight on hold: off
Backlight fade in: on
Backlight fade out: on
Caption backlight: on

My theory is that fade-in/out events from the caption backlight somehow get queued up, and happen once hold is released.

Happened as recently as today, with r21438. Reports in IRC said it appeared somewhere between 3.0 and 3.1.

As of r21894, the pitch changing mode (in the pitch screen) can only be toggled (cycled through) in one direction. However it would be handy to be able to cycle in the other direction to change procentual vs. semitone while still staying in the time stretch mode. This patch adds such a possibility.

The key mappings is only defined for H1xx and H3xx (as a long press of Mode). Please add keys for other platfroms.

In the "Scroll bar width" screen, the value used to show the width selected is the previous one, not the current one. The first value change has no effect.
Anyway it seems that the right value is stored: if you select a value and exit by the screen, when you re-enter in it, the width is correct.

Priority low.

Referred to r22406.

This patch makes the graphic EQ usable in the absolute mode on touchscreen models.
Additionally I made the following changes:

* Add a menu in the touchscreen settings to select the touchscreen mode in the graphic EQ ( because in menus I prefer the grid mode, in the EQ the absolute mode is much better)

* Always try to use the UI_FONT , make the EQ filling the whole screen and add a little margin on the left and right side. In that way it can even used with fingers on a touchscreen (automatic adaption to fill the whole screen should work for all targets with EQ and LCD).

I tested on my Cowon D2 and Iriver H340 to make sure non touchscreen models stil work, both worked perfect.

Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added scaling image by menu/holdmenu buttons, scrolling horizontally by plus/minus, scrolling vertically by holdplus/holdminus, exit to viewer menu by power switch, switching files by combinations of menus and plus/minus buttons combination.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can't post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Changed controls: moving selection to the left/right by minus/plus buttons, moving selection to the down/up by holdminus/holdplus buttons, choice symbol by the menu button, backspace - long holdmenu button (at release moment), moving cursor left/right by holdminus/holdplus buttons (at release moment), confirm by holding plus button (at release moment), abort by power switch.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can’t post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added movement left/right through the date/time fields by the holdminus/holdplus buttons.

Requires functionality of the buttons in the Hold mode patch by andrewthecoder (I can’t post it here, because this code is not mine, but you can take it with any config on http://iaudiophile.net/forums/showthread.php?t=28467 or on http://uploads.arago.shell.tor.hu/rockbox/hold_buttons_patch.patch)

Added seeking by holdplus/holdminus buttons, pause/play by holdmenu button, hiding the OSD panel by briefly pressing power switch.

This has been (slightly) discussed before, but this is a new take on the matter, not a repeat of  FS#10683 .

With this patch applied, the following functionality is recognised with the hold switch in place:

On any list/menu screen or the while playing screen;
pressing MINUS decreases volume by one,
pressing PLUS increases volume by one,
pressing MENU switches between Play and Pause,
holding MINUS skips back a track,
holding PLUS skips forward a track,
holding MENU advances to the next folder.

I feel that anybody using a Cowon D2 will find this functionality essential, not only because it is present in the original firmware, but because it is necessary for in-pocket operation.
With a small DAP like this, with tactile buttons as well as a touch screen, it makes sense to maximize convenience.

I have added as much functionality as I could without requiring pressing multiple buttons at once. I have made several similar patches and built them for members on the iAudiophile forums, and this configuration has consistently been the most popular.

I welcome any comments/suggestions.
-Andrew

This patch is for the Sansa Fuze but easily modified for other players with scroll wheels.
apps/keymaps/keymap-[your player].c needs to be modified

This patch changes the keyboard input method for scroll wheel players to this:

Scrolling the wheel forward selects the column of the desired character moving right.
Reversing the wheel moves the keyboard cursor down (not left) to select the character.
Reversing again inserts the letter and resets the row and column to the top left.
Repeat…(right, down, right, down…)

The benefit is not leaving the scroll wheel or stopping to click anything.

The center select button is now always mapped to delete.
Left and right always move the edit position.
To make overshoot more forgiving reverse scrolling past the bottom of the keyboard moves the cursor to the top of the previous column.

The posted patch includes keymap changes for the Sansa Fuze. These are the changes required for a different target:
- { ACTION_KBD_UP, BUTTON_SCROLL_BACK, BUTTON_NONE },
- { ACTION_KBD_UP, BUTTON_SCROLL_BACK|BUTTON_REPEAT, BUTTON_NONE },
- { ACTION_KBD_DOWN, BUTTON_SCROLL_FWD, BUTTON_NONE },
- { ACTION_KBD_DOWN, BUTTON_SCROLL_FWD|BUTTON_REPEAT, BUTTON_NONE },
+ { ACTION_KBD_SCROLL_BACK, BUTTON_SCROLL_BACK, BUTTON_NONE },
+ { ACTION_KBD_SCROLL_BACK, BUTTON_SCROLL_BACK|BUTTON_REPEAT, BUTTON_NONE },
+ { ACTION_KBD_SCROLL_FWD, BUTTON_SCROLL_FWD, BUTTON_NONE },
+ { ACTION_KBD_SCROLL_FWD, BUTTON_SCROLL_FWD|BUTTON_REPEAT, BUTTON_NONE },

This patch will remove Morse code but preserves the unicode capability (not tested)

The attached patch adds an indication of the current touchscreen mode to the "classic_statusbar" skin. This is useful since some screens automatically change mode, and there's currently no indication the user when this happens. The patch does the following:

- Adds a new WPS tag (%Tm) to return the current touch mode (Absolute|Grid)
- Updates classic_statusbar.sbs to conditionally show the correct icon

The reason I've made this a Flyspray task rather than just committing it is because the additions to classic_statusbar.sbs will also apply to non-touchscreen targets (though nothing will appear on screen). While the impact on these targets is minimal, I'm not sure about committing it since it will at least cause the new touchmode.bmp to be loaded unneccesarily.

Also, feel free to design some better icons!

I have started an discussion about the virtual keyboard in the mailing list.

In my opinion the text_editor’s control should be similar to the calculator:
- use the whole screen (no tiny font)
- support for touchscreen (raster map)
- separate characters into categories

I adjust the calculator plugin to show my concept.

during my research on FS#10883 i found out that it would be better do disable slide actions on ipods for yes no decisons. slides are too easy done and often cause an unwanted abort.

this patch solves this issue by only accepting pressed keys for abort actions. the solution for FS#10883 has been appended on the bug report seperately.

This patch which is a small change in bidi.c contributes with the diacritics patch (http://www.rockbox.org/tracker/task/10720) to fix the diacritized Arabic text joining problem

sansa fuze v1 scroller doesn’t obey ‘first button press enables backlight only’

rockbox 3.5.1

This patch implement alternative hold mode, mentioned in FS#10698.
To enter this mode you must:
1) switch hold button to on position(this results in normal hold mode).
2) press menu button.
3) switch hold button to off position
4) release menu button
To leave alternative model:
1) switch hold button to off position
2) press menu button
3)switch hold button to on position
4)release menu button(now you in normal hold mode)

Additionally I implement simple keymap which working only in wps contex:
if hold button off:

 Plus button increase volume

On Gogear sa9200, when hold is switched to off(means in the middle), the play stops.
Maybe because the hold and the on/off share the same swtich.

A mixed RTL with LTR text appears in a missed order not conforming to bidi logical to visual algorithm of unicdoe.

Implementation is ready in bidi_l2v() , but the “orientation” parameter is hardcoded and passed as “1” always

A suggested solution is either pass “orientation” as 0 for any RTL text, or tie the orientation parameter with the “alignment” option of the text viewer.

- write a word like “مسمار” in a text file, or just use the word as the file name

- the last character “ر” will appear as the first one like this: “رمسما”

- this bug appeared only since r26019

- when reverting to r26018 the bug won’t show up

- for some combination of letters like “دليل” the issue happens for the last 2 characters

- for some other words the problem doesn’t happen at all

- the only common case is that this happens only with last word in a line appearing on the viewport

This patch wil allow the use of the power key to respond yes in the yes&no screen, cause if in absolute touch screen mode would be impossible to respond yes.
It also will enable the hotkey option.
Italian and english translation for the yes&no.