|
5757 | Patches | Drivers | Very Low | Correctly display short DOS file names in file browser | 2006-08-01 | Alexander Levin | 2006-08-05 | 3 |
Task Description
This is a sequel for FS#5736 . It correctly displays the OEM-encoded short DOS file names.
Following code pages are supported: cp850 (western Europe), cp852 (central Europe), cp737 (greek), cp866 (cyriliic), cp862 (hebrew).
If you change the default code page (in the settings menu) and there are files that are displayed with the short DOS names, you’d better rebuild the dir cache (if it’s activated) since the UTF8-name of the file changes.
When I compile the modified sources, I get the following warning which I don’t understand: CC common/unicode.c common/unicode.c:136: warning: function declaration isn’t a prototype
Could anyone tell me what that means and what the reason is?
|
|
7180 | Patches | Plugins | Very Low | "Target" word game | 2007-05-17 | Will Robertson | 2007-05-17 | 1 |
Task Description
This is a rockbox version of the simple word game called “Target”. Rules: (stolen from The Age newspaper website) “See how many words of four letters or more can you make from the letters shown in the grids. In making a word, each letter must be used once only. The word must contain the centre letter and there must be at least one nine-letter word in the list. No plurals or verb forms ending with “s”; no words with initial capitals and no words with a hyphen or apostrophe are permitted. The first word of a phrase is permitted (eg inkjet in inkjet printer).”
Currently it only works on H300, iPod Photo and iPod 5g DAPs, but I plan to expand this to all bitmap targets soon enough. The games are either user selected or loaded from the file target_wordlist.dat, I’ve included 10 puzzles, but there are heaps more on The Age newpaper’s site (www.theage.com.au).
|
|
7203 | Patches | Plugins | Very Low | New game for Color-LCD-Rockboxes | 2007-05-22 | Andreas Kruschinski | 2007-06-28 | 1 |
Task Description
This is the game Squarebloxx. It works on Color-LCDs only because colors are an essential part of the game. I tested it in the Simulator for all the color Boxes. I also tested it on my H340. In the game you have to mark parts of an array of tiles. If the tiles in the corners of the mark are the same color, the marked area is done. If all tiles are done the level is finished. Please give me feedback and report bugs.
Thanks Krush
|
|
7544 | Patches | Plugins | Very Low | Tic Tac Toe Plugin | 2007-08-06 | Johnathon Mihalop | 2007-08-08 | 2 |
Task Description
This is the first plugin I’ve ever written from scratch, and well, it was fun. I haven’t worked out how to use bitmaps yet, bear with me, for now it uses coloured rectangles. Still learning :p.
If this were to get committed, please wait until I’ve added better support for more targets, commented as many lines as are possible to help other people new to making plugins, potentially add AI (Although that would kinda ruin it as it would probably force a draw every time), and figured out how to use bitmaps properly.
If people are willing to test this out for me and tell me any bugs, please do so. I have tested this on the H10, the Gigabeat, and, using the simulator, the iPod mini G2 (Which displays it but out of alignment, will work on that soon.
I realize it’s not too exciting, but for my first real bit of work in C I’m happy :p.
|
|
7650 | Patches | Build environment | Very Low | Script to aid in building voices (especially helpful fo... | 2007-08-24 | Jonas Häggqvist | 2007-08-28 | 1 |
Task Description
If you’re willing to produce a Human voice file (spoken by you or someone you know), this script will be particularly helpful. It expects you to put it in a directory with a subdirectory containing .wav files for all voice strings, named by the contents of the string (this will be problematic on FAT/NTFS, but could be fixed).
When run, it will check to see if all needed strings are available, and if they are, it will generate a voice-file for all targets. If they aren’t, it will print out a list of strings missing (to be recorded and put in the subdirectory). This list will also be put in the file “missingstrings.txt”, one on each line.
This might be suitable for inclusion in tools/
Edit: Script deleted. Will upload again soonish.
|
|
7790 | Patches | Applications | Very Low | Voicebox improvements | 2007-09-17 | Daniel Dalton | 2007-10-04 | 2 |
Task Description
Some improvements for voicebox on windows. Mainly an option to voice file extensions. Not perfect yet. Instead of an option to voice file extensions there are two voice files options in the hta file. Anyone know what is wrong with this? Thanks
|
|
6467 | Patches | Games | Very Low | New control scheme for Doom on Sansa e200 | 2006-12-21 | Piotr Jafiszow | 2007-10-10 | 2 |
Task Description
Patch changes controls for Doom:
Forward: rec/up Left/Right: scrollwheel (it needs a lot of scrolls for large turns, but hopefully it can be modified to work better in the future) Back: down Shoot/Enter (menu): select Change weapon: left Open: right Esc: power
|
|
7546 | Patches | Applications | Very Low | Rockboy LCD Unifications (+ iPod Greyscale Support) | 2007-08-06 | Tom Ross | 2007-10-19 | 2 |
Task Description
The patch reorganizes Rockboy to use the same method for storing GB frame buffer data on greyscale targets as color targets. As a result, support for greyscale iPods is much easier and has been implemented (inspired by FS #5282).
Some other changes include: - Enable the menu for iRiver H100 - Ability to “Show Stats” on all targets - Screen is redrawn all at once on greyscale instead of line by line - Elimination of fb.mode (all targets use options.scaling for scaling options) - Elimination of fb.cc on non-color targets - Minor variable renaming - Unification of LCD variables (vdest vs frameb) - Move greyscale LCD code into lcd.c - ifdef out vid_update() on greyscale and color targets
Since I don’t have an iPod, I’m curious to see how well this works. It should be fine since the patch my work is based on seems to work for people.
I really need iRiver H1X0 users to test this. There are significant changes to the LCD code and I’d like to know if the is any speed change, whether its an improvement or not. I’d guess that it’s slightly faster or the same as SVN but there’s always a chance that it is slower.
|
|
7984 | Patches | Database | Very Low | Talk clip support for Database | 2007-10-17 | Jonas Häggqvist | 2007-10-21 | 3 |
Task Description
Before you get carried away, this is the script that will build talk clips in /.rockbox/talkclips/* for all tags and labels (reading tagnavi.config as well as the database_[0-9]*.tcd files).
The idea is that the database code will then look here for talk clips.
In the long term, the same method could be used for the file browser if desired.
Hopefully someone will help me out with the database code side of things, as I don’t think I’m up to that challenge.
|
|
7464 | Bugs | FM Tuner | Very Low | Small weaknesses in FM-radio on iAudio X5 | 2007-07-21 | Davy Kager | 2007-11-03 | |
Task Description
I'm using the newest build of Rockbox (2007-07-21) with an iAudio X5 20 GB and I have my tuner set to the European region. I encounter two little flaws in the FM-radio. I think they partially have to do with the player's hardware, but maybe Rockbox can improve the quality a bit.
1. The player is really sensitive to movement. The signal strength differs with every meter that you take the player with you. On top of that, most stations sound like they're not correctly tuned, but I can't get them any better. Maybe Rockbox could be more accurate in frequency selection? (Like 101.100, 101.125, 101.150.) I can get these stations quite well on my home radio. I don't expect the same quality from such a small device, but some finetuning would be great. The only problem is that it would take a while to scroll through the frequencies, but once set it'd be fine. 2. (I assume this is very hardware related.) The radio signal may change between stereo and mono. I have it set to stereo, but sometimes it just picks mono. I guess this is because of the hardware, since it is place related. I also didn't find any potential bugs in the source code.
What are your thoughts on this?
Oh, and keep up this good work! I really enjoy Rockbox!
|
|
7911 | Patches | Playlists | Very Low | Decouple playlist editting from the play/stop state | 2007-10-09 | Costas Calamvokis | 2007-11-06 | 4 |
Task Description
This patch decouples playlist editting from the play/stop state. So, you get the same playlist menu independent of whether rockbox is playing or stopped (and all the commands do the same things). Also, editting the playlist while stopped does not restart playback.
The idea behind this is that now the current playlist appears to the user to be ‘still there’ when stopped (ie you can view it and resume it), it doesn’t make sense for an insert while stopped to insert to an empty playlist.
I have done two patches, the first just makes the current playlist menu available when stopped (no changes to the menu). The only changes are to onplay.c and most of the changes were deletes, so the new code is ~30 lines shorter than the original.
The second patch does the same as the first, but also:
1) it renames “Play Next” to “Replace” 2) it adds a “Replace shuffled” command 3) it renames “Insert” to “Insert in order” (and the same for queue) 4) it does not show the “Insert in order” order command until it is
useful: after an "Insert next" has already been done.
I think these changes make the playlist editing much easier to understand for people new to rockbox (and easier to remember for those not so new). In particular, the current “Insert” can do one of 3 different things (add to empty, insert next or insert after previous insert/ insert next). With the second patch all commands always do the same thing, and the renaming makes it a bit clearer what that thing is.
Anyone who wants to test this should probably also install http://www.rockbox.org/tracker/task/7898 - which fixes a bug in the “Insert next” code.
|
|
7670 | Patches | ID3 / meta data | Very Low | Read rating value from MP3 Id3 tag for display in WPS | 2007-08-28 | Nick Waterton | 2007-12-22 | 5 |
Task Description
This Patch changes the way that ratings work. It’s pretty simple, it reads the rating info from an MP3 files ID3 POPM tag, and converts that to a Rockbox rating value (0 to 10).
You can then use patch FS#6301 - new tags for WPS and tagcache patch 4 (4_rating.patch) to display the rating on the WPS (tag is %rr). Some Themes use this tag already so I’m not sure if it is in SVN already.
The patch is written for MediaMonkey (alpha 3), but it should work with other version of MediaMonkey, and other programs that put ratings in the ID3 tag (not iTunes).
Tested on iPod nano.
One thing I’m not sure of is what value to return for bufferpos - should this return an int ponting to the next id3 tag position, or is it OK to return it as is? it dosen’t seem to make any difference either way.
Comments are welcome.
|
|
8598 | Bugs | Recording | Very Low | FM Recording disk thrashing | 2008-02-12 | g | 2008-02-12 | 2 |
Task Description
When recording, as file size reaches 25.2MB and again at 52.4MB respectively, disk thrashing noise drowns out the recording for about 2 minutes. This occurs at about 27.5 minutes if recording as mp3. And about 5.25 minutes if recording as wav.
I am assuming that Rockbox is filling a cache and then dumping the file to disk all at once.
I would expect it to write quietly. Even if it where to write on the fly, the noise would be reduced to short bursts. 2 minutes of interruption is just not acceptable. I missed out on important information during those 2 minute periods.
How can we eliminate write noise altogether? Or at least in the recording itself.
Select ‘FM Radio’ Choose your station. Then from the menu select ‘Recording’ Press ‘play’ or ‘Rec’ to begin recording. Wait for file size to reach about 28MB. Then stop.
I can also provide recordings if necessary.
*note: I also had the USB cord attached to give better FM reception. tested on e260 & e280 Rockbox Version: r15988-080102
Thanks
|
|
8602 | Patches | Drivers | Very Low | Remove audiohw_set_lineout_vol call from sound.c | 2008-02-12 | Christian Gmeiner | 2008-02-13 | 2 |
Task Description
Hi all.
I have found a funny thing, which should get fixed. In set_prescaled_volume there is this call: audiohw_set_lineout_vol(tenthdb2master(0), tenthdb2master(0));
As far as I can see this call is not needed here. So this patch removes it, but as I own only a sansa e280 I can not test this change. I hope to commit this soon.
If this call is needed… do we need it every time audio changes or only once at init?
Thanks, AustrianCOder
|
|
8639 | Bugs | LCD | Very Low | Backlight does not turn off when hold switch is on | 2008-02-24 | Jeff | 2008-02-25 | |
Task Description
How to reproduce this:-
Use the remote to turn on the player while the hold switch is set to lock on the player. Backlight on both the player and the remote stay on constantly (timeout is set to 5s presently).
If you set the hold switch to unlock the backlight goes off after the timeout has expired and thereafter will turn off however the hold switch is set.
|
|
8764 | Patches | FM Tuner | Very Low | Auto mute weak stations | 2008-03-20 | Joel Garske | 2008-03-20 | 3 |
Task Description
Hi there,
first of all: this is my first contribution to rockbox and I tried my best to make myself familiar with the way things work there. I am sure, not everything is where it belongs. Please help me to get things in order :).
second: thanks to the author of Patch FS#1803 that made this possible.
The purpose of this patch is to watch the tuner reported field strength (estimate) and mute, when it drops below a customizable threshold. Wether muting or not as well as the threshold are customizable in the fm tuner menu. It should not interfere with manual muting and should not affect recording (i didn’t test that yet). THe threshold is specified in pseudo-dBuV. It also adjusts frequency display to display as MMM.KKK instead of MMM.KK. This is for people who adjust region settings and channel widths.
My testing conditions were limited to the sansa c250. FS#1803 reports to work on the tuner chips LV24020LP (e.g. sansa c250) and TEA5767. I only tested the first. Please report back possible field strength values you see on devices using these chips.
This code should not break anything. I did a testbuild for some iPods (without tuner) that compiled cleanly. Simulator also works.
Currently only english and german translation are done.
User guide: This patch conditionally adds 1 or 2 lines to the tuner main window that look like this:
Sig: [-M] -235dBuV
Automute below -555dBuV
The second line is only displayed if automute is enabled. The first line shows the status of the tuner. The 2 characters in the braces exlain as [ab]:
a: either 'O' or '-'
'O': current field strength is above threshold
'-': current field strength is equal to or below threshold
b: either 'M' or '-'
'M': will mute on or below threshold
'-': automute disabled.
(both are only updated on field strength change)
The second line should be selfexplaining, same for the menu entries.
Request for comments!
|
|
8867 | Bugs | Music playback | Very Low | Equalizer is adding high noises | 2008-04-10 | André Scheffler | 2008-04-10 | 1 |
Task Description
The (software-)equalizer is adding high noises to the playback.
I made a recording, the first part with eq enabled the second one with disabled equalizer.
I could also make a test on my older H110, on which I never used the sw-eq though.
|
|
8877 | Patches | Font/charset | Very Low | DejaVu-based fonts | 2008-04-12 | Ori Avtalion | 2008-04-12 | 4 |
Task Description
I created the following fonts from DejaVuSans.ttf using ttf2bdf.
I use them as an alternative for unifont, which is fixed-width.
Attached are a screenshot and a tarball with 8 to 12pt versions of the font. Perhaps they could be included in the official distribution, if others like them.
|
|
8991 | Patches | Plugins | Very Low | caps+symbol shifts for ZXBox | 2008-05-14 | Anton Romanov | 2008-05-14 | 1 |
Task Description
adds ability to use “Caps Shift” (displayed as ‘C’ in vkeyboard) and “Symbol Shift” ( ‘H’ ) so Jumping Jack can be played http://forums.rockbox.org/index.php?topic=16817.0
|
|
9059 | Patches | Font/charset | Very Low | WenQuanYi Unibit font | 2008-05-31 | William Poetra Yoga Hadisoeseno | 2008-05-31 | 3 |
Task Description
This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2].
I’m adding this font because: 1. Currently there is no good Chinese font for Rockbox. 2. The best Chinese font (unifont) has unevenly sized Chinese characters, while this font has uniformly sized Chinese characters.
The attachments contain screenshots of the simulator, to show how this font would look like on the iPod Nano. I’ve also attached a screenshot using the Unifont font to show the uneven sizes of Chinese characters, for comparison. I don’t know about other languages, but I’d think other CJK languages work better in this font as well, due to the merging of WenQuanYi Bitmap Song.
According to the project[3], this font is made by combining the GNU Unifont (GPL), WenQuanYi Bitmap Song (GPL) and Fixed-16×8 (Public Domain) fonts. The maintainer of GNU Unifont also acknowledges this fact at [4].
This font is licensed under the GPLv2 with a font embedding exception[3]:
[quote] ** GPL v2 license with font embedding exception:
As a special exception, if you create a document which uses this font, and embed this font or unaltered portions of this font into the document, this font does not by itself cause the resulting document to be covered by the GNU General Public License. This exception does not however invalidate any other reasons why the document might be covered by the GNU General Public License. If you modify this font, you may extend this exception to your version of the font, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. [/quote]
I don’t mind either way, but it would be up to Rockbox developers whether to strip off this exception. And either way, the font is compatible with Rockbox’s license (GPLv2).
The font I’m attaching is a modified version (and only the bdf); you can download the original version from [5]. My modification is:
— wqy-unibit.bdf.orig 2008-06-01 04:47:36.839752214 +0800 +++ wqy-unibit.bdf 2008-06-01 05:01:51.031748178 +0800 @@ -64,7 +64,7 @@ CHARSET_ENCODING “-1” CHARSET_COLLECTIONS “ASCII ISO8859-5 GB2312.1980 BIG5-0 KSC5601.1989-0 JISX0208.1997 ISO10646-1” ENDPROPERTIES -CHARS 46443 +CHARS 46444 STARTCHAR uni0000 ENCODING 0 SWIDTH 500 0
This is because convbdf will emit a warning “Warning: DWIDTH spec > max FONTBOUNDINGBOX” when converting the font. This is because there are actually 46444 STARTCHAR entries, but only 46443 glyphs – the character “mu” is encoded as 181 and 956, with the exact same glyph. The generated .fnt file is exactly the same with or without my modification.
Additionally, this font is quite big so it’s a bit big on the screen of the iPod Nano. But it would be great on larger screens. Please take a look at the screenshots in the attachments.
Links: [1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?Unibit_README [4] http://www.unifoundry.com/unifont.html [5] http://downloads.sourceforge.net/wqy/wqy-unibit-bdf-1.1.0-1.tar.gz?use_mirror=osdn
|
|
9060 | Patches | Font/charset | Very Low | WenQuanYi Bitmap Song fonts | 2008-05-31 | William Poetra Yoga Hadisoeseno | 2008-05-31 | 14 |
Task Description
This font is part of the WenQuanYi Project at [1]. It’s in Chinese, but there’s an english page at [2]. This font is similar to the WenQuanYi Unibit font (FS#9059) and focuses mostly on ASCII and CJK, but I’m also posting this font for inclusion because this one has different point sizes, like for example the nimbus, Sazanami and ProFont fonts already included in Rockbox. With the different point sizes, especially lower point sizes, this font is great for small screens such as my iPod Nano.
I’m attaching some screenshots of this font under various point sizes and weights. I’ve also taken screenshots with the simulator to show how it would look like in Rockbox.
Additionally, this font is available from the original website at [3]. There is also an online README file at [4]. The source BDF files are available from the project’s SourceForge page at [5], and the BDF files I’m attaching come from the source package at [6].
According to the project[4], this font is a derivation of older free fonts and enhanced with bitmaps made by online users. As such, it is licensed under the GPLv2 with a font embedding exception[4]:
[quote] ** GPL v2 license with font embedding exception:
As a special exception, if you create a document which uses this font, and embed this font or unaltered portions of this font into the document, this font does not by itself cause the resulting document to be covered by the GNU General Public License. This exception does not however invalidate any other reasons why the document might be covered by the GNU General Public License. If you modify this font, you may extend this exception to your version of the font, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. [/quote]
It’s up to Rockbox developers whether to strip off this exception. Either way, the font is compatible with Rockbox’s license (GPLv2).
Links: [1] http://www.wenq.org/ [2] http://wqy.sourceforge.net/cgi-bin/enindex.cgi [3] http://www.wenq.org/index.cgi?BitmapSong [4] http://www.wenq.org/index.cgi?Hero_README [5] http://sourceforge.net/projects/wqy/ [6] http://downloads.sourceforge.net/wqy/wqy-bitmapfont-bdf-gb18030-0.9.9-0.tar.gz?modtime=1194227675&big_mirror=0
|
|
9078 | Patches | Plugins | Very Low | Thinkfast - A plugin to measure your reaction speed | 2008-06-06 | Clément Pit--Claudel | 2008-06-06 | 1 |
Task Description
The purpose of the game is to press one of the four direction keys as fast as possible when randomly asked to do so. At the end of the game, min/max/average values are displayed.
|
|
8305 | Patches | Operating System/Drivers | Very Low | c200: support docking stations with audio | 2007-12-12 | Jerry | 2008-06-16 | 3 |
Task Description
When the c200 is docked (as detected by the charger discrete being active), switch to line out. This was necessary for the Griffen “iTrip Auto for Sansa” adapter to produce output. I would assume this is necessary for other docking stations.
This is *NOT* a perfect patch, but it is a start and is necessary to make docking stations with audio output work.
Limitations: * I mute the headphone output, so plugging in a non-docking charger will prevent listening via the headphones while charging. Both can be enabled… if the charger is plugged in, it probably isn’t an issue but that is what the Sansa firmware does.
* The charger/headphones detection is done only on power up. This is suboptimal, but usually “correct.” A better technique would be to hook into the charger status announcements, but I don’t have time right now.
|
|
7252 | Patches | Video | Very Low | SubRip (srt) subtitle support in MPEG Player. (Edit: +o... | 2007-06-02 | Antoine Cellerier | 2008-06-28 | 8 |
Task Description
This patch adds SubRip subtitle support to MPEG Player. http://wiki.multimedia.cx/index.php?title=SubRip
Files need to have the same name as the video file with a “.srt” extension.
I know that the OSD rendering is not implement in a way that linuxstb and jhMikeS would like but I still wanted to post the patch here in case anyone felt like adapting it. (Current OSD only renders on top of the video area, it can be adapted to add other OSD channels … like display a seek bar, volume control, playback state, etc.)
Enjoy,
Edit: I’ve also added a timebar display (when changing the volume)
|
|
8396 | Patches | Music playback | Very Low | next_dir within playlist | 2008-01-03 | Lee Kang Hyuk | 2008-06-29 | 8 |
Task Description
This patch is inspired by FS7571.
Currently we can move to next/prev directory with <short left/right + long left/right>. This patch changes two part of this functionality:
1. If <Auto-Change Directory> is not enabled, move to first track of current/next directory only within the playlist. So you can maintain dynamic playlist. This was very annoying problem for me.
2. do not wait till <long left/right> is released.
So ffwd or rewind will not be performed at new track.
|
|
9177 | Bugs | Rbutil | Very Low | RBUtil reports a successful install on the e200R when i... | 2008-07-09 | Marc Guay | 2008-07-12 | |
Task Description
Unsure if this is an RBUtil isssue or a sansapatcher issue, or even a Sansa issue that can’t be solved, but according to this (http://www.rockbox.org/irc/log-20080709#02:36:38), it reports a successful install on the e200R when it hasn’t. Related to FS#7526 ?
|
|
9169 | Patches | User Interface | Very Low | Allow seek speed limiting to be optional | 2008-07-08 | Steve Bavin | 2008-07-15 | 2 |
Task Description
This patch adds an option to disable the speed limiting that slows down seeking as you approach the end or beginning of a track.
It defaults to limiting enabled, to maintain compatibility. Personally, I prefer the fast seeking without the limiting.
The manual is not included, I can't compile them still…
|
|
9171 | Patches | Applications | Very Low | Replace the CUBE in cube with COBRA MK III | 2008-07-08 | Dave Hooper | 2008-07-18 | 2 |
Task Description
Dumb patch but introduces handling for non triangular faces (by triangulating them when rendering). Vertices courtesy of http://mackayj.doosh.net/eliteships.html (in particular I hand-converted http://mackayj.doosh.net/files/vrml/eliteships/cobra3.wrl)
|
|
9064 | Bugs | Music playback | Very Low | iRiver H340 skips when battery low | 2008-06-02 | Antony Stone | 2008-08-05 | |
Task Description
- What behaviour you are seeing
Rockbox 17612-080523 on an iRiver H340 skips entire tracks, and also skips within tracks, when the battery level falls below 30%
- What behaviour you expected
No skipping.
- How to reproduce the bug
Allow the battery level to fall below 30% and start playing a directory of files. Some files will be skipped, some files will have parts skipped in the middle.
- The SVN revision you are using and if possible the particular SVN revision in which you think the bug was introduced.
17612-080523, no idea when the bug started.
If you need any further info on this bug, please ask and I’ll give more details. I have no other hardware to test whether this behaviour occurs on other Rockbox platforms.
|
|
8589 | Patches | Build environment | Very Low | Allow to choose Loquendo and ViaVoice TTS | 2008-02-11 | Chelo Sacristán | 2008-08-07 | 2 |
Task Description
It would be useful to change the configure and voice.pl files in order to allow the user to choose also the Loquendo and ViaVoice TTS
|
|
9260 | Bugs | Applications | Very Low | r18234 - core + plugins shouldnt be calling opendir() d... | 2008-08-10 | Jonathan Gordon | 2008-08-10 | |
Task Description
Only filetree.c should be allowed to call opendir(), anything that needs to recursively scan directories should be calling ft_load() which can smartly open, scan and close a directory.
The problem with this is that the filename buffer could get corrupted easily if its misused.
as of r18234 the following is using opendir() in the core filetree.c:133: dir = opendir(c→currdir); ← not recursive filetree.c:257: dir = opendir(tempdir); ← in ft_load() so ok filetree.c:259: dir = opendir(c→currdir); ← “” “” “” misc.c:164: dir = opendir(pathlen ? buffer : “/”); misc.c:1059: dir = opendir(BOOTDIR); misc.c:1142: DIR* d = opendir(path); onplay.c:466: dir = opendir(dirname); onplay.c:817: srcdir = opendir(src); tagcache.c:4075: dir = opendir(dirname);
the tagcache and the onplay.c ones are dangerous… the 3 in misc.c are not recursive so safe.
the following are uses in plugins, havnt checked them so I only know for sure that stats, disktidy and properties are unsafe plugins/disktidy.c:203: dir = rb→opendir(name); plugins/disktidy.c:270: dir = rb→opendir(name); plugins/md5sum.c:78: dir = rb→opendir( path ); plugins/md5sum.c:113: DIR *dir = rb→opendir( newpath ); plugins/md5sum.c:209: dir = rb→opendir( arg ); plugins/properties.c:79: dir = rb→opendir(tstr); plugins/properties.c:151: dir = rb→opendir(dps→dirname); plugins/properties.c:276: dir = rb→opendir(str_dirname); plugins/random_folder_advance_config.c:70: dir = rb→opendir(fullpath); plugins/random_folder_advance_config.c:165: dir_check = rb→opendir(formatted_line); plugins/rockpaint.c:740: d = rb→opendir( bbuf ); plugins/rockpaint.c:754: d = rb→opendir( “/” ); plugins/rockpaint.c:915: d = rb→opendir( FONT_DIR “/” ); plugins/sokoban.c:925: if(!(dir = rb→opendir(dirname))) plugins/stats.c:139: dir = rb→opendir(fullpath); plugins/test_codec.c:763: dir = rb→opendir(dirpath); plugins/test_disk.c:356: dir = rb→opendir(testbasedir); plugins/test_disk.c:359: rb→splash(HZ, “opendir() failed.”); plugins/test_disk.c:421: if 1) == NULL) plugins/wavrecord.c:3774: if 2) == NULL)
so, The bad calls in the core should be changed to use ft_load, and the plugins should either get a new function in the lib to grab some ram and manage the whole thing, or maybe its safe to just call ft_load there also?
or alternatively, we can go on ignoring the issue.
|
|
8794 | Bugs | Operating System/Drivers | Very Low | Freeze/Long duration when auto-creating bookmark if the... | 2008-03-24 | T | 2008-08-11 | |
Task Description
Rockbox Version:r16780-080324
Description: If the “Bookmark on Stop” option is set to “Yes” and there is no free space left on the storage, rockbox freezes/takes a REALLY long time if pressing the Poweoff(=Stop) button, because it cannot save the bookmark(or has to push out the less recent?).
I wondered why rockbox crashed if doing this til I discovered this bug.
Expected behavoiur: Instantls notify user there’s no space left and don’t save the bookmark
How to reproduce: 1. Power on the player, launch rockbox. Make sure there’s enough disk space. 2. Go Settings→General Settings→Bookmarking→Bookmark on Stop→Set to “Yes” 3. Reboot, connect to PC 4. Create a text file which is big enough to consume the rest of your free disk space 5. Restart Sansa into rockbox 6. Play a track 7. Press poweroff (short)
|
|
7497 | Patches | Applications | Very Low | Add a magic string to bootloader version to enable loca... | 2007-07-28 | Dave Hooper | 2008-08-12 | 1 |
Task Description
Simple patch to add RBBLver prefix + suffix to the bootloader version string. rbutil can scan the binary bootloader file to locate this string to determine the bootloader version. download.rockbox.org can now be updated to include bootloader.version files alongside the binaries (e.g. extract the bootloader version from the binary using od -S 6 | grep RBBLver )
|
|
9295 | Patches | Battery/Charging | Very Low | Charger detection for iPod 2G (and 1G?) | 2008-08-18 | Mark Fawcus | 2008-08-18 | 1 |
Task Description
This patch adds detection of the charger connection. Not tested on a 1G, but should work if the ipodlinux GPIO documentation is correct.
NOTE: 'Charging' is not detected, just the presence of external power. See http://forums.rockbox.org/index.php?topic=18196.0 for forum topic.
|
|
9356 | Patches | Applications | Very Low | Allow to set the delay before button repeat is activate... | 2008-09-02 | Alexander Levin | 2008-09-03 | 1 |
Task Description
The patch allows to set the delay after which the button repeat event is generated. Since this event is used to detect a long button press, it effectively sets this 'threshold.'
Slow fingered users may often hold the select button too long and (unintentionally) get the context menu. For instance, from the WPS screen. But they actually wanted to go to the file browser.
The patch adds a setting for that delay. Its default value is 30 ticks (=0.3s). The menu entry is in Settings → General Settings → System → Long Button Press Duration.
|
|
9273 | Patches | Language | Very Low | Changing sapi_voice.pl To make japanese.voice sound bet... | 2008-08-13 | Taktak | 2008-09-23 | 18 |
Task Description
I would like to change voice strings to make them sound better with a specific SAPI voice.
I don’t intend to change string in *.lang directly. It should be done in voice.pl dinamically while building voice, shouldn’t it?
|
|
9413 | Bugs | Battery/Charging | Very Low | Rockbox (and bootloader) mistakes battery for USB. | 2008-09-22 | Paul Skinner | 2008-09-24 | |
Task Description
This may represent other players as well.
I installed a new battery on my iriver, a 2100 mAh that is working perfectly. The problem however, is that when fully charged, the voltage holds up to 4.12 volts, and until it drains to somewhere under 3.9 volts, Rockbox thinks that it is powered via USB, so naturally Rockbox gets stuck in USB mode until the battery is drained enough for Rockbox to realize that it IS a battery. With this problem at hand, I have to charge my iriver to only less than seventy percent of its battery life, or else wait for an hour or so to drain it to that point. I HAVE tested it in its original firmware, like I said, works perfectly. The problem lies with Rockbox thinking that the battery is a USB charger. I am asking for a fix around this. Is there a way that I can modify Rockbox so that it may understand that it is running off of a battery that will get up to 4.12 volts and not mistake that for USB power? I just now thought to turn off the “Charge During USB Connection,” maybe that will solve the problem; I will get back when I find out whether or not that works. However, I would still like to request a work around for this problem. Any help is much appreciated. Thanks.
|
|
9330 | Patches | Rbutil | Very Low | patch for openBSD support for ipodpatcher | 2008-08-28 | Brian | 2008-10-08 | 3 |
Task Description
The following patches will allow someone running openBSD to run ipodpatcher. This is my first pass at these patches, so they cannot be integrated without some problems.
A few outstanding questions remain:
1) should I use /dev/sd0c or /dev/rsd0c?
2) why do byteorder(3) functions exist in fat32format.c?
3) how do the developers want to handle disk geometry?
I ask the last question because my patch overwrites the existing ioctl with what works for openBSD, rather than separate it out. And the patch doesn't fully use what is available in struct disklabel. I plan to re-write this one.
The fat32format.diff comments out byteorder(3) functions. The ipodio-posix.diff converts the file to openBSD disk geometry. The ipodpatcher.diff corrects the device used.
I have only tested the patches above for ipodpatcher on iPod nano 1st gen.
|
|
9381 | Patches | User Interface | Very Low | Gigabeat S Play/Pause/Menu Keymap Change | 2008-09-08 | Marc Guay | 2008-10-11 | 1 |
Task Description
This patch modifies the Gigabeat S keymap so that it can be used almost solely using the buttons on the face of the player.
Currently, there is an unused button in the WPS screen (the BACK button, up-left from the cross) which in my mind makes more sense as the “back to the menu” button, while the MENU button (up-right from the cross) is the logical Play/Pause button (at least to a right-handed individual). It’s unfortunate that the button with the Windows logo has been called the MENU button in the code, thus making this rather confusing to read, but if enough people agree with the feel of this change, that could be modified as well.
|
|
9501 | Bugs | Applications | Very Low | severe screen corruption on H300 | 2008-10-21 | Khashayar Naderehvandi | 2008-10-22 | |
Task Description
I have just now installed the latest stable version of rockbox (that would be 3.0) on an iriver h340. Unfortunately, it’s unusable at the moment due to some serious screen corruption. It sort of looks like this picture: http://img54.imageshack.us/img54/2263/iriver3qs.jpg, but is so much worse that it’s impossible to navigate the menus. If I wait for the backlight to go off, and then press a button, the screen looks fine until I start navigating, at which point the corruption resurfaces.
I’m really excited about rockbox, but this bug is a showstopper for me at the moment.
Thanks for looking into it!
Regards.
|
|
9513 | Patches | Build environment | Very Low | Smarter release scripts | 2008-10-29 | Jonas Häggqvist | 2008-10-29 | 1 |
Task Description
This patch modifies bins.pl, manuals.pl and voices.pl to be smarter, just like the new w32sims.pl, adding a -r commandline switch, allowing the same script to be used for building both daily and release versions.
|
|
9514 | Patches | Operating System/Drivers | Very Low | make simple list accept a viewport | 2008-10-30 | Jonathan Gordon | 2008-10-30 | 1 |
Task Description
this is part of a different patch which was changed to use the menu api instead of simplelist so im putting it up here incase anyone decides to make simplelist draw in a viewport.
The patch works (or did last time i tried it) but isnt commited because its not really needed just yet.
|
|
8372 | Bugs | Bootloader | Very Low | Idle Poweroff only reboots my 1G iPod | 2007-12-25 | bil jeschke | 2008-11-12 | |
Task Description
The Idle Poweroff only reboots my 1G iPod. I assume it should power it off or put it into a power saving mode. This forces it to use up the battery faster then normal unless I set the Hold button to boot into the iPod firmware to do a proper suspend when Rockbox reboots.
|
|
9571 | Patches | Games | Very Low | new plugin for AEG style for roll and keep style dice r... | 2008-11-22 | Tom Bogue | 2008-11-22 | 1 |
Task Description
This patch adds a new plugin called aegdice, which allows for AEG style (i.e. 5k3) dice rolling.
|
|
8913 | Bugs | Build environment | Very Low | compilation error due to GNU core utils BLOCK_SIZE valu... | 2008-04-20 | Peter D. | 2008-12-02 | |
Task Description
Hi,
There is a compilation problem when the environment variable BLOCK_SIZE is set. It gave me errors about a comma.
This can be set or cleared systematically or on a command by command basis.
Suggestion one; unset BLOCK_SIZE and its relatives high in the build chain, but be prepared for POSIX to bite with 512 byte blocks.
Suggestion two; set LS_BLOCK_SIZE=1 high in the build chain. (And DF_BLOCK_SIZE=1024 and DU_BLOCK_SIZE=1024 ?)
Suggestion three; edit apps/lang/Makefile so that
$(SILENT)echo “#define MAX_LANGUAGE_SIZE `ls -ln $(OBJDIR)/* | awk ‘{print $$5}’ | sort -n | tail -1`” > $(HEADER)
becomes
$(SILENT)echo “#define MAX_LANGUAGE_SIZE `ls -ln –block-size=1 $(OBJDIR)/* | awk ‘{print $$5}’ | sort -n | tail -1`” > $(HEADER)
or
$(SILENT)echo “#define MAX_LANGUAGE_SIZE `LS_BLOCK_SIZE=1 ls -ln $(OBJDIR)/* | awk ‘{print $$5}’ | sort -n | tail -1`” > $(HEADER)
Suggestion four; just tell people that they are not allowed to have commas in their core utilities output (and be prepared to be bitten badly if the default block size ever changes).
BTW I *like* having thousands separators on my command line, so I have
export BLOCK_SIZE=\'1
export DF_BLOCK_SIZE=\'M
in my /etc/bashrc file.
|
|
9202 | Patches | Bootloader | Very Low | iriver H300 bootloader power/usb fixes | 2008-07-16 | Matthew Haun | 2008-12-09 | 2 |
Task Description
This patch changes the iriver H300 series bootloader's power and usb handling. When a USB or Power plug are inserted into the H300, it will now boot as normal, not stop in the bootloader usb/charging modes. This was mainly for use in my car, but is also helpful for people with charging cradles for their computers.
Forum thread can be found here http://forums.rockbox.org/index.php?topic=17202.0
|
|
6041 | Patches | Drivers | Very Low | H10 Scrollpad | 2006-09-21 | Holger Winnemoeller | 2008-12-12 | 2 |
Task Description
The scrollpad on the H10 (20gb, not sure about 5/10gb) has always bothered me with being jumpy, inaccurate, and unintuitive. At the moment (in rockbox) it seems as though it is working as a simple two button device (up/down), with no real dragging capabilities. I am wondering if this is a limitation of the hardware or current software implementation.
The original firmware seemed to work as follows: split slider into upper and lower field. Tapping in either upper or lower half would create click-type event for up/down. Dragging in upper half would produce scroll up, draggin in lower half would produce scroll down events. The problem was that upper and lower halves are really kinda arbitrary and not easily distinguishable.
What I think would work nicely: Tapping top and bottom, as before. Remove upper and lower restrictions for dragging, i.e. if dragging down (anywhere on the scrollpad) create scroll down event, if dragging up (again, anywhere) create scroll up event. Drag and hold will scroll in desired direction proportional to the drag speed (as in pushing a puck on ice). Hold (just hold, no tap or drag) on the touchpad creates a sliding value that can be used as a coordinate for different types of continuous input.
To implement this, we’d need some kind of knowledge about what signals the actual hardware provides, what resolution the pad has, i.e. what the physical and logical implementations of the device are. I am not sure how the Ipod scrollwheel works, but it seems that some of that code could be re-purposed, maybe?
|
|
7877 | Patches | Plugins | Very Low | Being able to adjust volume while using stopwatch plugi... | 2007-10-01 | Håkan Hagström | 2008-12-12 | 1 |
Task Description
It would be nice to be able to change volume while using the stopwatch plugin. If I don’t have the volume perfectly adjusted when starting my jogging round, I have to choose between running the rest of my laps with too low/high volume or discarding my times to change it, as the scroll wheel doesn’t have any function in the plugin.
|
|
9329 | Patches | ID3 / meta data | Very Low | Remove total tracks and total discs from ID3v2 tags. | 2008-08-27 | Magnus Holmgren | 2008-12-12 | 1 |
Task Description
This patch removes any total tracks and total discs number from the track and disc number fields in ID3v2 tags, so that track and disc numbers are displayed consistently across different tagging formats.
What happens is that if a number larger than zero can be parsed from the start of the field, then the field is terminated on the first “/” char.
Added as a patch as I don’t know if this behavior is wanted.
|
|
9628 | Bugs | Music playback | Very Low | Sound sometimes doesn't work on mr100 if booted without... | 2008-12-12 | Frank Gevaerts | 2008-12-12 | |
Task Description
Tested with r19410
If I boot with the headphones plugged in, sound always works (at least I didn’t have it fail yet). If I boot without headhones plugged in, and plug them in later, sound often doesn’t work. This may also depend on whether the player was turned off for a long time, whether the previous boot was USB mode, and whether the headphones were unplugged before or after shutting down.
|