Rockbox

IDTask TypeCategoryPrioritySummaryOpenedOpened byLast Edited
10143BugsDriversVery LowLicense of firmware/export/usb_ch9.h is unclear2009-04-18Frank Gevaerts12009-04-19 Task Description

firmware/export/usb_ch9.h comes from linux (include/linux/usb/ch9.h) with only trivial changes. The original doesn’t mention a specific license, so it probably is GPLv2
file basically contains only structure declarations and defines for things straight from the USB specification though, so I’m not sure if there is a real problem.

10135PatchesPluginsVery LowX-Y Scope Plugin2009-04-15Tony Huynh42009-04-194 Task Description

I brutally hacked the Oscilloscope to pieces and tried to make an x-y scope.

Please feel free to edit and contribute because I honestly have very limited knowledge of PCM data and the inner workings of rockbox =]

10117PatchesMusic playbackVery LowBehaviour of PREV/NEXT when "skip length" > 0 and "prev...2009-04-09Alexander Levin2009-04-093 Task Description

I put up the three patches (before they expire on pastebin.com) that correspond to the three proposals of how the behaviour of PREV/NEXT could/should be changed. Note that only the situation described in the “subject” of this task is considered and changed.

The IRC discussion is at http://www.rockbox.org/irc/log-20090406#21:35:42

The start of the discussion on the mail list is at http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-04/0057.shtml

10109BugsMusic playbackVery LowDirectory skip hangs iaudio x52009-04-08philip kao22009-04-09 Task Description

This IS a duplicate of  FS#6904 .

My iaudio x5 hangs when changing directories via short+long direction button presses. It switches to the next directory, but no audio plays, and the WPS shows that it stops at 0:02 of the track.

10106BugsBattery/ChargingVery LowClicking noise on Gigabeat S only when battery is fully...2009-04-08Eric Jorgensen12009-07-23 Task Description

Currently running r19940 but there doesn’t seem to have been any chage in the power code for the gigabeat S recently.

The issue is that there is a regular clicking noise heard if DC power is connected while the battery is fully charged. This noise is not heard while the battery is charging. The same power adapter doesn’t cause the same noise on an F.

10089BugsUser InterfaceVery LowScrolling doesn't pause at the top or bottom of a list ...2009-04-02Bertram Bourdrez12009-04-02 Task Description

I’ve been reliably informed that Rockbox should stop scrolling when it gets to the bottom or top of a menu, only to wrap around when you initiate a new scrolling gesture. On a 2nd Generation iPod, however, it just keeps scrolling.

See http://bertram.bourdrez.org/buggyrockbox.avi (the video is recorded with an old Rockbox, but 3.2-090323 does the same thing)

Also, the bug tracking system is overcomplicated. I have to register an account?!
“Why the hell should *I* set up an account? It’s not like any bugs will be assigned to me or anything. Just store my e-mail address and move on. It’s completely fucking bogus that I should have to go digging through my mail for confirmation passwords.” (http://zork.net/~sneakums/fortunes/gar/215)

Then I have to click a link with a magic number in it *as well as* having to enter a confirmation code from the same email (!?) and then when I’ve finished, I’m not even logged in! I have to log in with the same password I just set! Can’t it just set a cookie?

10071PatchesCodecsVery LowTrying out Tremolo optimisations for tremor on ARM2009-03-29Dave Hooper42009-03-296 Task Description

This first patch is a merge of Tremolo’s bitwise.c and bitwiseARM.s code into rockbox libtremor. As a naive version of the merge, I have taken out the previous rockbox optimisations to huffman decode (originally implemented in  FS#6848 ). Versus svn, decoding speed is worse with this patch. However something that incorporates both  FS#6848  and the Tremolo bitwise optimisations for little-endian ARM may well turn out better. This patch is seriously not committable, the arch-specific stuff is not done cleanly in the headers or the makefile

10063PatchesPluginsVery LowAdd fastforwad/rewind to Playback Control menu2009-03-27Teruaki Kawashima2009-03-271 Task Description

this is an attempt to implement the idea suggested in the forum (http://forums.rockbox.org/index.php?topic=20120.0).
I take values from “skip length” setting for variable steps.

10039BugsThemesVery Lowfast changing time indicators when pausing with fading ...2009-03-21Johannes Linke62011-07-27 Task Description

to reproduce:

1. set playback settings–>fade on stop/pause to on.
2. play some music.
3. press the pause button to stop the music, and again to restart it. repeat that a few times, because this bug does not always occur.

you will notice that both “time-displays” sometimes change very to the previous second and then back to the normal one, e.g 3:32, then very short 3:31, and back to 3:32. the progressbar sometimes get smaller for a fraction of a second, too.

maybe i’ll search for the revision which introduced this in the next few days

10037BugsDatabaseVery Lowdatabase_changelog corrupted/wrecked2009-03-20Giles82012-08-29 Task Description

Build 20399

The database_changelog.txt is corrupted in that the wrong filename is associated with a track, this has happened before (pre v3.0), I had to write ascript to correct it.

Exampe row from log:

artist=”Teach Yourself” album=”Polish Conversation (Disc 3)” genre=”Books & Spoken” title=”Conversation 1: Booking A Hotel In Krakow” filename=”/iPod_Control/Music/Blur/Blur - Blur/14 Essex Dogs.mp3” composer=”<Untagged>” comment=”<Untagged>” albumartist=”Teach Yourself” grouping=”Conversation 1: Booking A Hotel In Krakow” year=”2006” discnumber=”3” tracknumber=”2” bitrate=”71” length=”640824” playcount=”0” rating=”0” playtime=”0” lastplayed=”0” commitid=”12” mtime=”955689818”

10034PatchesLCDVery LowiPod Photo, Color: LCD sleep and proper LCD shutdown2009-03-19Boris Gjenero102010-06-234 Task Description

This patch implements HAVE_LCD_SHUTDOWN functionality for Photo and Color iPods. It is in response to issue 2 in http://forums.rockbox.org/index.php?topic=20994 : “2. The LCD screen on the iPod is not cleared properly when I shut down rockbox. I see 1-2 horizontal lines remain on the screen (which do fade after a minute or so). Nothing is wrong with my IPod’s LCD screen as I did not experience this with Apple’s Firmware”

It seems the Color iPod can have 4 different LCDs. They’re detected via two GPIO bits in lcd-color_nano.c. Types 0 and 2 are the old LCD with an unknown controller and they use the same init, shutdown and update procedures, and they are reported as 0. Types 1 and 3 are similar to HD66789R. They have different init and shutdown procedures but they share the same update procedure. Both 1 and 3 were reported as 1 earlier.

To see what LCD type you have, from the main menu go to System → Debug (Keep Out) → View HW Info and then see the number after “LCD type:”.

This patch has only been tested with LCD type 3 so far.

I am submitting this as a patch because I feel it is not a significant bug. Theoretically, the DC voltage that’s left can degrade the LCD, but the line fades quickly and no negative after-effects were reported.

I would like to also add LCD initialization code and develop HAVE_LCD_SLEEP functionality.

10030BugsUser InterfaceVery Lowlatest nat sort fix still sorts wrong2009-03-17bryan vandyke262011-09-067 Task Description

In the never ending saga of strnatcmp the fix for 10029 sorts as
001
002
01
02

Attached is yet another attempt to get it right.

10023PatchesDriversVery LowiTunes communication for software USB targets2009-03-14Jonas Häggqvist22009-03-173 Task Description

This patch will make an e200 present its SD card as an ipod mini 2G when queried by iTunes. It does this by changing a number of things:

1) Responding to SCSI inqueries
2) Using Ipod USB vid/pid and other usb details

The patch also enables logf for the usb_storage.c because I’m in a bit of a hurry.

To use this, make sure you have a partition on the SD card of type 0 (any size should do) and also the appropriate Ipod file structure (can be generated with e.g. gtkpod).

10022PatchesPluginsVery LowBeatbox fix2009-03-14Tony Huynh172009-06-227 Task Description

This should hopefully make beatbox compile and run on any target with enough buttons.

All it needed was some key mappings (and some typo fixes). I’m assuming the function declaration for synthSamaples() simply changed over time, as the original code was missing an ‘s’ on the end of function name and looked like this:

  synthSamples(&synthtemp[0], &synthtemp[1]);

The second param should be the sample size or something, but it was passed an address.

If it doesn’t work on a particular target due to lack of a key map, please add one, or tell me the target and i’ll stick a keymap in ^_^

Patch from within root rockbox source folder.

Hopefully this works for you all, its many hours of fun =D

10021PatchesBuild environmentVery LowPatch to build Rockbox firmware by using MinGW. 2009-03-13Yoshihisa Uchida72010-01-286 Task Description

The Rockbox firmware and cross compilers build by using MinGW.

It is necessary to use MSYS’s make (MinGW’s make (mingw32-make) does not used.).

The cross_compilers.zip is a patch file necessary to make cross compilers using by rockboxdev.sh.

I confirmed the Rockbox firmware, codecs and plugins was built by using the compiler on MinGW.
But I can not confirm whether the Rockbox executes excluding iPod video.

Could you confirm operation to various players?


9966BugsBuild environmentVery LowH10 5G MTP bootloader can't be built from configure2009-02-27Frank Gevaerts22009-03-031 Task Description

The H10 5G MTP needs a different bootloader than the UMS version (see http://www.rockbox.org/twiki/bin/view/Main/IriverH10PortDevInfo#Build_a_Rockbox_Bootloader).
I’m not sure about the correct way to do this in configure, so I’ll leave it to someone who is.

9957BugsUser InterfaceVery LowUSB connection not made when action_userabort() is used2009-02-26Jonas Häggqvist112009-10-272 Task Description

Using a bootloader from  FS#9955 , a USB connection is not made if Start Screen is set to WPS, and the user boots Rockbox by inserting a USB cable.

This is possibly also true for other values of Start Screen.

Tested on e280, but I expect it’ll likely be the case on other PP targets with USB

9954BugsRemoteVery LowiAudio X5L remote erratic starting with build from 2009...2009-02-25Chris Miller152011-09-282 Task Description

I have been using Rockbox for almost 2 years now on my X5L together with the remote and I have frequently updated to the current version, so I am familiar with how it works.

I have noticed that after updating to version 20090221, my X5’s remote’s LCD behaves erratically (strange lines being displayed all over, vertically shaky image) right after booting Rockbox, then the display turns off completely after a few seconds. Strangely though, the controls still work and the blue display light comes on when working the controls, but the display is turned off (there is nothing being displayed, as if the player were turned off). If I unplug and reconnect the remote, the remote’s LCD comes on, but soon turns off again. The X5’s main LCD is working just fine.

I thought that my remote was dying on me, but decided to check if it was somehow related to the development of Rockbox. I reverted back one build after another and found that the last build that works OK for my remote is 20090210. So, in all the builds starting with 20090211 (I have thoroughly checked all from 20090211 to 20090225), the remote is practically unusable. I looked at the changes done on that day (http://www.rockbox.org/daily/changelogs/changes-20090211.html), but could not single out the probable cause.

Great software, anyway!

9953PatchesPluginsVery LowAdd Playback Control to more plugins2009-02-25Joshua Simmons142009-03-2315 Task Description

I’ve noticed that many plugins don’t have the Playback Control menu even though they could. I’m going to have a go at fixing that.

I’ve categorised the plugins which could use the menu like so:

Already have a standard-ish menu (not bitmap), it just needs to be added:
bubbles
chessbox
chopper
minesweeper
reversi
superdom
wormlet
xobox
clock
fireworks
vu_meter

These are the easiest case, it’s just a matter of adding the menu item.

Don’t have a menu that makes sense to add Playback Control to (either they don’t have a menu at all, or they only have a start-menu that can’t be usefully returned to):
flipit
invadrox
maze
robotfindskitten
rockblox
rockblox1d
rocklife
sliding_puzzle
snake
snake2
spacerocks
star
stopwatch
mandelbrot
oscilloscope

These are a mixed bunch. Some could actually use a menu, and some could just have a key assigned to bring up the Playback Control menu. More involved than the first bunch in general.

Already have a menu, but it’s really custom in some way. They either need to be switched to more standard menus, or something special needs to be done:
brickmania
chessclock
pegbox
rockpaint

These will probably be the most work.

Let me know if I forgot any plugins, or if you think it doesn’t make sense to add the menu to a plugin that I’ve listed above.

Attached is a patch for the first bunch. The others will be coming eventually.

I’d appreciate it if you leave this FS entry open until I get to the second and third bunch, even if the first bunch happens to get commited to svn.

9951BugsRemoteVery LowIpod Accessory bug reports2009-02-24MichaelGiacomelli1732018-08-0439 Task Description

If your Ipod accessory doesn’t work with rockbox, you can report it here.

Please put your device name, Ipod model, and tested rockbox version in your post. If some but not all features work, be sure to mention that in your post.

Edit by rasher:
You should also add your results to this page page: http://www.rockbox.org/twiki/bin/view/Main/IpodAccessories

For any developers who might work on IAP support, please add patches to this task, so potential testers are notified.

9948PatchesLanguageVery LowUse sentence case in english.lang2009-02-23Dave Chapman72009-03-111 Task Description

This patch attempts to permanently fix the inconsistent mixture of “Title Case” and “Sentence case” in english.lang by applying “Sentence case” to the entire file.

I suggested we do this in a post to the rockbox-dev mailing list last year, but that just ended in a very split discussion with no conclusion.

I’m not sure if this patch wil result in anything different, but I made it for my own use, and thought I would post it, as there were a fair number of posters to that discussion that also prefered sentence case.

The old discussion:

http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-08/0034.shtml

EDIT: I forgot to say this patch also changes a couple of uses of “center” to “centre”…

9942BugsUser InterfaceVery Low"First Keypress Enables Backlight Only" broken on 5G an...2009-02-22Boris Gjenero352009-02-242 Task Description

“First Keypress Enables Backlight Only” doesn’t work on the 5G iPod. For example, if that’s enabled, the backlight is off and I press next track while at the WPS, Rockbox will go to the next track.

It seems like clickwheel event(s) generated when I touch the wheel turn on the backlight. When the button is pressed, the backlight is already considered to be on and the button press performs its usual action. If I carefully hold my finger still on the clickwheel, let the backlight fade, and then carefully press a button without moving my finger on the clickwheel, I am able to turn on the backlight without causing anything else to happen.

I don’t know what to do about this. Requiring a physical button press might be annoying. Removing this option on affected targets might be okay, because it’s easy to turn on the backlight by touching the clickwheel (and that doesn’t seem to cause anything else to happen). Another possibility is to require more or specific wheel events.

I set player type to iPod 5G because that’s all I have, but I expect this problem also exists on other clickwheel iPods. This problem exists on r20079 and r20033.

9917PatchesDriversVery LowCowon D2 Usb Serial2009-02-16Michaël Burtin52010-10-262 Task Description

Here’s a patch to have a functional usb_serial driver allowing the use of “Logf over Usb” debug function.

9906PatchesFont/charsetVery Low15-Adobe-Helvetica.bdf: invalid SWIDTH, DWIDTH for ETHI...2009-02-14Yoshihisa Uchida2009-12-151 Task Description

For 15-Adobe-Helvetica.bdf:

STARTCHAR ETHIOPIC SYLLABLE NO
ENCODING 4758
SWIDTH 1520 0
DWIDTH 19 0

The above value of SWIDTH, DWIDTH is too larger than that of other Ethiopian characters (This character protrudes from bounding box).

I send this bug’s patch.

9903BugsBattery/ChargingVery LowiAudio M3 does not charge *ever* using Rockbox2009-02-13Wyatt82010-03-10 Task Description

Using the latest revision (r20001 - but its been broken since I started using Rockbox) the iAudio M3 does not recharge the battery using either the USB or the Power adapter.

The only way I can get the iAudio M3 to charge is to use Cowon’s firmware.

9881PatchesPluginsVery LowEnable toggling the lamp on and off in the lamp plugin2009-02-07Alexander Levin12009-02-082 Task Description

This patch is a continuation of FS#9879 and includes it (but adds something more). It adds the possibility to switch the lamp on and off without leaving the plugin.

Key mappings were taken from FS#8934.

9879PatchesPluginsVery LowQuit the lamp plugin by pressing a dedicated QUIT butto...2009-02-07Alexander Levin32009-02-091 Task Description

As of r19940, the lamp plugin is quit by pressing any key besides some which have a function in that plugin (or so is the intention –see bug report  FS#9877 ).

This patch changes the plugin so that it’s left with a special button only. The patch also adds key definitions for some players that haven’t been included before (players without color LCD). Key mappings were taken from the patch in FS#8934.

Essentially, this patch implements an atomic part of that patch.

Also, correct handling of USB has been added.

This is in preparation of a (separate) patch for toggling the light on and off without leaving the plugin.

9861PatchesPluginsVery LowPlugin for flash card memorizing: mnemosyne2009-02-02Joseph Garvin72009-04-161 Task Description

This is a new plugin that mimics the open source PC program mnemosyne (http://www.mnemosyne-proj.org/), a program that assists with memorizing flash cards. The plugin is fully functional, but it still needs a menu and assumes that the user has setup the folders it needs for storing cards before running (if you don’t create them it will crash). I’ll fix these issues in the near future, but in the mean time any feedback is appreciated :)

9856PatchesPluginsVery LowMore robust patchset.cfg reader for midi player2009-02-01Corwyn Simpson22009-02-132 Task Description

I was reading http://forums.rockbox.org/index.php?topic=17079.0 and thought I’d take a swing at it. So far, I have added (potentially shaky?) support for the ‘#’ comments in the file posted, allowing both Windows and Linux line ending formats, and longer filename support.
Still having problems with the white space after each entry, and detecting or assuming the presence of the file extension.

9822BugsPlaylistsVery LowRB sometimes forgets where it is in a playlist and that...2009-01-23Jeff Nemic152009-04-161 Task Description

Sometimes when I shut my unit off and then turn it on again and resume playback, RB resumes from a different place than where it left off, and even though when I resume shuffle is on (as indicated by its icon), it isn’t. It’ll play the current track, then the next track in the playlist (which in my case is in order by track number, so it’ll play the next track on the album), and so on.

If I turn shuffle off and then on again, shuffle works correctly again.

I’m using a build from January 19 (19800-090119) on an Archos Recorder. I
noticed this bug occurring in the 3.1 build as well.

It seems to happen randomly – I can’t figure out anything specifically that I can do to always make it happen.

9802PatchesManualVery LowPlugin API documentation v22009-01-15Maurus Cuelenaere2009-01-151 Task Description

This is v2 of the Rockbox plugin API documentation generator.

See the mailing list for more information ( http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-01/0040.shtml ).

An example of what the output looks like is available here: http://mcuelenaere.alwaysdata.net/rockbox_api_example_3/

9787PatchesDriversVery LowiPod 5G TV out2009-01-12Boris Gjenero222009-03-094 Task Description

Here is a preliminary patch for TV out on a 5th generation iPod. Play a BMP file and TV out will activate. NTSC is the default. If the file has 576 lines, the output will be in PAL. The image stays until another is loaded or TV output is disabled via the debug menu..

The following formats ought to work:
720×480, 24 bpp for NTSC
720×576, 24 bpp for PAL
Many programs including Windows Paint and ImageMagick convert can write such files. Other resolutions and bit depths may work. For example WPS background screens display properly but other WPS bitmaps don’t.

Known issues:
- More work needs to be done to integrate this with Rockbox. No, you cannot view the Rockbox interface, JPEGs or mpegplayer output yet.
- When the LCD is updated, there is a temporary disturbance on TV output
- http://en.wikipedia.org/wiki/Macrovision#Analog_copy_prevention is enabled. Yes, the hardware can disable it, but I haven’t figured out how to do that yet.
- The original firmware probably outputs images differently. It can load programs into the BCM which perform decoding there, and that is probably faster.

9779PatchesBuild environmentVery Lowrework of assert2009-01-11Yoshihisa Uchida12010-02-172 Task Description

Building Rockbox fails if assert() (in firmware/include/assert.h) is used.

Then, I reworked assert.h.

changes:
When assert() failed, the correction that displayed the file name, the number of lines, and the condition of failing was done.
Moreover, when the log was enabled, the log was output to the file.

Please select the following to make assert() enabled when you make Rockbox.

1) Run tools/configure

2) Build (N)ormal, (A)dvanced, (S)imulator, (B)ootloader, …

    Select "A"

3) (D)EBUG, (L)ogf, (A)ssert, (S)imulator, (P)rofile, (V)oice

   Select "A"

4) make

9778BugsBootloaderVery LowSingle Mode Bootloader fails reboot on updated Gigabeat...2009-01-10Davide142011-04-11 Task Description

I used the official toshiba updater to get an “original” fresh install on my beast and then attempted to run through the install procedure for a single boot rockbox install. After a (seemingly) sucessful install I’d end up in recover mode after any reboot.

Fatal error when attempting to install nk.bin (rockbox only bootloader) using sendfirm in Windows to an updated (v1.2) Gigabeat S player.

After install of both bootloader and rockbox the Gigabeat S, once rebooted, goes into recovery mode (toshiba) and requires an update/restore. This is the Number 3 Triangle.

Notes:
Gigabeat was first updated using the official toshiba MESV12US updater. “gbs_update_1_2_us.exe”

Using SVN revision 19741 to compile nk.bin under WinXP and Cygwin.
Using MTP.zip of 7/4/2008 found on the wiki to send over the bootloader.

I suspect most devs updated their bootloaders using the sendfirm utility *before/without* updating the entire player with the updater utility from toshiba. Thus they started from a v1.1 OF and never updated any part of that.

Maybe the updater changes something in the bootcode. I don’t know.

9775BugsMusic playbackVery LowPremature and multiple storage_sleep() in buffering.c2009-01-10Boris Gjenero102011-11-111 Task Description

While examining disk performance with  FS#9708 , I found one album where the disk stayed spinning with no activity for 5 s longer when using PIO. This is repeatable with that particular album. With the downloaded r19739-090109 build, this did not happen with the default settings but it started happening as soon as I enabled dircache. Prolonging the disk timeout prolongs the extra sleeping time.

Experimentation with shows that the storage_sleep() part of fill_buffer() (in apps/buffering.c) is executed early in the buffering and it is not executed at the end. With another album where spindown happens properly, ata_sleep() is called twice. Note that ata_sleep() just sets last_disk_activity, and sleep happens over half a second later if there is no disk activity during that period and last_user_activity has timed out.

I think this is a race condition based on how dircache and transfer rates change things. I wonder if it is related to  FS#9541 .

The data mentioned is located at http://spreadsheets.google.com/ccc?key=pkeRcfM0sg949P3a5EYXtew and the delayed spindown is seen in the EP7 PIO test. In that data, also note how sectors written are 5, 10 or 15, with differences between different tests with the same album.

I have a 30GB 5th generation iPod, but I expect this issue affects all SW-codec players.

9765BugsMusic playbackVery Low"Beep" sounds very distorted and fuzzy.2009-01-06mike beauchamp42009-01-08 Task Description

After upgrading from 3.0 to 3.1, the “Beep” sound (enabled in Settings / Playback Settings / Beep Volume) now sounds very distorted and fuzzy.

It sounds this way on any setting. Strong, Moderate or Weak and with the player’s volume on any setting. It definitely sounded like a normal clean beep with 3.0

This is on an 80gb Ipod 5.5 with Rockbox r19569-081223

I’m not sure if this should be under “Music Playback”, as I don’t seem to hear the distortion and fuzziness when playing mp3’s.

Mike

9746PatchesDriversDeferDrive PP502x IDE pins low when IDE power is off, saving...2009-01-02Boris Gjenero162010-03-205 Task Description

The OF ide_power_enable routine sets some GPIO _ENABLE bits to zero when enabling power and sets them to 1 when disabling power. This makes a difference of about 1 in 4066_ISTAT ( FS#9728 ) on my 30 gig iPod, which probably means saving about 0.75 mA. But if 1 is enable, why does enabling pins save power?

9719BugsMusic playbackVery LowPlayback skips and hangs badly on iPod Video 80GB on st...2008-12-27Jeremy Cayot92011-09-26 Task Description

This is a recurring problem with this target it seems. With 3.1 installed and resume playback on start up enabled, playback hangs and skips badly while the hard drive is being scanned during start up.

The same behavior occurs when resume on start up is disabled, but playback is resumed by the user during the hard drive scan.

9677PatchesPlaylistsVery LowChange the erase dynamic playlist warning to a menu wit...2008-12-19Alex Bennee152009-12-136 Task Description

As discussed on the mailing list this patch gets rid of the “About to Erase Dynamic Playlist” warning and replaces it with a menu option to save the current playlist under it’s existing name.

The attached patch is a first cut for review as I’m just getting used to the menu system. If people think it’s the right way to go I’ll clean it up properly. Any suggestions for tweaks to the functionality also welcome.

9673PatchesPluginsVery LowImprove mpegplayer ( add pitch )2008-12-19Sanggon, Lee2008-12-191 Task Description

I found  FS#8521 (permanent pitch setting) can successfully combined with mpeg player.
Add  FS#8521  and some fix, we can use pitch function in mpeg player. This means, we can control mpeg play speed.

With  FS#8894 (speed control without pitch change) can produce similar effect and more attractive, but  FS#8894  have serious problem with gigabeat s30 and require more processer power and have lower sound quality.

This patch can patched with  FS#8607 (mpegplayer playlist).

9628BugsMusic playbackVery LowSound sometimes doesn't work on mr100 if booted without...2008-12-12Frank Gevaerts2008-12-12 Task Description

Tested with r19410

If I boot with the headphones plugged in, sound always works (at least I didn’t have it fail yet). If I boot without headhones plugged in, and plug them in later, sound often doesn’t work. This may also depend on whether the player was turned off for a long time, whether the previous boot was USB mode, and whether the headphones were unplugged before or after shutting down.

9621PatchesOperating System/DriversVery LowFAT read-ahead when filling buffer2008-12-10Boris Gjenero62010-03-263 Task Description

I noticed that when filling the buffer my Video iPod (32MB RAM) does noticeable seeks at semi-regular intervals even if reading from a single non-fragmented file. It seems this is due to having to read the next FAT sector. In firmware/drivers/fat.c there is a FAT cache but no read-ahead of the FAT.

I created fat_preload( struct fat_file *file, long sectorcount ) in firmware/drivers/fat.c to preload the FAT cache. In firmware/common/file.c I created file_preloadfat(int fd, size_t count) because calling a fat_ function directly would be too much of a kludge. I use file_preloadfat in apps/buffering.c just before filling the buffer.

This got rid of that regular seeking and it seems to it can remove about two seconds from the time needed to fill the buffer when reading a single non-fragmented file. Currently the code is quite simple and unintelligent. Fragmentation or other activity can overwrite the pre-loaded FAT sectors in the cache, and in such cases the pre-load leads to needless extra reads. More work is probably needed before this can be included in Rockbox.

Currently this patch is for SW-codec only. I think file_preloadfat could be called from HW-codec buffering code also, though few seeks would be prevented with 2MB of RAM. This patch is also probably useless with flash storage.

9613PatchesDatabaseVery LowAllow formatting of track names for the default <All Tr...2008-12-08Justin Gan152013-08-1714 Task Description

By default, whenever you choose the <All Tracks> option from the database menu, the list of results returned defaults to the standard track name format, i.e. “%02d. %s” tracknum title. What I wanted was to be able to define the format that gets applied to the <All Tracks> option, dependent on the current menu level. So for example, if I had browsed to genre→artist→<All Tracks> it would return the list of all tracks for all artists for the given genre and I wanted the track names to be formated with:

       	"%s %s %02d. %s" artist album tracknum title

and then sorted into order, since I already know what genre the tracks are for.

Similarly, if I simply browsed to genre→artist→album→<All Tracks>, it would return the list of all tracks for the selected genre and artist, but I want the track names to be formated with:

"%s %02d. %s" album tracknum title

so when it’s sorted, I get the tracks grouped only by album and tracknumber, since I already know what artist the tracks are for.

This patch attempts to address this issue by allowing users to define custom <All Tracks> formats in the tagnavi_custom.config file. Thus, sort order can be controlled by how you format the track names, just as it works in base Rockbox.

The premise behind the code is that if the <All Tracks> menu option is chosen, Rockbox will look for formats with a certain naming convention defined by concatenating the tag names of the parent menu levels with “.” characters and finally appending an “.All” identifier. So in the first example above where we had browsed to genre→artist→<All Tracks>, Rockbox will look for all formats called:

"genre.artist.All"

and then cycle through them to see if the appropriate clauses defined on the format are met. Similarly, for the second example where we had browsed to genre→artist→album→<All Tracks>, Rockbox will look for the format called:

"genre.artist.album.All"

As in base Rockbox, it will cycle through all applicable formats and apply the first format it comes across that meets all the clauses defined on the format. One minor change I had to make to get the relevant tags loaded for the search results was to add the tags defined in the clauses of all matching format names to the tagcache search, but not add the clauses themselves.

So now, in the tagnavi_custom.config file to illustrate the first example, I have defined 4 formats called “genre.artist.All” to format the final display name based on whether the artist/album tags are actually defined on the mp3’s in the database.

%format “genre.artist.All” “%s - %s - %02d. %s” artist album tracknum title ? artist !~ “<Untagged>” album !~ “<Untagged>” tracknum > “0” %format “genre.artist.All” “%s - %02d. %s” album tracknum title ? album !~ “<Untagged>” tracknum > “0” %format “genre.artist.All” “%s - %02d. %s” artist tracknum title ? artist !~ “<Untagged>” tracknum > “0” %format “genre.artist.All” “%02d. %s” tracknum title ? tracknum > “0”

The downside of this approach is that in order to have this style of functionality for every <All Tracks> menu option, I defined a lot of formats. As such, I had to increase the maximum number of formats from 32 to 96 in order to cope with my formatting schemes. I also increased the maximum number of tag filters from 4 to 8. Now this obviously increases the amount of memory allocated for formats, which will have an impact on available audio buffer size. The attached tagnavi_custom.config file shows the various “All” formats I’ve added and it’s pretty comprehensive in the way it handles missing tags, so technically, if your music library is properly tagged, you should never need all of the formats so you could easily reduce the maximum number of formats.

My principal concern with this patch is in terms of the memory usage of increasing the maximum number of formats and number of tag filters allowed. I’m not aware of a memory profiler for cygwin, but then I hadn’t used cygwin before playing with Rockbox - so any pointers would be helpful.

The second piece of functionality I wanted was in the handling of the “strip” functionality. Base Rockbox has an all or nothing approach; if the global format found for the list of tracks contains a strip modifier, then it applies the strip to ALL track names, even if the subsequent formatting of the track does not contain a strip modifier. I wanted Rockbox to only strip tracknames if a strip modifier was defined on the format that is applied to the track. This patch fixes this problem.

This works fine on my Sansa e280 with a full 8Gb drive and a full 2Gb micro-SD card. It’s formatted close to 1000 tracks with no noticeable difference in processing time, and I’ve not come across any out of memory errors on my e280, but I haven’t tested it on any other mp3 player so I would recommend you test this first using the appropriate simulator.

Note that this patch incorporates the year album patch  FS#8051  as the code is all tied up in the same files.

9595PatchesUser InterfaceVery LowCorrect thai font display2008-12-01Phinitnun Chanasabaeng52008-12-302 Task Description

This patch will correct how thai vowels and tonal makers display.

9571PatchesGamesVery Lownew plugin for AEG style for roll and keep style dice r...2008-11-22Tom Bogue12008-11-221 Task Description

This patch adds a new plugin called aegdice, which allows for AEG style (i.e. 5k3) dice rolling.

9551BugsUser InterfaceVery LowPLAY and STOP buttons should be universal (where possib...2008-11-14Steve Bavin62017-01-07 Task Description

Where possible (i.e. the buttons aren’t needed for somethinig else), the PLAY button should go straight to the WPS (resuming as required) or radio.

These are almost the case, but on the H300 there are the following exceptions:

- Rockbox Info (PLAY performs the disk free space scan, same as SELECT)
- Playlist Viewer when selected from the Main > Playlists menu (PLAY returns to the menu above, same as LEFT)
- Sleep Timer (PLAY does nothing)
- Debug Manu (PLAY enters the selected item, same as SELECT)
- Browse x in Settings, where x = Themes, Fonts or .cfg/.wps/.rwps Files (PLAY returns to the menu above, same as LEFT). (Note that the plugin browser works fine!)

Similarly, the STOP button should stop playback, which is largely ok, except:

- In the Playlist Viewer (STOP does nothing)

I don’t have any other targets handy, but feel free to add any other suspect screens here.

9547PatchesPluginsVery LowRAttax2008-11-13Alex Suykov32009-06-195 Task Description

Rockbox port of XAttax (which is in turn X port of some ancient arcade game). It’s a strategy game similar to Reversi, played agains AI opponent.

The rules should be obvious once you run it. You can place new stone next to you own stones, or you can move already placed stone over a cell. Moved or newly places stone changes color of all adjacent stones. The player who has more stones at the end wins.

To install, apply patch and unpack tar’ed sources. It should build successfuly on all LCD-based targets; please report in case build fails for your particular device so I could fix it.

9538PatchesDatabaseVery Lowtagnavi search condition opperator supports for non lat...2008-11-09Yoshihisa Uchida42009-07-104 Task Description

The search condition of tagnavi (eg. =, >, ^,…) doesn't return a correct search result to characters other than the Latin alphabet.

For example;
1) artist ^ "A"

    Neither "Ándre" nor "ándre" appear to the search result. 

2) artist = "Ándre"

    Neither "Andre" nor "andre" appear to the search result. 

My patch file solves such a problem.

Because it doesn't test enough.
There is still a possibility that the search result is not correct
according to the character used.
Please report.

About performance

The search time is slow than before. 
I will improve this in the future. 

About patch
  Please execute make zip (or make fullzip) after applying
the patch to the source file.



  There is uni.mt(or unimini.mt) in .rockbox/codepages folder
when rockbox.zip is unziped, and copy this file onto your player's
.rockbox/coepages.
(The search result doesn't correct if there is no uni.mt(or unimini.mt)).

About search result
1) It is considered that the character that is the difference
   of the uppercase, titlecase and the lowercase is the same.

   eg. A = a, Ω = ω

2) It is considered that the character with the pronunciation sign
(accent, umlaut, etc.) is the same as the character to which these are not attached.

   eg. A = Á

3) The combination character is considered to be a character that divides into each character.
  eg. Œ = O E

4) Only Japanese: the Hiragana, the halfwidth Katakana are considered to be the same character as the fullwidth Katakana.

eg. あ = ア, ア = ア
9537PatchesThemesVery LowBackdrop for viewport2008-11-08John Woznack72009-12-182 Task Description

I’d like to suggest the following new WPS feature(s):

1. A viewport can be assigned an image as a “backdrop”.

 a. A viewport may be assigned an image dynamically via the WPS tag "%VX<identifier>"
   (i.e. %VXa for image a, %VXZ for image Z, etc.)
  b. As a viewport is being processed and drawn, its backdrop would be drawn "first", followed by any other normal images/characters.

2. Viewport may define FF00FF as a background color, which would then be “transparent”. This would allow overlapping viewports.

3. Fonts drawn in a viewport with a backdrop would automatically be drawn with DRMODE_FG.

Notes on the attached patch file:
+ It was created from the SVN revision 18997 on Nov 3, 2008.
+ Although I stubbed in the new functions for all the LCD drivers, I’ve only flushed out the 16 bit driver so far.

Cheers!

9514PatchesOperating System/DriversVery Lowmake simple list accept a viewport2008-10-30Jonathan Gordon2008-10-301 Task Description

this is part of a different patch which was changed to use the menu api instead of simplelist so im putting it up here incase anyone decides to make simplelist draw in a viewport.

The patch works (or did last time i tried it) but isnt commited because its not really needed just yet.

Showing tasks 501 - 550 of 669 Page 11 of 14<<First - 9 - 10 - 11 - 12 - 13 - Last >>

Available keyboard shortcuts

Tasklist

Task Details

Task Editing