FS#10014 : Separate tracklocking out of skip length

FS#10014 - Separate tracklocking out of skip length

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Thursday, 12 March 2009, 18:19 GMT
Last edited by Nils Wallménius (nls) - Saturday, 28 March 2009, 08:27 GMT

Task Type	Patches
Category	Music playback
Status	Closed
Assigned To	No-one
Operating System	All players
Severity	Low
Priority	Normal
Reported Version	Version 3.1
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	0
Private	No

Details

This patch implements the idea that came up here: http://forums.rockbox.org/index.php?topic=20739.0

Read the topic for my reasonings, why I made this patch.

Short summary: It separates the tracklock feature of skip length out to a seperate setting, so that skip length is actually usable too for normal music playback.

One note: It does NOT prevent track changing due to normal playback (i.e. when the current track ends). For this, you'll want to combine with Repeat: One (this gives more flexibility to the setting too).

This patch doesn't change how tracklock works, it really just seperates the setting (e.g. the above also happens with the current skip length).

rockbox-tracklock.v1.diff (5.9 KiB)

This task depends upon

Closed by Nils Wallménius (nls)
Saturday, 28 March 2009, 08:27 GMT
Reason for closing: Accepted
Additional comments about closing: kugel committed this as r20553

Comments (1)
Related Tasks (0/0)

Comment by Thomas Martitz (kugel.) - Friday, 13 March 2009, 04:25 GMT

Sync'd. Also, remove the the keycombos that were there for skipping tracks within skip length mode, which are (I think) not needed anymore.

rockbox-tracklock.v1b.diff (5.5 KiB)

	Tasks related to this task (0)

Duplicate tasks of this task (0)

Rockbox

FS#10014 - Separate tracklocking out of skip length

Details

Loading...