Rockbox

Tasklist

FS#10043 - lcd_e200v2 updates

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Sunday, 22 March 2009, 21:54 GMT
Last edited by MichaelGiacomelli (saratoga) - Friday, 10 April 2009, 01:44 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch for the e200v2 cleans up unused GPIOs and implements LCD flipping and invert.
   lcd-e200v2.diff (4.4 KiB)
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Friday, 10 April 2009, 01:44 GMT
Reason for closing:  Accepted
Comment by Thomas Martitz (kugel.) - Monday, 23 March 2009, 18:05 GMT
I'll look if it works on the fuze too!

Please do not use fixed numbers like 0xaf or 0xdb, but LCD_WIDTH/_HEIGHT (-1) instead.
Comment by Michael Chicoine (mc2739) - Tuesday, 24 March 2009, 00:00 GMT
Here is a new version with LCD_WIDTH-1 and LCD_HEIGHT-1 instead of fixed numbers.
   lcd-e200v2-v2.diff (4.4 KiB)
Comment by Michael Chicoine (mc2739) - Friday, 27 March 2009, 00:51 GMT
Version 3 adds code to put lcd in standby to reduce power consumption.
   lcd-e200v2-v3.diff (4.6 KiB)
Comment by Maurus Cuelenaere (mcuelenaere) - Friday, 27 March 2009, 09:50 GMT
You can remove the '(void)yesno;' line (this is just to fix warnings when the parameter doesn't get used).
Comment by Michael Chicoine (mc2739) - Friday, 27 March 2009, 11:39 GMT
Additional cleanup - removed '(void)yesno;' and unused function flip_lcd()
   lcd-e200v2-v4.diff (4.7 KiB)
Comment by Andreas Langmann (cyclon1978) - Tuesday, 31 March 2009, 12:00 GMT
works fine on e280
Comment by MichaelGiacomelli (saratoga) - Tuesday, 07 April 2009, 16:29 GMT
Is this ready to commit?
Comment by Michael Chicoine (mc2739) - Tuesday, 07 April 2009, 17:24 GMT
I believe so. I have not seen any problems caused by this patch.

Loading...