• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rb_dev - 2003-03-04
Last edited by bagder - 2003-03-05

FS#1007 - Fix player full line progress bar

This patch fixes several bugs and limitations in the recently added player full line progress bar logic.

1) Corrects setting of maximum value of songpos to 55 on line 864 (11 lcd characters * 5 pixel width of
each character).

2) Fixes bug that occurred when both %pb and %pf appear in the wps format. Both formats used the
custom character defined by wps_progress_pat[0] so there was a conflict when both were specified in the
wps. Format %pf now uses characters defined by indices 1-7 to avoid conflict with character
defined at index 0 which is used by %pb. Now both %pb and %pf can be displayed on the wps

3) Improves on limitation of maximum elapsed time that can be displayed. Elapsed time up to 999:59
can now be displayed.

4) Elapsed time in %pf now displays formatted the same as in %pc with leading zeros not displayed in
10’s and 100’s place.

5) Changed index variable name from “digit” to “lcd_char_pos” for better code readability since it now is
an index for all 11 character positions of the lcd display, not just the digit positions.

Closed by  bagder
2003-03-05 23:14
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Logged In: YES

Many thanks, patch applied and committed.

Project Manager

Many thanks, patch applied and committed.


Available keyboard shortcuts


Task Details

Task Editing