Rockbox

Tasklist

FS#1007 - Fix player full line progress bar

Attached to Project: Rockbox
Opened by Craig Sather (rb_dev) - Tuesday, 04 March 2003, 01:55 GMT
Last edited by Daniel Stenberg (bagder) - Wednesday, 05 March 2003, 23:14 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

This patch fixes several bugs and limitations in the recently added player full line progress bar logic.

1) Corrects setting of maximum value of songpos to 55 on line 864 (11 lcd characters * 5 pixel width of
each character).

2) Fixes bug that occurred when both %pb and %pf appear in the wps format. Both formats used the
custom character defined by wps_progress_pat[0] so there was a conflict when both were specified in the
wps. Format %pf now uses characters defined by indices 1-7 to avoid conflict with character
defined at index 0 which is used by %pb. Now both %pb and %pf can be displayed on the wps
simultaneously.

3) Improves on limitation of maximum elapsed time that can be displayed. Elapsed time up to 999:59
can now be displayed.

4) Elapsed time in %pf now displays formatted the same as in %pc with leading zeros not displayed in
10's and 100's place.

5) Changed index variable name from "digit" to "lcd_char_pos" for better code readability since it now is
an index for all 11 character positions of the lcd display, not just the digit positions.
This task depends upon

Closed by  Daniel Stenberg (bagder)
Wednesday, 05 March 2003, 23:14 GMT
Reason for closing:  Accepted
Additional comments about closing:  Logged In: YES
user_id=1110

Many thanks, patch applied and committed.
Comment by Daniel Stenberg (bagder) - Wednesday, 05 March 2003, 23:14 GMT

Many thanks, patch applied and committed.

Loading...