FS#10070 - rework TTS and Encoders in rbutil, to better seperate the gui

Attached to Project: Rockbox
Opened by Dominik Wenger (Domonoky) - Sunday, 29 March 2009, 18:06 GMT
Last edited by Dominik Wenger (Domonoky) - Wednesday, 29 April 2009, 21:30 GMT
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This is the first attempt to better seperate the configuration Gui from the TTS and Encoders in Rbutil. The TTS and Encoders present now a Model, which can be displayed via a generic TableView.

This patch is nearly ready, but it still needs some improvements. Also i am not sure about the Gui. Is it enough to present the options in a Table like this, or do we need something better ?

Please try it and comment here.
This task depends upon

Closed by  Dominik Wenger (Domonoky)
Wednesday, 29 April 2009, 21:30 GMT
Reason for closing:  Accepted
Comment by Dominik Riebeling (bluebrother) - Sunday, 29 March 2009, 21:33 GMT
Got it crashed almost instantly:
- go to the configuration, select festival (note: festival isn't installed on my system)
- use Configure TTS, then Voice
The dialog hangs in an endless loop. Also, the table view is poorly layed out -- some lines are much bigger than other without containing more information at all which looks crappy. Also, I'm not sure if I like the table view at all...

Haven't checked the code (yet) though.
Comment by Dominik Wenger (Domonoky) - Monday, 30 March 2009, 16:50 GMT
Just as a note:
Festival is the one i didnt really test, as its not available on windows for now. But it shoudnt crash ofcourse :-) I will try to reproduce and test this later.

I also noticed this strange thing, where some lines in the TableView are bigger then others, (only if there are more then 2 Buttons) but it didnt want to spend too much time on this for now. (I probably just have to setup the Table View correctly). But i am with you, that the Table View itself isnt perfect, does anyone have a better Idea for a !generic! setting view ?

Ofcourse for now, the Code changes is what is important.. any comments ? :-)
Comment by Dominik Wenger (Domonoky) - Thursday, 02 April 2009, 21:17 GMT
Another attempt:

This time it has a dynamically generated ui, with seperate Gui elements, which should look much nicer :-)

Also i think the code looks much cleaner now. Please comment.

Comment by Dominik Wenger (Domonoky) - Friday, 03 April 2009, 18:30 GMT
new Version:
- improved Code for better readability and more Comments
- fix configuration Dialog for Festival.

I think this patch is now nearly finished. So please comment
Comment by Dominik Wenger (Domonoky) - Saturday, 04 April 2009, 12:20 GMT
Some more code cleanup. Make sure to always set a proper parent, so Qt Object handling works.

I think this patch is now nearly ready for commit. but should perhaps wait till after the next rbutil release.