Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#10081 : Rocklife: Handle comments in .cells files

Rockbox

Tasklist

FS#10081 - Rocklife: Handle comments in .cells files

Attached to Project: Rockbox
Opened by Justin Hannigan (Chronon) - Tuesday, 31 March 2009, 21:17 GMT
Last edited by Alexander Levin (fml2) - Friday, 03 April 2009, 20:35 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Previously there was no handling for comments, leaving the possibility for characters in the comment block to interfere with proper handling of the .cells file. Rocklife properly handles the comments with this patch. I checked by inserting the content of a .cells file into the comment block of another .cells file. Rocklife ignored the comment block properly.
   rocklife_comments.patch (1 KiB)
This task depends upon

Closed by  Alexander Levin (fml2)
Friday, 03 April 2009, 20:35 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20611. Thanks!
Comment by Justin Hannigan (Chronon) - Thursday, 02 April 2009, 17:50 GMT
This patch should be updated now, since it includes the fix that was committed in r20605 ("j=j++;" --> "j++;")

Loading...