Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rasher - 2009-04-03
Last edited by rasher - 2009-06-22

FS#10093 - Center on loaded file when browsing

This patch centers the browser on the currently loaded font when doing “browse fonts”.

Something smarter should probably be done that does the same for themes, languages and wps files.

Closed by  rasher
2009-06-22 18:02
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r21464

Updated patch that also works for languages, except when no language is selected, in which case it should use English, but doesn’t currently.

Fixes:
- Now picks English when no language has been set.
- Accidentally set the “current” variable static, which meant it was set even when none of the conditions were true (eg. when browsing themes)
Additions:
- Works for FM presets
- Works for WPS
- Works for RWPS
Remaining bugs:
- set_current_file() does something to the dirbrowser which means you don’t exit it when you press back, so when you browse fonts, and press back, you’re in .rockbox, and back again brings you to the root. Only on the third press on back are you taken to the menu.

Fixes
- Reset dirlevel to 0, so pressing back returns to the menu.
Remaining bugs:
- None! :-)

Commit candidate:

Fixes:
- Remove the DEBUGF
Additions
- Change “Browse Fonts” into “Font” - Change “Browse .wps files” into “While Playing Screen” - Change “Browse .rwps files” into “Remote While Playing Screen” - Change “Browse Themes” into “Browse Theme Files”

Second commit candidate, I’ll probably commit it shortly.

Additions
- Update the manual according to the menu wording changes.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing