• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2009-04-09
Last edited by fg - 2009-05-23

FS#10110 - USB stack code cosmetics

This patch contaings the following code cosmetics changes (no functional changes)

- Remove white spaces at the end of lines
- Remove redundant empty lines
- Put curly braces in separate lines
- Put space after if/for/while keywords
- Space binary operands (+ - « » |=) from both sides
- Enforce 80 characters per line

This patch is a preliminary work on the USB stack.
It is part of a GSoC suggested project, which I started working on lately.

Closed by  fg
2009-05-23 15:10
Reason for closing:  Rejected

I somewhat dislike this patch given the line in docs/CONTRIBUTING:

When changing code, follow the code style of the file you are editing.

As far as I can see from briefly skimming the touched files the bracing and spacing was consistend before, thus I disagree that it should be changed. I however do agree that removing trailing whitespace is a good thing, but that's the only item of the list of changes. As this patch changes code style it should get rejected IMO.


Available keyboard shortcuts


Task Details

Task Editing