Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by funman - 2009-04-09
Last edited by kugel. - 2009-04-10

FS#10114 - Sansa AMS : use IRAM for codecs on >2MB targets

Stable mp3 decoding on Fuze

some codecs (mad_iram.h for example) use .icode section and not ICODE_ATTR

This caused a problem because we defined incorrectly IRAMSIZE to be >0 in plugin.lds for these targets

   0002-Sansa-AMS-make-models-wi... (2.7 KiB)
Closed by  kugel.
2009-04-10 17:05
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed r20678. Thank you very much again :) Great job, really!

kugel. commented on 2009-04-09 13:57

Weird. I’m fairly sure I tried this very changes too (exactly these!), and I couldn’t get it to work :S

funman commented on 2009-04-09 15:11

strange :/

are you sure you kept first range of IRAM (0×0 - something) for rockbox (because the vectors are there)?

sko commented on 2009-04-09 16:34

Now mp3 works really fine on my e250v2 (even my 320k/bit files)!

FlynDice commented on 2009-04-09 17:21

Let me demonstrate my lack of practical experience here by asking if it makes a difference if you’ve used 0×50000 instead of 0x4FFFF as the end of IRAM. The memory map at the end of the 3525 datasheet lists the “embedded T-ram” from 0x0000_0000 to 0x0004_FFFF which is a size of 0×50000. But if you’re using the endpoint as a reference to count back from shouldn’t it be 0x4FFFF?

kugel. commented on 2009-04-09 20:24

Well, guess how the patch is working for me,

Not at all. I get the same symptoms which I got with my work: Every codec just skips every track, except MP3 which throws a undefined instruction :(

Is it my hardware? That would explain why it didn’t work for me when I implemented it :( I cannot really explain it.

kugel. commented on 2009-04-10 16:16

Alright, seems to be a dependecy problem. I now built from a fresh checkout and it works.

If I knew that before we already had mp3 3 weeks ago :(

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing