Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To
    kugel.
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by kugel. - 2009-04-11
Last edited by kugel. - 2009-04-13

FS#10120 - fuze/e200v2: poll the wheel more often

This patch uses the tick_task timer to poll the scrollwheel every 5ms (the tick tasks stay at every 10ms of course).

This makes the scrollwheel on my fuze pretty much perfectly usable.

I’d like to hear opinions (from e200v2 owners too). It’s a bit of a hack, but I’m fairly sure it cannot be done better (without an interrupt, that is), so I hope it’s acceptable.

   scrolllwheel-polling.diff (4.9 KiB)
Closed by  kugel.
2009-04-13 10:29
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r20699.

sko commented on 2009-04-11 12:15

Works very good on my e250v2. A little cleanup for button-e200v2.c: scrollwheel(); is not necessary in button_read_device() because its called already through button_dbop() (which is called by button_read_device() ).

   scrolllwheel-polling_02.diff (5 KiB)
kugel. commented on 2009-04-11 12:31

Cool. And yes, you're correct :)

saratoga commented on 2009-04-11 22:09

Tried this out and it works nicely on my Fuze.

kugel. commented on 2009-04-12 02:00

No real functional change, just a bit of cleanup. And also add the comments for the dbp read function to the fuze driver.

Sadly, I cannot test anymore due to the lack of hardware. But if it works well, feel free to commit.

   scrolllwheel-polling-v2.diff (7.5 KiB)
sko commented on 2009-04-12 07:42

I can't compile it, get some errors: http://pastebin.com/d3bb99831

kugel. commented on 2009-04-12 12:38

There was a stupid typo :/

   scrolllwheel-polling-v2b.diff (7.4 KiB)
sko commented on 2009-04-12 13:16

ok, now it's working again

FlynDice commented on 2009-04-13 04:55

Works fine on my e280v2. I dropped in the fuze scrollcode also and the scrolling action was perfectly acceptable. It wraps the menus always, which I personally tend to dislike, but the scrolling action was just fine. I did not need to change any parameters in the fuze scrollcode. It worked as is with only minor modifications to variable declarations so as not to redeclare.

kugel. commented on 2009-04-13 10:19

You also needed to change "++count >= 4" to "++count >= 2", right?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing