Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2009-04-11
Last edited by tomers - 2009-09-30

FS#10122 - Fix wrong format type of logf functions in speex.c

When compiling Rockbox with logf enabled you get many warnings for bad format type and too many arguments for format.

This patch fixes this.

   fix_bad_logf_format.diff (2.2 KiB)
Closed by  tomers
2009-09-30 12:57
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r22857

tomers commented on 2009-04-11 16:42

Added same fixes that was required in apps/codecs/ape.c too.

   fix_bad_logf_format.diff (2.7 KiB)
tomers commented on 2009-06-03 11:22

The compiler warnings are in the following link:
http://pastebin.com/f64d0238

$ uname -a
Linux ubuntu904 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux

$ gcc -v
Using built-in specs.
Target: i486-linux-gnu
Configured with: ../src/configure -v –with-pkgversion='Ubuntu 4.3.3-5ubuntu4' –with-bugurl=file:///usr/share/doc/gcc-4.3/README.Bugs –enable-languages=c,c++,fortran,objc,obj-c++ –prefix=/usr –enable-shared –with-system-zlib –libexecdir=/usr/lib –without-included-gettext –enable-threads=posix –enable-nls –with-gxx-include-dir=/usr/include/c++/4.3 –program-suffix=-4.3 –enable-clocale=gnu –enable-libstdcxx-debug –enable-objc-gc –enable-mpfr –enable-targets=all –with-tune=generic –enable-checking=release –build=i486-linux-gnu –host=i486-linux-gnu –target=i486-linux-gnu
Thread model: posix
gcc version 4.3.3 (Ubuntu 4.3.3-5ubuntu4)

Can someone please commit this?

tomers commented on 2009-06-03 11:23

The correct versions are:
Using arm-elf-gcc 4.0.3 (400)
Using arm-elf-ld 2.16.1

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing