Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Rbutil
  • Assigned To
    bluebrother
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2009-04-11
Last edited by tomers - 2009-10-01

FS#10124 - Fix some rbutil compilation warnings

This patch eliminates some of the warnings that are shown during compilation of the Rockbox applications.

The patch includes:
- Wrapping ‘if’ blocks with curly brackets.
- Remove ‘typedef’ from struct declaration when nothing is typedef’ed to the struct.

   fix_compiler_warnings.diff (1.8 KiB)
Closed by  tomers
2009-10-01 05:27
Reason for closing:  Wont Fix
bluebrother commented on 2009-04-12 18:05

can you please explain this patch? I don’t get any warnings for the changed code at all, adding braces for one line statements isn’t required at all and the typedef thing is in imported code which shouldn’t be changed unless necessary IMO. Besides, we have one-line-statements without braces in quite a lot of places. If you get warnings here you should get a ton of other warnings as well.

tomers commented on 2009-04-14 20:21

Please read attached console log file to look at the warnings I got.
My system details (compilers versions, Linux kernel versions) are here: http://pastebin.com/f29d14717

   rbutil_build_warnings.txt (65.4 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing