Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Version 3.2
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mc2739 - 2009-04-14
Last edited by kugel. - 2009-04-20

FS#10128 - Sansa AMS debug cosmetic fix

This is a cosmetic fix for the Sansa AMS ports debug screen. DBOP_DIN displays 8 hex characters until the record button is pressed, then it displays only 4 hex characters (first 4 charactersare "0"). Changed the sprintf parameter from %4x to %8x so that the leading zeros are displayed.

   debug-as3525.c.diff (0.5 KiB)
Closed by  kugel.
2009-04-20 20:11
Reason for closing:  Fixed
Additional comments about closing:  

Fixed in r20757.

kugel. commented on 2009-04-14 01:20

It should only display 4 character, since dbop is a short :/

mc2739 commented on 2009-04-14 03:39

Since dbop is a short, then why would it displaying 8 characters? Could there be someplace it is expanded?

kugel. commented on 2009-04-14 22:33

According to amiconn it's expanded due to the sign bit. Currently dbop_din is a signed short. Since the sign bit changes due to button presses, the sign bit gets added again before the actual short data. The attached patch just changes it to unsigned. Please test and report back.

   unsigned-dbop.diff (3.3 KiB)
mc2739 commented on 2009-04-15 00:11

The patch works on the e200v2, although I had to change button-target.h to get it to build. Attached is the updated patch.

   unsigned-dbop-v2.diff (4.3 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing