Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mcuelenaere - 2009-04-15
Last edited by mcuelenaere - 2009-04-19

FS#10136 - Touchscreen mode switching in plugins

When entering some plugins on a touchscreen target, the touchscreen mode sometimes gets set to 3x3 grid when leaving the plugin even though the original setting was absolute mode.

This patch sets the touchscreen mode to 3x3 grid for rockpaint and sets the old mode back when leaving (ideally this should be done for all plugins - or they should get adapted to absolute point mode).

Closed by  mcuelenaere
2009-04-19 15:22
Reason for closing:  Fixed
Additional comments about closing:  

Committed plugin touchscreen mode switching in r20738

Wouldn't it be easier for the plugin loader to do this? ie. enable grid mode before entering the plugin, and return to the user's preference afterwards.

Those small minority of plugins that are adapted to touchscreen usage should set absolute mode themselves, imho.

agreed… edit: to elaborate.. the reason 3x3 was added was to make plugins easy to get working… so yes they shuold default to being grid and the ones which are converted should manually swicth to touch

Hmm I agree, but IMO this is a hack and should get removed in the future.. (will work on a patch for this)

edit:
How is the user going to know in which mode it is? Shouldn't there be a visual confirmation when switching modes?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing